{"id":540,"url":"http://patchwork.ozlabs.org/api/1.0/patches/540/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1221757668.23007.12.camel@ns-test>","date":"2008-09-18T17:07:48","name":"clarify code intent","commit_ref":null,"pull_url":null,"state":"rejected","archived":true,"hash":"810584cb50badff35937231b92ef75ed5912804a","submitter":{"id":270,"url":"http://patchwork.ozlabs.org/api/1.0/people/270/?format=json","name":"Mathieu Lacage","email":"mathieu.lacage@sophia.inria.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1221757668.23007.12.camel@ns-test/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/540/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 5D1F1DDE26\n\tfor ;\n\tFri, 19 Sep 2008 03:17:54 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754114AbYIRRRu (ORCPT );\n\tThu, 18 Sep 2008 13:17:50 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1754128AbYIRRRt\n\t(ORCPT ); Thu, 18 Sep 2008 13:17:49 -0400","from mail2-relais-roc.national.inria.fr ([192.134.164.83]:35173\n\t\"EHLO mail2-relais-roc.national.inria.fr\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752266AbYIRRRt (ORCPT\n\t); Thu, 18 Sep 2008 13:17:49 -0400","from unknown (HELO [128.95.3.63]) ([128.95.3.63])\n\tby mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 18 Sep 2008 19:07:09 +0200"],"X-Greylist":"delayed 632 seconds by postgrey-1.27 at vger.kernel.org;\n\tThu, 18 Sep 2008 13:17:49 EDT","X-IronPort-AV":"E=Sophos;i=\"4.32,422,1217800800\"; d=\"scan'208\";a=\"15105999\"","Subject":"clarify code intent","From":"Mathieu Lacage ","To":"netdev@vger.kernel.org","Content-Type":"multipart/mixed; boundary=\"=-5ZIWZpeoWDcOCjb10Cvn\"","Date":"Thu, 18 Sep 2008 10:07:48 -0700","Message-Id":"<1221757668.23007.12.camel@ns-test>","Mime-Version":"1.0","X-Mailer":"Evolution 2.12.1 ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"hi,\n\nThe attached patch hopefully clarifies the intent of the unix_bind\nfunction in net/unix/af_unix.c. That 'feature' (the ability to delegate\nthe endpoint allocation to the kernel with bind by sending a\nsockaddr_un.sun_family = AF_UNIX rather than have to wait until the\nautobind is triggered by a later call to send) would be nice to document\nin the unix '7' manpage but, I have no idea where these are maintained.\nI also have no idea whether that specific 'feature' is common among\nother unixes. It is quite useful though.\n\nMathieu","diff":"diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c\nindex 015606b..efa725e 100644\n--- a/net/unix/af_unix.c\n+++ b/net/unix/af_unix.c\n@@ -777,7 +777,7 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)\n \tif (sunaddr->sun_family != AF_UNIX)\n \t\tgoto out;\n \n-\tif (addr_len==sizeof(short)) {\n+\tif (addr_len==sizeof(sa_family_t)) {\n \t\terr = unix_autobind(sock);\n \t\tgoto out;\n \t}\n","prefixes":[]}