{"id":534,"url":"http://patchwork.ozlabs.org/api/1.0/patches/534/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<1221757033-4874-2-git-send-email-benli@broadcom.com>","date":"2008-09-18T16:57:10","name":"[UPDATED,NET-NEXT,1/4] bnx2: In bnx2_set_mac_link() return void rather then int","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"fc00af5a155bdb17434ba0eb8ba1b19b33e5342e","submitter":{"id":234,"url":"http://patchwork.ozlabs.org/api/1.0/people/234/?format=json","name":"Benjamin Li","email":"benli@broadcom.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1221757033-4874-2-git-send-email-benli@broadcom.com/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/534/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id A9901DE0B4\n\tfor ;\n\tFri, 19 Sep 2008 02:57:43 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756486AbYIRQ53 (ORCPT );\n\tThu, 18 Sep 2008 12:57:29 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1756467AbYIRQ53\n\t(ORCPT ); Thu, 18 Sep 2008 12:57:29 -0400","from mms1.broadcom.com ([216.31.210.17]:4705 \"EHLO\n\tmms1.broadcom.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755115AbYIRQ51 (ORCPT );\n\tThu, 18 Sep 2008 12:57:27 -0400","from [10.11.16.99] by mms1.broadcom.com with ESMTP (Broadcom\n\tSMTP Relay (Email Firewall v6.3.2)); Thu, 18 Sep 2008 09:57:16 -0700","by mail-irva-10.broadcom.com (Postfix, from userid 47) id\n\t87B702B1; Thu, 18 Sep 2008 09:57:16 -0700 (PDT)","from mail-irva-8.broadcom.com (mail-irva-8 [10.11.18.52]) by\n\tmail-irva-10.broadcom.com (Postfix) with ESMTP id 73B0D2B0;\n\tThu, 18 Sep 2008 09:57:16 -0700 (PDT)","from mail-irva-13.broadcom.com (mail-irva-13.broadcom.com\n\t[10.11.16.103]) by mail-irva-8.broadcom.com (MOS 3.7.5a-GA) with\n\tESMTP id HDR82878; Thu, 18 Sep 2008 09:57:14 -0700 (PDT)","from localhost (dhcp-10-12-137-98.broadcom.com [10.12.137.98])\n\tby mail-irva-13.broadcom.com (Postfix) with ESMTP id BADB874D06; Thu,\n\t18 Sep 2008 09:57:13 -0700 (PDT)"],"X-Server-Uuid":"02CED230-5797-4B57-9875-D5D2FEE4708A","From":"\"Benjamin Li\" ","To":"\"Jeff Garzik\" ","cc":"benli@broadcom.com,\n\t\"netdev@vger.kernel.org\" ","Subject":"[UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link()\n\treturn void rather then int","Date":"Thu, 18 Sep 2008 09:57:10 -0700","Message-ID":"<1221757033-4874-2-git-send-email-benli@broadcom.com>","X-Mailer":"git-send-email 1.6.0.1","In-Reply-To":"<1221757033-4874-1-git-send-email-benli@broadcom.com>","References":"<20080918063933.GA8027@verge.net.au>\n\t<1221757033-4874-1-git-send-email-benli@broadcom.com>","MIME-Version":"1.0","X-WSS-ID":"64CC57E64E0151931902-01-01","Content-Type":"text/plain","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"bnx2_set_mac_link() doesn't need to return any error codes. And\nall the callers don't check the return code. It is safe to\nchange the return type to a void.\n\nSigned-off-by: Benjamin Li \nSigned-off-by: Michael Chan ","diff":"diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c\nindex 2486a65..192a24e 100644\n--- a/drivers/net/bnx2.c\n+++ b/drivers/net/bnx2.c\n@@ -1127,7 +1127,7 @@ bnx2_init_all_rx_contexts(struct bnx2 *bp)\n \t}\n }\n \n-static int\n+static void\n bnx2_set_mac_link(struct bnx2 *bp)\n {\n \tu32 val;\n@@ -1193,8 +1193,6 @@ bnx2_set_mac_link(struct bnx2 *bp)\n \n \tif (CHIP_NUM(bp) == CHIP_NUM_5709)\n \t\tbnx2_init_all_rx_contexts(bp);\n-\n-\treturn 0;\n }\n \n static void\n","prefixes":["UPDATED","NET-NEXT","1/4"]}