{"id":510,"url":"http://patchwork.ozlabs.org/api/1.0/patches/510/?format=json","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.0/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20080918130652.GA10552@xi.wantstofly.org>","date":"2008-09-18T13:06:52","name":"phylib: phy_mii_ioctl() fixes","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"887860cc2de04bed4a72ee86952f6cdc45eff0fc","submitter":{"id":94,"url":"http://patchwork.ozlabs.org/api/1.0/people/94/?format=json","name":"Lennert Buytenhek","email":"buytenh@wantstofly.org"},"delegate":{"id":36,"url":"http://patchwork.ozlabs.org/api/1.0/users/36/?format=json","username":"jgarzik","first_name":"Jeff","last_name":"Garzik","email":"jgarzik@pobox.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20080918130652.GA10552@xi.wantstofly.org/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/510/checks/","tags":{},"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id D5CADDDFD1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 18 Sep 2008 23:06:58 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752769AbYIRNGx (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 18 Sep 2008 09:06:53 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752822AbYIRNGx\n\t(ORCPT <rfc822; netdev-outgoing>); Thu, 18 Sep 2008 09:06:53 -0400","from xi.wantstofly.org ([83.160.184.112]:45876 \"EHLO\n\txi.wantstofly.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751588AbYIRNGx (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 18 Sep 2008 09:06:53 -0400","by xi.wantstofly.org (Postfix, from userid 500)\n\tid 487BB7FAC2; Thu, 18 Sep 2008 15:06:52 +0200 (CEST)"],"Date":"Thu, 18 Sep 2008 15:06:52 +0200","From":"Lennert Buytenhek <buytenh@wantstofly.org>","To":"Andy Fleming <afleming@freescale.com>","Cc":"netdev@vger.kernel.org","Subject":"[PATCH] phylib: phy_mii_ioctl() fixes","Message-ID":"<20080918130652.GA10552@xi.wantstofly.org>","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.4.2.2i","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Make the SIOCGMIIPHY case fall through properly (it is supposed\nto not only return the ID of the default PHY but also to read from\nthat PHY), and make phy_mii_ioctl() return the same error code as\ngeneric_mii_ioctl() in case of an unsupported operation.\n\nSigned-off-by: Lennert Buytenhek <buytenh@marvell.com>","diff":"Index: linux-2.6/drivers/net/phy/phy.c\n===================================================================\n--- linux-2.6.orig/drivers/net/phy/phy.c\n+++ linux-2.6/drivers/net/phy/phy.c\n@@ -411,7 +411,8 @@ int phy_mii_ioctl(struct phy_device *phy\n \tswitch (cmd) {\n \tcase SIOCGMIIPHY:\n \t\tmii_data->phy_id = phydev->addr;\n-\t\tbreak;\n+\t\t/* fall through */\n+\n \tcase SIOCGMIIREG:\n \t\tmii_data->val_out = phy_read(phydev, mii_data->reg_num);\n \t\tbreak;\n@@ -458,7 +459,7 @@ int phy_mii_ioctl(struct phy_device *phy\n \t\tbreak;\n \n \tdefault:\n-\t\treturn -ENOTTY;\n+\t\treturn -EOPNOTSUPP;\n \t}\n \n \treturn 0;\n","prefixes":[]}