{"id":225,"url":"http://patchwork.ozlabs.org/api/1.0/patches/225/?format=json","project":{"id":1,"url":"http://patchwork.ozlabs.org/api/1.0/projects/1/?format=json","name":"Cell Broadband Engine development","link_name":"cbe-oss-dev","list_id":"cbe-oss-dev.ozlabs.org","list_email":"cbe-oss-dev@ozlabs.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<48C6E366.4030304@am.sony.com>","date":"2008-09-09T20:58:14","name":"MARS: fix dma list element initialization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"57456eccac9779147c8a3467a529db4cddbf01c5","submitter":{"id":127,"url":"http://patchwork.ozlabs.org/api/1.0/people/127/?format=json","name":"Yuji Mano","email":"yuji.mano@am.sony.com"},"delegate":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.0/users/26/?format=json","username":"ymano","first_name":"Yuji","last_name":"Mano","email":"yuji.mano@am.sony.com"},"mbox":"http://patchwork.ozlabs.org/project/cbe-oss-dev/patch/48C6E366.4030304@am.sony.com/mbox/","series":[],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/225/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Delivered-To":["patchwork@ozlabs.org","cbe-oss-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 52C4ADE7D6\n\tfor ; Wed, 10 Sep 2008 06:59:33 +1000 (EST)","from SG2EHSOBE003.bigfish.com (outbound-sin.frontbridge.com\n\t[207.46.51.80]) by ozlabs.org (Postfix) with ESMTP id 6184BDDF75\n\tfor ; Wed, 10 Sep 2008 06:58:56 +1000 (EST)","from mail19-sin-R.bigfish.com (10.3.40.3) by\n\tSG2EHSOBE003.bigfish.com (10.3.40.23) with Microsoft SMTP Server id\n\t8.1.291.1; Tue, 9 Sep 2008 20:58:53 +0000","from mail19-sin (localhost.localdomain [127.0.0.1])\tby\n\tmail19-sin-R.bigfish.com (Postfix) with ESMTP id 48F88A001AB\tfor\n\t; Tue, 9 Sep 2008 20:58:53 +0000 (UTC)","by mail19-sin (MessageSwitch) id 1220993932606409_8698; Tue, 9 Sep\n\t2008 20:58:52 +0000 (UCT)","from mail8.fw-bc.sony.com (mail8.fw-bc.sony.com [160.33.98.75])\tby\n\tmail19-sin.bigfish.com (Postfix) with ESMTP id 012ECF8061\tfor\n\t; Tue, 9 Sep 2008 20:58:51 +0000 (UTC)","from mail3.sjc.in.sel.sony.com (mail3.sjc.in.sel.sony.com\n\t[43.134.1.211])\tby mail8.fw-bc.sony.com (8.14.2/8.14.2) with ESMTP id\n\tm89Kwomu027921\tfor ;\n\tTue, 9 Sep 2008 20:58:50 GMT","from USSDIXIM01.am.sony.com (ussdixim01.am.sony.com\n\t[43.130.140.33])\n\tby mail3.sjc.in.sel.sony.com (8.12.11/8.12.11) with ESMTP id\n\tm89KwoQu022083\n\tfor ; Tue, 9 Sep 2008 20:58:50 GMT","from ussdixms03.am.sony.com ([43.130.140.23]) by\n\tUSSDIXIM01.am.sony.com with Microsoft SMTPSVC(5.0.2195.6713);\n\tTue, 9 Sep 2008 13:58:49 -0700","from [43.135.148.175] ([43.135.148.175]) by ussdixms03.am.sony.com\n\twith Microsoft SMTPSVC(5.0.2195.6713);\n\tTue, 9 Sep 2008 13:58:49 -0700"],"X-BigFish":"VS3(zzzz10c0j10d3izzz2dh6bh62h)","X-Spam-TCS-SCL":"1:0","Message-ID":"<48C6E366.4030304@am.sony.com>","Date":"Tue, 9 Sep 2008 13:58:14 -0700","From":"Yuji Mano ","User-Agent":"Thunderbird 2.0.0.5 (X11/20070719)","MIME-Version":"1.0","To":"CBE Development ","X-Enigmail-Version":"0.95.7","X-OriginalArrivalTime":"09 Sep 2008 20:58:49.0467 (UTC)\n\tFILETIME=[DBA1CCB0:01C912BE]","X-SEL-encryption-scan":"scanned","Subject":"[Cbe-oss-dev] [PATCH 2/2]MARS: fix dma list element initialization","X-BeenThere":"cbe-oss-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Discussion about Open Source Software for the Cell Broadband Engine\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org","Errors-To":"cbe-oss-dev-bounces+patchwork=ozlabs.org@ozlabs.org"},"content":"This fixes a critical bug where the notify and reserved structure members of\nthe dma list element are not properly initialized, causing random stalls after\nthe dma completion.\n\nSigned-off-by: Yuji Mano ","diff":"--- a/include/mpu/mars/mars_dma.h\n+++ b/include/mpu/mars/mars_dma.h\n@@ -67,6 +67,8 @@ static inline unsigned int _list_init(mf\n \t\tunsigned int block_size;\n \t\tblock_size = (size < MARS_DMA_SIZE_MAX) ?\n \t\t\t\tsize : MARS_DMA_SIZE_MAX;\n+\t\tlist[count].notify = 0;\n+\t\tlist[count].reserved = 0;\n \t\tlist[count].size = block_size;\n \t\tlist[count].eal = eal;\n \t\tsize -= block_size;\n","prefixes":[]}