{"id":2223067,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2223067/?format=json","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.0/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260414104900.2617863-1-hxzene@gmail.com>","date":"2026-04-14T10:49:00","name":"[v2] netfilter: nfnetlink_osf: fix null-ptr-deref in nf_osf_ttl","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"84887649eb91594a98305d9001e5aa6a1c00b0bf","submitter":{"id":93139,"url":"http://patchwork.ozlabs.org/api/1.0/people/93139/?format=json","name":"Kito Xu (veritas501)","email":"hxzene@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260414104900.2617863-1-hxzene@gmail.com/mbox/","series":[{"id":499815,"url":"http://patchwork.ozlabs.org/api/1.0/series/499815/?format=json","date":"2026-04-14T10:49:00","name":"[v2] netfilter: nfnetlink_osf: fix null-ptr-deref in nf_osf_ttl","version":2,"mbox":"http://patchwork.ozlabs.org/series/499815/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223067/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=d7iBFd94;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11866-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"d7iBFd94\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.179","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw1Ns6Lrjz1y2d\n\tfor ; Tue, 14 Apr 2026 20:54:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 91E0E3024A38\n\tfor ; Tue, 14 Apr 2026 10:49:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7E28A3D6685;\n\tTue, 14 Apr 2026 10:49:14 +0000 (UTC)","from mail-pf1-f179.google.com (mail-pf1-f179.google.com\n [209.85.210.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A81C83D5255\n\tfor ; Tue, 14 Apr 2026 10:49:09 +0000 (UTC)","by mail-pf1-f179.google.com with SMTP id\n d2e1a72fcca58-8296dabef74so5213854b3a.1\n for ;\n Tue, 14 Apr 2026 03:49:09 -0700 (PDT)","from localhost.localdomain ([180.167.178.215])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c30ee32sm14570388b3a.7.2026.04.14.03.49.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 03:49:08 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776163753; cv=none;\n b=a6duUqKUDsS4Ex0yKqcIbQHR7EMHCGtEH22EEI0P24UXoqPNIGVrX9oCK92nuS/W5f3k6Q8/iL/BauteS1EHtQvDtr0Iuj2wuyJGH0OyvymvgSvm9BpiDJPdNLDHhsQOjIPZ/nL83/OFaV37Ii9b3B18EohDaO1ktJHpNFTknkw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776163753; c=relaxed/simple;\n\tbh=ii6RV1ygzwacH0zsmbOvUdY7N1HLtKusBUxFfTTs880=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=DXXaHn6RrKbD326s6/TJRHDapTh+FPcmvdvo6Xe3h3CVVBC+8s+qkxCkOspVV7bsraYCIb6v9NPrC7xyLbgjwk8gNZDIItiDOKcUxJRg8IKQ9yNfithqAHRGwZ9TTXzuQ7HDQXfboDjglJWaBn12vNtEkhyt4DE06muOSplM6hA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=d7iBFd94; arc=none smtp.client-ip=209.85.210.179","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776163749; x=1776768549;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qdNNcNCom14+hME7vkl9Ojg8yeM3zI8TCPW0A6x3yd0=;\n b=d7iBFd94OtA2PzD9vTFRILEHBlV/R1ybwhL84mjC1XMApTIkreP5T/mCDAELWdEBFh\n ZYyT+6f16P3f9qJLrBiFVWYWoL7yjGJXMHV8odKotPllfdbWFhaaxnG82AxqHl6pdD7I\n pwbMg2zxHyJYtTLKXOqLd8FSNZEhZm2473tPRvG89BLFPva+LOWUdiyZ0Zml/ffoCEcZ\n aui90YfrvYLQ4UzT//BvGbLS7xzAz3ljGKu5B/J7srUoAHjf0nv2bUkLz6qJh0qauyHt\n w0XtadPNTh9F10XanRnwVySwUsaanDue4CB5YDbBPGQKPtAX9thEahPs8+fOvsSclxMg\n rjdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776163749; x=1776768549;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qdNNcNCom14+hME7vkl9Ojg8yeM3zI8TCPW0A6x3yd0=;\n b=m03uubd8QQuIOD6XXFfQvbgEYkIp7/cC8UMQA7nNoIaGru17HXdePklZSHlL1eRE0s\n 7oMUKFUD7m3at8DZuTG/5/LwUWjrl9al6Fifk6WODTl/Z6AIbZ0qkb8lhEdmBnnMj2p5\n 8sh67HDx/lbEgU9dRnrQaLzRT8dT6T+pYlydT86O+1jwH8m3rP6eWCn2HAXjK7jJcV3b\n Lu9DDY7qrnB0E8FwA9Si6KtDdVKzmLXF9kPCXolxUDTkB4+klWOcgvhIDXOdziLfydHj\n 6IRs/o/Pb18JLq0qQgKyV40u6MTPVYyB6KvV7tn2yX4H8B1NZfQZqulI6bogpEITJkZL\n z1Tw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ94w4tQGHAqtOa5jAm6jHTgj4re4WXK7rjELc0xNk1hdwPkYdVC3CdztkEG+ytq6ua+pTXvTGbLn9q4O20ST8Y=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw2ETTxEngpVuHG38byDn+sDwVn1zX1dS3V19qo/obcDo0yBbLw\n\tw9j0S56p3Redbd9pInV1dtAJJLXk3hxWGDt2+cT1JpxVoJdZlE0V81s+","X-Gm-Gg":"AeBDietWDuSsTs4ct+j35YH67nAB8EuYmVKL9kEQOgHxmUzjSUzNf/MoEAjBnYfjd0G\n\tIl9s16EbNZ597YTUBx8sEiAKQBVYBFQAvePgwlkjMkYCeBzGOrp2MTKnz5J30sMTFeFErTd5907\n\tx2+fYSRCJqe2fq8IbmGtUdLcZu1PXDCf2qakqZdhhR93f3IV7dvpAWlhYiJhebPzVyjCypXXy9D\n\t7M/rsER++4yitsjHYgsl7eianp5FhvylebCBtcb3K7p56KIflGI3UBQ61OtCE618t8t47HUx8YM\n\tD9HBdoZmTI8fnkZ1L3EKGQDbOvQ1lxl9+L1Q4tWp54XB9rczwGKwM8w5HrRCaWT7p8JzxDWk9z9\n\tTpWlaFLNsB4e73uf2/bB+eIgk6Q7T10fH2AfBgwHcwwsGXAJxZqjFOaO7wuuXOjfajoCxTF9U7L\n\txLTOSnidb6JyDv25hRcBb5uqHrI6+7hbcZ","X-Received":"by 2002:a05:6a00:bd85:b0:82c:9c90:54cf with SMTP id\n d2e1a72fcca58-82f0c2c3c43mr16170482b3a.43.1776163748735;\n Tue, 14 Apr 2026 03:49:08 -0700 (PDT)","From":"\"Kito Xu (veritas501)\" ","To":"pablo@netfilter.org","Cc":"coreteam@netfilter.org,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tffmancera@riseup.net,\n\tfw@strlen.de,\n\thorms@kernel.org,\n\thxzene@gmail.com,\n\tkuba@kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tnetdev@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org,\n\tpabeni@redhat.com,\n\tphil@nwl.cc","Subject":"[PATCH v2] netfilter: nfnetlink_osf: fix null-ptr-deref in nf_osf_ttl","Date":"Tue, 14 Apr 2026 18:49:00 +0800","Message-ID":"<20260414104900.2617863-1-hxzene@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260414074556.2512750-1-hxzene@gmail.com>","References":"<20260414074556.2512750-1-hxzene@gmail.com>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"nf_osf_ttl() calls __in_dev_get_rcu(skb->dev) and passes the result\nto in_dev_for_each_ifa_rcu() without checking for NULL. When the\nreceiving device has no IPv4 configuration (ip_ptr is NULL),\n__in_dev_get_rcu() returns NULL and in_dev_for_each_ifa_rcu()\ndereferences it unconditionally, causing a kernel crash.\n\nThis can happen when a packet arrives on a device that has had its\nIPv4 configuration removed (e.g., MTU set below IPV4_MIN_MTU causing\ninetdev_destroy) or on a device that was never assigned an IPv4\naddress, while an xt_osf or nft_osf rule with TTL_LESS mode is\nactive and the packet TTL exceeds the fingerprint TTL.\n\nAdd a NULL check for in_dev before using it. When in_dev is NULL,\nreturn 0 (no match) since source-address locality cannot be\ndetermined without IPv4 addresses on the device.\n\nKASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]\nRIP: 0010:nf_osf_match_one+0x204/0xa70\nCall Trace:\n \n nf_osf_match+0x2f8/0x780\n xt_osf_match_packet+0x11c/0x1f0\n ipt_do_table+0x7fe/0x12b0\n nf_hook_slow+0xac/0x1e0\n ip_rcv+0x123/0x370\n __netif_receive_skb_one_core+0x166/0x1b0\n process_backlog+0x197/0x590\n __napi_poll+0xa1/0x540\n net_rx_action+0x401/0xd80\n handle_softirqs+0x19f/0x610\n \n\nFixes: a218dc82f0b5 (\"netfilter: nft_osf: Add ttl option support\")\nSuggested-by: Pablo Neira Ayuso \nSigned-off-by: Kito Xu (veritas501) \n---\n net/netfilter/nfnetlink_osf.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/net/netfilter/nfnetlink_osf.c b/net/netfilter/nfnetlink_osf.c\nindex d64ce21c7b55..dd2cbbd449e7 100644\n--- a/net/netfilter/nfnetlink_osf.c\n+++ b/net/netfilter/nfnetlink_osf.c\n@@ -36,6 +36,9 @@ static inline int nf_osf_ttl(const struct sk_buff *skb,\n \tconst struct in_ifaddr *ifa;\n \tint ret = 0;\n \n+\tif (!in_dev)\n+\t\treturn 0;\n+\n \tif (ttl_check == NF_OSF_TTL_TRUE)\n \t\treturn ip->ttl == f_ttl;\n \tif (ttl_check == NF_OSF_TTL_NOCHECK)\n","prefixes":["v2"]}