{"id":2221375,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221375/?format=json","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.0/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409103041.8253-3-chrubis@suse.cz>","date":"2026-04-09T10:30:41","name":"[2/2] syscalls: newuname01: Fix fail on empty domainname","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ea5e665f21708e34d423bc6983776fa7863ec5b2","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/1.0/people/8530/?format=json","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260409103041.8253-3-chrubis@suse.cz/mbox/","series":[{"id":499269,"url":"http://patchwork.ozlabs.org/api/1.0/series/499269/?format=json","date":"2026-04-09T10:30:39","name":"Fix proc parsing in newuname01","version":1,"mbox":"http://patchwork.ozlabs.org/series/499269/mbox/"}],"check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2221375/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=bBMZmXMx;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=sUMNKbmA;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=bBMZmXMx;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=sUMNKbmA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frx6m1QJ9z1xy1\n\tfor ; Thu, 09 Apr 2026 20:31:12 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id A829F3E4CFE\n\tfor ; Thu, 9 Apr 2026 12:31:09 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 5D9623E4CF3\n for ; Thu, 9 Apr 2026 12:30:35 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id E5B751A00607\n for ; Thu, 9 Apr 2026 12:30:34 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 56B0C5BD25\n for ; Thu, 9 Apr 2026 10:30:31 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4780C4A0B3\n for ; Thu, 9 Apr 2026 10:30:31 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id NN1UEMd/12lCEAAAD6G6ig\n (envelope-from )\n for ; Thu, 09 Apr 2026 10:30:31 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775730631; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UxnEn+24FH/3y6AW04xdH1ckfRCo18RAAvKVLBoiHwk=;\n b=bBMZmXMxNqWeTz82XEpnx/T12VD76n/TErUqVOMkvOOO3FdXIHyFd3dqugQYsxnzYozNsb\n /1Rn+9MKF30GtAg3HC8OAHvlceWdIqcq8896ZCCtK+kjT6tI6JI2WLnNZzgIp6WXili/Xw\n 0XzWj0elsgyo/fAMby+ixdEGD+V7/q0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775730631;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UxnEn+24FH/3y6AW04xdH1ckfRCo18RAAvKVLBoiHwk=;\n b=sUMNKbmAKXh9EKUtbB+NE2EHPUDDR4Rl+1MD4Hv098JhyvjUC0CqJvr6gBfolpkoCNxy5N\n 9OVBghP8OtdcJADA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1775730631; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UxnEn+24FH/3y6AW04xdH1ckfRCo18RAAvKVLBoiHwk=;\n b=bBMZmXMxNqWeTz82XEpnx/T12VD76n/TErUqVOMkvOOO3FdXIHyFd3dqugQYsxnzYozNsb\n /1Rn+9MKF30GtAg3HC8OAHvlceWdIqcq8896ZCCtK+kjT6tI6JI2WLnNZzgIp6WXili/Xw\n 0XzWj0elsgyo/fAMby+ixdEGD+V7/q0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1775730631;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UxnEn+24FH/3y6AW04xdH1ckfRCo18RAAvKVLBoiHwk=;\n b=sUMNKbmAKXh9EKUtbB+NE2EHPUDDR4Rl+1MD4Hv098JhyvjUC0CqJvr6gBfolpkoCNxy5N\n 9OVBghP8OtdcJADA=="],"From":"Cyril Hrubis ","To":"ltp@lists.linux.it","Date":"Thu, 9 Apr 2026 12:30:41 +0200","Message-ID":"<20260409103041.8253-3-chrubis@suse.cz>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260409103041.8253-1-chrubis@suse.cz>","References":"<20260409103041.8253-1-chrubis@suse.cz>","MIME-Version":"1.0","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1];\n ARC_NA(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:mid,suse.cz:email,imap1.dmz-prg2.suse.org:helo];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n PREVIOUSLY_DELIVERED(0.00)[ltp@lists.linux.it];\n RCVD_TLS_ALL(0.00)[]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH 2/2] syscalls: newuname01: Fix fail on empty domainname","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"The domainname can be empty hence we cannot use scanf() string for\nformat for reading the file. Use the newly added SAFE_FILE_READ_STR()\nto read the strings from procfs instead.\n\nFixes: https://github.com/linux-test-project/ltp/issues/1304\nSigned-off-by: Cyril Hrubis \n---\n testcases/kernel/syscalls/newuname/newuname01.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/testcases/kernel/syscalls/newuname/newuname01.c b/testcases/kernel/syscalls/newuname/newuname01.c\nindex 37058023a..995ea978e 100644\n--- a/testcases/kernel/syscalls/newuname/newuname01.c\n+++ b/testcases/kernel/syscalls/newuname/newuname01.c\n@@ -31,16 +31,16 @@ static void run(void)\n \n \tTST_EXP_EQ_STR(name->sysname, \"Linux\");\n \n-\tSAFE_FILE_SCANF(\"/proc/sys/kernel/hostname\", \"%1023[^\\n]\", proc_val);\n+\tSAFE_FILE_READ_STR(\"/proc/sys/kernel/hostname\", proc_val, sizeof(proc_val));\n \tTST_EXP_EQ_STR(name->nodename, proc_val);\n \n-\tSAFE_FILE_SCANF(\"/proc/sys/kernel/osrelease\", \"%1023[^\\n]\", proc_val);\n+\tSAFE_FILE_READ_STR(\"/proc/sys/kernel/osrelease\", proc_val, sizeof(proc_val));\n \tTST_EXP_EQ_STR(name->release, proc_val);\n \n-\tSAFE_FILE_SCANF(\"/proc/sys/kernel/version\", \"%1023[^\\n]\", proc_val);\n+\tSAFE_FILE_READ_STR(\"/proc/sys/kernel/version\", proc_val, sizeof(proc_val));\n \tTST_EXP_EQ_STR(name->version, proc_val);\n \n-\tSAFE_FILE_SCANF(\"/proc/sys/kernel/domainname\", \"%1023[^\\n]\", proc_val);\n+\tSAFE_FILE_READ_STR(\"/proc/sys/kernel/domainname\", proc_val, sizeof(proc_val));\n \tTST_EXP_EQ_STR(name->domainname, proc_val);\n }\n \n","prefixes":["2/2"]}