{"id":2221298,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221298/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409-work-qmp-monitor-hotplug-v4-4-89c4fdf69df1@kernel.org>","date":"2026-04-09T07:18:21","name":"[v4,4/5] tests/qtest: add tests for dynamic monitor add/remove","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8ea0c92424251929f29fd4e694a25e4e363c2315","submitter":{"id":82326,"url":"http://patchwork.ozlabs.org/api/1.0/people/82326/?format=json","name":"Christian Brauner","email":"brauner@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-work-qmp-monitor-hotplug-v4-4-89c4fdf69df1@kernel.org/mbox/","series":[{"id":499242,"url":"http://patchwork.ozlabs.org/api/1.0/series/499242/?format=json","date":"2026-04-09T07:18:17","name":"monitor: add dynamic QMP monitor hotplug support","version":4,"mbox":"http://patchwork.ozlabs.org/series/499242/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221298/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=M11ggZ7J;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frrtH5Rntz211P\n\tfor ; Thu, 09 Apr 2026 17:20:07 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAjfE-0007MA-8B; Thu, 09 Apr 2026 03:18:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAjf8-0007LE-Ab\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 03:18:50 -0400","from sea.source.kernel.org ([172.234.252.31])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAjf2-0000ZU-1Z\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 03:18:46 -0400","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 16AB14083E;\n Thu, 9 Apr 2026 07:18:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A46F5C116C6;\n Thu, 9 Apr 2026 07:18:40 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1775719123;\n bh=eFQHDBLnQd7WByUYlLzT6pUo4auGgUaiOW6f2kX44DI=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=M11ggZ7JYY42QzswapCEZAr0qpNgLGAo1ZTgvuImxvjwPSjGpd+iA/oGFa6826gsW\n 6xWbp/FGTMCaOemKZdGeHFqQUF4Rdst7UP1IA9YvZ6KTlfJIa4QPApk3HZmBzCq7KX\n 9LCXH6EroGwqMFo6AjXkiiF/yGIrfc2u0BFCMafQVkx7zeqKGM2Ehw0zmNYLwhZF6R\n EYaDdNZIBkEUIhTrNBTJu6AJbnhgxY2LBecf1bShefAJBZAQfPPOvkTyBgo8ySNvOi\n KhsCK1IvZ95BrUyvmS5IX5/aecN9qN6a0GHidPSXOlUUyIDStn5oC8Y1nB1csqMKK9\n zH1E3H2eBEjxQ==","From":"Christian Brauner ","Date":"Thu, 09 Apr 2026 09:18:21 +0200","Subject":"[PATCH v4 4/5] tests/qtest: add tests for dynamic monitor add/remove","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260409-work-qmp-monitor-hotplug-v4-4-89c4fdf69df1@kernel.org>","References":"<20260409-work-qmp-monitor-hotplug-v4-0-89c4fdf69df1@kernel.org>","In-Reply-To":"<20260409-work-qmp-monitor-hotplug-v4-0-89c4fdf69df1@kernel.org>","To":"qemu-devel@nongnu.org","Cc":"Markus Armbruster , Eric Blake ,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini , Thomas Huth ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n Christian Brauner ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=8185; i=brauner@kernel.org;\n h=from:subject:message-id; bh=eFQHDBLnQd7WByUYlLzT6pUo4auGgUaiOW6f2kX44DI=;\n b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWReDzrav6m1kK38pWbvnYV2sZuULWxLw6becH94ewJ3c\n pD4tq5fHaUsDGJcDLJiiiwO7Sbhcst5KjYbZWrAzGFlAhnCwMUpABNhrmRkmG/7fA6/ctOHkoO+\n EXuPXrp5iWM9b93OwAntl9STf69iOcbIcFW8zDFt575Pgmwx4ZcMs5jqhbadORBr/ufGn1efhfT\n 2cgAA","X-Developer-Key":"i=brauner@kernel.org; a=openpgp;\n fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624","Received-SPF":"pass client-ip=172.234.252.31; envelope-from=brauner@kernel.org;\n helo=sea.source.kernel.org","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Test the monitor-add, monitor-remove, and query-monitors QMP commands:\n\n- Basic lifecycle: chardev-add -> monitor-add -> query-monitors ->\n monitor-remove -> chardev-remove\n- Error: duplicate monitor id\n- Error: monitor-remove on nonexistent id\n- Error: monitor-add with nonexistent chardev\n- Error: second monitor on same chardev (chardev already in use)\n- Removal of CLI-created QMP monitor succeeds\n- Error: monitor-remove on HMP monitor\n- Re-add after remove: same id and chardev reusable after removal\n\nSigned-off-by: Christian Brauner (Amutable) \n---\n tests/qtest/qmp-test.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 193 insertions(+)","diff":"diff --git a/tests/qtest/qmp-test.c b/tests/qtest/qmp-test.c\nindex edf0886787..3ff6de3626 100644\n--- a/tests/qtest/qmp-test.c\n+++ b/tests/qtest/qmp-test.c\n@@ -337,6 +337,193 @@ static void test_qmp_missing_any_arg(void)\n qtest_quit(qts);\n }\n \n+static void test_qmp_monitor_add_remove(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_init(common_args);\n+\n+ /* Create a null chardev for the dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-add',\"\n+ \" 'arguments': {'id': 'monitor-chardev',\"\n+ \" 'backend': {'type': 'null',\"\n+ \" 'data': {}}}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Add a dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Verify it shows up in query-monitors */\n+ resp = qtest_qmp(qts, \"{'execute': 'query-monitors'}\");\n+ g_assert(!qdict_haskey(resp, \"error\"));\n+ qobject_unref(resp);\n+\n+ /* Error: duplicate id */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Remove the dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Error: remove nonexistent */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Add again after remove -- same id and chardev should work */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Clean up */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-remove',\"\n+ \" 'arguments': {'id': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ qtest_quit(qts);\n+}\n+\n+static void test_qmp_monitor_error_paths(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_init(common_args);\n+\n+ /* Error: chardev does not exist */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'bad-mon',\"\n+ \" 'chardev': 'nonexistent'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Error: remove nonexistent monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'bogus'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ qtest_quit(qts);\n+}\n+\n+static void test_qmp_monitor_chardev_in_use(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_init(common_args);\n+\n+ /* Create a null chardev */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-add',\"\n+ \" 'arguments': {'id': 'shared-chr',\"\n+ \" 'backend': {'type': 'null',\"\n+ \" 'data': {}}}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Attach first monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'mon-1',\"\n+ \" 'chardev': 'shared-chr'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Error: second monitor on the same chardev */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'mon-2',\"\n+ \" 'chardev': 'shared-chr'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Clean up */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'mon-1'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-remove',\"\n+ \" 'arguments': {'id': 'shared-chr'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ qtest_quit(qts);\n+}\n+\n+static void test_qmp_monitor_remove_cli(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ /* Launch with a named CLI monitor on a null chardev */\n+ qts = qtest_initf(\"%s -chardev null,id=cli-chr\"\n+ \" -mon id=cli-mon,chardev=cli-chr,mode=control\",\n+ common_args);\n+\n+ /* CLI-created QMP monitors can be removed */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'cli-mon'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-remove',\"\n+ \" 'arguments': {'id': 'cli-chr'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ qtest_quit(qts);\n+}\n+\n+static void test_qmp_monitor_remove_hmp(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_initf(\"%s -chardev null,id=hmp-chr\"\n+ \" -mon id=hmp-mon,chardev=hmp-chr,mode=readline\",\n+ common_args);\n+\n+ /* Error: monitor-remove must reject HMP monitors */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'hmp-mon'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ qtest_quit(qts);\n+}\n+\n int main(int argc, char *argv[])\n {\n g_test_init(&argc, &argv, NULL);\n@@ -348,6 +535,12 @@ int main(int argc, char *argv[])\n #endif\n qtest_add_func(\"qmp/preconfig\", test_qmp_preconfig);\n qtest_add_func(\"qmp/missing-any-arg\", test_qmp_missing_any_arg);\n+ qtest_add_func(\"qmp/monitor-add-remove\", test_qmp_monitor_add_remove);\n+ qtest_add_func(\"qmp/monitor-error-paths\", test_qmp_monitor_error_paths);\n+ qtest_add_func(\"qmp/monitor-chardev-in-use\",\n+ test_qmp_monitor_chardev_in_use);\n+ qtest_add_func(\"qmp/monitor-remove-cli\", test_qmp_monitor_remove_cli);\n+ qtest_add_func(\"qmp/monitor-remove-hmp\", test_qmp_monitor_remove_hmp);\n \n return g_test_run();\n }\n","prefixes":["v4","4/5"]}