{"id":2221291,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221291/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409-fix-unit-address-v1-3-946840930af2@iscas.ac.cn>","date":"2026-04-09T06:40:13","name":"[3/5] hw/mips: Use hex unit addresses in FDT CPU nodes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"591460d7f7daee3c30f27fc56a736e6413ead38a","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/1.0/people/91053/?format=json","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-fix-unit-address-v1-3-946840930af2@iscas.ac.cn/mbox/","series":[{"id":499239,"url":"http://patchwork.ozlabs.org/api/1.0/series/499239/?format=json","date":"2026-04-09T06:40:10","name":"hw: Fix unit addresses of FDT CPU nodes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499239/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221291/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frr2Y0yMTz1yD3\n\tfor ; Thu, 09 Apr 2026 16:42:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAj4V-0007tg-6F; Thu, 09 Apr 2026 02:40:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4N-0007qy-QO; Thu, 09 Apr 2026 02:40:52 -0400","from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4H-0004Pl-FD; Thu, 09 Apr 2026 02:40:50 -0400","from [127.0.0.2] (unknown [36.110.52.2])\n by APP-03 (Coremail) with SMTP id rQCowABnht3aSddpeI91DQ--.34096S5;\n Thu, 09 Apr 2026 14:40:27 +0800 (CST)"],"From":"Vivian Wang ","Date":"Thu, 09 Apr 2026 14:40:13 +0800","Subject":"[PATCH 3/5] hw/mips: Use hex unit addresses in FDT CPU nodes","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260409-fix-unit-address-v1-3-946840930af2@iscas.ac.cn>","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","In-Reply-To":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org,\n Vivian Wang ","X-Mailer":"b4 0.15.1","X-CM-TRANSID":"rQCowABnht3aSddpeI91DQ--.34096S5","X-Coremail-Antispam":"1UD129KBjvdXoW7GF4xtFWrWFW8uw4DuF4rXwb_yoWDGwbE9a\n 9FvrnYva1DJry2gF93Zr9FyFyrJ345XF1I9an7Kr43t348ArWrA3ZY9rWDJry5XrW8Cry3\n u3s8Xr15KanxtjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n 9fnUUIcSsGvfJTRUUUbkAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG\n 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY02\n 0Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv\n wVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM2\n 8EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS\n 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2\n IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0\n Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kIc2\n xKxwCY1x0262kKe7AKxVW8ZVWrXwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU\n JVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67\n kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY\n 6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42\n IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIev\n Ja73UjIFyTuYvjTRuzuWDUUUU","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.81;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These unit addresses should have been in hex, not decimal, as per de\nfacto convention [1]. Fix them.\n\nLink: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\nSigned-off-by: Vivian Wang \n---\n hw/mips/boston.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/mips/boston.c b/hw/mips/boston.c\nindex 4579df23eb..9ef3f6c814 100644\n--- a/hw/mips/boston.c\n+++ b/hw/mips/boston.c\n@@ -542,7 +542,7 @@ static const void *create_fdt(BostonState *s,\n qemu_fdt_setprop_cell(fdt, \"/cpus\", \"#address-cells\", 0x1);\n \n for (cpu = 0; cpu < ms->smp.cpus; cpu++) {\n- name = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n+ name = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n qemu_fdt_add_subnode(fdt, name);\n qemu_fdt_setprop_string(fdt, name, \"compatible\", \"img,mips\");\n qemu_fdt_setprop_string(fdt, name, \"status\", \"okay\");\n","prefixes":["3/5"]}