{"id":2221290,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221290/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409-fix-unit-address-v1-4-946840930af2@iscas.ac.cn>","date":"2026-04-09T06:40:14","name":"[4/5] hw/or1k: Use hex unit addresses in FDT CPU nodes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a1f4c90b04b86c6c9eb2a1d5d6dda241b822f060","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/1.0/people/91053/?format=json","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-fix-unit-address-v1-4-946840930af2@iscas.ac.cn/mbox/","series":[{"id":499239,"url":"http://patchwork.ozlabs.org/api/1.0/series/499239/?format=json","date":"2026-04-09T06:40:10","name":"hw: Fix unit addresses of FDT CPU nodes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499239/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221290/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frr2W2TF8z1yD3\n\tfor ; Thu, 09 Apr 2026 16:42:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAj4V-0007tf-5O; Thu, 09 Apr 2026 02:40:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4N-0007qr-P9; Thu, 09 Apr 2026 02:40:52 -0400","from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAj4H-0004PV-FD; Thu, 09 Apr 2026 02:40:50 -0400","from [127.0.0.2] (unknown [36.110.52.2])\n by APP-03 (Coremail) with SMTP id rQCowABnht3aSddpeI91DQ--.34096S6;\n Thu, 09 Apr 2026 14:40:27 +0800 (CST)"],"From":"Vivian Wang ","Date":"Thu, 09 Apr 2026 14:40:14 +0800","Subject":"[PATCH 4/5] hw/or1k: Use hex unit addresses in FDT CPU nodes","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260409-fix-unit-address-v1-4-946840930af2@iscas.ac.cn>","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","In-Reply-To":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org,\n Vivian Wang ","X-Mailer":"b4 0.15.1","X-CM-TRANSID":"rQCowABnht3aSddpeI91DQ--.34096S6","X-Coremail-Antispam":"1UD129KBjvJXoW7KFyUXF1fZr4UKF1rJr48tFb_yoW8Wr4Dpa\n 97Aa4UtryxtrW7Ga9avF1UC3WrtrnxXr47WFZ3uw48Arn8Xry7WF1Iy393tryUXF95tF4a\n qFZ3GFy0qw1vgrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDU0xBIdaVrnRJUUUma14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI\n kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2\n z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F\n 4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE\n 3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2I\n x0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8\n JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2\n ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Y\n z7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zV\n AF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4l\n IxAIcVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF\n 4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsG\n vfC2KfnxnUUI43ZEXa7sREBOJ5UUUUU==","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.81;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These unit addresses should have been in hex, not decimal, as per de\nfacto convention [1]. Fix them.\n\nLink: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\nSigned-off-by: Vivian Wang \n---\n hw/or1k/or1k-sim.c | 2 +-\n hw/or1k/virt.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/or1k/or1k-sim.c b/hw/or1k/or1k-sim.c\nindex f1b1f63274..b851e48c16 100644\n--- a/hw/or1k/or1k-sim.c\n+++ b/hw/or1k/or1k-sim.c\n@@ -138,7 +138,7 @@ static void openrisc_create_fdt(Or1ksimState *state,\n qemu_fdt_setprop_cell(fdt, \"/cpus\", \"#address-cells\", 0x1);\n \n for (cpu = 0; cpu < num_cpus; cpu++) {\n- nodename = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n+ nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n qemu_fdt_add_subnode(fdt, nodename);\n qemu_fdt_setprop_string(fdt, nodename, \"compatible\",\n \"opencores,or1200-rtlsvn481\");\ndiff --git a/hw/or1k/virt.c b/hw/or1k/virt.c\nindex 39f54058ab..ac644f128e 100644\n--- a/hw/or1k/virt.c\n+++ b/hw/or1k/virt.c\n@@ -162,7 +162,7 @@ static void openrisc_create_fdt(OR1KVirtState *state,\n qemu_fdt_setprop_cell(fdt, \"/cpus\", \"#address-cells\", 0x1);\n \n for (cpu = 0; cpu < num_cpus; cpu++) {\n- nodename = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n+ nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n qemu_fdt_add_subnode(fdt, nodename);\n qemu_fdt_setprop_string(fdt, nodename, \"compatible\",\n \"opencores,or1200-rtlsvn481\");\n","prefixes":["4/5"]}