{"id":2221286,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221286/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260409-fix-unit-address-v1-2-946840930af2@iscas.ac.cn>","date":"2026-04-09T06:40:12","name":"[2/5] hw/loongarch: Use hex unit addresses in FDT CPU nodes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7f57f65c3f483f79e5312904c29e8b034a347af3","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/1.0/people/91053/?format=json","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260409-fix-unit-address-v1-2-946840930af2@iscas.ac.cn/mbox/","series":[{"id":499239,"url":"http://patchwork.ozlabs.org/api/1.0/series/499239/?format=json","date":"2026-04-09T06:40:10","name":"hw: Fix unit addresses of FDT CPU nodes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499239/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221286/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frr1w4JvKz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 16:41:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAj4S-0007sB-VO; Thu, 09 Apr 2026 02:40:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <wangruikang@iscas.ac.cn>)\n id 1wAj4L-0007qe-Rf; Thu, 09 Apr 2026 02:40:51 -0400","from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from <wangruikang@iscas.ac.cn>)\n id 1wAj4H-0004PS-EC; Thu, 09 Apr 2026 02:40:49 -0400","from [127.0.0.2] (unknown [36.110.52.2])\n by APP-03 (Coremail) with SMTP id rQCowABnht3aSddpeI91DQ--.34096S4;\n Thu, 09 Apr 2026 14:40:27 +0800 (CST)"],"From":"Vivian Wang <wangruikang@iscas.ac.cn>","Date":"Thu, 09 Apr 2026 14:40:12 +0800","Subject":"[PATCH 2/5] hw/loongarch: Use hex unit addresses in FDT CPU nodes","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260409-fix-unit-address-v1-2-946840930af2@iscas.ac.cn>","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","In-Reply-To":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>","To":"qemu-devel@nongnu.org","Cc":"Peter Maydell <peter.maydell@linaro.org>,\n  Leif Lindholm <leif.lindholm@oss.qualcomm.com>, qemu-arm@nongnu.org,\n  Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>,\n  Jiaxun Yang <jiaxun.yang@flygoat.com>, Paul Burton <paulburton@kernel.org>,\n  Aleksandar Rikalo <arikalo@gmail.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>,  Jia Liu <proljc@gmail.com>,\n Stafford Horne <shorne@gmail.com>,\n  Alistair Francis <Alistair.Francis@wdc.com>,\n  Palmer Dabbelt <palmer@dabbelt.com>, Weiwei Li <liwei1518@gmail.com>,\n  Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n  Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n  Chao Liu <chao.liu.zevorn@gmail.com>, qemu-riscv@nongnu.org,\n  Vivian Wang <wangruikang@iscas.ac.cn>","X-Mailer":"b4 0.15.1","X-CM-TRANSID":"rQCowABnht3aSddpeI91DQ--.34096S4","X-Coremail-Antispam":"1UD129KBjvJXoW7GF4xtFWrWFW8uw4DuF4rXwb_yoW8JrW3p3\n 929asrJrZ7KrZrJ342yFyY9F15KFn8Gw42qa9Fgw40yr9rWr18uF1IyrWqvFyUJa4rJF4r\n ZFs5tF93Xas0y3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDU0xBIdaVrnRJUUUmF14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2\n x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0\n Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw\n A2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1l\n e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI\n 8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwAC\n jcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka0x\n kIwI1lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_\n Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1V\n AY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAI\n cVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIx\n AIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2\n KfnxnUUI43ZEXa7sREHGQ3UUUUU==","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.81;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These unit addresses should have been in hex, not decimal, as per de\nfacto convention [1]. Fix them.\n\nLink: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\nSigned-off-by: Vivian Wang <wangruikang@iscas.ac.cn>\n---\n hw/loongarch/virt-fdt-build.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/loongarch/virt-fdt-build.c b/hw/loongarch/virt-fdt-build.c\nindex 6c06b36fca..5875c6d9ae 100644\n--- a/hw/loongarch/virt-fdt-build.c\n+++ b/hw/loongarch/virt-fdt-build.c\n@@ -66,7 +66,7 @@ static void fdt_add_cpu_nodes(const LoongArchVirtMachineState *lvms)\n             continue;\n         }\n \n-        nodename = g_strdup_printf(\"/cpus/cpu@%d\", num);\n+        nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)num);\n         cpu = LOONGARCH_CPU(cs);\n \n         qemu_fdt_add_subnode(ms->fdt, nodename);\n@@ -91,7 +91,7 @@ static void fdt_add_cpu_nodes(const LoongArchVirtMachineState *lvms)\n             continue;\n         }\n \n-        nodename = g_strdup_printf(\"/cpus/cpu@%d\", num);\n+        nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)num);\n         if (ms->smp.threads > 1) {\n             map_path = g_strdup_printf(\n                 \"/cpus/cpu-map/socket%d/core%d/thread%d\",\n","prefixes":["2/5"]}