{"id":2221238,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221238/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260408220928.3328551-2-daniel@thingy.jp>","date":"2026-04-08T22:09:24","name":"[v3,1/5] sysreset: qemu virt: Use __raw_writel()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"03d77042ecd6a309518600d5df879451ce44a2c1","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/1.0/people/85408/?format=json","name":"Daniel Palmer","email":"daniel@thingy.jp"},"delegate":{"id":14103,"url":"http://patchwork.ozlabs.org/api/1.0/users/14103/?format=json","username":"spectrum","first_name":"Angelo","last_name":"Dureghello","email":"sysamfw@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260408220928.3328551-2-daniel@thingy.jp/mbox/","series":[{"id":499218,"url":"http://patchwork.ozlabs.org/api/1.0/series/499218/?format=json","date":"2026-04-08T22:09:23","name":"Add virtio-mmio support to m68k virt machine","version":3,"mbox":"http://patchwork.ozlabs.org/series/499218/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221238/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=mkut9WoT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"mkut9WoT\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frcgg33N7z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 08:10:07 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3D95B84099;\n\tThu,  9 Apr 2026 00:09:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A91B184120; Thu,  9 Apr 2026 00:09:54 +0200 (CEST)","from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n [IPv6:2607:f8b0:4864:20::430])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7F94B84099\n for <u-boot@lists.denx.de>; Thu,  9 Apr 2026 00:09:52 +0200 (CEST)","by mail-pf1-x430.google.com with SMTP id\n d2e1a72fcca58-82cd70febc7so210363b3a.2\n for <u-boot@lists.denx.de>; Wed, 08 Apr 2026 15:09:52 -0700 (PDT)","from kinako ([2400:2200:7f0:5ee8:dac6:2cde:760c:93f])\n by smtp.googlemail.com with ESMTPSA id\n d2e1a72fcca58-82cf9b60199sm19877723b3a.25.2026.04.08.15.09.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 08 Apr 2026 15:09:50 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1775686191; x=1776290991; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wh+AjOI1neGCNksUBRwhLrJZffLtfeFK2xp9XDYIzUM=;\n b=mkut9WoTOhkLzcLkOzOlS1Be8w07Yr0N04qbA4JVFIS1+sRFHu9skmz69Vbt6Dd3z/\n 0ejSamlJI2VzqF4rQbJ65aog3jGxZz5Ra6/ROILds946EWHbUuT6M1q0A6TvMUUHFUTF\n hSQ7tMTL/Ngy9H1Jk3JVCwGnuyEY7f8oq+Cww=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775686191; x=1776290991;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=wh+AjOI1neGCNksUBRwhLrJZffLtfeFK2xp9XDYIzUM=;\n b=bgK5r2kx2e9liY7ow85vxM1CNF/yF07rITLVUpdSDkWjOqLbiRussco5MdrxAeRvVH\n uu2q7eTGm9efoiSfLGzOUpSEnR6j46pyPIzegHDZASBNwbT8uXSM/sNxacpHjkJT2Qo8\n 4D2KbvdDlyFDsFJiCdeiWx04W+Tju7yQNacx6uYPaqPMTw6eIbZKARjdCe3vH96jrc2U\n TvvR4r/cRE61C8w95mtQsbRhhC0IE/dw8XcgAih323skbl2lycbaoHbkBcguHnIsMAlQ\n CPXUxJLbh2k6X+p6J3j6mOe5hOqqzNyscaw7Y3Fdmn3hTeGqxh++0dmyQwfWHeflw4qv\n wfxQ==","X-Gm-Message-State":"AOJu0YwJH8OYeWb+rpYalklxFG6RVPA5pp+kIt/zcs0ZytzX1uYJVcz8\n 0d/0QNzgRj+i4kqr2vGNGbO5l4yDMOD442p91XuorBDW+s2tC3ERzAi6kRFXtnz8rmI=","X-Gm-Gg":"AeBDiev52u3UkDdnmEd8WIwdrBgFugNImfm5VtE+Td4zoW5cXhw21F1ibMcA54FyRz3\n 4D/Ub95OKcByIaOiHzSrLiWl9kG7ZC6r03v4AqvH4wReSNQo5zG1ybue0/uW9Q5iJXI884AVW4k\n PDYtUuKRNzuMGCD+JfWzHNWVvX6EtJ99Rfb3rUf0Nnjtl765vxUMnVuY3Ii3tt/TajLu9YA4AnG\n JkRu8rRL9NNFZxSh2QLYUegrqdV+wBZO2MEp9gGtBv2FxXcItIJ6TMTaK1G+Vczgby7NXg3DYxU\n lySqRTGqRknZylCwZ9oa/aryO+pHTptROnNlKkGyfkE9wWQvulxvDxoVCyOR0Hl5i46z6aXKt1q\n mQQtsynul47Dc8AochddTeT3OWj6vN33SEVdayzIXVZMNGEUr0x2X5F7yTEd9E37mhtU5FF6C5c\n pXKWOYaWwf/JGKYcZHoH9uZ2U=","X-Received":"by 2002:a05:6a00:e06:b0:81f:5037:a317 with SMTP id\n d2e1a72fcca58-82d0da2834dmr23045091b3a.11.1775686191008;\n Wed, 08 Apr 2026 15:09:51 -0700 (PDT)","From":"Daniel Palmer <daniel@thingy.jp>","To":"visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com","Cc":"u-boot@lists.denx.de,\n\tDaniel Palmer <daniel@thingy.jp>","Subject":"[PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel()","Date":"Thu,  9 Apr 2026 07:09:24 +0900","Message-ID":"<20260408220928.3328551-2-daniel@thingy.jp>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260408220928.3328551-1-daniel@thingy.jp>","References":"<20260408220928.3328551-1-daniel@thingy.jp>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The virt ctrl register seems to be native endian, currently this driver\nuses writel(), which works by luck because its currently broken on m68k.\n\nUse __raw_writel() instead to avoid breaking this driver when the\nendianness of writel() is fixed.\n\nSigned-off-by: Daniel Palmer <daniel@thingy.jp>\nAcked-by: Kuan-Wei Chiu <visitorckw@gmail.com>\n---\n drivers/sysreset/sysreset_qemu_virt_ctrl.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/sysreset/sysreset_qemu_virt_ctrl.c b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\nindex e7cacc9b6e98..5ab16001922b 100644\n--- a/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n+++ b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n@@ -38,7 +38,7 @@ static int qemu_virt_ctrl_request(struct udevice *dev, enum sysreset_t type)\n \t\treturn -EPROTONOSUPPORT;\n \t}\n \n-\twritel(val, plat->reg + VIRT_CTRL_REG_CMD);\n+\t__raw_writel(val, plat->reg + VIRT_CTRL_REG_CMD);\n \n \treturn -EINPROGRESS;\n }\n","prefixes":["v3","1/5"]}