{"id":2221143,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221143/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408100605.66795-2-philmd@linaro.org>","date":"2026-04-08T10:06:04","name":"[PATCH-for-11.0?,1/2] io: Clear dangling GLib event source tag","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d72b672e34fcb2dcdb16bd2d2c3c1a08b499a76","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408100605.66795-2-philmd@linaro.org/mbox/","series":[{"id":499196,"url":"http://patchwork.ozlabs.org/api/1.0/series/499196/?format=json","date":"2026-04-08T10:06:04","name":"io: use g_clear_handle_id() for GSource cleanup","version":1,"mbox":"http://patchwork.ozlabs.org/series/499196/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221143/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LS2OjBEO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frY0y6GVxz1xv0\n\tfor ; Thu, 09 Apr 2026 05:24:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYJN-0007zR-4S; Wed, 08 Apr 2026 15:11:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAYGn-0004RJ-4M\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:08:57 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAPnc-0005kD-Fe\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 06:06:17 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so48359785e9.2\n for ; Wed, 08 Apr 2026 03:06:15 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488c5271676sm16822945e9.0.2026.04.08.03.06.12\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 08 Apr 2026 03:06:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775642774; x=1776247574; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dEuPWWzhYNRcUX4pgtCbVMTtFv0Mv67NoRXMJwkflzs=;\n b=LS2OjBEOCw00wtlRNvgcq7PbntqqzyxaVSKiJnDPVChdXZ63US58j/FLef229Z2y54\n uqqn0fIXjXzEVi+6va4PknI5hoTSG1v1EzRhGZMpyJlYeQa6d3yp6xJd3EVeSRaKyT1E\n OrTUYPwKwHkyibTOqFD8oexOgavAScfBa08w+cBEXvH9B+m8yspRHf/yM+EHivD1ZYH2\n y5ilApZT79GYYMMlrdef4spvQxYWgNgt4oEHEPATiBPtND7zMlFUJh1W54DtUpleog0l\n +htpIN/UWIMliWPn7aF4okM7vuzAmpUayeWMG2AtY1n8fVg8LzWaUnj3EfOdMIO9kF0T\n kqCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775642774; x=1776247574;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=dEuPWWzhYNRcUX4pgtCbVMTtFv0Mv67NoRXMJwkflzs=;\n b=AIynODrlicoesN12M3V8kUOBwLC4zwu+ZYBKSv5NoI+LZRRrwgt4w9Zd6mIq/MHYUz\n YqXkuZxmVr0Wjt22MhxYja5l3b482V0sLBfy7l60jtD1EeyuF9NkjwUWyQRPkwDVkUri\n wjQJja5cRlFacE5PriICGa+16cFrilnbeQKxhb5foSq9LQwvgBqdZY/hilSQuf/sqhiG\n a4LJIz2jEkYo/LghYofVo3wIBaRkpqqf476WxHHRU2yxuZmTyTbwxf/os8T0KY/qlkMP\n vD2lCer1dRg+czy5lDjRiK5UbP66fys7X6GVxNfq6faZW43vfHfKikRBf1/4OXWdmZy9\n I8Cw==","X-Gm-Message-State":"AOJu0Yy/ecKizGoUHm664GOWroikW5aHOM0oNNA7tITxUEnGMYKFhFlK\n 4tdJxH50aI4VHEQ5WkkR2Qu0cbmyGreLkwipA14TKmqdq/vVhdmko1/dPZcq83SIU6ytTBt3W8X\n 8qJKl/Sg=","X-Gm-Gg":"AeBDies7JtDjeyy7FqXKKL30R3dxMUpzkY7p9YfgBe+r69xH4fmvLhP99kBVhrdZHxl\n 3zbf7oDMorbkMEaO5SaCPtWWaqfYUJ3ahdFBtdianTDGLzwDUN4QP5dx7PnfDazY4PXaMos6Vzn\n 6Bb/I6v2tzmt6XskSQfqEcuIfRWUlWuvxOerled5//8RqvNI6P1cD26FVZJSIMpSponRl4UGfVu\n ob1u7eRN2/ky5oSxz2DxWt3DpaOISMvAgE/qNOqKlPDLr8AH+Zp7qa+zg4FxT0CLaHePblSeqVm\n RO/hvHgQW04eIbyx2B8d80rH5rcORW2OsA96rt6KvGh7BZGcD9XfHVjAFYP+rxUma2s2WHeH7Da\n hNu0P9nL9m5jRQ3sFd4wPBt/Mnj+s7hVfXOaNPQ5UcQkbpTKoM9qI9SEOzKV8RDG0TXZc8KN0gn\n BabXNnYjOwYWqhGyM7DU2/7x3tyu6e3d3sPO87t6eIR/CBP4G9SCFPmT85yOa+QPjosjHinoq4","X-Received":"by 2002:a05:600c:3b87:b0:486:fe23:1707 with SMTP id\n 5b1f17b1804b1-488997ac1bdmr300733115e9.20.1775642773800;\n Wed, 08 Apr 2026 03:06:13 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Matthew Penney ","Subject":"[PATCH-for-11.0? 1/2] io: Clear dangling GLib event source tag","Date":"Wed, 8 Apr 2026 12:06:04 +0200","Message-ID":"<20260408100605.66795-2-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260408100605.66795-1-philmd@linaro.org>","References":"<20260408100605.66795-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Following commit 34aad589019 (\"hw/char/virtio-console: clear\ndangling GLib event source tag\"), prevent stale tags from\nbeing reused by clearing dangling GLib event source tag during\nthe cleanup phase (finalize, unrealize).\n\nInspiread-by: Matthew Penney \nSigned-off-by: Philippe Mathieu-Daudé \n---\n hw/usb/redirect.c | 4 +---\n io/channel-websock.c | 8 ++------\n target/i386/kvm/tdx-quote-generator.c | 5 +----\n 3 files changed, 4 insertions(+), 13 deletions(-)","diff":"diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c\nindex fda5bbca676..100afbdb06a 100644\n--- a/hw/usb/redirect.c\n+++ b/hw/usb/redirect.c\n@@ -1494,9 +1494,7 @@ static void usbredir_unrealize(USBDevice *udev)\n if (dev->parser) {\n usbredirparser_destroy(dev->parser);\n }\n- if (dev->watch) {\n- g_source_remove(dev->watch);\n- }\n+ g_clear_handle_id(&dev->watch, g_source_remove);\n \n free(dev->filter_rules);\n qemu_del_vm_change_state_handler(dev->vmstate);\ndiff --git a/io/channel-websock.c b/io/channel-websock.c\nindex 9902b014f79..da7e7c9e345 100644\n--- a/io/channel-websock.c\n+++ b/io/channel-websock.c\n@@ -950,12 +950,8 @@ static void qio_channel_websock_finalize(Object *obj)\n buffer_free(&ioc->encinput);\n buffer_free(&ioc->encoutput);\n buffer_free(&ioc->rawinput);\n- if (ioc->hs_io_tag) {\n- g_source_remove(ioc->hs_io_tag);\n- }\n- if (ioc->io_tag) {\n- g_source_remove(ioc->io_tag);\n- }\n+ g_clear_handle_id(&ioc->hs_io_tag, g_source_remove);\n+ g_clear_handle_id(&ioc->io_tag, g_source_remove);\n error_free(ioc->io_err);\n object_unref(OBJECT(ioc->master));\n }\ndiff --git a/target/i386/kvm/tdx-quote-generator.c b/target/i386/kvm/tdx-quote-generator.c\nindex dee8334b27a..002bc40c8a8 100644\n--- a/target/i386/kvm/tdx-quote-generator.c\n+++ b/target/i386/kvm/tdx-quote-generator.c\n@@ -74,10 +74,7 @@ static void encode_header(char *buf, size_t len, uint32_t size) {\n static void tdx_generate_quote_cleanup(TdxGenerateQuoteTask *task)\n {\n timer_del(&task->timer);\n-\n- if (task->watch) {\n- g_source_remove(task->watch);\n- }\n+ g_clear_handle_id(&task->watch, g_source_remove);\n qio_channel_close(QIO_CHANNEL(task->sioc), NULL);\n object_unref(OBJECT(task->sioc));\n \n","prefixes":["PATCH-for-11.0?","1/2"]}