{"id":2221122,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221122/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408041953.1899532-6-brian.cain@oss.qualcomm.com>","date":"2026-04-08T04:19:30","name":"[v4,05/28] target/hexagon: Implement wait helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c6c994dac3fd41dd9b7653489affc6ef2e96b387","submitter":{"id":89839,"url":"http://patchwork.ozlabs.org/api/1.0/people/89839/?format=json","name":"Brian Cain","email":"brian.cain@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408041953.1899532-6-brian.cain@oss.qualcomm.com/mbox/","series":[{"id":499179,"url":"http://patchwork.ozlabs.org/api/1.0/series/499179/?format=json","date":"2026-04-08T04:19:31","name":"Hexagon system emulation - Part 2/3","version":4,"mbox":"http://patchwork.ozlabs.org/series/499179/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221122/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=pD8uVQnG;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Dy0sQR3Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXvX3cTYz1yD3\n\tfor ; Thu, 09 Apr 2026 05:20:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYKH-00038r-OO; Wed, 08 Apr 2026 15:12:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAYIy-0007Je-5v\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:11:12 -0400","from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAKOm-0005Z5-A4\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 00:20:18 -0400","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 637J81dc3362677\n for ; Wed, 8 Apr 2026 04:20:15 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd7tkhexe-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 08 Apr 2026 04:20:14 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2ba9a744f7dso8188875eec.0\n for ; Tue, 07 Apr 2026 21:20:14 -0700 (PDT)","from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c14a371b1sm6480362c88.13.2026.04.07.21.20.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 21:20:12 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=; b=pD8uVQnGfLzRoYKj\n n06zRY9N/4780ZX1HU4Xnfslh97achh1026fk6inUT9dILEtexOgAhZjEys5xfEm\n BjHhI9ikFlBaG4RQ2Q65BbTQXi+DnBWQfjDWIH40vTvtAme4HLIkwNCEHuJG10J/\n XtWw+/GLevwuEiehiO76iJvahH5QhKnszKrYv1nGYmfDL6ssrf9ORO/HpE0GkPFD\n 2F8VgUO9P3UgV8F6UFuv6u/NTT551/8RRvSCFkFuHWPYMYAmGTnOBfH/R3mtPGzZ\n QgUjDaV0heP9qxySBJ/zotb6IApJ8MjY6fScpp+KM4NxJPMOgM/QTpkD3fWRMes2\n DXy96A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775622014; x=1776226814; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=;\n b=Dy0sQR3QjDDbBXEJVNR5cEFG5MyM1RvMxbA0S0h29UtH33DdOW8KGeRrhMKybtsHPL\n ZenPkmG7sb9myHKRR/G558lEpwHQjBi68qdND8yVvbiDQnfK822mHgl/uohn5xcmnumg\n qs70n3Y0rp/LTj6dYpvd+yzTqiLKS6UKwoLIa4mbmNaUSTmBdTkubM3Ly7y2XvB3pwnY\n iehJ6CN0Ptcu0u+YYB3+yJ45rcPPzwgTjdXkE0pDu6L9N3cGWuXbkCzoble7KThOJKES\n 8Z2v0VRL9ODxPcykKc0csnOB+ZI4mq64yzQ6MJAnrO/uVJsLBhGDF5Lu4iKTQleXMoho\n 2RRQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775622014; x=1776226814;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=fr3r1l7govQ0n2tgYo7tIfg3KvIKEMQ0pqpyUPHfVc8=;\n b=HDADqoKi3THq2gNM3WuqNnFDXZNRpiKMDMFthZ524TPBUzi2XK8IYfw+1bp+8AEBa9\n cu2GaIE22rL5hq0rfBYp+1EpbaC1xoH8ehuoVkLnr3nA+Jb+j/E9CNCq51M80jlT/kLo\n KywW+2V2JVSAmOh4Cs1eB0aL3wK2ZceMii3MPlgsK/m4UoqSU4jOxEx+jsOr5eDJNE8D\n /zoekYIYlKEtzVjl/vglimlOxmiEI23T1GIfBXPjonfZuzTKaj7c5vjPpjnYk4sUMP/7\n JNgjfTH1D49/JNfzIv9MxOTimmIAzziq55bwC93cqJP6LzbkgKjmw/PAWEy2q4GnOW18\n n/tA==","X-Gm-Message-State":"AOJu0Yx79e6zzV92UrY6hExPQe681U7z8Xo7ugmvxf+MsEeB5WQ4GYJb\n ZbA68ughPMHgUbnE4Lz3/cuJfvGDpcQLAn5/4ySE48AIEXTQbQvjSuGscqk6rg5lG9G7a41sEe4\n LAiNThbeP3ZC9U/Gbbtkvb66RWVs1IaZkT2lcfYFvrQsZLW28YSqGQPviJ3A/ZZhaow==","X-Gm-Gg":"AeBDieuFLEvfa4DVDrTEP/4G3A1C3w4cIzpPaVaUdiOvdIEHFywCISkxbNkcSSgRw7h\n Sdjq1R5rAFoBb92MRbbV4xjAtAyF57Niwdd7SOBSOpxBZMy+QRM3i5xtaB26zDjU4mj3PTllmAZ\n g81RX3iH+NApnwz9Ld3B14wrD8HNwtWNPRmE/LmQO4awb4HRWA9q8YkbGZLvwIoMTvjIBeO1UQf\n 3+PbuaX4gyluzInv5LCzmAQgHhibYVkueeHVmuCchyOw+rwWBb1krIw4ANAQsGMlAdZhLJeMd2k\n wI9Kw4YMdT1uUj7Juhb/m3/kFXeZGEoLpvhypw6+o31wxbE68uM1nsKiFii2YhPZzRMwjbLnVfq\n ZIqKCp/xxv5W+79xvhunEJC+dXEv8Q5oggLKU5gOXP6h45MAz/RWRMlWh3t24YMFmrrcAYg==","X-Received":["by 2002:a05:7022:325:b0:12b:ebb9:1c0b with SMTP id\n a92af1059eb24-12bfb77ecedmr9784860c88.31.1775622014057;\n Tue, 07 Apr 2026 21:20:14 -0700 (PDT)","by 2002:a05:7022:325:b0:12b:ebb9:1c0b with SMTP id\n a92af1059eb24-12bfb77ecedmr9784840c88.31.1775622013502;\n Tue, 07 Apr 2026 21:20:13 -0700 (PDT)"],"From":"Brian Cain ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com,\n matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng,\n anjo@rev.ng, Brian Cain ","Subject":"[PATCH v4 05/28] target/hexagon: Implement wait helper","Date":"Tue, 7 Apr 2026 21:19:30 -0700","Message-Id":"<20260408041953.1899532-6-brian.cain@oss.qualcomm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>","References":"<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","X-Authority-Analysis":"v=2.4 cv=drPrzVg4 c=1 sm=1 tr=0 ts=69d5d77e cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22\n a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=UWtQ3YZIe0Xef7kIUYIA:9\n a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 a=TjNXssC_j7lpFel5tvFf:22","X-Proofpoint-ORIG-GUID":"mC-DEzHI51w1bzGme9gVkDUetycQ2t2G","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX8LLNzwR6iNuV\n lkdHxfjs3cUmW1C8ZI+Hsvpxu8sZaaVMQKTP8HqzcEaI8U245K1SisEOYuXK7sZnOSrVRBA2VxL\n NjDHwtUbt/meERielFcKo6bLGSPFV772SJy67eZwwS5UyAcPmmUINym9IINmh6FPVTL2NcYifoZ\n YHu2iogVXQiDZR8yLnqSY3dH2j9DlfRqpVxFWYMfMn473bA3w3CozWUQVlF7CdhgY8zxSki6H6u\n 1aDLAA496+BfANozH4Ep9vE0eWFOTP7Mztf648TER1fk32NDoX1uRgE/if9V5Z8i7tpLESp4ACg\n cEmfRZWVhgEXStdbIWSr/HWDblM0y3q/iwAzCYTFIRvXCysxlF/UQyVKe4DVeseslYNG7fYlGei\n NMu2uDrd7Lszz3It66DenzCr/qna9fDG0CTwlLaGZFcTOUjBbEaxQpCwSuS5CYG7fdb+1UlIzrN\n Ti8iSlnmEY5kMG3FNUg==","X-Proofpoint-GUID":"mC-DEzHI51w1bzGme9gVkDUetycQ2t2G","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0\n bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080036","Received-SPF":"pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Brian Cain \n\nReviewed-by: Taylor Simpson \nSigned-off-by: Brian Cain \n---\n target/hexagon/op_helper.c | 60 ++++++++++++++++++++++++++++++++++++--\n 1 file changed, 58 insertions(+), 2 deletions(-)","diff":"diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c\nindex 235c70f7370..d40061de06e 100644\n--- a/target/hexagon/op_helper.c\n+++ b/target/hexagon/op_helper.c\n@@ -1486,9 +1486,65 @@ void HELPER(stop)(CPUHexagonState *env)\n hexagon_stop_thread(env);\n }\n \n-void HELPER(wait)(CPUHexagonState *env, target_ulong PC)\n+static void set_wait_mode(CPUHexagonState *env)\n {\n- g_assert_not_reached();\n+ HexagonCPU *cpu;\n+ uint32_t modectl;\n+ uint32_t thread_wait_mask;\n+\n+ g_assert(bql_locked());\n+\n+ cpu = env_archcpu(env);\n+ if (!cpu->globalregs) {\n+ return;\n+ }\n+ modectl =\n+ hexagon_globalreg_read(cpu->globalregs, HEX_SREG_MODECTL,\n+ env->threadId);\n+ thread_wait_mask = GET_FIELD(MODECTL_W, modectl);\n+ thread_wait_mask |= 0x1 << env->threadId;\n+ SET_SYSTEM_FIELD(env, HEX_SREG_MODECTL, MODECTL_W, thread_wait_mask);\n+}\n+\n+static void hexagon_wait_thread(CPUHexagonState *env, uint32_t PC)\n+{\n+ CPUState *cs;\n+\n+ g_assert(bql_locked());\n+\n+ if (qemu_loglevel_mask(LOG_GUEST_ERROR) &&\n+ (env->k0_lock_state != HEX_LOCK_UNLOCKED ||\n+ env->tlb_lock_state != HEX_LOCK_UNLOCKED)) {\n+ qemu_log(\"WARNING: executing wait() with acquired lock\"\n+ \"may lead to deadlock\\n\");\n+ }\n+ g_assert(get_exe_mode(env) != HEX_EXE_MODE_WAIT);\n+\n+ cs = env_cpu(env);\n+ /*\n+ * The addtion of cpu_has_work is borrowed from arm's wfi helper\n+ * and is critical for our stability\n+ */\n+ if ((cs->exception_index != HEX_EVENT_NONE) ||\n+ (cpu_has_work(cs))) {\n+ qemu_log_mask(CPU_LOG_INT,\n+ \"%s: thread %\" PRIu32 \" skipping WAIT mode, have some work\\n\",\n+ __func__, env->threadId);\n+ return;\n+ }\n+ set_wait_mode(env);\n+ env->wait_next_pc = PC + 4;\n+\n+ cpu_interrupt(cs, CPU_INTERRUPT_HALT);\n+}\n+\n+void HELPER(wait)(CPUHexagonState *env, uint32_t PC)\n+{\n+ BQL_LOCK_GUARD();\n+\n+ if (!fIN_DEBUG_MODE(env->threadId)) {\n+ hexagon_wait_thread(env, PC);\n+ }\n }\n \n void HELPER(resume)(CPUHexagonState *env, uint32_t mask)\n","prefixes":["v4","05/28"]}