{"id":2221118,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2221118/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408041953.1899532-29-brian.cain@oss.qualcomm.com>","date":"2026-04-08T04:19:53","name":"[v4,28/28] target/hexagon: Add guest reg reading functionality","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"211a8f611c8cc3a0e55c7fed233055b7082433b0","submitter":{"id":89839,"url":"http://patchwork.ozlabs.org/api/1.0/people/89839/?format=json","name":"Brian Cain","email":"brian.cain@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260408041953.1899532-29-brian.cain@oss.qualcomm.com/mbox/","series":[{"id":499179,"url":"http://patchwork.ozlabs.org/api/1.0/series/499179/?format=json","date":"2026-04-08T04:19:31","name":"Hexagon system emulation - Part 2/3","version":4,"mbox":"http://patchwork.ozlabs.org/series/499179/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2221118/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=IN+auyB3;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=DbYaC4Kz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXv56Ct6z1xy1\n\tfor ; Thu, 09 Apr 2026 05:19:45 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAYMo-0006kO-Fx; Wed, 08 Apr 2026 15:15:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAYJy-0001Dp-Rd\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 15:12:14 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAKPJ-0005dA-Ef\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 00:20:53 -0400","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 637M4aIU2861188\n for ; Wed, 8 Apr 2026 04:20:38 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddad8rwvm-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 08 Apr 2026 04:20:38 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2b81ff82e3cso352182eec.0\n for ; Tue, 07 Apr 2026 21:20:38 -0700 (PDT)","from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c14a371b1sm6480362c88.13.2026.04.07.21.20.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Apr 2026 21:20:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n VyS//kJE8X1YiFhWbpMP89yyJBq8IVDF64zKKUVJKZQ=; b=IN+auyB3ntkHmqf/\n HKDJ+cmlc2q1YPJ8dEjbkJsXZn7NDdETNNPCw8bb5OfZp0NAxJTWP4BmkBuBQrf+\n AN1R5ZNquindE3DNbQM5S568N/Fb3X5D0EuBfP9LlxG3S/gyBYuiRS1PRgW3MdOW\n pxAdW822Ko4+bpDePKXiGyCWt7OLiDeKdhYU7ehH5HyOScsPVu2zLzkdTwgQQ42n\n a9uDDD2oPp3O4E1C11fBB1re1hRiZqm+IkH/Pu9s61iolQo89rTz1FlHn4OnRSkw\n yzvRKybZe1U6r/6xifEoyVfWHa0gDEUJKM8GgY2W5lrjeyzMatTxNdNtjqQlebOH\n RvthDA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775622037; x=1776226837; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VyS//kJE8X1YiFhWbpMP89yyJBq8IVDF64zKKUVJKZQ=;\n b=DbYaC4KzSAvRNhcGSAay84LwGfuiC46BrcZBb6BkosXGZiucEpVysjZCmnL+0uoTyj\n dBsXb1+3V8ntEtM+hj7pA5wSMEoKQloQ/uwzwfiNM2vEJ71bQhgWCJ7LYVd3WZAluoa7\n 27ivX5MRu+JOByNguDWzH0VE+mW6FBmrNEAYK2Fr0vwvC6ItWmEqE/IjGaZbL8nY4/t4\n Y7QU9RA9Elusmvtc0cQrKh0mLpAZXoZm1sY+cK8aDtgTM49rnb0ZTP2pkW3A6zN+lXuR\n So6MK/Dzsvj2LlY2Z5QHSv6nVxUtD8E6GUQnX8JDGN7nfNNwVfMxVRkQAVeJyEIk0l/g\n 6Ewg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775622037; x=1776226837;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=VyS//kJE8X1YiFhWbpMP89yyJBq8IVDF64zKKUVJKZQ=;\n b=UPjAJ6oCGuNSORRznIHDAi5SQbquERTx7oy4c0OJBiYgoAe2JHIvDVCl2ZpEV+0h3/\n NxCZlKL1VdcWmfexU279tZHx8FNVCOqv9H//OcQgDkrv960QrnloE/RYQOniBdZ3mWRa\n KZuFRYbBMUFDXF59ouM0fBwmABBUslMo8BKZB0mTyPuJL8Q/n6dbNjxMFOfwQUFIjiby\n nB3MnGdupzv4mUC8oU/JqZyvb8BLbCd/SfNjaVadMDU003RLa86e2G9KNezjMeSaPdOP\n GJdhMZKtOMYWc3bcY2ErNGafbqRV3TPDbzd0rdcv4BgcX0rDHrWl9rKFzJThdEb1jO8O\n TOcw==","X-Gm-Message-State":"AOJu0YxZ2j0/5ZIOUDdxkg4FcXgVIRmkZtreUFG9n/W6f9JFJ3RKjIGf\n ZwxKg12iZdG9vemacuYWTiSJDDET2ccZNYubvZRhMaJF6qq7+3CYMa6CNriOOy51hyjcY+Hd+Zx\n tRs7p+UXaGR6tUMGNJz6154QgnGvQu60rnXm/YTT04rJ5mQb1kacer+4iHyosfsDFuw==","X-Gm-Gg":"AeBDieutZMG8r4Qlk6zOW4D4dX0XlUwpH0M0EiUFuZ3cMFRhqYbtiyUO29b32RKRZkq\n WYEuiU42u9Hd3jKZ0TiKh4rNOIkCQ8aAXtDG19o6LHi/i2M0RmAWe7Xw08snh3aKv+KOX3y21gE\n wnRa+EHld7aHBifoy0aqiRCNYkp1/E0uz8tYqUze4l+avDA9778PwbJYoWOWcLOwl2jaP9sRIhN\n /jF4F7j+wHg0KeLsVjv4hy6N3R4fQgM4keeYDwLOSNzxvlv6pISbDtCzksrsW7FrKT/MdE2i+2C\n yWw2U5XDdXJUuik02w4Yj/MuTFkdamVKbn4AYz/aXglpuHBNrHFCzwFuo8nee0SOIskENh9Au0J\n V7Dl+/El+M9awrT66MlvvPEdxmMCRc/4y6TtorkjRbKSsfFsgI++EBqAuclrI3BdyRfuQxg==","X-Received":["by 2002:a05:7022:420:b0:128:d1f6:16da with SMTP id\n a92af1059eb24-12bfaf58986mr9462708c88.14.1775622037369;\n Tue, 07 Apr 2026 21:20:37 -0700 (PDT)","by 2002:a05:7022:420:b0:128:d1f6:16da with SMTP id\n a92af1059eb24-12bfaf58986mr9462695c88.14.1775622036845;\n Tue, 07 Apr 2026 21:20:36 -0700 (PDT)"],"From":"Brian Cain ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, philmd@linaro.org, ltaylorsimpson@gmail.com,\n matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng,\n anjo@rev.ng, Matheus Tavares Bernardino ","Subject":"[PATCH v4 28/28] target/hexagon: Add guest reg reading functionality","Date":"Tue, 7 Apr 2026 21:19:53 -0700","Message-Id":"<20260408041953.1899532-29-brian.cain@oss.qualcomm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>","References":"<20260408041953.1899532-1-brian.cain@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","X-Proofpoint-ORIG-GUID":"BQ9pnrlvzdFZKAgeMwANDIPnqX5MtvP2","X-Proofpoint-GUID":"BQ9pnrlvzdFZKAgeMwANDIPnqX5MtvP2","X-Authority-Analysis":"v=2.4 cv=EoDiaycA c=1 sm=1 tr=0 ts=69d5d796 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22\n a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=IJQQmebJWjVxhimlKuwA:9 a=QEXdDO2ut3YA:10\n a=bBxd6f-gb0O0v-kibOvt:22 a=TjNXssC_j7lpFel5tvFf:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA4MDAzNiBTYWx0ZWRfX89OPvUBJRefe\n f8yxL3p8v1Fyw1D6tlBc3MBmZk++mu+/WabA6AEuh4QL0DHLyZ1VExbCD1CKfF/LxAesdSlpKfd\n oq258P3EsIxPVpZ4p+5wP3AMkX6nYukiRVvzQKKLPwMVLEdCHgaxmWPmCq6JL4wR4aKUIkWH3tI\n zjAt7jiMJM0ph9bwps7ryxpZufARnn7MOvB8MyHpkMhI/wxUodfRJPNLD/UUobwajmso5mjASZG\n 0j4LHaTWqMkdQuKOhjw2mrnMLEV4re9/KHuRdHWY715/pGkKrR0tDHjHEcig69b8GdJ+EvPKDWd\n ceFcVDAWTeptp2m5cF778NZ2XCtt5YUk8Kzdz5ixwGlNGbjBCGg9FOgnXBxloDMdfhbeHv4RCh2\n 93j9IzjZ8eOiqEOysurt5H1o1zcQbVM2CxsfwGKLqS6bCJn/zdVMSGhV8eVLEKQE2GeJusV8HlW\n FiRFLIqEbwgpLsS01LA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-08_02,2026-04-07_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0\n malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080036","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Matheus Tavares Bernardino \n\nSigned-off-by: Matheus Tavares Bernardino \nReviewed-by: Taylor Simpson \n---\n target/hexagon/cpu.h | 1 +\n target/hexagon/cpu.c | 19 +++++++++++++++++++\n target/hexagon/op_helper.c | 16 ++++++++++++++--\n 3 files changed, 34 insertions(+), 2 deletions(-)","diff":"diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h\nindex 1048e767e6d..09d5cac4fe5 100644\n--- a/target/hexagon/cpu.h\n+++ b/target/hexagon/cpu.h\n@@ -219,6 +219,7 @@ G_NORETURN void hexagon_raise_exception_err(CPUHexagonState *env,\n * not stopped.\n */\n bool hexagon_thread_is_enabled(CPUHexagonState *thread_env);\n+uint32_t hexagon_greg_read(CPUHexagonState *env, uint32_t reg);\n void hexagon_cpu_soft_reset(CPUHexagonState *env);\n #endif\n \ndiff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\nindex a48d6178e06..bd3eec0d525 100644\n--- a/target/hexagon/cpu.c\n+++ b/target/hexagon/cpu.c\n@@ -765,6 +765,25 @@ static void hexagon_cpu_class_init(ObjectClass *c, const void *data)\n #endif\n }\n \n+#ifndef CONFIG_USER_ONLY\n+uint32_t hexagon_greg_read(CPUHexagonState *env, uint32_t reg)\n+{\n+ if (reg <= HEX_GREG_G3) {\n+ return env->greg[reg];\n+ }\n+ switch (reg) {\n+ case HEX_GREG_GPCYCLELO:\n+ return hexagon_get_sys_pcycle_count_low(env);\n+ case HEX_GREG_GPCYCLEHI:\n+ return hexagon_get_sys_pcycle_count_high(env);\n+ default:\n+ qemu_log_mask(LOG_UNIMP, \"reading greg %\" PRId32\n+ \" not yet supported.\\n\", reg);\n+ return 0;\n+ }\n+}\n+#endif\n+\n #define DEFINE_CPU(type_name, initfn) \\\n { \\\n .name = type_name, \\\ndiff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c\nindex c4ad6015689..a1c0c9910f2 100644\n--- a/target/hexagon/op_helper.c\n+++ b/target/hexagon/op_helper.c\n@@ -1877,13 +1877,25 @@ uint64_t HELPER(sreg_read_pair)(CPUHexagonState *env, uint32_t reg)\n }\n \n uint32_t HELPER(greg_read)(CPUHexagonState *env, uint32_t reg)\n+\n {\n- g_assert_not_reached();\n+ return hexagon_greg_read(env, reg);\n }\n \n uint64_t HELPER(greg_read_pair)(CPUHexagonState *env, uint32_t reg)\n+\n {\n- g_assert_not_reached();\n+ if (reg == HEX_GREG_G0 || reg == HEX_GREG_G2) {\n+ return (uint64_t)(env->greg[reg]) |\n+ (((uint64_t)(env->greg[reg + 1])) << 32);\n+ }\n+ switch (reg) {\n+ case HEX_GREG_GPCYCLELO:\n+ return hexagon_get_sys_pcycle_count(env);\n+ default:\n+ return (uint64_t)hexagon_greg_read(env, reg) |\n+ ((uint64_t)(hexagon_greg_read(env, reg + 1)) << 32);\n+ }\n }\n \n /*\n","prefixes":["v4","28/28"]}