{"id":2219707,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219707/?format=json","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.0/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260403205907.92749-1-marino.dzalto@gmail.com>","date":"2026-04-03T20:59:07","name":"[v3] netfilter: xt_HL: add pr_fmt and checkentry validation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f511badbc6be818d393b0d7070acbf29fb2acb5a","submitter":{"id":93048,"url":"http://patchwork.ozlabs.org/api/1.0/people/93048/?format=json","name":"Marino Dzalto","email":"marino.dzalto@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260403205907.92749-1-marino.dzalto@gmail.com/mbox/","series":[{"id":498679,"url":"http://patchwork.ozlabs.org/api/1.0/series/498679/?format=json","date":"2026-04-03T20:59:07","name":"[v3] netfilter: xt_HL: add pr_fmt and checkentry validation","version":3,"mbox":"http://patchwork.ozlabs.org/series/498679/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219707/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dBE4CG55;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11621-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"dBE4CG55\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWNK3FQWz1yCs\n\tfor ; Sat, 04 Apr 2026 08:01:05 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D5FD5303322D\n\tfor ; Fri, 3 Apr 2026 20:59:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5034F3D8916;\n\tFri, 3 Apr 2026 20:59:15 +0000 (UTC)","from mail-wm1-f49.google.com (mail-wm1-f49.google.com\n [209.85.128.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9CB3D6666\n\tfor ; Fri, 3 Apr 2026 20:59:13 +0000 (UTC)","by mail-wm1-f49.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso35842285e9.0\n for ;\n Fri, 03 Apr 2026 13:59:13 -0700 (PDT)","from localhost.localdomain (cpe-188-129-81-72.dynamic.amis.hr.\n [188.129.81.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48893f39027sm104356165e9.2.2026.04.03.13.59.10\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 03 Apr 2026 13:59:11 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775249954; cv=none;\n b=uObQ1KuSdu/zQKU0d1dILUaEpOqRmJnxHrLcZtMlvvSMG+B3Tm/TzWYTBhBDw6Gu0bGJ3lTWxeVVlScAsy6MsrmzM8gXk3qDpZMjSOjeusNCtFsYW0i0WmWQsQo+0XtnJLqjek0FAbTvKTP6QrHhAbDH46q9eBkTqUo63RF4A6Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775249954; c=relaxed/simple;\n\tbh=kqYs482WFY46q7KpNwPM4K3CeK+5fOx+6sZ6nE4D9Rc=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=ATDQEzS/cA/GCr1IUVcPEe07wTfMxwZLEdPW47ySG4fDeWTXV1rPAdtgKO6Uv4YGvHIEirlGBmqqMBADcVw1+/l9E+msFhooAXp7mVKqnMtPTpspVG858101gVRTjgp98S75PbOKBGz+pF2QlfqDsf0EGtVX24rmMWRwrk6ANVM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=dBE4CG55; arc=none smtp.client-ip=209.85.128.49","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775249952; x=1775854752;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=PC6QSIaCKHRw04W5RZeL/4jeRdbgtJ8aXjIrqAGfS2c=;\n b=dBE4CG55oJU4skkB0N1F6ZGedSw9a0i0B5D6KUGu0YFmN3X0zxdmmerqUp8UFMWMpo\n d0kExpCFgbmRzYlYvmbM70tM/HUAhlYHPDHKiLA80bH5/Z18zK1hiAKaZG++E49wtleD\n k63gW05g8SdtedyJYkzuRlkzyaQHvHayeJl9tSeReu3Zk1ezWtV1CdfUq/VnNZsy2xM3\n j0JOhhbvNmwW2YCiCqSGLneD/Fz+JPNpE6tzR395C+pjHfik3ICkH3Up0ypSVck+Qcrt\n eraGrCez0eaFQv4mjTXtWhbBN8L65IXkNY38kQc2GNY92AJQM62V2Dwkp8y8fEoqKxdC\n CkQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775249952; x=1775854752;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=PC6QSIaCKHRw04W5RZeL/4jeRdbgtJ8aXjIrqAGfS2c=;\n b=rlGLsse+6gq7sxfBbYPULS6LNlRtgkDzI999oL/pXD7BIEs3MXr4DAlByH5vOC0yAV\n f4hIeiBFBWAHhLSRB1Moh5PZfxUUElzm7KOAXXHq0Esyezbs3LY4e+GVx3DDP2sDV7/x\n /SvH1C/s7L7XdHOyEnuCLUyTen2ISAgxapWHNl+Wundeh82RjuvUK7yfblgHrsGjSZoI\n ZOk4hu1x59GduCkQoa9ptAvbfsvZYN4/iSBcDGu3gCca3QDji9fysATWXE67m/JoZ9fH\n 6IRDjRAsmkBOhSNJozTa4U49PYDAKQIGh15Npa5jZtkS7DjV76FDkk2HJyf022BaD/rg\n CXbw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUBQafsMEvg22qP5H9hSF0bffsiyCTr+ENzhNCMaRi6N8FNjs6luI8yfbkowiscUxBH32xrpZ7z8i366tuf7xM=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz3XjL6I3LdkX7OvdUvZ8uDXf45H8/9Mc7J7SwrS4UYedAHRuvF\n\tMqPo7uP/YNn4QzOa12FPzNx5eBg78GNBvVkNgcbYi57CsC1HwBNpoJWC","X-Gm-Gg":"ATEYQzw3tuYsCTj3WhKGJA4dFJBlUZGQg5S/i/EzkI47ue/7rW/gIr6RQgYR+4pWKEb\n\tAEmFu612zeY7rk1tK2vrkak4wyoNzQ5eo9ay+jnXdbHXBEXrh/LvVtWzrCltOATg9dO5+1audW6\n\tcwbAwcY6KrX00UJBX6DFn5oC7S4vF88hj6jSu06fXjIPkRldMci/IzYGo1IABECZIuVkm8QthFz\n\t6Uk6HlzCPc1N41lN6A3kLe4bZBf0g+BRPokp1eQ8hU5HU3cTiZW/tNa0EfGiHh1hx9ybkqjIaf5\n\t6oF0SJnKN+4kb+qy0NQz8vwDZtG3LNib854PfQM0C1QsmB4g1Q7LMAzypMnnhTXBOlAmZQIxwD7\n\tK356z2D82IJAu0IniK/TLQFObqQGdr87VFayDw4+9E+1y2v+odgkSczDKZgK7UM65EM2t6iCtli\n\tg7SsCMfN4h3sH65jm5N45t9ozdwTbSzBrIYR18Ao2kbn+4/eifrbArIu8D69ygxgPOw4NVvHOA2\n\tvjIQWuzZ9gsQOV8y8dsFFC1/jEE+qjXeLFKbLGxysMKgbtwKyw=","X-Received":"by 2002:a05:600c:450d:b0:485:3428:774c with SMTP id\n 5b1f17b1804b1-4889946a42dmr64393995e9.4.1775249951503;\n Fri, 03 Apr 2026 13:59:11 -0700 (PDT)","From":"Marino Dzalto ","To":"pablo@netfilter.org,\n\tfw@strlen.de","Cc":"jacob.e.keller@intel.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMarino Dzalto ","Subject":"[PATCH v3] netfilter: xt_HL: add pr_fmt and checkentry validation","Date":"Fri, 3 Apr 2026 22:59:07 +0200","Message-ID":"<20260403205907.92749-1-marino.dzalto@gmail.com>","X-Mailer":"git-send-email 2.50.1","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Add pr_fmt to prefix log messages with the module name for\neasier debugging in dmesg.\n\nAdd checkentry functions for IPv4 (ttl_mt_check) and IPv6\n(hl_mt6_check) to validate the match mode at rule registration\ntime, rejecting invalid modes with -EINVAL.\n\nSigned-off-by: Marino Dzalto \n---\nv3: Remove mention of NULL checks from commit message, as they\n were never part of the original code.\nv2: Remove NULL checks for skb as suggested by Florian Westphal\n (skb is guaranteed non-NULL by netfilter core). Move mode\n validation to checkentry functions instead of match function,\n also as suggested by Florian Westphal.\n---\n net/netfilter/xt_hl.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)","diff":"diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c\nindex c1a70f8f0441..4a12a757ecbf 100644\n--- a/net/netfilter/xt_hl.c\n+++ b/net/netfilter/xt_hl.c\n@@ -6,6 +6,7 @@\n * Hop Limit matching module\n * (C) 2001-2002 Maciej Soltysiak \n */\n+#define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n \n #include \n #include \n@@ -22,6 +23,18 @@ MODULE_LICENSE(\"GPL\");\n MODULE_ALIAS(\"ipt_ttl\");\n MODULE_ALIAS(\"ip6t_hl\");\n \n+static int ttl_mt_check(const struct xt_mtchk_param *par)\n+{\n+\tconst struct ipt_ttl_info *info = par->matchinfo;\n+\n+\tif (info->mode > IPT_TTL_GT) {\n+\t\tpr_err(\"Unknown TTL match mode: %d\\n\", info->mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par)\n {\n \tconst struct ipt_ttl_info *info = par->matchinfo;\n@@ -41,6 +54,18 @@ static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par)\n \treturn false;\n }\n \n+static int hl_mt6_check(const struct xt_mtchk_param *par)\n+{\n+\tconst struct ip6t_hl_info *info = par->matchinfo;\n+\n+\tif (info->mode > IP6T_HL_GT) {\n+\t\tpr_err(\"Unknown Hop Limit match mode: %d\\n\", info->mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static bool hl_mt6(const struct sk_buff *skb, struct xt_action_param *par)\n {\n \tconst struct ip6t_hl_info *info = par->matchinfo;\n@@ -65,6 +90,7 @@ static struct xt_match hl_mt_reg[] __read_mostly = {\n \t\t.name = \"ttl\",\n \t\t.revision = 0,\n \t\t.family = NFPROTO_IPV4,\n+\t\t.checkentry = ttl_mt_check,\n \t\t.match = ttl_mt,\n \t\t.matchsize = sizeof(struct ipt_ttl_info),\n \t\t.me = THIS_MODULE,\n@@ -73,6 +99,7 @@ static struct xt_match hl_mt_reg[] __read_mostly = {\n \t\t.name = \"hl\",\n \t\t.revision = 0,\n \t\t.family = NFPROTO_IPV6,\n+\t\t.checkentry = hl_mt6_check,\n \t\t.match = hl_mt6,\n \t\t.matchsize = sizeof(struct ip6t_hl_info),\n \t\t.me = THIS_MODULE,\n","prefixes":["v3"]}