{"id":2219693,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219693/?format=json","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.0/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260403200320.90449-1-marino.dzalto@gmail.com>","date":"2026-04-03T20:03:20","name":"[v2] netfilter: xt_HL: add pr_fmt, drop NULL checks, add checkentry validation","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"f511badbc6be818d393b0d7070acbf29fb2acb5a","submitter":{"id":93048,"url":"http://patchwork.ozlabs.org/api/1.0/people/93048/?format=json","name":"Marino Dzalto","email":"marino.dzalto@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260403200320.90449-1-marino.dzalto@gmail.com/mbox/","series":[{"id":498669,"url":"http://patchwork.ozlabs.org/api/1.0/series/498669/?format=json","date":"2026-04-03T20:03:20","name":"[v2] netfilter: xt_HL: add pr_fmt, drop NULL checks, add checkentry validation","version":2,"mbox":"http://patchwork.ozlabs.org/series/498669/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219693/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=aOiluptj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11618-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"aOiluptj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.53","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnVBH4Hb3z1yG2\n\tfor ; Sat, 04 Apr 2026 07:07:19 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EB247309D3F6\n\tfor ; Fri, 3 Apr 2026 20:03:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A5DC73D6CB7;\n\tFri, 3 Apr 2026 20:03:27 +0000 (UTC)","from mail-wm1-f53.google.com (mail-wm1-f53.google.com\n [209.85.128.53])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DD04826ED45\n\tfor ; Fri, 3 Apr 2026 20:03:25 +0000 (UTC)","by mail-wm1-f53.google.com with SMTP id\n 5b1f17b1804b1-48897fd88ebso9743385e9.2\n for ;\n Fri, 03 Apr 2026 13:03:25 -0700 (PDT)","from localhost.localdomain (cpe-188-129-81-72.dynamic.amis.hr.\n [188.129.81.72])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48895e19c10sm95627995e9.8.2026.04.03.13.03.23\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 03 Apr 2026 13:03:23 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775246607; cv=none;\n b=Wtx+1q+O/BZrzt8tv0wgoOdOPPh10nMHunAEV8gO+OXqdmQJscVHfwrS/DCLjJNvJnI7T6U2vrIjAMHWG/Y1y73FU6G+2Gzo32VBtA8DpQOuWKZ7S3ejGMm2fMN2m+Uws1DsPyTyneaqi5Q/BIk5y4F6yi8LlZJpmcYLo2J1WeM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775246607; c=relaxed/simple;\n\tbh=wADCUDHqv3AIFQTlK0LzdVUglw2571qUMkTdVWFvIxQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=cBVpqFDEuaNeJodGM0YWPPt0xkE8tX/JyhfH7+TNOhSY1/3O0abqiKyapD9yD88AMj3o/dz7NkusiNnRc97pJDyOVAwR2HGVSPUQmjoFyVwZ6TLoReNtRUwSiEq4ksjxz2Zhvh1SqB0qSPT5mScN/j3uxFFp9IJcYR2bHqr9VOY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=aOiluptj; arc=none smtp.client-ip=209.85.128.53","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775246604; x=1775851404;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=xE2VFOzNRG0wByucdsL3FPChPaVcDUKG/JIrmw8PamQ=;\n b=aOiluptjCA/ZuUk28yb+vu+KXgUVQcrEcTmITTmklUfzU7D9DiikISVepgca2lmm0l\n I3JfWMG1Zi+WkI8ZZAy/DXsuGo3s0TtfkgyVSS6390T/ZowHrHXx1CJMtDNwhy0e7sC0\n ccnW1Hu0f7Ej2rzsH3QgiL0zWbVr/KTMgouHx808x9HytlV5KE1hUGzVeZ62k+DFG8a0\n 3ar+Krzt3UbkeyavIAhoTKjck4rZkYIHHtL/spA63/9JiKBSAVLv32lzF2NkxgllSF1K\n +D4/gWfyJdV+Rn204SI8X2JW6yiBORGV/r2XIW9UCRubhrYA0ilDag23CPFBmMhYMC6Y\n zAtA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775246604; x=1775851404;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xE2VFOzNRG0wByucdsL3FPChPaVcDUKG/JIrmw8PamQ=;\n b=JF1ABRovMx7akPEKD2XHswQFnVtB3IMGGG5aNbeBLE41RI4P8giLmHSWB3qdz2JZdy\n IonLnEM1u88EzuuffbIjRQVGdKszl0Hgl/60ns91S+1etQClQGHRgNwjvXDtcC6mOD8k\n EZYorgRw+pC6ZaPFshuQjZrmxv++wOIRif61++oZV5Ff2EZt3QQYdXF0fZ5f4s/VMYve\n h155UDFzcLugp045Taq1k5o8mZiF4yNjkuNk61DmvRf/scUyWVLDVo0UDnmtpfI/gvIo\n XDiYoOg5hu05awzScvx84nelHJz2f6rNEiwHi6GJ0es+uZEbl3Y060i1jtKy2V9thyHi\n 8rmg==","X-Gm-Message-State":"AOJu0YwYPtRKmKDb03aJEAmi9qmz7x5bnm1Tz39SjbxGr9iZCXrh0f0I\n\tALwggZ2z8xD16Lsb8e6m74NAijlz0TH24JgNaw/TRW9qn76Nov/8uHwN","X-Gm-Gg":"ATEYQzy9W4RV7Wnr2k4dBRP/aHJzonkFuJiRvvFxujkgaom6jyFb012giHxGN8N2PlI\n\twAkQjAg/lIbFHTTg1nUCj+dT8RA48c293tBDioN8tKArB7R6oO+/IWfUSmJx+sT+mnWMV094vNH\n\tYB4g4mvWTfzsjSGy6o+8f3Z7XUZq6JQ2HbwL3gQykdD6xVWCNKuO9LhZ8GF3Qa0/sAVssSg+0in\n\tDbyeDhrblCGJ/3wxo1g00DUbudueaCSCA85BABejzUjYHKeV6vWw/yXsVNKtXmGndV2ykQ0NoSv\n\tCM1vUhZd+Wb2N6il20F5SzsLclbPgFtobScjU2CriKO90nweiLvtfXONHhLc54AiqqrBDQr3zjP\n\tZJHSvbFkqn0ISvKg6sE8+hA94OFsaNUdPF5xs2L1VvmHVPeweyPuEeft4iLeW0twmSICynwtaiR\n\tkPMuJiddCWesHcSsnUre3Qhi5TIvj77CPv0JHN3f9uhoDYwa+KjYDnwvs7INkKS+FH7ART0fcj8\n\tc++T2RFPY/vwXq1FIndqhOSrXoDnDjzGpBhaSjNcKtWbsYNKDI=","X-Received":"by 2002:a05:600c:1d1d:b0:488:7ebd:78 with SMTP id\n 5b1f17b1804b1-4889977cbb7mr65937275e9.14.1775246604026;\n Fri, 03 Apr 2026 13:03:24 -0700 (PDT)","From":"Marino Dzalto ","To":"pablo@netfilter.org,\n\tfw@strlen.de","Cc":"netfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMarino Dzalto ","Subject":"[PATCH v2] netfilter: xt_HL: add pr_fmt, drop NULL checks,\n add checkentry validation","Date":"Fri, 3 Apr 2026 22:03:20 +0200","Message-ID":"<20260403200320.90449-1-marino.dzalto@gmail.com>","X-Mailer":"git-send-email 2.50.1","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Add pr_fmt for module-prefixed log messages. Remove unnecessary NULL\nchecks for skb, as netfilter core guarantees skb is non-NULL. Add\ncheckentry functions to validate match mode at rule registration time.\n\nSigned-off-by: Marino Dzalto \n---\n net/netfilter/xt_hl.c | 27 +++++++++++++++++++++++++++\n 1 file changed, 27 insertions(+)","diff":"diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c\nindex c1a70f8f0..4a12a757e 100644\n--- a/net/netfilter/xt_hl.c\n+++ b/net/netfilter/xt_hl.c\n@@ -6,6 +6,7 @@\n * Hop Limit matching module\n * (C) 2001-2002 Maciej Soltysiak \n */\n+#define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n \n #include \n #include \n@@ -22,6 +23,18 @@ MODULE_LICENSE(\"GPL\");\n MODULE_ALIAS(\"ipt_ttl\");\n MODULE_ALIAS(\"ip6t_hl\");\n \n+static int ttl_mt_check(const struct xt_mtchk_param *par)\n+{\n+\tconst struct ipt_ttl_info *info = par->matchinfo;\n+\n+\tif (info->mode > IPT_TTL_GT) {\n+\t\tpr_err(\"Unknown TTL match mode: %d\\n\", info->mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par)\n {\n \tconst struct ipt_ttl_info *info = par->matchinfo;\n@@ -41,6 +54,18 @@ static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par)\n \treturn false;\n }\n \n+static int hl_mt6_check(const struct xt_mtchk_param *par)\n+{\n+\tconst struct ip6t_hl_info *info = par->matchinfo;\n+\n+\tif (info->mode > IP6T_HL_GT) {\n+\t\tpr_err(\"Unknown Hop Limit match mode: %d\\n\", info->mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static bool hl_mt6(const struct sk_buff *skb, struct xt_action_param *par)\n {\n \tconst struct ip6t_hl_info *info = par->matchinfo;\n@@ -65,6 +90,7 @@ static struct xt_match hl_mt_reg[] __read_mostly = {\n \t\t.name = \"ttl\",\n \t\t.revision = 0,\n \t\t.family = NFPROTO_IPV4,\n+\t\t.checkentry = ttl_mt_check,\n \t\t.match = ttl_mt,\n \t\t.matchsize = sizeof(struct ipt_ttl_info),\n \t\t.me = THIS_MODULE,\n@@ -73,6 +99,7 @@ static struct xt_match hl_mt_reg[] __read_mostly = {\n \t\t.name = \"hl\",\n \t\t.revision = 0,\n \t\t.family = NFPROTO_IPV6,\n+\t\t.checkentry = hl_mt6_check,\n \t\t.match = hl_mt6,\n \t\t.matchsize = sizeof(struct ip6t_hl_info),\n \t\t.me = THIS_MODULE,\n","prefixes":["v2"]}