{"id":2219654,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219654/?format=json","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.0/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260403-add-mcu-fan-khadas-vim4-v2-4-70536b22439a@aliel.fr>","date":"2026-04-03T16:08:37","name":"[v2,4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"06e86ae18cabb4434cad5d27684c4e4c577793b3","submitter":{"id":93040,"url":"http://patchwork.ozlabs.org/api/1.0/people/93040/?format=json","name":"Ronald Claveau","email":"linux-kernel-dev@aliel.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260403-add-mcu-fan-khadas-vim4-v2-4-70536b22439a@aliel.fr/mbox/","series":[{"id":498653,"url":"http://patchwork.ozlabs.org/api/1.0/series/498653/?format=json","date":"2026-04-03T16:08:34","name":"Add VIM4 MCU/FAN support","version":2,"mbox":"http://patchwork.ozlabs.org/series/498653/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219654/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=aliel.fr header.i=@aliel.fr header.a=rsa-sha256\n header.s=courrier-s1 header.b=syPq+mVR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16951-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=\"syPq+mVR\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=65.21.61.41","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=aliel.fr"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnP3d582Qz1yCt\n\tfor ; Sat, 04 Apr 2026 03:16:13 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 3424830DE88E\n\tfor ; Fri, 3 Apr 2026 16:09:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 539E13CF04A;\n\tFri, 3 Apr 2026 16:09:28 +0000 (UTC)","from courrier.aliel.fr (courrier.aliel.fr [65.21.61.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CACF3CCFD1;\n\tFri, 3 Apr 2026 16:09:26 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775232567; cv=none;\n b=TlBz5v6rlYrKwsMEkc6x8D0K6kttvqI8+PSuAWdTH3AiRiEqOV1ZBcCUAMAy/05eDE/wQCH0rcObTUf7XtFJzeVuzjjNPSOGWxQgZCo5qlWkkYtxmHK1hAAXd590QoYgWCTRvGkv/DzSF4Wz/o2LX+rf/zV3aHtVxyfY0Rr0KWQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775232567; c=relaxed/simple;\n\tbh=emjopVGd5uVLfwcqEy71jr1NYUE1/T1lgxk1RfDuCzk=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=X+KwmA7MwvY4e732s71rVPHLgVjxgjrWQBio0cXhS4V89UoeGrtVI7YpcgY1F80wV13Qr6nNxI8MVkoaJMHBnxLnWTkAaAo80Xd4tV7OqMTBGPF2ysiY4LjWnr73vx6g9DyMhibCCyRHVbQAUGcovWxmbZvgxerg37J0ZIYV9GU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr;\n spf=pass smtp.mailfrom=aliel.fr;\n dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=syPq+mVR; arc=none smtp.client-ip=65.21.61.41","From":"Ronald Claveau ","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr;\n\ts=courrier-s1; t=1775232559;\n\tbh=emjopVGd5uVLfwcqEy71jr1NYUE1/T1lgxk1RfDuCzk=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc;\n\tb=syPq+mVRfCWfVMO5kwGj5d87YfQIA8M8v5mx3QAzGQPSVEB2LIRNy34U31VsWEhPI\n\t zaYj4LvmDfdagEhc9HBu1qP9u5JLT87WVjtcdgIlBckDp1lYAy8ozszD4FbnkQUGbZ\n\t NPM2Tx26mP9XX+gnqKZ7Ck6zFHtiyS7fmwOMyzN4=","Date":"Fri, 03 Apr 2026 18:08:37 +0200","Subject":"[PATCH v2 4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260403-add-mcu-fan-khadas-vim4-v2-4-70536b22439a@aliel.fr>","References":"<20260403-add-mcu-fan-khadas-vim4-v2-0-70536b22439a@aliel.fr>","In-Reply-To":"<20260403-add-mcu-fan-khadas-vim4-v2-0-70536b22439a@aliel.fr>","To":"Neil Armstrong , Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,\n Ronald Claveau ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openssh-sha256; t=1775232552; l=5062;\n i=linux-kernel-dev@aliel.fr; s=id_ed25519; h=from:subject:message-id;\n bh=emjopVGd5uVLfwcqEy71jr1NYUE1/T1lgxk1RfDuCzk=;\n b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgMGec55oxeeisqykQiUedekMYyOnR9\n BG9E/7rDWyqdNoAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA\n QIsXEJ4KldedgbozLhByCUwgiAptnRgyd6YnNjxsASYMDtbP1w6KzoV+MY6POn72D1RG5kMF5hy\n F9AK2tmMcQg8=","X-Developer-Key":"i=linux-kernel-dev@aliel.fr; a=openssh;\n fpr=SHA256:kch4osYZ6A1BrPps5AUs6KnfdE2wm4ocMtyTc8TmZMs"},"content":"Refactor probe() to use per-variant khadas_mcu_data\ninstead of hardcoded globals.\n\nAdd dedicated regmap configuration and device data for the VIM4 MCU,\nwith its own volatile/writeable registers.\n\nAdd the fan control register\n(0–100 levels vs 0–3 for previous supported boards).\n\nAdd a new compatible string \"khadas,vim4-mcu\".\n\nSigned-off-by: Ronald Claveau \n---\n drivers/mfd/khadas-mcu.c | 106 ++++++++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 95 insertions(+), 11 deletions(-)","diff":"diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c\nindex ba981a7886921..b36b3b3ab73c0 100644\n--- a/drivers/mfd/khadas-mcu.c\n+++ b/drivers/mfd/khadas-mcu.c\n@@ -75,15 +75,91 @@ static const struct regmap_config khadas_mcu_regmap_config = {\n \t.cache_type\t= REGCACHE_MAPLE,\n };\n \n+static const struct khadas_mcu_fan_pdata khadas_mcu_fan_pdata = {\n+\t.fan_reg\t= KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n+\t.max_level\t= 3,\n+};\n+\n static struct mfd_cell khadas_mcu_fan_cells[] = {\n \t/* VIM1/2 Rev13+ and VIM3 only */\n-\t{ .name = \"khadas-mcu-fan-ctrl\", },\n+\t{\n+\t\t.name = \"khadas-mcu-fan-ctrl\",\n+\t\t.platform_data = &khadas_mcu_fan_pdata,\n+\t\t.pdata_size = sizeof(khadas_mcu_fan_pdata),\n+\t},\n };\n \n static struct mfd_cell khadas_mcu_cells[] = {\n \t{ .name = \"khadas-mcu-user-mem\", },\n };\n \n+static const struct khadas_mcu_data khadas_mcu_data = {\n+\t.regmap_config\t= &khadas_mcu_regmap_config,\n+\t.cells\t\t= khadas_mcu_cells,\n+\t.ncells\t\t= ARRAY_SIZE(khadas_mcu_cells),\n+\t.fan_cells\t= khadas_mcu_fan_cells,\n+\t.nfan_cells\t= ARRAY_SIZE(khadas_mcu_fan_cells),\n+};\n+\n+static bool khadas_mcu_vim4_reg_volatile(struct device *dev, unsigned int reg)\n+{\n+\tswitch (reg) {\n+\tcase KHADAS_MCU_PWR_OFF_CMD_REG:\n+\tcase KHADAS_MCU_VIM4_REST_CONF_REG:\n+\tcase KHADAS_MCU_WOL_INIT_START_REG:\n+\tcase KHADAS_MCU_VIM4_LED_ON_RAM_REG:\n+\tcase KHADAS_MCU_VIM4_FAN_CTRL_REG:\n+\tcase KHADAS_MCU_VIM4_WDT_EN_REG:\n+\tcase KHADAS_MCU_VIM4_SYS_RST_REG:\n+\t\treturn true;\n+\tdefault:\n+\t\treturn false;\n+\t}\n+}\n+\n+static bool khadas_mcu_vim4_reg_writeable(struct device *dev, unsigned int reg)\n+{\n+\tswitch (reg) {\n+\tcase KHADAS_MCU_VERSION_0_REG:\n+\tcase KHADAS_MCU_VERSION_1_REG:\n+\tcase KHADAS_MCU_SHUTDOWN_NORMAL_STATUS_REG:\n+\t\treturn false;\n+\tdefault:\n+\t\treturn true;\n+\t}\n+}\n+\n+static const struct regmap_config khadas_mcu_vim4_regmap_config = {\n+\t.reg_bits\t= 8,\n+\t.reg_stride\t= 1,\n+\t.val_bits\t= 8,\n+\t.max_register\t= KHADAS_MCU_VIM4_SYS_RST_REG,\n+\t.volatile_reg\t= khadas_mcu_vim4_reg_volatile,\n+\t.writeable_reg\t= khadas_mcu_vim4_reg_writeable,\n+\t.cache_type\t= REGCACHE_MAPLE,\n+};\n+\n+static const struct khadas_mcu_fan_pdata khadas_vim4_fan_pdata = {\n+\t.fan_reg\t= KHADAS_MCU_VIM4_FAN_CTRL_REG,\n+\t.max_level\t= 0x64,\n+};\n+\n+static const struct mfd_cell khadas_mcu_vim4_cells[] = {\n+\t{\n+\t\t.name\t\t= \"khadas-mcu-fan-ctrl\",\n+\t\t.platform_data\t= &khadas_vim4_fan_pdata,\n+\t\t.pdata_size\t= sizeof(khadas_vim4_fan_pdata),\n+\t},\n+};\n+\n+static const struct khadas_mcu_data khadas_vim4_mcu_data = {\n+\t.regmap_config\t= &khadas_mcu_vim4_regmap_config,\n+\t.cells\t\t= NULL,\n+\t.ncells\t\t= 0,\n+\t.fan_cells\t= khadas_mcu_vim4_cells,\n+\t.nfan_cells\t= ARRAY_SIZE(khadas_mcu_vim4_cells),\n+};\n+\n static int khadas_mcu_probe(struct i2c_client *client)\n {\n \tstruct device *dev = &client->dev;\n@@ -94,28 +170,35 @@ static int khadas_mcu_probe(struct i2c_client *client)\n \tif (!ddata)\n \t\treturn -ENOMEM;\n \n+\tddata->data = i2c_get_match_data(client);\n+\tif (!ddata->data)\n+\t\treturn -EINVAL;\n+\n \ti2c_set_clientdata(client, ddata);\n \n \tddata->dev = dev;\n \n-\tddata->regmap = devm_regmap_init_i2c(client, &khadas_mcu_regmap_config);\n+\tddata->regmap = devm_regmap_init_i2c(client,\n+\t\t\t\t\t ddata->data->regmap_config);\n \tif (IS_ERR(ddata->regmap)) {\n \t\tret = PTR_ERR(ddata->regmap);\n \t\tdev_err(dev, \"Failed to allocate register map: %d\\n\", ret);\n \t\treturn ret;\n \t}\n \n-\tret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,\n-\t\t\t\t khadas_mcu_cells,\n-\t\t\t\t ARRAY_SIZE(khadas_mcu_cells),\n-\t\t\t\t NULL, 0, NULL);\n-\tif (ret)\n-\t\treturn ret;\n+\tif (ddata->data->cells && ddata->data->ncells) {\n+\t\tret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,\n+\t\t\t\t\t ddata->data->cells,\n+\t\t\t\t\t ddata->data->ncells,\n+\t\t\t\t\t NULL, 0, NULL);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n \n \tif (of_property_present(dev->of_node, \"#cooling-cells\"))\n \t\treturn devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,\n-\t\t\t\t\t khadas_mcu_fan_cells,\n-\t\t\t\t\t ARRAY_SIZE(khadas_mcu_fan_cells),\n+\t\t\t\t\t ddata->data->fan_cells,\n+\t\t\t\t\t ddata->data->nfan_cells,\n \t\t\t\t\t NULL, 0, NULL);\n \n \treturn 0;\n@@ -123,7 +206,8 @@ static int khadas_mcu_probe(struct i2c_client *client)\n \n #ifdef CONFIG_OF\n static const struct of_device_id khadas_mcu_of_match[] = {\n-\t{ .compatible = \"khadas,mcu\", },\n+\t{ .compatible = \"khadas,mcu\", .data = &khadas_mcu_data },\n+\t{ .compatible = \"khadas,vim4-mcu\", .data = &khadas_vim4_mcu_data },\n \t{},\n };\n MODULE_DEVICE_TABLE(of, khadas_mcu_of_match);\n","prefixes":["v2","4/8"]}