{"id":2219539,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219539/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260403104327.1163942-3-mjt@tls.msk.ru>","date":"2026-04-03T10:43:22","name":"[for-11.0,2/6] hw/core: Move compat_props_add() to 'hw/core/boards.h'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e2ac203197bf4a2487e80a57c2234f3636ac8526","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/1.0/people/183/?format=json","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260403104327.1163942-3-mjt@tls.msk.ru/mbox/","series":[{"id":498613,"url":"http://patchwork.ozlabs.org/api/1.0/series/498613/?format=json","date":"2026-04-03T10:43:24","name":"allow building tools and qemu-guest-agent on 32bit hosts","version":1,"mbox":"http://patchwork.ozlabs.org/series/498613/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219539/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=pYkecZT+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnFj54RZlz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 21:44:41 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8c06-0003zV-7Q; Fri, 03 Apr 2026 06:43:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c03-0003yc-EW\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:39 -0400","from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mjt@tls.msk.ru>) id 1w8c01-0005YN-SN\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 06:43:39 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n by isrv.corpit.ru (Postfix) with ESMTP id 0CD2119A63C;\n Fri, 03 Apr 2026 13:42:51 +0300 (MSK)","from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by tsrv.corpit.ru (Postfix) with ESMTP id BF64B38DB6C;\n Fri, 03 Apr 2026 13:43:28 +0300 (MSK)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1775212971; bh=sxYYGzxX13JLYTURZXmXs1BXBksyTpPz/55bI456ahI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=pYkecZT+t+EzK+2uNSv2aGwNevLhB7vxO3KgyjSCjI50c8yNU67LSde9SZ0Akv9+Q\n 1q9fljJVSbkFRt98pP6nL9P7C7C7ZqLIJDq7EAy90bJhyhnJT3GfV3NEBFSNSLB7Hb\n mpTGOnrUbTsqyAWPzEJCUZd6K/3h4HTUIuZQ99VJsq8TgVWfa6fmy0s22dP1qimYNO\n x52pNSLM95dxhgW602f5RiUsA6yggO1AIYwxxNSYdopcG+J/VCHoszHBmZqDHDr82P\n 7d37SMHeflT1gZXRJx3YS9cob9SN0pvQW7npN03z/7L4GTeDQBOR7Pp3qk22sA41ls\n vbiANOzvKKeOQ==","From":"Michael Tokarev <mjt@tls.msk.ru>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Michael Tokarev <mjt@tls.msk.ru>","Subject":"[PATCH for-11.0 2/6] hw/core: Move compat_props_add() to\n 'hw/core/boards.h'","Date":"Fri,  3 Apr 2026 13:43:22 +0300","Message-ID":"<20260403104327.1163942-3-mjt@tls.msk.ru>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260403104327.1163942-1-mjt@tls.msk.ru>","References":"<20260403104327.1163942-1-mjt@tls.msk.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Philippe Mathieu-Daudé <philmd@linaro.org>\n\ncompat_props_add() is only used by board models, no need\nto expose it to any device model. Restrict by defining it\nonly in \"hw/core/boards.h\".\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Michael Tokarev <mjt@tls.msk.ru>\n---\n include/hw/core/boards.h | 10 ++++++++++\n include/hw/core/qdev.h   | 10 ----------\n 2 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h\nindex b8dad0a107..0ac7e17ef7 100644\n--- a/include/hw/core/boards.h\n+++ b/include/hw/core/boards.h\n@@ -798,6 +798,16 @@ struct MachineState {\n         } \\\n     } while (0)\n \n+static inline void\n+compat_props_add(GPtrArray *arr,\n+                 GlobalProperty props[], size_t nelem)\n+{\n+    int i;\n+    for (i = 0; i < nelem; i++) {\n+        g_ptr_array_add(arr, (void *)&props[i]);\n+    }\n+}\n+\n extern GlobalProperty hw_compat_10_2[];\n extern const size_t hw_compat_10_2_len;\n \ndiff --git a/include/hw/core/qdev.h b/include/hw/core/qdev.h\nindex f99a8979cc..778617787c 100644\n--- a/include/hw/core/qdev.h\n+++ b/include/hw/core/qdev.h\n@@ -421,16 +421,6 @@ typedef struct GlobalProperty {\n     bool optional;\n } GlobalProperty;\n \n-static inline void\n-compat_props_add(GPtrArray *arr,\n-                 GlobalProperty props[], size_t nelem)\n-{\n-    int i;\n-    for (i = 0; i < nelem; i++) {\n-        g_ptr_array_add(arr, (void *)&props[i]);\n-    }\n-}\n-\n /*** Board API.  This should go away once we have a machine config file.  ***/\n \n /**\n","prefixes":["for-11.0","2/6"]}