{"id":2219423,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219423/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402234724.88276-2-mohamed@unpredictable.fr>","date":"2026-04-02T23:47:18","name":"[v3,1/7] target/i386: emulate: include name of unhandled instruction","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3a767fdef94ad0a8b91bb13206d74bf020915274","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.0/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402234724.88276-2-mohamed@unpredictable.fr/mbox/","series":[{"id":498566,"url":"http://patchwork.ozlabs.org/api/1.0/series/498566/?format=json","date":"2026-04-02T23:47:19","name":"whpx: i386: x2apic emulation for kernel-irqchip=off, feature probing","version":3,"mbox":"http://patchwork.ozlabs.org/series/498566/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219423/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=a2oAvlv0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmz8S61y3z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 10:48:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8RlC-0004Fn-38; Thu, 02 Apr 2026 19:47:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w8RlA-0004FL-BM\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 19:47:36 -0400","from p-west2-cluster6-host6-snip4-1.eps.apple.com ([57.103.70.34]\n helo=outbound.mr.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1w8Rl8-00042c-Mo\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 19:47:36 -0400","from outbound.mr.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-6 (Postfix) with ESMTPS id\n 094251800138; Thu, 02 Apr 2026 23:47:30 +0000 (UTC)","from localhost.localdomain (unknown [17.57.152.38])\n by p00-icloudmta-asmtp-us-west-2a-60-percent-6 (Postfix) with ESMTPSA id\n 146D6180011E; Thu, 02 Apr 2026 23:47:28 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775173652; x=1777765652;\n bh=jSFEY3OW57r5Gmf0SB6G349rIgUNCT10rXc1M/CBSww=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=a2oAvlv0jODbR5Ae/eWAArBOEf2BVOeiZfb3dN81B3XkNbpGTzq9UkMFgsUIueZ4OaCsTkfPeV1UkB+U4oN3EXqHj2II6VZJK98M9b+0I35SZ990Jb9fN26I/h3OOAX/xebIQVrN7TvBVAqokvjRcZJS7DYkTpS79E7H3ZyNt9yyottlz4sUOYWW3JPFKYvsXzHmQcn5PrkuYRUHcthUwSjNoAZ14j2rZEFaStA9Q5e+fCEtS/7264uzZ6G7Fqxld6Zaep/ozgs0BDOJNpmchUpbnO4k3mKaOvWYgBXNSmWInSLSD/mMOVJrA/w0U9Nh/Rjm50q8fsxe1mgz7uAWIQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni <mohamed@unpredictable.fr>","To":"qemu-devel@nongnu.org","Cc":"Mohamed Mediouni <mohamed@unpredictable.fr>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Roman Bolshakov <rbolshakov@ddn.com>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Pedro Barbuda <pbarbuda@microsoft.com>, Wei Liu <wei.liu@kernel.org>","Subject":"[PATCH v3 1/7] target/i386: emulate: include name of unhandled\n instruction","Date":"Fri,  3 Apr 2026 01:47:18 +0200","Message-ID":"<20260402234724.88276-2-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260402234724.88276-1-mohamed@unpredictable.fr>","References":"<20260402234724.88276-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDIxMiBTYWx0ZWRfXybt9psVA9pVZ\n pjHvCxDKNWmbipvjrHFk/umggtDWNiQjvTTwH6wYvaWX6XD1VZIYCPwa087vlhMLb8l5eKcgYNZ\n CH7dZRsCaly37xBRocjUNuuTnFdBZ5rwYClm9vfILiLGovslQjCw6y8KYCEXc/BtAtvVhWEFmk4\n Vursa8MkrtM63eU5zaLsvCYGclXolhzqo2HAZsBvqWlC8UkDhBXhxEa5CAFVwJLkbZ2F0p7q4kO\n XLdoXsaoiMbfJIO3b+aLocSiQYKydt5YnrN//SU8P5hp9w4g3Cv71NU2aEwv02chM39aI1muv1/\n EMDDELQy0TsmPLcoAtGwGGvBQ9mDCn5gsaFfBlhglJXoCorVI3UOwbwkhCbPsY=","X-Proofpoint-GUID":"DxRbvDKC-UprgcSirXR5wnw9UNbBSYVW","X-Proofpoint-ORIG-GUID":"DxRbvDKC-UprgcSirXR5wnw9UNbBSYVW","X-Authority-Info-Out":"v=2.4 cv=UOnQ3Sfy c=1 sm=1 tr=0 ts=69cf0013\n cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117\n a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=x0iqa3ucmZZh0HPruXgA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 bulkscore=0\n phishscore=0 suspectscore=0 clxscore=1030 mlxscore=0 spamscore=0\n malwarescore=0 lowpriorityscore=0 mlxlogscore=903 adultscore=0\n classifier=spam authscore=0 adjust=0 reason=mlx scancount=1\n engine=8.22.0-2601150000 definitions=main-2604020212","Received-SPF":"pass client-ip=57.103.70.34;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Instead of just the command number, include the instruction name to make debugging easier.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/emulate/x86_emu.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/i386/emulate/x86_emu.c b/target/i386/emulate/x86_emu.c\nindex 55b1a68eb6..c2da1a133f 100644\n--- a/target/i386/emulate/x86_emu.c\n+++ b/target/i386/emulate/x86_emu.c\n@@ -1399,8 +1399,8 @@ static void init_cmd_handler(void)\n bool exec_instruction(CPUX86State *env, struct x86_decode *ins)\n {\n     if (!_cmd_handler[ins->cmd].handler) {\n-        printf(\"Unimplemented handler (\" TARGET_FMT_lx \") for %d (%x %x)\\n\",\n-                env->eip,\n+        printf(\"Unimplemented handler (\" TARGET_FMT_lx \") for %s - %d (%x %x)\\n\",\n+                env->eip, decode_cmd_to_string(ins->cmd),\n                 ins->cmd, ins->opcode[0],\n                 ins->opcode_len > 1 ? ins->opcode[1] : 0);\n         env->eip += ins->len;\n","prefixes":["v3","1/7"]}