{"id":2219398,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219398/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402221453.1602899-3-zycai@linux.ibm.com>","date":"2026-04-02T22:14:24","name":"[v10,02/30] crypto/x509-utils: Refactor with GNUTLS fallback","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7ad2cdc9b4c4456cd73ae6c27695b9052e21f289","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.0/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-3-zycai@linux.ibm.com/mbox/","series":[{"id":498557,"url":"http://patchwork.ozlabs.org/api/1.0/series/498557/?format=json","date":"2026-04-02T22:14:35","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":10,"mbox":"http://patchwork.ozlabs.org/series/498557/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219398/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=noGRX4cA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx7n6LKlz1xtJ\n\tfor ; Fri, 03 Apr 2026 09:18:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8QJu-0000gh-AE; Thu, 02 Apr 2026 18:15:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QJs-0000eE-8A; Thu, 02 Apr 2026 18:15:20 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QJp-0004lQ-GQ; Thu, 02 Apr 2026 18:15:19 -0400","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632EdSUb188586; Thu, 2 Apr 2026 22:15:12 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66nnxs7y-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:11 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632L2nrG013922;\n Thu, 2 Apr 2026 22:15:10 GMT","from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6ttkuuqs-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:10 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MF9JT22479420\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:09 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 5AEEA58065;\n Thu, 2 Apr 2026 22:15:09 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 048B858056;\n Thu, 2 Apr 2026 22:15:08 +0000 (GMT)","from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:07 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=WKks+E\n dIYbxgjkTxmJqLBnT3Rd/1ziDHPOiDpayzQQo=; b=noGRX4cAZwRMMjQJuK1Z0q\n WxLB66dYVwPlDY018AVdbqWbe/3Ue8rHm9gugjFUaOiyoFqLqXxjPAK34E4pxIMp\n jvWeJC+OIAvCdKJGh4dOKgJh6t5DGqS9FF/T6ufjXCEzr7WcHkZbfp1QpDeomMRO\n NJIHIkTKc81tn2Zl4/83UREBmO3K8/9lOehJKBmuG/9gn1nSUUSSn/Eq+yenxSOk\n lRYsb9wQtj536EVCDrN9lpgFUHAFZIhGydy4m6cmcViKLPjJTeTHdvYXJfAtj5GE\n XdMjHXz5Cw7n66sEL4rAiZew2HYz+ZnL4+u106+XH6TOQLAgKcnYTosaFLeSCDRQ\n ==","From":"Zhuoying Cai ","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com","Subject":"[PATCH v10 02/30] crypto/x509-utils: Refactor with GNUTLS fallback","Date":"Thu, 2 Apr 2026 18:14:24 -0400","Message-ID":"<20260402221453.1602899-3-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402221453.1602899-1-zycai@linux.ibm.com>","References":"<20260402221453.1602899-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-GUID":"hsep4-eUCeV-sVcd27sg_lf8SjRviLIr","X-Authority-Analysis":"v=2.4 cv=KslAGGWN c=1 sm=1 tr=0 ts=69ceea6f cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=FUyA0-9y5A7gcD0mOlIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfXzO6Qlo/ppJTc\n 4vYjGUF4QYXsofgFwKBd4bMLKzqS+pPYxKNSbph1GzZjcbR7QI2cHma4h59FptLVBUOGNd3csEz\n 35FsQ+EGE/XQptyaPRVp2YVntuIQayu0UscNMW0z5zk6Y3wzUagQNp8VKhyXNY14HbdCUFFfqxl\n ARmsVtgV8xeOiHjx66MKMBDT4LRJsph77MC997bioGqEI2Na4abCy9z+4ktpfxXkN0gzVH3E9Hv\n 5iU7DPR1hdNPp32PZ+e38fwjZUtAU6A0jMQhqHvWbW8oHepLpv7McAEgpnQI2E/IAjIV+EbPpHx\n bGMiYVxAVGRkPmsegUc4uHcPZt9gKQ4EOF05JGBoQpbvQX+w+KNwZF3r6VyYnP1s7zKnwlN5C8w\n EI4pPuJpCLKr7i1s1gksIR1n02KLCfpTKZXMTRiJA2xbE00+0UJ+T7T2oiYGKE3nbatJQyZWCxN\n UeIYoa8OIuDXERfhnaw==","X-Proofpoint-ORIG-GUID":"hsep4-eUCeV-sVcd27sg_lf8SjRviLIr","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0\n phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1011\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020195","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=zycai@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Always compile x509-utils.c and add a fallback when GNUTLS is\nunavailable.\n\nThese functions will be needed in the s390x code regardless of whether\nGNUTLS is available.\n\nSigned-off-by: Zhuoying Cai \nAcked-by: Daniel P. Berrangé \nReviewed-by: Daniel P. Berrangé \nReviewed-by: Farhan Ali \nReviewed-by: Thomas Huth \n---\n crypto/meson.build | 2 +-\n crypto/x509-utils.c | 16 ++++++++++++++++\n 2 files changed, 17 insertions(+), 1 deletion(-)","diff":"diff --git a/crypto/meson.build b/crypto/meson.build\nindex b51597a879..fda85543de 100644\n--- a/crypto/meson.build\n+++ b/crypto/meson.build\n@@ -22,12 +22,12 @@ crypto_ss.add(files(\n 'tlscredsx509.c',\n 'tlssession.c',\n 'rsakey.c',\n+ 'x509-utils.c',\n ))\n \n if gnutls.found()\n crypto_ss.add(files(\n 'tlscredsbox.c',\n- 'x509-utils.c',\n ))\n endif\n \ndiff --git a/crypto/x509-utils.c b/crypto/x509-utils.c\nindex 39bb6d4d8c..6176a88653 100644\n--- a/crypto/x509-utils.c\n+++ b/crypto/x509-utils.c\n@@ -11,6 +11,8 @@\n #include \"qemu/osdep.h\"\n #include \"qapi/error.h\"\n #include \"crypto/x509-utils.h\"\n+\n+#ifdef CONFIG_GNUTLS\n #include \n #include \n #include \n@@ -78,3 +80,17 @@ int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n gnutls_x509_crt_deinit(crt);\n return ret;\n }\n+\n+#else /* ! CONFIG_GNUTLS */\n+\n+int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n+ QCryptoHashAlgo hash,\n+ uint8_t *result,\n+ size_t *resultlen,\n+ Error **errp)\n+{\n+ error_setg(errp, \"GNUTLS is required to get fingerprint\");\n+ return -1;\n+}\n+\n+#endif /* ! CONFIG_GNUTLS */\n","prefixes":["v10","02/30"]}