{"id":2219391,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219391/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402221453.1602899-7-zycai@linux.ibm.com>","date":"2026-04-02T22:14:28","name":"[v10,06/30] s390x/diag: Refactor address validation check from diag308_parm_check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"70d9fb05daf4aea056826a96bdd95634d072e53f","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.0/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-7-zycai@linux.ibm.com/mbox/","series":[{"id":498557,"url":"http://patchwork.ozlabs.org/api/1.0/series/498557/?format=json","date":"2026-04-02T22:14:35","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":10,"mbox":"http://patchwork.ozlabs.org/series/498557/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219391/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=jgw096SC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx794xqjz1xtJ\n\tfor ; Fri, 03 Apr 2026 09:17:41 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8QJv-0000iz-MM; Thu, 02 Apr 2026 18:15:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QJu-0000h4-Jj; Thu, 02 Apr 2026 18:15:22 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QJt-0004mD-2W; Thu, 02 Apr 2026 18:15:22 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632EOvlv119453; Thu, 2 Apr 2026 22:15:18 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66msdtfj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:17 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632JWV7Z005910;\n Thu, 2 Apr 2026 22:15:17 GMT","from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6spyc0vc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:17 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFFtj27918992\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:15 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 66DDF58056;\n Thu, 2 Apr 2026 22:15:15 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0897D58052;\n Thu, 2 Apr 2026 22:15:14 +0000 (GMT)","from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:13 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=7jCarr+WGbmHu+2Yi\n 3YrMYGZaXdJCHOLAvclBahg01U=; b=jgw096SCW6gZ7hPkZhZoLVK6QVJn9yP/v\n oqVBHmXyk8Dp9mj7QjFMcJeLqvoZP8d5wdecnus6rhn/X94NWfwu0Izc01TI6qUE\n gtnnuObXq6RKwsKzD3dBWhkEQj+jLiPo3p3EfFiYkxA+7BTc/ByHycjR1jYP4mZB\n IV7N4s+kiX6ImRes+1/zoW2wDCm4iAHDbR2/RLMC2nrCJpQBQKP3I1U/Rixp3QAV\n 1mLpq/yFvqLtG6FidzxYeu6dgLBlegHBGOJH/WyevUxfJjCAyK20AP4FCY/P1nwz\n 24eUHX3OpwNTqzwPvYrCU2iPBFRSbRO7fcZcDQHuGN39mz8C5ZJ5w==","From":"Zhuoying Cai ","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com","Subject":"[PATCH v10 06/30] s390x/diag: Refactor address validation check from\n diag308_parm_check","Date":"Thu, 2 Apr 2026 18:14:28 -0400","Message-ID":"<20260402221453.1602899-7-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402221453.1602899-1-zycai@linux.ibm.com>","References":"<20260402221453.1602899-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69ceea75 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=130TwiEZxdn8fhqcL5YA:9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX/8EznLBrjF8b\n dJu7LL0QeSXM8osnHnVsSUKiwdBqoDoO10lG8+5b1X8lxIRNymeZ8p6/2MPU5w2kL4rFre5S/I0\n c+JTtKM0mjaSJwNsWKrD8hiZ41S/idBSUEMvh3qgkVUyYoPTcCW5VRvhTXNTFrkiYLkAHp1YGDm\n xgdUwLXWfYiJvH82qzSCDNjvvd9Cw9pfQYdp1bwdLym/T0frRys/EI9EbMpUuVfPI90Jydh71eK\n UoFPcXk6x7ALMYKjhsbZm7RIx/CHu6w92ZSZsA8Kgo1Cs55ukg1ZYXouwcBSdymAeeWnvdEj4DV\n zjxV07gLVUnVV8kGFvE9/Tz+JTOQlJVOatLd8dPP/sTHkpRXQQbQ9rkg/4IJOcK6XjeqUnm+eIP\n QhlHui0nHoUy+yRZLpRFQBBWHMC/K5eiYsfEqPs8/Zx/208/HXVID0FGwbEqfi/PyaRf7H6sv5B\n fmZZ5Bn7LzmvA0fwFtw==","X-Proofpoint-GUID":"emhI1b7og59J_X8_3h95tBtWG5mu5RqK","X-Proofpoint-ORIG-GUID":"emhI1b7og59J_X8_3h95tBtWG5mu5RqK","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Create a function to validate the address parameter of DIAGNOSE.\n\nRefactor the function for reuse in the next patch, which allows address\nvalidation in read or write operation of DIAGNOSE.\n\nSigned-off-by: Zhuoying Cai \nReviewed-by: Farhan Ali \nReviewed-by: Collin Walling \nReviewed-by: Hendrik Brueckner \nReviewed-by: Thomas Huth \n---\n target/s390x/diag.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex 6373544bb2..8ab40437a2 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -26,6 +26,12 @@\n #include \"qemu/error-report.h\"\n \n \n+static inline bool diag_parm_addr_valid(uint64_t addr, size_t size, bool write)\n+{\n+ return address_space_access_valid(&address_space_memory, addr,\n+ size, write, MEMTXATTRS_UNSPECIFIED);\n+}\n+\n int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3)\n {\n uint64_t func = env->regs[r1];\n@@ -65,9 +71,7 @@ static int diag308_parm_check(CPUS390XState *env, uint64_t r1, uint64_t addr,\n s390_program_interrupt(env, PGM_SPECIFICATION, ra);\n return -1;\n }\n- if (!address_space_access_valid(&address_space_memory, addr,\n- sizeof(IplParameterBlock), write,\n- MEMTXATTRS_UNSPECIFIED)) {\n+ if (!diag_parm_addr_valid(addr, sizeof(IplParameterBlock), write)) {\n s390_program_interrupt(env, PGM_ADDRESSING, ra);\n return -1;\n }\n","prefixes":["v10","06/30"]}