{"id":2219386,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219386/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402221453.1602899-4-zycai@linux.ibm.com>","date":"2026-04-02T22:14:25","name":"[v10,03/30] crypto/x509-utils: Add helper functions for certificate store","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d2b865a3bd2337ca2f5272d31d2fbed5513f3738","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.0/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-4-zycai@linux.ibm.com/mbox/","series":[{"id":498557,"url":"http://patchwork.ozlabs.org/api/1.0/series/498557/?format=json","date":"2026-04-02T22:14:35","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":10,"mbox":"http://patchwork.ozlabs.org/series/498557/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219386/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=s2czc4xv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6n6Sdwz1yDH\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:17:21 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QJu-0000gz-Hd; Thu, 02 Apr 2026 18:15:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QJs-0000eZ-J4; Thu, 02 Apr 2026 18:15:20 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QJp-0004lU-Tk; Thu, 02 Apr 2026 18:15:20 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632D0HeV3435060; Thu, 2 Apr 2026 22:15:13 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d65dcnvem-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:12 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632LJ9pZ030952;\n Thu, 2 Apr 2026 22:15:11 GMT","from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6uhk3rjp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:11 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFA2R27132650\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:11 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id E49C558068;\n Thu,  2 Apr 2026 22:15:10 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 81AA358052;\n Thu,  2 Apr 2026 22:15:09 +0000 (GMT)","from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu,  2 Apr 2026 22:15:09 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=QD5O1x\n GaUG4/7Rrqjf+RXzCnnv0+4bav5v+IJcUSyso=; b=s2czc4xvrZ6F4nIKiJ38+d\n JhY2xGjwJEzghq9e0qHmMe33rbq380UNCTQB9v1i55fnM8nNNR3BgsVNIh5+Y7K2\n ikDlIoSG6wOVICXZR+GKTYKbgOvm5O/Z2RFVYj8vzKnJT949pmN7coguQiS2X6Rq\n I/lCjd/3blkKxHm1mndXdBNxXXW8G9XOcgDcTOEn/0mTB+/9gPcplXSivLEq0LoT\n 2pRDT8ObZP7V3tCX7heym6WvNd9WA2/dk/geqt94a1BBfXTPDjdsHhTVEn/8FmN/\n /bGSpsIJ4YsAE4dBmBB5IREVGkGoPJaCQ8q2t8vf/JckessUXp0Y9ZBImtaY5o1A\n ==","From":"Zhuoying Cai <zycai@linux.ibm.com>","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com","Subject":"[PATCH v10 03/30] crypto/x509-utils: Add helper functions for\n certificate store","Date":"Thu,  2 Apr 2026 18:14:25 -0400","Message-ID":"<20260402221453.1602899-4-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402221453.1602899-1-zycai@linux.ibm.com>","References":"<20260402221453.1602899-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=RsjI7SmK c=1 sm=1 tr=0 ts=69ceea70 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=GX81FK21qHpjiM7aGUoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-GUID":"mXYY91L_o89b9cE26ZPkjMSN19Y2Pfkk","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX/SD6+GJJDpIw\n pF4yfc5IhkxwrzbBSlmrMQ9JIAREvDgu4ttd6Ob7cZ9Vv1pHvJTb0PIg2v3y5JtapawgPXq29zg\n oc0W28UVNmt5h3JqIvBP53YBv/SlPpEAT1r4BacM45vh5qNpP1QBBGxOpmOQBil3fA7ZNS7hhyY\n JMYgICq+vNzE5C0jBEhdLn1C34RjZjOCMlv9whBhiPUtr+h/N6zoy7sa2ountSfrRIp1ZDOq7Fg\n LZM/9lku6CXamyA7PBB01c2cM+vobNgciBF2Df3fTwEwkv+niVBbWs+qGcbUZXxjY+JvtLx4M+x\n 2kVfHCrHH2/r/28bWY7o3F93rMQE2hO08mQe2GiaHVsJMeOjTqPAEojf4iPCqgoq4yuaI1RIKae\n /FuT172PCQ6Ew8AFOpq42dRDvAUCuEvwAuCrm+WJkt+jnyPtv4qfITC8SDHrdWg7QzycOOye69j\n RZcqlABHggd+6/gM6FA==","X-Proofpoint-ORIG-GUID":"mXYY91L_o89b9cE26ZPkjMSN19Y2Pfkk","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0\n suspectscore=0 malwarescore=0 spamscore=0 clxscore=1011 phishscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Introduce new helper functions for x509 certificate, which will be used\nby the certificate store:\n\nqcrypto_x509_convert_cert_der() - converts a certificate from PEM to DER format\n\nThese functions provide support for certificate format conversion.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nAcked-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Farhan Ali <alifm@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n crypto/x509-utils.c         | 49 +++++++++++++++++++++++++++++++++++++\n include/crypto/x509-utils.h | 21 ++++++++++++++++\n 2 files changed, 70 insertions(+)","diff":"diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c\nindex 6176a88653..2696d48155 100644\n--- a/crypto/x509-utils.c\n+++ b/crypto/x509-utils.c\n@@ -81,6 +81,46 @@ int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n     return ret;\n }\n \n+int qcrypto_x509_convert_cert_der(uint8_t *cert, size_t size,\n+                                  uint8_t **result, size_t *resultlen,\n+                                  Error **errp)\n+{\n+    int ret = -1;\n+    int rc;\n+    gnutls_x509_crt_t crt;\n+    gnutls_datum_t datum = {.data = cert, .size = size};\n+    gnutls_datum_t datum_der = {.data = NULL, .size = 0};\n+\n+    rc = gnutls_x509_crt_init(&crt);\n+    if (rc < 0) {\n+        error_setg(errp, \"Failed to initialize certificate: %s\", gnutls_strerror(rc));\n+        return ret;\n+    }\n+\n+    rc = gnutls_x509_crt_import(crt, &datum, GNUTLS_X509_FMT_PEM);\n+    if (rc != 0) {\n+        error_setg(errp, \"Failed to import certificate: %s\", gnutls_strerror(rc));\n+        goto cleanup;\n+    }\n+\n+    rc = gnutls_x509_crt_export2(crt, GNUTLS_X509_FMT_DER, &datum_der);\n+    if (rc != 0) {\n+        error_setg(errp, \"Failed to convert certificate to DER format: %s\",\n+                   gnutls_strerror(rc));\n+        goto cleanup;\n+    }\n+\n+    *resultlen = datum_der.size;\n+    *result = g_memdup2(datum_der.data, datum_der.size);\n+\n+    ret = 0;\n+\n+cleanup:\n+    gnutls_x509_crt_deinit(crt);\n+    gnutls_free(datum_der.data);\n+    return ret;\n+}\n+\n #else /* ! CONFIG_GNUTLS */\n \n int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n@@ -93,4 +133,13 @@ int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n     return -1;\n }\n \n+int qcrypto_x509_convert_cert_der(uint8_t *cert, size_t size,\n+                                  uint8_t **result,\n+                                  size_t *resultlen,\n+                                  Error **errp)\n+{\n+    error_setg(errp, \"GNUTLS is required to export X.509 certificate\");\n+    return -1;\n+}\n+\n #endif /* ! CONFIG_GNUTLS */\ndiff --git a/include/crypto/x509-utils.h b/include/crypto/x509-utils.h\nindex 1e99661a71..91ae79fb03 100644\n--- a/include/crypto/x509-utils.h\n+++ b/include/crypto/x509-utils.h\n@@ -19,4 +19,25 @@ int qcrypto_get_x509_cert_fingerprint(uint8_t *cert, size_t size,\n                                       size_t *resultlen,\n                                       Error **errp);\n \n+/**\n+ * qcrypto_x509_convert_cert_der\n+ * @cert: pointer to the raw certificate data in PEM format\n+ * @size: size of the certificate\n+ * @result: output location for the allocated buffer for the certificate\n+ *          in DER format\n+ *          (the function allocates memory which must be freed by the caller)\n+ * @resultlen: pointer to the size of the buffer (will be updated with the\n+ *             actual size of the DER-encoded certificate)\n+ * @errp: error pointer\n+ *\n+ * Convert the given @cert from PEM to DER format.\n+ *\n+ * Returns: 0 on success,\n+ *         -1 on error.\n+ */\n+int qcrypto_x509_convert_cert_der(uint8_t *cert, size_t size,\n+                                  uint8_t **result,\n+                                  size_t *resultlen,\n+                                  Error **errp);\n+\n #endif\n","prefixes":["v10","03/30"]}