{"id":2219385,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219385/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402221453.1602899-27-zycai@linux.ibm.com>","date":"2026-04-02T22:14:48","name":"[v10,26/30] hw/s390x/ipl: Handle secure boot with multiple boot devices","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1952de835d410ae79684a5c48e98fb50f2f24103","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.0/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-27-zycai@linux.ibm.com/mbox/","series":[{"id":498557,"url":"http://patchwork.ozlabs.org/api/1.0/series/498557/?format=json","date":"2026-04-02T22:14:35","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":10,"mbox":"http://patchwork.ozlabs.org/series/498557/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219385/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=Bs3y6Mgf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6n19XLz1xtJ\n\tfor ; Fri, 03 Apr 2026 09:17:21 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8QL3-0002bt-3g; Thu, 02 Apr 2026 18:16:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QKl-00017Q-IS; Thu, 02 Apr 2026 18:16:19 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8QKi-0004s4-VG; Thu, 02 Apr 2026 18:16:14 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632EVRIv330917; Thu, 2 Apr 2026 22:15:49 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d64dgx0s3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:49 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632M0qlZ008685;\n Thu, 2 Apr 2026 22:15:48 GMT","from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6v11upr5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:48 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFkcM15729052\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:46 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 93F9A58056;\n Thu, 2 Apr 2026 22:15:46 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 34EC75805D;\n Thu, 2 Apr 2026 22:15:45 +0000 (GMT)","from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 22:15:45 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=zohZBaQ3Pchg18/Ld\n XvmfXEUQE71vbMUkT+CsS/Yk6Y=; b=Bs3y6Mgf1XXS4GqahhB6JKtLr8bNI6uJ1\n 3JG5oiZOpzi1Ibcr7TFu2r+jaWWe+Unb1bX0S4z4Q2NWrYRkveH3/WUzCZJoOuG0\n TQZGe4cjtIUir39XlzNsJpZIpNuZb2kJpsXkvhtnd2n2IXVaUL9lXN3HAOlTQXWV\n x8crbIV4YZJaQ+qTBwgrSy8oXOGyXZs23wjKAhW73ScwGFF5lQH6XXIuG2MzxXln\n nXo0/6atsMbX9fUo1KUoYD8OyzNMxLctoQQnhO9su2vvWZZXkySohvHL4Nf4Pmw2\n G5TT0yf3CmRWTVgDqlv5F8H15/+UJmAmtd0eDk4PizTSO2QwZZ7jw==","From":"Zhuoying Cai ","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com","Subject":"[PATCH v10 26/30] hw/s390x/ipl: Handle secure boot with multiple boot\n devices","Date":"Thu, 2 Apr 2026 18:14:48 -0400","Message-ID":"<20260402221453.1602899-27-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402221453.1602899-1-zycai@linux.ibm.com>","References":"<20260402221453.1602899-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX2g2ppYAr9S7r\n MSzcrpaMDOiGVuQA2wDbfjJN+d6DvRtXgKZFab/Ccdj5/SDuY6Mn0SCtr7W2wzSBzNVplwtAfTe\n 5O9Bc3eB1fnPxvAxkCUjJMPoYe5sjmK4mwB/Ru+nbnvkdi1DbLzE2EzLHxhmXnSWFQIxwugyXAX\n RmoTuBg6UQRUhzubwmp5Apq3orzA26dmHTxT9zJlapPpW8/44qbbvbjAZiRK+4ZiK+LJs1T0rhr\n EAb0Xi2/iJod3WmU8X6m1v9wy/h0gqp9LVYhB3jKgMd/taR+getqTBuiku14/krRTHKMUZdV6vu\n pzP+9a0OIw4D93DAsABrgoP+9Hw3F/SBqS8na5MwjpPMYqRq37gFSUpMa2Mx2nnMwNdaOFniQXP\n 9TLepuS08BAk3LUg9Sff2elDQcovMUhLew1ge9o0OOQ9NDF2NzGT5OrLiXofL9WBojUxmessvhR\n d7h/LXk/3biJ55LLlKA==","X-Authority-Analysis":"v=2.4 cv=QKZlhwLL c=1 sm=1 tr=0 ts=69ceea95 cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=Q8-XYP680VqNmkEzHFAA:9","X-Proofpoint-GUID":"lrjRvEbw3T4PCT70nO3KHtwUiC2dBCyM","X-Proofpoint-ORIG-GUID":"lrjRvEbw3T4PCT70nO3KHtwUiC2dBCyM","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1015\n spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The current approach to enable secure boot relies on providing\nsecure-boot and boot-certs parameters of s390-ccw-virtio machine\ntype option, which apply to all boot devices.\n\nWith the possibility of multiple boot devices, secure boot expects all\nprovided devices to be supported and eligible (e.g.,\nvirtio-blk/virtio-scsi using the SCSI scheme).\n\nIf multiple boot devices are provided and include an unsupported (e.g.,\nECKD, VFIO) or a non-eligible (e.g., Net) device, the boot process will\nterminate with an error logged to the console.\n\nSigned-off-by: Zhuoying Cai \nReviewed-by: Thomas Huth \n---\n hw/s390x/ipl.c | 79 ++++++++++++++++++++++++++++-------------\n pc-bios/s390-ccw/main.c | 3 --\n 2 files changed, 54 insertions(+), 28 deletions(-)","diff":"diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c\nindex 67e8231c76..52f953fd32 100644\n--- a/hw/s390x/ipl.c\n+++ b/hw/s390x/ipl.c\n@@ -473,6 +473,58 @@ static bool s390_secure_boot_enabled(void)\n return S390_CCW_MACHINE(qdev_get_machine())->secure_boot;\n }\n \n+static bool s390_validate_secure_boot_device(int devtype, Error **errp)\n+{\n+ switch (devtype) {\n+ case CCW_DEVTYPE_VFIO:\n+ error_setg(errp, \"Passthrough (vfio) CCW device does not support secure boot!\");\n+ return false;\n+ case CCW_DEVTYPE_VIRTIO_NET:\n+ error_setg(errp, \"Virtio net boot device does not support secure boot!\");\n+ return false;\n+ default:\n+ return true;\n+ }\n+}\n+\n+static void s390_apply_secure_boot(IplParameterBlock *iplb, int devtype,\n+ bool secure_boot, bool audit_mode)\n+{\n+ Error *local_error = NULL;\n+\n+ if (!secure_boot && !audit_mode) {\n+ return;\n+ }\n+\n+ if (!s390_validate_secure_boot_device(devtype, &local_error)) {\n+ error_report_err(local_error);\n+ exit(1);\n+ }\n+\n+ /*\n+ * If secure-boot is enabled, then toggle the secure IPL flags (SIPL) to\n+ * trigger secure boot in the s390 BIOS.\n+ *\n+ * Boot process will terminate if any error occurs during secure boot.\n+ */\n+ if (secure_boot) {\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_SIPL;\n+ }\n+\n+ /*\n+ * For both secure boot and audit mode, enable the IPL Information\n+ * Report (IPLIR) flag so that the firmware generates an IPL\n+ * Information Report Block (IIRB).\n+ *\n+ * Results of secure boot will be stored in IIRB.\n+ *\n+ * Extend the IPL parameter block to its maximum length to ensure\n+ * sufficient space for the BIOS to populate the IIRB.\n+ */\n+ iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n+ iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n+}\n+\n static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n {\n CcwDevice *ccw_dev = NULL;\n@@ -529,31 +581,8 @@ static bool s390_build_iplb(DeviceState *dev_st, IplParameterBlock *iplb)\n s390_ipl_convert_loadparm((char *)lp, iplb->loadparm);\n iplb->flags |= DIAG308_FLAGS_LP_VALID;\n \n- /*\n- * If secure-boot is enabled, then toggle the secure IPL flags to\n- * trigger secure boot in the s390 BIOS.\n- *\n- * Boot process will terminate if any error occurs during secure boot.\n- *\n- * If SIPL is on, IPLIR must also be on.\n- */\n- if (s390_secure_boot_enabled()) {\n- iplb->hdr_flags |= (DIAG308_IPIB_FLAGS_SIPL | DIAG308_IPIB_FLAGS_IPLIR);\n- iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n- }\n- /*\n- * Secure boot in audit mode will perform\n- * if certificate(s) exist in the key store.\n- *\n- * IPL Information Report Block (IIRB) will exist\n- * for secure boot in audit mode.\n- *\n- * Results of secure boot will be stored in IIRB.\n- */\n- else if (s390_has_certificate()) {\n- iplb->hdr_flags |= DIAG308_IPIB_FLAGS_IPLIR;\n- iplb->len = cpu_to_be32(S390_IPLB_MAX_LEN);\n- }\n+ s390_apply_secure_boot(iplb, devtype, s390_secure_boot_enabled(),\n+ s390_has_certificate());\n \n return true;\n }\ndiff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c\nindex 93d22fc77c..7233f3db89 100644\n--- a/pc-bios/s390-ccw/main.c\n+++ b/pc-bios/s390-ccw/main.c\n@@ -304,9 +304,6 @@ static void ipl_ccw_device(void)\n switch (cutype) {\n case CU_TYPE_DASD_3990:\n case CU_TYPE_DASD_2107:\n- IPL_assert((boot_mode == ZIPL_BOOT_MODE_NORMAL),\n- \"Passthrough (vfio) CCW device does not support secure boot!\");\n-\n dasd_ipl(blk_schid, cutype);\n break;\n case CU_TYPE_VIRTIO:\n","prefixes":["v10","26/30"]}