{"id":2219383,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219383/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402221453.1602899-17-zycai@linux.ibm.com>","date":"2026-04-02T22:14:38","name":"[v10,16/30] s390x: Guest support for Secure-IPL Facility","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1c548810eda8cb6f319a246561c45f85832063ff","submitter":{"id":90643,"url":"http://patchwork.ozlabs.org/api/1.0/people/90643/?format=json","name":"Zhuoying Cai","email":"zycai@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402221453.1602899-17-zycai@linux.ibm.com/mbox/","series":[{"id":498557,"url":"http://patchwork.ozlabs.org/api/1.0/series/498557/?format=json","date":"2026-04-02T22:14:35","name":"Secure IPL Support for SCSI Scheme of virtio-blk/virtio-scsi Devices","version":10,"mbox":"http://patchwork.ozlabs.org/series/498557/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219383/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=tl5+2CxB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmx6V1ZRsz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 09:17:06 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8QKb-0000zB-5h; Thu, 02 Apr 2026 18:16:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QKC-0000r9-Hu; Thu, 02 Apr 2026 18:15:55 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <zycai@linux.ibm.com>)\n id 1w8QK8-0004p5-Mj; Thu, 02 Apr 2026 18:15:38 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632BiTem4172385; Thu, 2 Apr 2026 22:15:33 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d65dcnvfk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:33 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 632K924n022210;\n Thu, 2 Apr 2026 22:15:32 GMT","from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6tanbw84-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 22:15:32 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632MFUab19202722\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 22:15:31 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id D01775806D;\n Thu,  2 Apr 2026 22:15:30 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 588B758068;\n Thu,  2 Apr 2026 22:15:29 +0000 (GMT)","from fedora-workstation.ibmuc.com (unknown [9.61.183.185])\n by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Thu,  2 Apr 2026 22:15:29 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=ZBv08pQ05NR1iOEpF\n CdnkOz8FE6Qof7cX46vh8HxqFU=; b=tl5+2CxBwqedDSotNp4WWlQDyQe1DcIvA\n ggF1OX0d+sdcHLGaagMiIqmfLs4u/7SbnW8XpzifAowBU+gLf+0ZghRuvruVGwQ5\n MnYtz+Ys20SxPVy0NAC9Qs+o7/IOg2dmvqlcZ3JXJkTfADPqY+An4C5dKe1fFO3L\n 6C0lQrfBrAnuVYjaolUlpPjWc4I1uQl+70nVxLgdSXpZ7PLU/4WUfm2LK5wruqre\n OAl7zuToZIZs+omod/E7X0bn40uqIWlHPe4lG8i1dzPVM6htCQv9369sjOxRZiZx\n H21AQIpd+b+PUDo335hyYHvvIWBx/LzNfbRRZJ3ttwDJamRoyCI1Q==","From":"Zhuoying Cai <zycai@linux.ibm.com>","To":"qemu-s390x@nongnu.org, qemu-devel@nongnu.org","Cc":"jrossi@linux.ibm.com, cohuck@redhat.com, berrange@redhat.com,\n richard.henderson@linaro.org, pierrick.bouvier@linaro.org,\n david@kernel.org, walling@linux.ibm.com, jjherne@linux.ibm.com,\n pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com,\n mjrosato@linux.ibm.com, iii@linux.ibm.com, eblake@redhat.com,\n armbru@redhat.com, zycai@linux.ibm.com, alifm@linux.ibm.com,\n brueckner@linux.ibm.com, jdaley@linux.ibm.com","Subject":"[PATCH v10 16/30] s390x: Guest support for Secure-IPL Facility","Date":"Thu,  2 Apr 2026 18:14:38 -0400","Message-ID":"<20260402221453.1602899-17-zycai@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402221453.1602899-1-zycai@linux.ibm.com>","References":"<20260402221453.1602899-1-zycai@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=RsjI7SmK c=1 sm=1 tr=0 ts=69ceea85 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8\n a=Bichc5AjJS213ZhIJUEA:9","X-Proofpoint-GUID":"1LN-9eSNNbgAT3czvm-EhP6vss6dzzQZ","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDE5NSBTYWx0ZWRfX6503xnRkNMxE\n 3NDYlqCYYFrTGYRp+XcSERZUOr7xVuirOpBJhPQMSH/hye8lcPk3LRi7RA9zkUmcdJ83NujhsQo\n R9uwKLcUvO+/Uz1OsK+ar4qyz2LBq7APs8TdzYIpEYhnFtKWsof1zastgsdJJRRO0ZubFgNdpWg\n bx9eW73uf3ki082C3jqPJQ6dulykRJePh3zIEGkQoxISzTTVTk5aY12j111g/74XnuXPZMlYskG\n J8WEIW03XK72CwP3DPJjI+iJP0z+0rPN4mKnr41/gSt/uHG3M6GckDb8OSvPnIu66U+rBnnw7vP\n TuHYi+9MbUrAdsDqJs0z14jKmcvF8XQKxayCMc0qMtWZ+iJEnoff+ZICfyWlWiBnjUrsIyIoiPz\n CyqJDKWV180tB9Ap8DE8Br49lM0rFed4+BJREsMny9BqHbJxXWfXdExO27e+4USIfiMTqtGJuEQ\n PC1h0X/oLVAAekP/mcw==","X-Proofpoint-ORIG-GUID":"1LN-9eSNNbgAT3czvm-EhP6vss6dzzQZ","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0\n suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 phishscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020195","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=zycai@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Introduce Secure-IPL (SIPL) facility.\n\nUse fac_ipl to represent bytes 136 and 137 for IPL device facilities\nof the SCLP Read Info block.\n\nAvailability of SIPL facility is determined by byte 136 bit 1 of the\nSCLP Read Info block. Byte 136's facilities cannot be represented\nwithout the availability of the extended-length-SCCB, so add it as a\ncheck for consistency.\n\nSecure IPL is not available for guests under protected virtualization.\n\nThis feature is available starting with the gen16 CPU model.\n\nSigned-off-by: Zhuoying Cai <zycai@linux.ibm.com>\nReviewed-by: Collin Walling <walling@linux.ibm.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n hw/s390x/sclp.c                     | 2 ++\n include/hw/s390x/sclp.h             | 4 +++-\n target/s390x/cpu_features.c         | 4 ++++\n target/s390x/cpu_features.h         | 1 +\n target/s390x/cpu_features_def.h.inc | 3 +++\n target/s390x/cpu_models.c           | 2 ++\n target/s390x/gen-features.c         | 2 ++\n target/s390x/kvm/kvm.c              | 3 +++\n 8 files changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c\nindex b9c3983df1..666bae33f0 100644\n--- a/hw/s390x/sclp.c\n+++ b/hw/s390x/sclp.c\n@@ -146,6 +146,8 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)\n     if (s390_has_feat(S390_FEAT_EXTENDED_LENGTH_SCCB)) {\n         s390_get_feat_block(S390_FEAT_TYPE_SCLP_FAC134,\n                             &read_info->fac134);\n+        s390_get_feat_block(S390_FEAT_TYPE_SCLP_FAC_IPL,\n+                            read_info->fac_ipl);\n     }\n \n     read_info->facilities = cpu_to_be64(SCLP_HAS_CPU_INFO |\ndiff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h\nindex ddc61f1c21..a9595d8007 100644\n--- a/include/hw/s390x/sclp.h\n+++ b/include/hw/s390x/sclp.h\n@@ -136,7 +136,9 @@ typedef struct ReadInfo {\n     uint32_t hmfai;\n     uint8_t  _reserved7[134 - 128];     /* 128-133 */\n     uint8_t  fac134;\n-    uint8_t  _reserved8[144 - 135];     /* 135-143 */\n+    uint8_t  _reserved8;\n+    uint8_t  fac_ipl[2];                /* 136-137 */\n+    uint8_t  _reserved9[144 - 138];     /* 138-143 */\n     struct CPUEntry entries[];\n     /*\n      * When the Extended-Length SCCB (ELS) feature is enabled the\ndiff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c\nindex 436471f4b4..200bd8c15b 100644\n--- a/target/s390x/cpu_features.c\n+++ b/target/s390x/cpu_features.c\n@@ -119,6 +119,7 @@ void s390_fill_feat_block(const S390FeatBitmap features, S390FeatType type,\n      * Some facilities are not available for CPUs in protected mode:\n      * - All SIE facilities because SIE is not available\n      * - DIAG318\n+     * - Secure IPL Facility\n      *\n      * As VMs can move in and out of protected mode the CPU model\n      * doesn't protect us from that problem because it is only\n@@ -149,6 +150,9 @@ void s390_fill_feat_block(const S390FeatBitmap features, S390FeatType type,\n         clear_be_bit(s390_feat_def(S390_FEAT_DIAG_318)->bit, data);\n         clear_be_bit(s390_feat_def(S390_FEAT_CERT_STORE)->bit, data);\n         break;\n+    case S390_FEAT_TYPE_SCLP_FAC_IPL:\n+        clear_be_bit(s390_feat_def(S390_FEAT_SIPL)->bit, data);\n+        break;\n     default:\n         return;\n     }\ndiff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h\nindex 5635839d03..b038198555 100644\n--- a/target/s390x/cpu_features.h\n+++ b/target/s390x/cpu_features.h\n@@ -24,6 +24,7 @@ typedef enum {\n     S390_FEAT_TYPE_SCLP_CONF_CHAR,\n     S390_FEAT_TYPE_SCLP_CONF_CHAR_EXT,\n     S390_FEAT_TYPE_SCLP_FAC134,\n+    S390_FEAT_TYPE_SCLP_FAC_IPL,\n     S390_FEAT_TYPE_SCLP_CPU,\n     S390_FEAT_TYPE_MISC,\n     S390_FEAT_TYPE_PLO,\ndiff --git a/target/s390x/cpu_features_def.h.inc b/target/s390x/cpu_features_def.h.inc\nindex 2976ecd0ee..bcf8a666e4 100644\n--- a/target/s390x/cpu_features_def.h.inc\n+++ b/target/s390x/cpu_features_def.h.inc\n@@ -140,6 +140,9 @@ DEF_FEAT(SIE_IBS, \"ibs\", SCLP_CONF_CHAR_EXT, 10, \"SIE: Interlock-and-broadcast-s\n DEF_FEAT(DIAG_318, \"diag318\", SCLP_FAC134, 0, \"Control program name and version codes\")\n DEF_FEAT(CERT_STORE, \"cstore\", SCLP_FAC134, 5, \"Certificate Store functions\")\n \n+/* Features exposed via SCLP SCCB Facilities byte 136 - 137 (bit numbers relative to byte-136) */\n+DEF_FEAT(SIPL, \"sipl\", SCLP_FAC_IPL, 1, \"Secure-IPL facility\")\n+\n /* Features exposed via SCLP CPU info. */\n DEF_FEAT(SIE_F2, \"sief2\", SCLP_CPU, 4, \"SIE: interception format 2 (Virtual SIE)\")\n DEF_FEAT(SIE_SKEY, \"skey\", SCLP_CPU, 5, \"SIE: Storage-key facility\")\ndiff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c\nindex 962f135f42..a52e34aa95 100644\n--- a/target/s390x/cpu_models.c\n+++ b/target/s390x/cpu_models.c\n@@ -263,6 +263,7 @@ bool s390_has_feat(S390Feat feat)\n         case S390_FEAT_SIE_CMMA:\n         case S390_FEAT_SIE_PFMFI:\n         case S390_FEAT_SIE_IBS:\n+        case S390_FEAT_SIPL:\n         case S390_FEAT_CONFIGURATION_TOPOLOGY:\n             return false;\n             break;\n@@ -507,6 +508,7 @@ static void check_consistency(const S390CPUModel *model)\n         { S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, S390_FEAT_AP },\n         { S390_FEAT_DIAG_318, S390_FEAT_EXTENDED_LENGTH_SCCB },\n         { S390_FEAT_CERT_STORE, S390_FEAT_EXTENDED_LENGTH_SCCB },\n+        { S390_FEAT_SIPL, S390_FEAT_EXTENDED_LENGTH_SCCB },\n         { S390_FEAT_NNPA, S390_FEAT_VECTOR },\n         { S390_FEAT_RDP, S390_FEAT_LOCAL_TLB_CLEARING },\n         { S390_FEAT_UV_FEAT_AP, S390_FEAT_AP },\ndiff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c\nindex 6c20c3a862..bd2060ab93 100644\n--- a/target/s390x/gen-features.c\n+++ b/target/s390x/gen-features.c\n@@ -721,6 +721,7 @@ static uint16_t full_GEN16_GA1[] = {\n     S390_FEAT_UV_FEAT_AP,\n     S390_FEAT_UV_FEAT_AP_INTR,\n     S390_FEAT_CERT_STORE,\n+    S390_FEAT_SIPL,\n };\n \n static uint16_t full_GEN17_GA1[] = {\n@@ -922,6 +923,7 @@ static uint16_t qemu_MAX[] = {\n     S390_FEAT_PRNO_TRNG,\n     S390_FEAT_EXTENDED_LENGTH_SCCB,\n     S390_FEAT_CERT_STORE,\n+    S390_FEAT_SIPL,\n };\n \n /****** END FEATURE DEFS ******/\ndiff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c\nindex cba431688b..40197cca7a 100644\n--- a/target/s390x/kvm/kvm.c\n+++ b/target/s390x/kvm/kvm.c\n@@ -2518,6 +2518,9 @@ bool kvm_s390_get_host_cpu_model(S390CPUModel *model, Error **errp)\n \n     set_bit(S390_FEAT_CERT_STORE, model->features);\n \n+    /* Some Secure IPL facilities are emulated by QEMU */\n+    set_bit(S390_FEAT_SIPL, model->features);\n+\n     /* Test for Ultravisor features that influence secure guest behavior */\n     query_uv_feat_guest(model->features);\n \n","prefixes":["v10","16/30"]}