{"id":2219359,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219359/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402215629.745866-9-ruslichenko.r@gmail.com>","date":"2026-04-02T21:55:53","name":"[v3,08/33] hw/core/fdt_generic_util: implement fdt_init_qdev","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"07b51deb72ec33fe9c01b2eefe4d518d7624c7b2","submitter":{"id":92275,"url":"http://patchwork.ozlabs.org/api/1.0/people/92275/?format=json","name":"Ruslan Ruslichenko","email":"ruslichenko.r@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402215629.745866-9-ruslichenko.r@gmail.com/mbox/","series":[{"id":498555,"url":"http://patchwork.ozlabs.org/api/1.0/series/498555/?format=json","date":"2026-04-02T21:55:47","name":"hw/arm: Introduce generic FDT-driven machine","version":3,"mbox":"http://patchwork.ozlabs.org/series/498555/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219359/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=tJWvlBfg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmwmd4TKBz1xtJ\n\tfor ; Fri, 03 Apr 2026 09:01:37 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8Q2A-0008Io-E2; Thu, 02 Apr 2026 17:57:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Q27-0008Hq-Ju\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:59 -0400","from mail-ed1-x532.google.com ([2a00:1450:4864:20::532])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8Q25-00075L-W9\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:56:59 -0400","by mail-ed1-x532.google.com with SMTP id\n 4fb4d7f45d1cf-66c05fb27e4so2504490a12.2\n for ; Thu, 02 Apr 2026 14:56:57 -0700 (PDT)","from thinkpad-t470s.. (93-143-182-244.adsl.net.t-com.hr.\n [93.143.182.244]) by smtp.googlemail.com with ESMTPSA id\n a640c23a62f3a-b9c3cac0e1asm134009166b.27.2026.04.02.14.56.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 14:56:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775167016; x=1775771816; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IY/Psqmc5gYs7mEXOklu9W6iJGvX3f2xns3E+/gt5OY=;\n b=tJWvlBfgwmrT/6bF9jRxdYwlDOGWKMehNzg7cdihLz0+5X++8cXHU3qKZJ39w0v7kT\n 6euxrvug/z2vP2v+gD5HXd3CEAovlwlT5z7CwicY7AxjWNKzSLYFSK+qIbymO4/7lGEx\n HSuekU1ZfqamjAHirI7qgKlmQQTEMbR4zHlZgOWBbeScy0ztG4VvYYm19Nx1d2T6r9xt\n oqHdnKG86+TyVbkwkVHsfBt2i1w4wAxMPsiMn70N6oAkjYMCtxUqkXT8Kcz+xwQhYEKi\n 4EVyT/GqX2QHCUYIuHik1SVIbX5wJU3tl08cYYLb/4iUNjtt7MHNFPYkgH10jPVh8DPe\n 7ZIg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775167016; x=1775771816;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IY/Psqmc5gYs7mEXOklu9W6iJGvX3f2xns3E+/gt5OY=;\n b=Yl9IPqFbhuZ3PAH3ldaMIzIyXVklUEbOax+D22c7BKgwdFa2IE7vKR1/SYCiPu7KRn\n B4VzOC8Ju8QpVfjuJwBpg0TFsbiqT0PE7uXDUXBa1qbFcSd4qnNnPjyOqOsIpvMuyb+x\n hiQBKcCN58uQc5geZ925VhaNuj359ZDEdisfXtV6dc527bEZry18Zisn8n/qv/+pibJp\n NBqNC8swipRt7URHvdxXBgRdc5+qd5mcKmQ7aItR2uw5uL1bTf0VnYJSbFw+WEeJS5WJ\n vgiyynF9FI2sIhXXbOUWp3r+T69WYRGzEQ1aMG1LFYJl9ueKovxTfJtfKE3WDpnxq1Tj\n Mmjg==","X-Gm-Message-State":"AOJu0YyFNSqTwbvHQWWZGKZHr4BMfDugHlI9wfDwJ3ODNE6E2DVAutAT\n ZiQJ1Bu5dwHx3vpnvupz5ZtzU5xI7vgOmduw19v/tBWP/tT3T/xi88J8ZPdcuhRn","X-Gm-Gg":"ATEYQzyHjgPBzkApRWzwxBmjNmwBnWRGg+xBjj5QcxlTNjpdDUnXz9bJrKT9HPW0zZ+\n jaFPVt6rzR+jIfCnkAG9hfoAopHdaZhjkTGwb2SYb+vHmuBz+uqQmotBgpGlGtPW4JKSe+xy/HV\n 1mXGj4jU7vUEBzxSPi2vwk+YdPE9Dh2R/Ye9+IwMo/3H368tEzhaSuAgmTCzZdbZsRlOo9o8xy4\n sszULJe/FxsW2kwqEysc55jPXTmf/i4AuxGXfGpd+a+zSeVabbdhtKC+K4ySnYjJ2eqDMdy7Itb\n SQ5ysNpuNxrlWvRMaFg0cxDwtWoPLal8gEHd9ChC75DETJ71Eel0YxqCzuRt99BInAjpTmqIz79\n OotTZAw/cz9xa8GdsFWDEAiqXGpllKx0oKxBPGfuxREA+vwHcKPm2NT2b1VvtO+rNGwKzJcaF3O\n EzCv42l2gb0z1Nv1Pz/BRJ4/d8yEAd9vBakf9bz8aIfzS0VcfSWayT4kyhVXqZCJWmSjI9esBl+\n Uk3uTwY","X-Received":"by 2002:a17:906:bf49:b0:b98:3b5d:e147 with SMTP id\n a640c23a62f3a-b9c67446620mr30557666b.3.1775167015877;\n Thu, 02 Apr 2026 14:56:55 -0700 (PDT)","From":"Ruslan Ruslichenko ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" ,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu","Subject":"[PATCH v3 08/33] hw/core/fdt_generic_util: implement fdt_init_qdev","Date":"Thu, 2 Apr 2026 23:55:53 +0200","Message-ID":"<20260402215629.745866-9-ruslichenko.r@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260402215629.745866-1-ruslichenko.r@gmail.com>","References":"<20260402215629.745866-1-ruslichenko.r@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::532;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-ed1-x532.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Ruslan Ruslichenko \n\nImplement main routine to create device object from\ncompat.\n\nThe following steps implemented:\n\n- parse node compatible and device types\n- try to create object from compat\n- set correct parent based on device tree.\n\nSigned-off-by: Ruslan Ruslichenko \n---\n hw/core/fdt_generic_util.c | 120 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 120 insertions(+)","diff":"diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 2f7a3fc3dd..565f577238 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -41,6 +41,7 @@\n #include \"qemu/config-file.h\"\n #include \"hw/core/boards.h\"\n #include \"qemu/option.h\"\n+#include \"hw/cpu/cluster.h\"\n \n #define fdt_debug(...) do { \\\n qemu_log_mask(LOG_FDT, \": %s: \", __func__); \\\n@@ -226,8 +227,127 @@ static int simple_bus_fdt_init(const char *node_path, FDTMachineInfo *fdti)\n return 0;\n }\n \n+static inline const char *trim_vendor(const char *s)\n+{\n+ /* FIXME: be more intelligent */\n+ const char *ret = memchr(s, ',', strlen(s));\n+ return ret ? ret + 1 : s;\n+}\n+\n+static Object *fdt_create_from_compat(const char *compat)\n+{\n+ Object *ret = NULL;\n+\n+ /* Try to create the object */\n+ ret = object_new(compat);\n+ if (!ret) {\n+ const char *no_vendor = trim_vendor(compat);\n+\n+ if (no_vendor != compat) {\n+ return fdt_create_from_compat(no_vendor);\n+ }\n+ }\n+ return ret;\n+}\n+\n+static void fdt_init_parent_node(Object *dev, Object *parent, char *node_path)\n+{\n+ if (dev->parent) {\n+ fdt_debug_np(\"Node already parented - skipping node\\n\");\n+ } else if (parent) {\n+ fdt_debug_np(\"parenting node\\n\");\n+ object_property_add_child(OBJECT(parent),\n+ strdup(strrchr(node_path, '/') + 1),\n+ OBJECT(dev));\n+ if (object_dynamic_cast(dev, TYPE_DEVICE)) {\n+ Object *parent_bus = parent;\n+ unsigned int depth = 0;\n+\n+ fdt_debug_np(\"bus parenting node\\n\");\n+ /* Look for an FDT ancestor that is a Bus. */\n+ while (parent_bus && !object_dynamic_cast(parent_bus, TYPE_BUS)) {\n+ /*\n+ * Assert against insanely deep hierarchies which are an\n+ * indication of loops.\n+ */\n+ assert(depth < 4096);\n+\n+ parent_bus = parent_bus->parent;\n+ depth++;\n+ }\n+\n+ if (!parent_bus\n+ && object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) {\n+ /*\n+ * Didn't find any bus. Use the default sysbus one.\n+ * This allows ad-hoc busses belonging to sysbus devices to be\n+ * visible to -device bus=x.\n+ */\n+ parent_bus = OBJECT(sysbus_get_default());\n+ }\n+\n+ if (parent_bus) {\n+ qdev_set_parent_bus(DEVICE(dev), BUS(parent_bus),\n+ &error_abort);\n+ }\n+ }\n+ } else {\n+ fdt_debug_np(\"orphaning node\\n\");\n+ if (object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) {\n+ qdev_set_parent_bus(DEVICE(dev), BUS(sysbus_get_default()),\n+ &error_abort);\n+ }\n+\n+ /* FIXME: Make this go away (centrally) */\n+ object_property_add_child(\n+ object_get_root(),\n+ strrchr(node_path, '/') + 1,\n+ OBJECT(dev));\n+ }\n+}\n+\n static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n {\n+ Object *dev, *parent;\n+ char *parent_node_path;\n+\n+ if (!compat) {\n+ return 1;\n+ }\n+ dev = fdt_create_from_compat(compat);\n+ if (!dev) {\n+ fdt_debug_np(\"no match found for %s\\n\", compat);\n+ return 1;\n+ }\n+ fdt_debug_np(\"matched compat %s\\n\", compat);\n+\n+ /* Do this super early so fdt_generic_num_cpus is correct ASAP */\n+ if (object_dynamic_cast(dev, TYPE_CPU)) {\n+ fdt_generic_num_cpus++;\n+ fdt_debug_np(\"is a CPU - total so far %d\\n\", fdt_generic_num_cpus);\n+ }\n+\n+ parent_node_path = qemu_devtree_getparent(fdti->fdt, node_path);\n+ if (!parent_node_path) {\n+ abort();\n+ }\n+ while (!fdt_init_has_opaque(fdti, parent_node_path) &&\n+ !object_dynamic_cast(dev, TYPE_CPU)) {\n+ fdt_init_yield(fdti);\n+ }\n+\n+ parent = fdt_init_get_opaque(fdti, parent_node_path);\n+\n+ if (object_dynamic_cast(dev, TYPE_CPU)) {\n+ parent = fdt_init_get_cpu_cluster(fdti, parent, compat);\n+ }\n+\n+ fdt_init_parent_node(dev, parent, node_path);\n+\n+ fdt_init_set_opaque(fdti, node_path, dev);\n+\n+ g_free(parent_node_path);\n+\n return 0;\n }\n \n","prefixes":["v3","08/33"]}