{"id":2219342,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219342/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402215629.745866-18-ruslichenko.r@gmail.com>","date":"2026-04-02T21:56:02","name":"[v3,17/33] hw/core/fdt_generic_util: Connect device irqs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cb773e28cbea69c0358b080fb1b6cd6f34ff5723","submitter":{"id":92275,"url":"http://patchwork.ozlabs.org/api/1.0/people/92275/?format=json","name":"Ruslan Ruslichenko","email":"ruslichenko.r@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402215629.745866-18-ruslichenko.r@gmail.com/mbox/","series":[{"id":498555,"url":"http://patchwork.ozlabs.org/api/1.0/series/498555/?format=json","date":"2026-04-02T21:55:47","name":"hw/arm: Introduce generic FDT-driven machine","version":3,"mbox":"http://patchwork.ozlabs.org/series/498555/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219342/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hJTx89Rm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmwhw1pgbz1yD3\n\tfor ; Fri, 03 Apr 2026 08:58:24 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8Q2R-0008UA-VI; Thu, 02 Apr 2026 17:57:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Q2O-0008RJ-Pj\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:57:16 -0400","from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8Q2N-0007AO-2N\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:57:16 -0400","by mail-ej1-x62d.google.com with SMTP id\n a640c23a62f3a-b936331786dso140380366b.3\n for ; Thu, 02 Apr 2026 14:57:14 -0700 (PDT)","from thinkpad-t470s.. (93-143-182-244.adsl.net.t-com.hr.\n [93.143.182.244]) by smtp.googlemail.com with ESMTPSA id\n a640c23a62f3a-b9c3cac0e1asm134009166b.27.2026.04.02.14.57.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Apr 2026 14:57:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775167033; x=1775771833; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7wwyEKp+01Czgx6hMOiu7U9RUmG9r7Ino8NfNmLre3Q=;\n b=hJTx89Rmc1d/z+24efKjQZwMzn994uitYnp5u7C0clajh5Sq8o1Pb4N1rwutCEByHv\n TgugYBbk+Llj3F/xd/HGAid9Il0MZg4YvXkE1l4gPS7+S7WK7x9eenIRhf/ME4oB2iwM\n EgdPd5v+VQUJqQI73Ebl6l4NKC8Ks2vB+HEnihMmcZVGWgh2ZUFYmomoXs3Wom4dkRNk\n H30JDBxadrlIl4+NkniSVgjc/83JxcOfl1m/KbyUsQQeWw44fKCen3SVqQgGU1impB4I\n kQtvw+bJUxKDvbkCYT3nSvmxum/ghDCdWtrsQ4imMArDRAq5K1GSQZx4aJS4WtC2EnyI\n ahIw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775167033; x=1775771833;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7wwyEKp+01Czgx6hMOiu7U9RUmG9r7Ino8NfNmLre3Q=;\n b=TjRn5HNVzjwMr/WnOtElJegylzaWA0yE8nbebIGImUs0z2dv2tU2kkB7bAde0+gSCX\n 7znIgeKeO9jv+dLN3zLHm2hSU1XkRFAHTsxi2A26K92fzNcYQb3XVOsKF1Ddd6EAL4uz\n x45u/NkJh3J3IPQxophqBZKLbNeliYqdpYv5pH5kofdSdjspM7Gi7x6CCqx1TytxYvwY\n w3NU3xfB9XzvLd/XYgZZG0xcmRYDuO6NDu+tuihTC0JyMKpZqTP8w/BKrVbuVKC1Y9S8\n zCShsC4d9HTCwd19X78OLN9ZEyP+sNvHICVq8vfHjzGZeywMMW/rOwU7da8tTNckC/8s\n LP+Q==","X-Gm-Message-State":"AOJu0YyO2mD0+gYOaZARL6FWrlR6spyxeyvSUbbzf0wZY7IIaW9xvrjI\n DC8BMww9mABLySth4MlPMCvECrarwOaiIHXaSlDdlZz4hilHcyz/5TjzpRsapIja","X-Gm-Gg":"ATEYQzy87wp3LazE828dxV7pHJgCxSPWXFcbc1ZbJ05PyxXcpaMSWUf+JIHvEvTCDJM\n vgz1Ck/Y+5bhD7/uGKw0tvAwA95S/XKs/TECTXNIibnHRmoDy138QH2069XseeM+EJkPi54xbl3\n +W4NqhOPA3McIabW738Drl4H8Dm6e/wHK6NNPT81obHHTOkrovgnn5S8BLFB2H+U4F0Gzv93PKO\n giaYdhLzITMdmhx5VCyQ5vgg0GIaojC28FvwIrF8IJmR35YFYASOIf5n3UKWe4k51w4zeLd97l2\n fxUUjdpcfGgi/d/uPPlUH/HT5hPiGtnpXvljjSnTBiGp6orwdhcEyQxA+eHYuArb9Rz9m09pW5a\n EY/Ob8WP8JZrNqrnuNA0xULIsVCcQC5HcjR7Fhvnlg1NT3biJ6QSfzVV3Vgl9z6I9Edh9B5SiVn\n 3tzvn6lSKE6Dw+J4bNQgITF1wyPS2g72IgfBvVWzzWqhVzk9VRaCpBu20P1MwkUAKyNCFyNk84Q\n Hvw+rcu","X-Received":"by 2002:a17:907:25c3:b0:b98:8a9c:7059 with SMTP id\n a640c23a62f3a-b9c6744d8b8mr26019066b.19.1775167033216;\n Thu, 02 Apr 2026 14:57:13 -0700 (PDT)","From":"Ruslan Ruslichenko ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" ,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu","Subject":"[PATCH v3 17/33] hw/core/fdt_generic_util: Connect device irqs","Date":"Thu, 2 Apr 2026 23:56:02 +0200","Message-ID":"<20260402215629.745866-18-ruslichenko.r@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260402215629.745866-1-ruslichenko.r@gmail.com>","References":"<20260402215629.745866-1-ruslichenko.r@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::62d;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-ej1-x62d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Ruslan Ruslichenko \n\nThe patch implements IRQ wiring logic for fdt created\ndevices.\n\nThe wiring performed in two stages. As devices are\ncreated, their IRQs saved in the list.\nAfter all devices processed, fdt_init_all_irqs() goes\nthrough all IRQs and does actual wiring. For IRQs\nwhich have multiple source, shared IRQ handler\nallocated.\n\nFor interrupt controllers with auto_parent callback\nimplemented and their fdt node has 'interrupt' and\n'interrupts-extended' properties empty,\nthe auto_parent() will be called to connect them\nto their interrupt-parent, for example to CPUs.\n\nSigned-off-by: Ruslan Ruslichenko \n---\n hw/core/fdt_generic_util.c | 143 ++++++++++++++++++++++++++++++++++\n include/hw/core/fdt_generic.h | 12 +++\n 2 files changed, 155 insertions(+)","diff":"diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 0b374b550d..b0e26e11bc 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -69,6 +69,88 @@ static void fdt_get_irq_info_from_intc(FDTMachineInfo *fdti, qemu_irq *ret,\n uint32_t *cells, uint32_t num_cells,\n uint32_t max, Error **errp);\n \n+typedef struct QEMUIRQSharedState {\n+ qemu_irq sink;\n+ int num;\n+ bool (*merge_fn)(bool *, int);\n+/* FIXME: remove artificial limit */\n+#define MAX_IRQ_SHARED_INPUTS 256\n+ bool inputs[MAX_IRQ_SHARED_INPUTS];\n+} QEMUIRQSharedState;\n+\n+static bool qemu_irq_shared_or_handler(bool *inputs, int n)\n+{\n+ int i;\n+\n+ assert(n < MAX_IRQ_SHARED_INPUTS);\n+\n+ for (i = 0; i < n; ++i) {\n+ if (inputs[i]) {\n+ return true;\n+ }\n+ }\n+ return false;\n+}\n+\n+static void qemu_irq_shared_handler(void *opaque, int n, int level)\n+{\n+ QEMUIRQSharedState *s = opaque;\n+\n+ assert(n < MAX_IRQ_SHARED_INPUTS);\n+ s->inputs[n] = level;\n+ qemu_set_irq(s->sink, s->merge_fn(s->inputs, s->num));\n+}\n+\n+static void fdt_init_all_irqs(FDTMachineInfo *fdti)\n+{\n+ while (fdti->irqs) {\n+ FDTIRQConnection *first = fdti->irqs;\n+ qemu_irq sink = first->irq;\n+ bool (*merge_fn)(bool *, int) = first->merge_fn;\n+ int num_sources = 0;\n+ FDTIRQConnection *irq;\n+\n+ for (irq = first; irq; irq = irq->next) {\n+ if (irq->irq == sink) { /* Same sink */\n+ num_sources++;\n+ }\n+ }\n+ if (num_sources > 1) {\n+ QEMUIRQSharedState *s = g_malloc0(sizeof *s);\n+ s->sink = sink;\n+ s->merge_fn = merge_fn;\n+ qemu_irq *sources = qemu_allocate_irqs(qemu_irq_shared_handler, s,\n+ num_sources);\n+ for (irq = first; irq; irq = irq->next) {\n+ if (irq->irq == sink) {\n+ char *shared_irq_name = g_strdup_printf(\"shared-irq-%p\",\n+ *sources);\n+\n+ if (irq->merge_fn != merge_fn) {\n+ fprintf(stderr, \"ERROR: inconsistent IRQ merge fns\\n\");\n+ exit(1);\n+ }\n+\n+ object_property_add_child(OBJECT(irq->dev), shared_irq_name,\n+ OBJECT(*sources));\n+ g_free(shared_irq_name);\n+ irq->irq = *(sources++);\n+ s->num++;\n+ }\n+ }\n+ }\n+ fdt_debug(\"%s: connected to %s irq line %d (%s)\\n\",\n+ first->sink_info ? first->sink_info : \"\",\n+ object_get_canonical_path(OBJECT(first->dev)),\n+ first->i, first->name ? first->name : \"\");\n+\n+ qdev_connect_gpio_out_named(DEVICE(first->dev), first->name, first->i,\n+ first->irq);\n+ fdti->irqs = first->next;\n+ g_free(first);\n+ }\n+}\n+\n FDTMachineInfo *fdt_generic_create_machine(void *fdt, qemu_irq *cpu_irq)\n {\n FDTMachineInfo *fdti = fdt_init_new_fdti(fdt);\n@@ -82,6 +164,7 @@ FDTMachineInfo *fdt_generic_create_machine(void *fdt, qemu_irq *cpu_irq)\n while (qemu_co_enter_next(fdti->cq, NULL)) {\n ;\n }\n+ fdt_init_all_irqs(fdti);\n memory_region_transaction_commit();\n \n /* FIXME: Populate these from DTS and create CPU clusters. */\n@@ -772,6 +855,64 @@ static void fdt_parse_node_reg_prop(FDTMachineInfo *fdti, char *node_path,\n g_free(reg);\n }\n \n+static void fdt_parse_node_irq_prop(FDTMachineInfo *fdti, char *node_path,\n+ Object *dev)\n+{\n+ int is_intc, len;\n+ int i, j;\n+\n+ if (!object_dynamic_cast(dev, TYPE_SYS_BUS_DEVICE)) {\n+ return;\n+ }\n+\n+ fdt_get_property(fdti->fdt, fdt_path_offset(fdti->fdt, node_path),\n+ \"interrupt-controller\", &len);\n+ is_intc = len >= 0;\n+ fdt_debug_np(\"is interrupt controller: %c\\n\",\n+ is_intc ? 'y' : 'n');\n+\n+ /* connect irq */\n+ j = 0;\n+ for (i = 0;; i++) {\n+ char irq_info[6 * 1024];\n+ char *irq_info_p = irq_info;\n+ len = -1;\n+ qemu_irq *irqs = fdt_get_irq_info(fdti, node_path, i, irq_info);\n+ /* INTCs inferr their top level, if no IRQ connection specified */\n+ fdt_get_property(fdti->fdt, fdt_path_offset(fdti->fdt, node_path),\n+ \"interrupts-extended\", &len);\n+ if (!irqs && is_intc && i == 0 && len <= 0) {\n+ FDTGenericIntc *id = (FDTGenericIntc *)object_dynamic_cast(\n+ dev, TYPE_FDT_GENERIC_INTC);\n+ FDTGenericIntcClass *idc = FDT_GENERIC_INTC_GET_CLASS(id);\n+ if (id && idc->auto_parent) {\n+ Error *err = NULL;\n+ idc->auto_parent(id, &err);\n+ } else {\n+ irqs = fdti->irq_base;\n+ }\n+ }\n+ if (!irqs) {\n+ break;\n+ }\n+ while (*irqs) {\n+ FDTIRQConnection *irq = g_new0(FDTIRQConnection, 1);\n+ *irq = (FDTIRQConnection) {\n+ .dev = DEVICE(dev),\n+ .name = SYSBUS_DEVICE_GPIO_IRQ,\n+ .merge_fn = qemu_irq_shared_or_handler,\n+ .i = j,\n+ .irq = *irqs,\n+ .sink_info = g_strdup(irq_info_p),\n+ .next = fdti->irqs\n+ };\n+ j++;\n+ fdti->irqs = irq;\n+ irqs++;\n+ }\n+ }\n+}\n+\n static void fdt_init_parent_node(Object *dev, Object *parent, char *node_path)\n {\n if (dev->parent) {\n@@ -902,6 +1043,8 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n \n fdt_parse_node_reg_prop(fdti, node_path, dev);\n \n+ fdt_parse_node_irq_prop(fdti, node_path, dev);\n+\n g_free(parent_node_path);\n \n return 0;\ndiff --git a/include/hw/core/fdt_generic.h b/include/hw/core/fdt_generic.h\nindex 05ab07e08c..3961615a9c 100644\n--- a/include/hw/core/fdt_generic.h\n+++ b/include/hw/core/fdt_generic.h\n@@ -25,6 +25,16 @@ typedef struct FDTCPUCluster {\n bool user;\n } FDTCPUCluster;\n \n+typedef struct FDTIRQConnection {\n+ DeviceState *dev;\n+ const char *name;\n+ int i;\n+ bool (*merge_fn)(bool *, int);\n+ qemu_irq irq;\n+ char *sink_info; /* Debug only */\n+ void *next;\n+} FDTIRQConnection;\n+\n typedef struct FDTMachineInfo {\n /* the fdt blob */\n void *fdt;\n@@ -34,6 +44,8 @@ typedef struct FDTMachineInfo {\n FDTDevOpaque *dev_opaques;\n /* recheck coroutine queue */\n CoQueue *cq;\n+ /* list of all IRQ connections */\n+ FDTIRQConnection *irqs;\n /* list of all CPU clusters */\n FDTCPUCluster *clusters;\n } FDTMachineInfo;\n","prefixes":["v3","17/33"]}