{"id":2219334,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219334/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402-work-qmp-monitor-hotplug-v1-5-6313a5cdd574@kernel.org>","date":"2026-04-02T21:19:20","name":"[5/5] tests/functional: add e2e test for dynamic QMP monitor hotplug","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fa86faf3e9fc5c562de00444a16765bee23c5a01","submitter":{"id":82326,"url":"http://patchwork.ozlabs.org/api/1.0/people/82326/?format=json","name":"Christian Brauner","email":"brauner@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402-work-qmp-monitor-hotplug-v1-5-6313a5cdd574@kernel.org/mbox/","series":[{"id":498554,"url":"http://patchwork.ozlabs.org/api/1.0/series/498554/?format=json","date":"2026-04-02T21:19:15","name":"monitor: add dynamic QMP monitor hotplug support","version":1,"mbox":"http://patchwork.ozlabs.org/series/498554/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219334/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=VLZ3Njje;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmvsm4Q9rz1yCs\n\tfor ; Fri, 03 Apr 2026 08:21:00 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8PS7-0003kS-EX; Thu, 02 Apr 2026 17:19:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8PS6-0003kJ-2u\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:19:46 -0400","from tor.source.kernel.org ([172.105.4.254])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8PS4-0004bn-Cj\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:19:45 -0400","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id B59D660128;\n Thu, 2 Apr 2026 21:19:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3D952C19424;\n Thu, 2 Apr 2026 21:19:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1775164783;\n bh=TVRVKzeNnGI5lMhmM0XW/KBaDtbgq3fQ6PSz+PGbl/w=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=VLZ3NjjezyXcCo1WBC9dI1xLPNMJwPm1fX/RFAz9dacZQUPVQIrn0tS8H+o9/Oqz1\n QbFAr2IoEgVIicPT8h4raC1dcxkaLqaoTUQIpa/holD0wocYmdzOhupsuYwb9/qt4C\n s/B7OzTYxIIWmC9MU0W9p4UzZjsZqAyLHl1Y6CBdar3czB/v6HMKt88qkIuAugCwwG\n xbLXooTjQ7tNnV16XjznM0WZ1G+n2E6N1MOBX+gbqiXufw5vwrZNw1azb7uPAKAtno\n G22NLejByBw66u/jeTjZ/leqWsSu38FppKGBOHevDGbjbg8B5ABFgo+LkT9AhNrgnI\n 8ZMctXTpUAknw==","From":"Christian Brauner ","Date":"Thu, 02 Apr 2026 23:19:20 +0200","Subject":"[PATCH 5/5] tests/functional: add e2e test for dynamic QMP monitor\n hotplug","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260402-work-qmp-monitor-hotplug-v1-5-6313a5cdd574@kernel.org>","References":"<20260402-work-qmp-monitor-hotplug-v1-0-6313a5cdd574@kernel.org>","In-Reply-To":"<20260402-work-qmp-monitor-hotplug-v1-0-6313a5cdd574@kernel.org>","To":"qemu-devel@nongnu.org","Cc":"Markus Armbruster , Eric Blake ,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini , Thomas Huth ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n Christian Brauner ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4767; i=brauner@kernel.org;\n h=from:subject:message-id; bh=TVRVKzeNnGI5lMhmM0XW/KBaDtbgq3fQ6PSz+PGbl/w=;\n b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWSeuxvfbHhh9x93pmvmRxeIBi9ifPFY+kLx3TnlT4ND+\n Q/6hOvKd5SyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAEzkkzrD/5pjtzmfPuaUm/u0\n 99iXr43iCZsak9fZJSZOshNTKOyI2MjwP/jF7pqc0r51D/53TBGyeN76OGBtXp+/aNQlTcfbzjt\n v8QAA","X-Developer-Key":"i=brauner@kernel.org; a=openpgp;\n fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624","Received-SPF":"pass client-ip=172.105.4.254; envelope-from=brauner@kernel.org;\n helo=tor.source.kernel.org","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.542,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add a functional test that exercises the full monitor hotplug lifecycle\nwith a real socket connection:\n\n1. Launch QEMU\n2. chardev-add a unix socket chardev\n3. monitor-add to attach a QMP monitor to it\n4. Connect to the socket, receive the QMP greeting, negotiate\n capabilities, and send a query-version command\n5. Disconnect, monitor-remove, chardev-remove\n6. Repeat the entire cycle a second time to verify cleanup and reuse\n\nThis complements the qtest unit tests by verifying that a real QMP\nclient can connect to a dynamically-added monitor and exchange messages.\n\nSigned-off-by: Christian Brauner (Amutable) \n---\n tests/functional/generic/meson.build | 1 +\n tests/functional/generic/test_monitor_hotplug.py | 102 +++++++++++++++++++++++\n 2 files changed, 103 insertions(+)","diff":"diff --git a/tests/functional/generic/meson.build b/tests/functional/generic/meson.build\nindex 09763c5d22..c94105c62e 100644\n--- a/tests/functional/generic/meson.build\n+++ b/tests/functional/generic/meson.build\n@@ -4,6 +4,7 @@ tests_generic_system = [\n 'empty_cpu_model',\n 'info_usernet',\n 'linters',\n+ 'monitor_hotplug',\n 'version',\n 'vnc',\n ]\ndiff --git a/tests/functional/generic/test_monitor_hotplug.py b/tests/functional/generic/test_monitor_hotplug.py\nnew file mode 100644\nindex 0000000000..f8f24320c6\n--- /dev/null\n+++ b/tests/functional/generic/test_monitor_hotplug.py\n@@ -0,0 +1,102 @@\n+#!/usr/bin/env python3\n+#\n+# Functional test for dynamic QMP monitor hotplug\n+#\n+# Copyright (c) 2026 Christian Brauner\n+#\n+# This work is licensed under the terms of the GNU GPL, version 2 or\n+# later. See the COPYING file in the top-level directory.\n+\n+import os\n+import tempfile\n+\n+from qemu.qmp.legacy import QEMUMonitorProtocol\n+\n+from qemu_test import QemuSystemTest\n+\n+\n+class MonitorHotplug(QemuSystemTest):\n+\n+ def setUp(self):\n+ super().setUp()\n+ # Use /tmp to avoid UNIX socket path length limit (108 bytes).\n+ # The scratch_file() path is too deep for socket names.\n+ fd, self._sock_path = tempfile.mkstemp(\n+ prefix='qemu-mon-', suffix='.sock')\n+ os.close(fd)\n+ os.unlink(self._sock_path)\n+\n+ def tearDown(self):\n+ try:\n+ os.unlink(self._sock_path)\n+ except FileNotFoundError:\n+ pass\n+ super().tearDown()\n+\n+ def _add_monitor(self):\n+ \"\"\"Create a chardev + monitor and return the socket path.\"\"\"\n+ sock = self._sock_path\n+ self.vm.cmd('chardev-add', id='hotplug-chr', backend={\n+ 'type': 'socket',\n+ 'data': {\n+ 'addr': {\n+ 'type': 'unix',\n+ 'data': {'path': sock}\n+ },\n+ 'server': True,\n+ 'wait': False,\n+ }\n+ })\n+ self.vm.cmd('monitor-add', id='hotplug-mon',\n+ chardev='hotplug-chr')\n+ return sock\n+\n+ def _remove_monitor(self):\n+ \"\"\"Remove the monitor + chardev.\"\"\"\n+ self.vm.cmd('monitor-remove', id='hotplug-mon')\n+ self.vm.cmd('chardev-remove', id='hotplug-chr')\n+\n+ def _connect_and_handshake(self, sock_path):\n+ \"\"\"\n+ Connect to the dynamic monitor socket, perform the QMP\n+ greeting and capability negotiation, send a command, then\n+ disconnect.\n+ \"\"\"\n+ qmp = QEMUMonitorProtocol(sock_path)\n+\n+ # connect(negotiate=True) receives the greeting, validates it,\n+ # and sends qmp_capabilities automatically.\n+ greeting = qmp.connect(negotiate=True)\n+ self.assertIn('QMP', greeting)\n+ self.assertIn('version', greeting['QMP'])\n+ self.assertIn('capabilities', greeting['QMP'])\n+\n+ # Send a real command to prove the session is fully functional\n+ resp = qmp.cmd_obj({'execute': 'query-version'})\n+ self.assertIn('return', resp)\n+ self.assertIn('qemu', resp['return'])\n+\n+ qmp.close()\n+\n+ def test_hotplug_cycle(self):\n+ \"\"\"\n+ Hotplug a monitor, do the full QMP handshake, unplug it,\n+ then repeat the whole cycle a second time.\n+ \"\"\"\n+ self.set_machine('none')\n+ self.vm.add_args('-nodefaults')\n+ self.vm.launch()\n+\n+ # First cycle\n+ sock = self._add_monitor()\n+ self._connect_and_handshake(sock)\n+ self._remove_monitor()\n+\n+ # Second cycle -- same ids, same path, must work\n+ sock = self._add_monitor()\n+ self._connect_and_handshake(sock)\n+ self._remove_monitor()\n+\n+\n+if __name__ == '__main__':\n+ QemuSystemTest.main()\n","prefixes":["5/5"]}