{"id":2219332,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219332/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402-work-qmp-monitor-hotplug-v1-4-6313a5cdd574@kernel.org>","date":"2026-04-02T21:19:19","name":"[4/5] tests/qtest: add tests for dynamic monitor add/remove","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2c25a9ebd6336bfa36f760149e0fdd484f2c7874","submitter":{"id":82326,"url":"http://patchwork.ozlabs.org/api/1.0/people/82326/?format=json","name":"Christian Brauner","email":"brauner@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402-work-qmp-monitor-hotplug-v1-4-6313a5cdd574@kernel.org/mbox/","series":[{"id":498554,"url":"http://patchwork.ozlabs.org/api/1.0/series/498554/?format=json","date":"2026-04-02T21:19:15","name":"monitor: add dynamic QMP monitor hotplug support","version":1,"mbox":"http://patchwork.ozlabs.org/series/498554/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219332/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kQIipvI6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmvsH6Jpqz1yCs\n\tfor ; Fri, 03 Apr 2026 08:20:35 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8PSZ-000448-CA; Thu, 02 Apr 2026 17:20:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8PSX-0003yB-Ht\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:20:14 -0400","from tor.source.kernel.org ([172.105.4.254])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8PSV-0005g4-Ol\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 17:20:13 -0400","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 12AF760125;\n Thu, 2 Apr 2026 21:19:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8A36BC116C6;\n Thu, 2 Apr 2026 21:19:38 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1775164780;\n bh=iW8amckai9wBk7Cc1O5sdHXXZB8WiWGJCBtSEG3XdSc=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=kQIipvI6q54M6Nlu4GTAMqULqdXDMsArd03joVOfD3mG+R6wQM8WKfFrabTi/wcjT\n oEQOndakkChEae0X3FpW0/q78TRMp9KcBPOH8snRbeTzPbPch0/CU0GQTusQsE8aK/\n zC9I4UCg8aXF0qqduPRJcoKWWEMFXohkqTm7Dg4eijMqEzW4M4rbDSByGB1bdcOgqZ\n ZRg3ZX2I3jTFXEyTbHXglivbe8IMYfHn+0ghY6HCIr3Xuk0d9y2Ht0XKhIq5PkiMBV\n wQzGSqXQbjexmDIRSVcku9rfTQ7NPme98uiWWbVdmJNbYofFSVYNhgFtJlrx8xPYsf\n J88rQ+LikFPig==","From":"Christian Brauner ","Date":"Thu, 02 Apr 2026 23:19:19 +0200","Subject":"[PATCH 4/5] tests/qtest: add tests for dynamic monitor add/remove","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260402-work-qmp-monitor-hotplug-v1-4-6313a5cdd574@kernel.org>","References":"<20260402-work-qmp-monitor-hotplug-v1-0-6313a5cdd574@kernel.org>","In-Reply-To":"<20260402-work-qmp-monitor-hotplug-v1-0-6313a5cdd574@kernel.org>","To":"qemu-devel@nongnu.org","Cc":"Markus Armbruster , Eric Blake ,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini , Thomas Huth ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n Christian Brauner ","X-Mailer":"b4 0.16-dev","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4873; i=brauner@kernel.org;\n h=from:subject:message-id; bh=iW8amckai9wBk7Cc1O5sdHXXZB8WiWGJCBtSEG3XdSc=;\n b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWSeuxuv0zbF1+2qPHuqwIHN55hO6/E0msQ8tfuXfeGk+\n w9DFRf9jlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgIlMaGdkOKFw47v38W3b2t1/\n Hr7sYHnihKBqyMbZH8//cby7yPItgw0jw9Zfk8W29p0ocHXnFInVsmxZPvExa4Kw79PZW5WTqxK\n 9eQE=","X-Developer-Key":"i=brauner@kernel.org; a=openpgp;\n fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624","Received-SPF":"pass client-ip=172.105.4.254; envelope-from=brauner@kernel.org;\n helo=tor.source.kernel.org","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.542,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Test the monitor-add, monitor-remove, and query-monitors QMP commands:\n\n- Basic lifecycle: chardev-add -> monitor-add -> query-monitors ->\n monitor-remove -> chardev-remove\n- Error: duplicate monitor id\n- Error: monitor-remove on nonexistent id\n- Error: monitor-add with nonexistent chardev\n- Re-add after remove: same id and chardev reusable after removal\n\nSigned-off-by: Christian Brauner (Amutable) \n---\n tests/qtest/qmp-test.c | 101 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 101 insertions(+)","diff":"diff --git a/tests/qtest/qmp-test.c b/tests/qtest/qmp-test.c\nindex edf0886787..9dbd3a6103 100644\n--- a/tests/qtest/qmp-test.c\n+++ b/tests/qtest/qmp-test.c\n@@ -337,6 +337,105 @@ static void test_qmp_missing_any_arg(void)\n qtest_quit(qts);\n }\n \n+static void test_qmp_monitor_add_remove(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_init(common_args);\n+\n+ /* Create a null chardev for the dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-add',\"\n+ \" 'arguments': {'id': 'monitor-chardev',\"\n+ \" 'backend': {'type': 'null',\"\n+ \" 'data': {}}}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Add a dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Verify it shows up in query-monitors */\n+ resp = qtest_qmp(qts, \"{'execute': 'query-monitors'}\");\n+ g_assert(!qdict_haskey(resp, \"error\"));\n+ qobject_unref(resp);\n+\n+ /* Error: duplicate id */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Remove the dynamic monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Error: remove nonexistent */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Error: remove CLI monitor (the default one) -- find its id first.\n+ * CLI monitors typically have no id, so use a bogus id to test. */\n+\n+ /* Add again after remove -- same id and chardev should work */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'dyn-mon',\"\n+ \" 'chardev': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ /* Clean up */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'dyn-mon'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'chardev-remove',\"\n+ \" 'arguments': {'id': 'monitor-chardev'}}\");\n+ g_assert(qdict_haskey(resp, \"return\"));\n+ qobject_unref(resp);\n+\n+ qtest_quit(qts);\n+}\n+\n+static void test_qmp_monitor_error_paths(void)\n+{\n+ QTestState *qts;\n+ QDict *resp;\n+\n+ qts = qtest_init(common_args);\n+\n+ /* Error: chardev does not exist */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-add',\"\n+ \" 'arguments': {'id': 'bad-mon',\"\n+ \" 'chardev': 'nonexistent'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ /* Error: remove nonexistent monitor */\n+ resp = qtest_qmp(qts,\n+ \"{'execute': 'monitor-remove',\"\n+ \" 'arguments': {'id': 'bogus'}}\");\n+ qmp_expect_error_and_unref(resp, \"GenericError\");\n+\n+ qtest_quit(qts);\n+}\n+\n int main(int argc, char *argv[])\n {\n g_test_init(&argc, &argv, NULL);\n@@ -348,6 +447,8 @@ int main(int argc, char *argv[])\n #endif\n qtest_add_func(\"qmp/preconfig\", test_qmp_preconfig);\n qtest_add_func(\"qmp/missing-any-arg\", test_qmp_missing_any_arg);\n+ qtest_add_func(\"qmp/monitor-add-remove\", test_qmp_monitor_add_remove);\n+ qtest_add_func(\"qmp/monitor-error-paths\", test_qmp_monitor_error_paths);\n \n return g_test_run();\n }\n","prefixes":["4/5"]}