{"id":2219323,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219323/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260402205038.4005350-4-rs@ti.com>","date":"2026-04-02T20:50:36","name":"[PATCHv2,3/5] efi_selftest_memory: check for duplicates first","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"da0f9363d32d580d85e2574334ebbd352fbde8ac","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/1.0/people/88727/?format=json","name":"Randolph Sapp","email":"rs@ti.com"},"delegate":{"id":68728,"url":"http://patchwork.ozlabs.org/api/1.0/users/68728/?format=json","username":"xypron","first_name":"Heinrich","last_name":"Schuchardt","email":"xypron.glpk@gmx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260402205038.4005350-4-rs@ti.com/mbox/","series":[{"id":498552,"url":"http://patchwork.ozlabs.org/api/1.0/series/498552/?format=json","date":"2026-04-02T20:50:33","name":"various memory related fixups","version":1,"mbox":"http://patchwork.ozlabs.org/series/498552/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219323/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=BRmVbxxd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"BRmVbxxd\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmvCv4czXz1yCs\n\tfor ; Fri, 03 Apr 2026 07:51:39 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8512784056;\n\tThu, 2 Apr 2026 22:51:26 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0271E80212; Thu, 2 Apr 2026 22:51:25 +0200 (CEST)","from BN8PR05CU002.outbound.protection.outlook.com\n (mail-eastus2azlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c110::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F369B80212\n for ; Thu, 2 Apr 2026 22:51:22 +0200 (CEST)","from BY3PR03CA0008.namprd03.prod.outlook.com (2603:10b6:a03:39a::13)\n by CH3PR10MB6788.namprd10.prod.outlook.com (2603:10b6:610:14b::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Thu, 2 Apr\n 2026 20:51:18 +0000","from SJ5PEPF000001D2.namprd05.prod.outlook.com\n (2603:10b6:a03:39a:cafe::4b) by BY3PR03CA0008.outlook.office365.com\n (2603:10b6:a03:39a::13) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.21 via Frontend Transport; Thu,\n 2 Apr 2026 20:51:18 +0000","from flwvzet201.ext.ti.com (198.47.21.195) by\n SJ5PEPF000001D2.mail.protection.outlook.com (10.167.242.54) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Thu, 2 Apr 2026 20:51:16 +0000","from DFLE210.ent.ti.com (10.64.6.68) by flwvzet201.ext.ti.com\n (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 15:51:00 -0500","from DFLE203.ent.ti.com (10.64.6.61) by DFLE210.ent.ti.com\n (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 15:51:00 -0500","from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE203.ent.ti.com\n (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Thu, 2 Apr 2026 15:51:00 -0500","from rs-desk.dhcp.ti.com (rs-desk.dhcp.ti.com [128.247.81.39])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 632Kp0bQ2708543;\n Thu, 2 Apr 2026 15:51:00 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=sFRi8306KE+o3Vu7Y+RVZMoJF81tzqHZkuqzaSYRJuzI79laqkBMTVBzibyQvkJP74Z0KJPBbD2XQi3fT86WNpedR6/0H0LD39AxbrdeoIzOHFHFHvlDZTexRbwg6f08987KgzpwCgNcPWwBKVPDqdKzQmc13qFX2IiezIrEZQYivFVj/RLDLukZSNpaFS5Sqabal5ZonlTsPx0/jf50AuiVmkAtpt+7a+rd1mBE8XYkl0MEoQZPi+AdLEEnjFqAcf386mp0TnuITjzNtykFWdNuMrU6f4vHNO3UbOct2SrKN1wjNEVFJTN/t4GClDw1NQdP9g1hULTUVI6u6dfgbQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Eq+tB3bgbR8TKICMNQRm6vnQICrwF0l75XD9ToSuq+o=;\n b=L7Qyu1SSfgv45+DJ/91NCQsBInkTrxrVC/uHQzl0JwvxbAtLM2mFkVGxa9LD6tGo5hPoUF25crYsfB7y7OD/DfTH22trWr1z9q21oPyz/zosQ4nYb6IFNCWY+bsgck2J2q6lt5MyNq+60SuoY3mTki0trXvT6mIDWtbQNtD5tdLWhQqNHwtznJcNGOSEG2Rj6FRJH4eBxdD975dwR+TNzPiLyKC3xgSbSWmJLlZQTnf01NK0n+f26wLdJWmqcBwQYfvEkfozSkVNKOomKREFC2aB4+7UPteThr+oEGyiIBVkGbXGmS2NWtZhLNEfcTkncG7JEX6kepBB1ydeakuYvQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.21.195) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Eq+tB3bgbR8TKICMNQRm6vnQICrwF0l75XD9ToSuq+o=;\n b=BRmVbxxdtAgGuI7tgN4VewzfbNdxq/9hHZYJLJtaJvHvp4MupSDuvjpjXhRIg/olnvp2fa+9WFCcGZJZ3iRMQIRPObb9rH8bGAK3SLwePwJv6j6r/v9ujhuitVZot/jYj3MQcJzpisoDk5zEyrWoYTxoF+IjMJl/a8fiYSR+seE=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.21.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.21.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C","From":"","To":", ,\n , , ,\n , , ,\n ","CC":"","Subject":"[PATCHv2 3/5] efi_selftest_memory: check for duplicates first","Date":"Thu, 2 Apr 2026 15:50:36 -0500","Message-ID":"<20260402205038.4005350-4-rs@ti.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260402205038.4005350-1-rs@ti.com>","References":"<20260402205038.4005350-1-rs@ti.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ5PEPF000001D2:EE_|CH3PR10MB6788:EE_","X-MS-Office365-Filtering-Correlation-Id":"3d4bba51-f444-43cc-da23-08de90f995c4","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|82310400026|1800799024|36860700016|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n f9ifWaPFQ3uWBW6Zbe1sjtA+shx6Egm3AacpvzvGikdIGhBCKB+ytIvJQDEAgKZPAT+JzNZ1Dzl7gQGyMMs6YzSd44KlNbH8vrrCvbjkvnqQTkCY5aj5llQ9Grx32aqGcoMRHb0wVnyC8PoL3yiDOVgOj31522AoFr2JQpZlB5JvlGD+zCXa/sfUKMqk73YXE3nXUS5CfpWWe3SAjrzngImFMUyzwy/U1g0KyFZjXYMITBMRvouS+zE7fzYZDlcEkVPbd48rLyAXVLi3Z6v3lHhWxwW06zAGqNA6UDeW6M24NwhFc0xE5BqgEBGw9r4uFT20d4Pu8fMil9ISCGf4OEgbkA40FrrCs2Zb92lnLalJoDyYNV54UZkwb585+W6fnbNMS52Qrieid96ccxZSpJlT2rvDHgSAcZUeDE9A87k2SJLsWUr3VMsYsdsWpSSO28ClH/KK4Y6142qQPxvKxW7UnUDAPXDOXwZ57twYC/EhP4oseRhRGt5Exbc8sFpoqTFB310abGvWVkcFHk0Bwntw3cSY1mGRCAWGZx7iukDj98QqyllGvGHT6f7Vgj1Md31DeFeuhOq4IFGcxakQqrZKD6bFwLhWfyGrkgZ2Vc0MStE1zNhv9j18q9CFtX2StZ/9lMX/6jStYWohsKy3ZbnrlpTIYyoEyS1FqVFy0u2XoztOj1rgUbXb4EgS/rt26C9IiYmeimh38oJtRoExwLblaas3jYuxh5y8I9OJ4Mr2yfwSukbUTI09mHmsvEMKxR4tSTLSpicplwzgCISE1A==","X-Forefront-Antispam-Report":"CIP:198.47.21.195; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:flwvzet201.ext.ti.com; PTR:ErrorRetry; CAT:NONE;\n SFS:(13230040)(376014)(82310400026)(1800799024)(36860700016)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n 51dUe20utSYZSWW/31gLJnRFb7FB9rp03jIEpcfaPXG88iGeTY988D2JejfyOMvg27MkPiFJwCsV6EaiUBfco6BGsgYnCTcqL8emdGwNMTSUfJjg+V9AN19myTnp1WxTFZOH88CP7YVhs+rHkE/5t3kBFnSKlPk9/X/+4YL0kvHWVbZ+xdM7Y2QYBBKwrT4aCSPhyjY9648BVqCOfjWsm7oiXAIeAGabny2jALaujyu8pdlpiQhOMv+ko1Q8Jo3t2YOPVow2xrJkXsYxlOqJifThGCl+CLPsmfCaASpoURjHxKbh0LJtwWO0LqxV0E4+nktGnta5AEtMgeX2aSj56fB1YKyZdXwzMvLfI5mp4RbWSInBFHGMkEsAAQgrO1xP/2dC5Sy2NB1+9uV2auvpBARjCmFFXlBaAMqJ4d+EtixTf5XBzXnV0FW2gdeaAkX8","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Apr 2026 20:51:16.5879 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 3d4bba51-f444-43cc-da23-08de90f995c4","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.21.195];\n Helo=[flwvzet201.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n SJ5PEPF000001D2.namprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH3PR10MB6788","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Randolph Sapp \n\nCheck for duplicate memory mappings before reporting any incorrect\nattributes. Could be that second allocation has the correct type while\nthe first doesn't. Knowing there is a duplicate in this scenario is\nmore helpful than just reporting the first mismatch.\n\nSigned-off-by: Randolph Sapp \n---\n lib/efi_selftest/efi_selftest_memory.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/lib/efi_selftest/efi_selftest_memory.c b/lib/efi_selftest/efi_selftest_memory.c\nindex 4d32a280061..7320964c129 100644\n--- a/lib/efi_selftest/efi_selftest_memory.c\n+++ b/lib/efi_selftest/efi_selftest_memory.c\n@@ -60,7 +60,7 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \t\t\t u64 addr, int memory_type)\n {\n \tefi_uintn_t i;\n-\tbool found = false;\n+\tstruct efi_mem_desc *match = NULL;\n \n \tfor (i = 0; map_size; ++i, map_size -= desc_size) {\n \t\tstruct efi_mem_desc *entry = &memory_map[i];\n@@ -72,24 +72,23 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \n \t\tif (addr >= entry->physical_start &&\n \t\t addr < entry->physical_start +\n-\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n-\t\t\tif (found) {\n+\t\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n+\t\t\tif (match) {\n \t\t\t\tefi_st_error(\"Duplicate memory map entry\\n\");\n \t\t\t\treturn EFI_ST_FAILURE;\n \t\t\t}\n-\t\t\tfound = true;\n-\t\t\tif (memory_type != entry->type) {\n-\t\t\t\tefi_st_error\n-\t\t\t\t\t(\"Wrong memory type %d, expected %d\\n\",\n-\t\t\t\t\t entry->type, memory_type);\n-\t\t\t\treturn EFI_ST_FAILURE;\n-\t\t\t}\n+\t\t\tmatch = entry;\n \t\t}\n \t}\n-\tif (!found) {\n+\tif (!match) {\n \t\tefi_st_error(\"Missing memory map entry\\n\");\n \t\treturn EFI_ST_FAILURE;\n \t}\n+\tif (memory_type != match->type) {\n+\t\tefi_st_error(\"Wrong memory type %d, expected %d\\n\", match->type,\n+\t\t\t memory_type);\n+\t\treturn EFI_ST_FAILURE;\n+\t}\n \treturn EFI_ST_SUCCESS;\n }\n \n","prefixes":["PATCHv2","3/5"]}