{"id":2219215,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219215/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"","date":"2026-04-02T15:36:58","name":"[v4,1/3] event: Check return value from event_notify_null()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47ca16625680c5dd184118943700438138a4bad6","submitter":{"id":84271,"url":"http://patchwork.ozlabs.org/api/1.0/people/84271/?format=json","name":"Michal Simek","email":"michal.simek@amd.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.0/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/f8e89783ece4070d90889b730222f09ef7b40c12.1775144215.git.michal.simek@amd.com/mbox/","series":[{"id":498503,"url":"http://patchwork.ozlabs.org/api/1.0/series/498503/?format=json","date":"2026-04-02T15:36:57","name":"fwu: Call EFI stack initialization after preboot","version":4,"mbox":"http://patchwork.ozlabs.org/series/498503/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219215/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256\n header.s=selector1 header.b=tGTHVfaN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=amd.com header.i=@amd.com header.b=\"tGTHVfaN\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=amd.com","phobos.denx.de;\n spf=fail smtp.mailfrom=michal.simek@amd.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmmFf3Ydcz1xtJ\n\tfor ; Fri, 03 Apr 2026 02:37:42 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D4CDB84056;\n\tThu, 2 Apr 2026 17:37:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CAF5084056; Thu, 2 Apr 2026 17:37:32 +0200 (CEST)","from SA9PR02CU001.outbound.protection.outlook.com\n (mail-southcentralusazlp170130001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c10c::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A88BB80212\n for ; Thu, 2 Apr 2026 17:37:30 +0200 (CEST)","from SJ0PR13CA0136.namprd13.prod.outlook.com (2603:10b6:a03:2c6::21)\n by DS0PR12MB8320.namprd12.prod.outlook.com (2603:10b6:8:f8::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr\n 2026 15:37:24 +0000","from MWH0EPF000A6733.namprd04.prod.outlook.com\n (2603:10b6:a03:2c6:cafe::96) by SJ0PR13CA0136.outlook.office365.com\n (2603:10b6:a03:2c6::21) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.18 via Frontend Transport; Thu,\n 2 Apr 2026 15:37:23 +0000","from satlexmb08.amd.com (165.204.84.17) by\n MWH0EPF000A6733.mail.protection.outlook.com (10.167.249.25) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Thu, 2 Apr 2026 15:37:23 +0000","from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com\n (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 2 Apr\n 2026 10:37:23 -0500","from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 2 Apr\n 2026 10:37:21 -0500","from localhost (10.180.168.240) by satlexmb07.amd.com\n (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend\n Transport; Thu, 2 Apr 2026 10:37:21 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=tNsVLmRdBzElTMkvaqDmzVFlxKbeMuPD00FNDvBaylYcgrbgnLKCVsYt3JWX7DAyDwpFY5xC9ivEOdtUuJkC+uDyNs3mrS3nZRL+bVT84YaG1fgnzujQ2SYE9qNVM1bp/EnqjrhKEfI/oV/Eh1hbTsQQ1wvdQfK5Y4K/T12pH7EkqAj6evn4CVKz+K+PTOzXUld8EAeYJeIS1io7JW2qeFu6X23EI+mcKNcNGfA/cfCSf02FXOXoNf8b1QZhZ397/w4mU1xG/80OL3TUoyejCMBsjaM6JOzTpb0if8igXTwgRQv6ma6EOmYp6gUa0YVSrUV24onveFy1kTSSliQrWQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4TFJAClpuH92ckVRZSQKGvxv2/djTUpjxDRzo3IuRDs=;\n b=X6oaD5UziJKy2pIJIOiugMshjNtyKjpr7TY/l4oBlWX4ijzXLX6+jjPcfTOQXRX6plAMbU218/ecInHaiTXXHEJScwEloQZqllz2bW01HZHYdhBUJ039WBQNfWPwhiltlTzIFzJCCqusERPA0fANDdJmCHhECtF9ydAX4syqn9Q3p/7J1hTyaw8howHWRlYgfPzUsVu924b/7Qs4gDGiwU87GOJLlNpLl3XSdW8QnKibhAvTQXdv15imbMahjszbYNWrEmGHS43lSjFVFk7UH3gKlQj2zHiqMycZ4nFnDFquxa0bUq4C0uY3nrF6amjICiqvUphMP+w23jS/kVAXjQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=amd.com; dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=4TFJAClpuH92ckVRZSQKGvxv2/djTUpjxDRzo3IuRDs=;\n b=tGTHVfaNx3YKbKHtTW9Li52WoMAre4zOLi25VlOTYvnONPOkO3RXo/saOqz6ftsjtaFdQR9zlsiqMVX19dBSyl1R6nLBmTYMKeKJaaG5XRIQSFyJFxTCj+8CqHe6RS+khlldSPq8XxM5Djy+9vEpb2SFYlDuLOvGFz3L4LkhaCU=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;","Received-SPF":["Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C","None (SATLEXMB04.amd.com: michal.simek@amd.com does not\n designate permitted sender hosts)"],"From":"Michal Simek ","To":", , ,\n , ","CC":"Jerome Forissier , Leo Yu-Chi Liang\n , Marek Vasut ,\n Quentin Schulz , Tom Rini ,\n \"Yao Zi\" ","Subject":"[PATCH v4 1/3] event: Check return value from event_notify_null()","Date":"Thu, 2 Apr 2026 17:36:58 +0200","Message-ID":"\n ","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"","References":"","MIME-Version":"1.0","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1943; i=michal.simek@amd.com;\n h=from:subject:message-id; bh=e/ATTfThTkr0LYgVDSD0/s45WOXVXYB9VZJLx6ipyok=;\n b=owGbwMvMwCG2mv3fB7+vgl8ZT6slMWSe69Xyz5NvyM1UcPLRkOTT57uQZcgzQXJ9yCPLhL1fN\n yTICW/pKGVhEONgkBVTZJnOpOOw5tu1pWLLI/Nh5rAygQxh4OIUgIl4ajIy9GeGf9+9vFo6d3Lt\n 4S231I7V9m55wMdV6m+1T5qd+91cN0aGDXblx04GT+x5Xcu3542eUZGX5pVwq68rbwTH2ieaiBQ\n wAQA=","X-Developer-Key":"i=michal.simek@amd.com; a=openpgp;\n fpr=67350C9BF5CCEE9B5364356A377C7F21FE3D1F91","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MWH0EPF000A6733:EE_|DS0PR12MB8320:EE_","X-MS-Office365-Filtering-Correlation-Id":"b259dd74-5d24-48f7-cd9d-08de90cdbc54","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|7416014|376014|82310400026|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n NQvx1QO8hYriClCrC0Tu9u6xsvpzkJF2xctYwtp2CCy7JYDwJDi85HB+wwLcsqOsi+70IhdCtK2B7D4yA1RSm5U9T1zBUSzP5acNyRZkBb5c1tWXTqitCBga7kisojEEw1zFgip2ApQPO/QHh/wrd5l+TZX2RyIfCNrnGfRVv5zT6aLSPb73dU10ueMP5FdopZkhXxiVCsS0yGUFQ14G7OB4zKrMz3/bGdVThLccEsAz9nyP6+7YY5AiIOtg4cGSWUPpWuv+UFTemuRNxhUNsdcRahN+NEz6IUSkVV6xGJ/rA1X9gErLoJlDqdYF/X8bZT/D0XJUVEGDly+A25opdQiEy6JvWCA1E8xxBDQfrkJSYNr8BM051UStH/YCUqzePR+wvxwRSiMQ0HNvrKHh8NhMfAK/DlynxrmdNOIDDylfwkr017YjztCHDY1GQJDy+Cy3RGIy94fl2PEbry3puIZ1Kbv3J8yIquA4kiEU9a+cqOd91dinogiHykTvBVhtILi/oHc5Jj322mTFdj1nnZNc91sgjlTipD/O+vqzfOhL0XkvZkLdiP4qMcLBzQiqM8Tl4BPsqf0q44VIWseusqo5l+yBGo6bGlXvRH7HUycDOj2Z2AmR/xCi+lGH75U/wHUzzm1+gBL8/w+VAM3wXp4TSIzzW2nqsYI29aWVyuP3wy66JxzO9IEJ6wKrTo8hxBD4qqECyw3KPfxqRr0/iG6yIG662+J9/boaETdAE+9vWNpQKSHCwdmyUYa9v77eNzsNlp3xsJqKtqASshc67A==","X-Forefront-Antispam-Report":"CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:satlexmb08.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700016)(7416014)(376014)(82310400026)(1800799024)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n yMt7RhuYDt3nTwEA/DbT7VXnzN5TRXw+Nab3pFj6b8MELYJAi2ZkAA+JTn84OSMGxOyAMUkyE0mBfOTd/yRTqX9v9DKfvut5JpYjXoSIJsAgWAl1GP2Ve7JuJihuSt0K0Avpo351xolcesD78aD3RGrAK0YRNO8Zhpix3O4n5ImdO3J/91BABHUeagglzm9+pBiiMWyh8TWeGaTkrsxOuGLTD6DRx+3JNRzv4lZU5xiH47zXCYCU5RtibeVvG2lJHZa5fs9aCelue8mElXlaCMWWxnG3V1T1KelF3Kk1sA3n6OfOn+Oqa8u22jlU7XTDi4oQ9+05szYmjo7lyLUBH2pweMCEIMMTilptujIcLdcFgLmdydTUs4QSy7hMepv9LYRyzCVz4U1MwSdeJUACA8S8X6/VaAs6FZYBNeYg/hxQFjbWOoJJ2yfFcfu639MD","X-OriginatorOrg":"amd.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Apr 2026 15:37:23.4840 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n b259dd74-5d24-48f7-cd9d-08de90cdbc54","X-MS-Exchange-CrossTenant-Id":"3dd8961f-e488-4e60-8e11-a82d994e183d","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[satlexmb08.amd.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n MWH0EPF000A6733.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR12MB8320","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"event_notify_null() returns int but its return value is not\nchecked in run_main_loop() and in fwu_mdata tests.\nAdd proper error checking to all unchecked call sites.\n\nSigned-off-by: Michal Simek \nReviewed-by: Simon Glass \nAcked-by: Ilias Apalodimas \n\n---\n\n(no changes since v2)\n\nChanges in v2:\n- new patch in series\n\n common/board_r.c | 6 +++++-\n test/dm/fwu_mdata.c | 4 ++--\n 2 files changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/common/board_r.c b/common/board_r.c\nindex 8cf0e14679c0..5d37345ca09d 100644\n--- a/common/board_r.c\n+++ b/common/board_r.c\n@@ -569,11 +569,15 @@ static int dm_announce(void)\n \n static int run_main_loop(void)\n {\n+\tint ret;\n+\n #ifdef CONFIG_SANDBOX\n \tsandbox_main_loop_init();\n #endif\n \n-\tevent_notify_null(EVT_MAIN_LOOP);\n+\tret = event_notify_null(EVT_MAIN_LOOP);\n+\tif (ret)\n+\t\treturn ret;\n \n \t/* main_loop() can return to retry autoboot, if so just run it again */\n \tfor (;;)\ndiff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c\nindex b7680632f95f..643b647af0a9 100644\n--- a/test/dm/fwu_mdata.c\n+++ b/test/dm/fwu_mdata.c\n@@ -100,7 +100,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts)\n \t * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()\n \t * to populate g_dev global pointer in that library.\n \t */\n-\tevent_notify_null(EVT_MAIN_LOOP);\n+\tut_assertok(event_notify_null(EVT_MAIN_LOOP));\n \n \tut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));\n \tut_assertok(fwu_init());\n@@ -127,7 +127,7 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts)\n \t * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()\n \t * to populate g_dev global pointer in that library.\n \t */\n-\tevent_notify_null(EVT_MAIN_LOOP);\n+\tut_assertok(event_notify_null(EVT_MAIN_LOOP));\n \n \tut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));\n \n","prefixes":["v4","1/3"]}