{"id":2219130,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2219130/?format=json","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/1.0/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<2f14be46-11b2-45d0-bd94-0ee2d4f0ac87@gmail.com>","date":"2026-04-02T13:29:21","name":"[v2,1/5] ata: libata-transport: instantiate struct ata_internal statically","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f536138d98fe4cac9179792ae4b059d6bed0f835","submitter":{"id":65365,"url":"http://patchwork.ozlabs.org/api/1.0/people/65365/?format=json","name":"Heiner Kallweit","email":"hkallweit1@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/2f14be46-11b2-45d0-bd94-0ee2d4f0ac87@gmail.com/mbox/","series":[{"id":498482,"url":"http://patchwork.ozlabs.org/api/1.0/series/498482/?format=json","date":"2026-04-02T13:30:05","name":"ata: libata-transport: series with further refactorings","version":2,"mbox":"http://patchwork.ozlabs.org/series/498482/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2219130/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=PDOSkgEW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5423-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"PDOSkgEW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.42","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmjck6czCz1xtJ\n\tfor ; Fri, 03 Apr 2026 00:39:02 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6C5B530FCC99\n\tfor ; Thu, 2 Apr 2026 13:29:30 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 79522307492;\n\tThu, 2 Apr 2026 13:29:29 +0000 (UTC)","from mail-wm1-f42.google.com (mail-wm1-f42.google.com\n [209.85.128.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B55EF2BF3F3\n\tfor ; Thu, 2 Apr 2026 13:29:26 +0000 (UTC)","by mail-wm1-f42.google.com with SMTP id\n 5b1f17b1804b1-4888375f735so7398515e9.3\n for ; Thu, 02 Apr 2026 06:29:26 -0700 (PDT)","from ?IPV6:2003:ea:8f19:9500:c168:ad27:2fdd:9334?\n (p200300ea8f199500c168ad272fdd9334.dip0.t-ipconnect.de.\n [2003:ea:8f19:9500:c168:ad27:2fdd:9334])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4888a567bfasm153322115e9.0.2026.04.02.06.29.22\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 02 Apr 2026 06:29:22 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775136569; cv=none;\n b=L4hIHC0rb+/Ejhch1qdmZhPpTAqJodYr5K27MLdSBFskX2xKo9pLuEptwInDEAbPk6nqA8jDrss53JXg9DIgh7p5a3D/J5TPoW0550V8yyLejDceWQrz+t9zK6Xpd8nhTz8e+0nXvhMFl8OsUpLMBRlo6s/opfC+sXIVuQ+na/A=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775136569; c=relaxed/simple;\n\tbh=Pkt3T9OIZGp9qirfgJYTgEnRWa4IrP07FmHp04xMgpM=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=uy5yoUwXo9KUoVklUdt4TTaMHyYi+cDMW/m/gRsSa2hoamPa5VpsjKvYzWyNkOu5ZwZiWaD+piRz0WOn03vTVPjCJgFByPSeWaRgxPehy+RvXavVN0MY4H/SUP7VT1ddJuYrGVrTyNTCAGGt50yZFLCumLMCKc/4tZomilSM8nE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=PDOSkgEW; arc=none smtp.client-ip=209.85.128.42","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775136565; x=1775741365;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=w7lyX97kUYtzBJUQjAG70TMLjz/e+eDEZJ6A2bZetvc=;\n b=PDOSkgEWaS92SMn1bx3gELpnYo6QpUqwD+THSDfh5R8eshMfCprw30fTwoJKKLd0tQ\n 5+PWK7dMtO3VRmtwVzXedRT9fJHzqFbpO2kfd7RJRjfjL2TL6NWG01tA+ioxXhLtKdc3\n aHZToZsEsS+j03VtRdSckMigKGhzsUDVE0uVf7fDSax9skgajOa+NxoimvUIfjVNnJBs\n iON0XhIhloEFxPYtWErKXJNm+Bnh2o7wBPzw1DyMj8Q7ygq+bUYDb34tCc0wHka0M3b7\n QLyzQ2NmtzWv08mHvaTgS2EWJNo8ZltJBWpxXdqtLAEG3RyK5pZD6phrsZ0C/S2fSHhm\n QT4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775136565; x=1775741365;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=w7lyX97kUYtzBJUQjAG70TMLjz/e+eDEZJ6A2bZetvc=;\n b=gTOoejPyuFGf6lDCr3K/8/s4ilbAAe0fCahXJgaNhEewM/gOFz1k5RiGrL+k9Rp7bw\n EmcISTcFGOKxa3vrYWu3f74QYFqt9iQ1ef2seyRuvEiPdiRLuBSkaLeJv6MLIGYzz8NE\n c5Zk0lOMpaK29muXC2w44GEssYv1eg2Gw9LcB+vqP+bBAzCMbdEBaw1rbWnUdu9FIlnq\n pJXUlFkh/HwmI+sKohzx65ZVDuqIrMLPUwQuAbleRUIMbZF/MjF+UbAXBuwYg3U0IAzO\n A237Qlhs4bXDhjEBJnDLJAWzn6j0FNdzYrMo0RTyvZfmzP6YlvJRaTbSKD6J/Neaa53X\n b18A==","X-Gm-Message-State":"AOJu0YwiYajEwfmxUlYQlIJzCx34Egt5ltqmT8qNbqEzlarI6ICqI37Y\n\t051WBfXrJr2KZa/HTf4yeISO0ObclPQT17Vcg1DWI6+Q6Z1hFpohpZ8HaFVkxg==","X-Gm-Gg":"ATEYQzytVfck94OQNM71L5ysTl4BTk7HLK5mRwl+Cs9OiV/Rte/Gh+0h53bb2SGgCDt\n\tfk0R27BL/Yrcc0GYTRlY45oG15aL8I7lWJovRc4Ci7aCRBz+zs7OmVydzjrG2Gi0n7u5SFLxW01\n\tycU/MKaS5hEuS83kOQ4PlBaoGWPC5Ztd1s51IW39l4nkthz38xJB7ADlNwuk45R+INcP76Uhx/S\n\tZaxi7OjRLmpxe+a+OZ0GC5fGN3pD5Vyl3Pfzzlc64VA2d/On+kaObuVozLJGG9atRixLXgi4WGY\n\t174raOV3eLMMGs+yTTntiZPnDnWRizEvJbOucH9Yk0TgTfGhS2IFbsd+iKouruGsMtNDwZ1MNKt\n\tt+kWo9FEeHFbFWbTmv7gmsypuIMh5QF0LSvu6yXbDCQ3hz1j2DjMOiSP0cGWL07is6byDR6S8MR\n\tGmkIvLN/lju9comv/T5rTeZ87IAhrVagdBajlPuos12NcjxYVZ1PEaXJ0HDOeVjUKyEqJBaRafB\n\tACrWqc63b5X8uvnHvE4YAdTYTSx/OpRjvXXifnZOJ5A8CoyiAyqkIT/KkVrKGNNkw==","X-Received":"by 2002:a05:600c:4f53:b0:486:fb5c:3b20 with SMTP id\n 5b1f17b1804b1-4888358be65mr130438095e9.13.1775136563103;\n Thu, 02 Apr 2026 06:29:23 -0700 (PDT)","Message-ID":"<2f14be46-11b2-45d0-bd94-0ee2d4f0ac87@gmail.com>","Date":"Thu, 2 Apr 2026 15:29:21 +0200","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"[PATCH v2 1/5] ata: libata-transport: instantiate struct ata_internal\n statically","From":"Heiner Kallweit ","To":"Damien Le Moal , Niklas Cassel ","Cc":"linux-ide@vger.kernel.org","References":"<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>","Content-Language":"en-US","In-Reply-To":"<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"},"content":"Struct ata_internal is only instantiated once, in module init code.\nSo we can also instantiate it statically, which allows simplifying\nthe code.\n\nReviewed-by: Damien Le Moal \nSigned-off-by: Heiner Kallweit \n---\n drivers/ata/libata-core.c | 11 ++-----\n drivers/ata/libata-transport.c | 57 +++++++++++++++-------------------\n drivers/ata/libata-transport.h | 2 +-\n 3 files changed, 28 insertions(+), 42 deletions(-)","diff":"diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c\nindex 81479ddb8..ae56567af 100644\n--- a/drivers/ata/libata-core.c\n+++ b/drivers/ata/libata-core.c\n@@ -6779,22 +6779,15 @@ static int __init ata_init(void)\n \n \tlibata_transport_init();\n \tata_scsi_transport_template = ata_attach_transport();\n-\tif (!ata_scsi_transport_template) {\n-\t\tata_sff_exit();\n-\t\trc = -ENOMEM;\n-\t\tgoto err_out;\n-\t}\n \n \tprintk(KERN_DEBUG \"libata version \" DRV_VERSION \" loaded.\\n\");\n-\treturn 0;\n \n-err_out:\n-\treturn rc;\n+\treturn 0;\n }\n \n static void __exit ata_exit(void)\n {\n-\tata_release_transport(ata_scsi_transport_template);\n+\tata_release_transport();\n \tlibata_transport_exit();\n \tata_sff_exit();\n \tata_free_force_param();\ndiff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c\nindex 7ad180265..0c7ce278e 100644\n--- a/drivers/ata/libata-transport.c\n+++ b/drivers/ata/libata-transport.c\n@@ -745,6 +745,23 @@ int ata_tlink_add(struct ata_link *link)\n \treturn error;\n }\n \n+static struct ata_internal ata_transport_internal = {\n+\t.t.eh_strategy_handler\t= ata_scsi_error,\n+\t.t.user_scan\t\t= ata_scsi_user_scan,\n+\n+\t.t.host_attrs.ac.class\t= &ata_port_class.class,\n+\t.t.host_attrs.ac.grp\t= &ata_port_attr_group,\n+\t.t.host_attrs.ac.match\t= ata_tport_match,\n+\n+\t.link_attr_cont.ac.class = &ata_link_class.class,\n+\t.link_attr_cont.ac.grp = &ata_link_attr_group,\n+\t.link_attr_cont.ac.match = ata_tlink_match,\n+\n+\t.dev_attr_cont.ac.class\t= &ata_dev_class.class,\n+\t.dev_attr_cont.ac.grp\t= &ata_device_attr_group,\n+\t.dev_attr_cont.ac.match\t= ata_tdev_match,\n+};\n+\n /*\n * Setup / Teardown code\n */\n@@ -754,46 +771,22 @@ int ata_tlink_add(struct ata_link *link)\n */\n struct scsi_transport_template *ata_attach_transport(void)\n {\n-\tstruct ata_internal *i;\n-\n-\ti = kzalloc_obj(struct ata_internal);\n-\tif (!i)\n-\t\treturn NULL;\n+\ttransport_container_register(&ata_transport_internal.t.host_attrs);\n+\ttransport_container_register(&ata_transport_internal.link_attr_cont);\n+\ttransport_container_register(&ata_transport_internal.dev_attr_cont);\n \n-\ti->t.eh_strategy_handler\t= ata_scsi_error;\n-\ti->t.user_scan\t\t\t= ata_scsi_user_scan;\n-\n-\ti->t.host_attrs.ac.class = &ata_port_class.class;\n-\ti->t.host_attrs.ac.grp = &ata_port_attr_group;\n-\ti->t.host_attrs.ac.match = ata_tport_match;\n-\ttransport_container_register(&i->t.host_attrs);\n-\n-\ti->link_attr_cont.ac.class = &ata_link_class.class;\n-\ti->link_attr_cont.ac.grp = &ata_link_attr_group;\n-\ti->link_attr_cont.ac.match = ata_tlink_match;\n-\ttransport_container_register(&i->link_attr_cont);\n-\n-\ti->dev_attr_cont.ac.class = &ata_dev_class.class;\n-\ti->dev_attr_cont.ac.grp = &ata_device_attr_group;\n-\ti->dev_attr_cont.ac.match = ata_tdev_match;\n-\ttransport_container_register(&i->dev_attr_cont);\n-\n-\treturn &i->t;\n+\treturn &ata_transport_internal.t;\n }\n \n /**\n * ata_release_transport -- release ATA transport template instance\n * @t:\t\ttransport template instance\n */\n-void ata_release_transport(struct scsi_transport_template *t)\n+void ata_release_transport(void)\n {\n-\tstruct ata_internal *i = to_ata_internal(t);\n-\n-\ttransport_container_unregister(&i->t.host_attrs);\n-\ttransport_container_unregister(&i->link_attr_cont);\n-\ttransport_container_unregister(&i->dev_attr_cont);\n-\n-\tkfree(i);\n+\ttransport_container_unregister(&ata_transport_internal.t.host_attrs);\n+\ttransport_container_unregister(&ata_transport_internal.link_attr_cont);\n+\ttransport_container_unregister(&ata_transport_internal.dev_attr_cont);\n }\n \n __init int libata_transport_init(void)\ndiff --git a/drivers/ata/libata-transport.h b/drivers/ata/libata-transport.h\nindex 50cd2cbe8..a464b8fcd 100644\n--- a/drivers/ata/libata-transport.h\n+++ b/drivers/ata/libata-transport.h\n@@ -9,7 +9,7 @@ int ata_tlink_add(struct ata_link *link);\n void ata_tlink_delete(struct ata_link *link);\n \n struct scsi_transport_template *ata_attach_transport(void);\n-void ata_release_transport(struct scsi_transport_template *t);\n+void ata_release_transport(void);\n \n __init int libata_transport_init(void);\n void __exit libata_transport_exit(void);\n","prefixes":["v2","1/5"]}