{"id":2218907,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2218907/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402022921.298818-11-kshk@linux.ibm.com>","date":"2026-04-02T02:29:16","name":"[10/15] s390x/pci: Move pba from S390PCIIOMMU to S390PCIBusDevice","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3db8cad971cca49e0f6dbfcd8bf2052e6f6e44dc","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.0/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402022921.298818-11-kshk@linux.ibm.com/mbox/","series":[{"id":498419,"url":"http://patchwork.ozlabs.org/api/1.0/series/498419/?format=json","date":"2026-04-02T02:29:08","name":"s390x/pci: Implement migration for emulated devices","version":1,"mbox":"http://patchwork.ozlabs.org/series/498419/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218907/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=JXI8eCDy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmQqV5pX0z1yGH\n\tfor ; Thu, 02 Apr 2026 13:32:22 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w87pZ-0004o2-2o; Wed, 01 Apr 2026 22:30:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87os-0004E6-O1; Wed, 01 Apr 2026 22:30:07 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87or-0001oT-0e; Wed, 01 Apr 2026 22:30:06 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 631Ju8Oo3941833; Thu, 2 Apr 2026 02:30:01 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66msa3tn-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:30:00 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63212omo030990;\n Thu, 2 Apr 2026 02:30:00 GMT","from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6uhk05j0-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:59 +0000","from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 6322TwHX9044658\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 02:29:58 GMT","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 313D0580F4;\n Thu, 2 Apr 2026 02:29:58 +0000 (GMT)","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 9CE52580F6;\n Thu, 2 Apr 2026 02:29:57 +0000 (GMT)","from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.247.119])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 02:29:57 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=Ju3TdCo9F+qwi0b5K\n e4joOc8d4Yfdtaokv5jWfReqNc=; b=JXI8eCDy+HXx/CkH/39ivl89rJNXr6RyT\n Z935IZnuh8/ySeNSoxYWfYfU3odxoNTZlsbGHqjhOpwrWUlAPzlVq1ZdiWuxQjyK\n Gb9/UuFg11f3Dn2MUWahsCO9I089SNcPdZaxkxeR3+VCMenGcA84BmXi7/WaUGth\n ud3CarfkdtV4sulbbugbnAdnuzFQx2m9nwllVxAr/TsmiYocTGl3KkEH6tWdvwRh\n PM+znNitVlLAk5faiVaysnbxBA6N/tXERCFVvFhpwWoFP/zETWLoqCj7H76l+b1j\n ycmnAZTASMsCb+wdtWsHIHwM+MbskR7U3E3WdW7oWklzZ2Ff1eTOQ==","From":"Konstantin Shkolnyy ","To":"mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy ","Subject":"[PATCH 10/15] s390x/pci: Move pba from S390PCIIOMMU to\n S390PCIBusDevice","Date":"Wed, 1 Apr 2026 21:29:16 -0500","Message-Id":"<20260402022921.298818-11-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260402022921.298818-1-kshk@linux.ibm.com>","References":"<20260402022921.298818-1-kshk@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69cdd4a8 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=THYS1zffzJpO_GefUMYA:9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDAxOSBTYWx0ZWRfX0aMI4+kJHcRN\n Qs/BOmYaYW1YBLN+e8uN86VPZaaDBUC7pGC/8EdvgC0UW5OkO+crNOvvb9tXVp2Bsn6JzcBQHt4\n CIlbpUHFfCcsSPs6EgJU7x5H95MoHu6K1J8MN3OKo2VVgl4IC79Z94uGXKRY2zOlpmCLgDiFbtc\n YDpgziGvTRTak0i7EPxY3kawT+lEYFGiqZb7GU0+cyDJdO6Cy09gOACZPL0RKlBEA00QeB4+EO1\n QhMrT4DBVOzRgIpJvR2UOdMIQqxgjGcy3r0GaHVWbIl+ifLqYoQpulCO3LouDTRMv9hbG5/zMxs\n uFbAm8R76ZVDtCJ1EO9aS3nNpq+ug8K0u4mFZOahEzbpMS/Cn7oKmrKNQaGwS9QR1QjVi4+hZjx\n XVzUAHBPlcWHYaloxSZq/57BQ+ecAfGNctdYiD5GqIJUUOPRd3SymFZTfMGqj0f2Ev6xB/m9CVV\n 4LuE0SchNer4hp1ZAcQ==","X-Proofpoint-GUID":"aCmxvNOByQ4d8nyum1RP09cUn3PrBc-e","X-Proofpoint-ORIG-GUID":"aCmxvNOByQ4d8nyum1RP09cUn3PrBc-e","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-01_05,2026-04-01_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020019","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-6","X-Spam_score":"-0.7","X-Spam_bar":"/","X-Spam_report":"(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This field is only used when S390PCIBusDevice exists, so it can be moved\nthere to simplify S390PCIIOMMU which purpose is just to store the \"root\"\nAddressSpace.\n\nThis also allows to save/restore this field during migration.\n\nSigned-off-by: Konstantin Shkolnyy \n---\n hw/s390x/s390-pci-bus.c | 4 ++--\n hw/s390x/s390-pci-inst.c | 8 ++++----\n include/hw/s390x/s390-pci-bus.h | 2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex b784196c9e..734af3a307 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -564,7 +564,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n \n trace_s390_pci_iommu_xlate(addr);\n \n- if (addr < iommu->pba || addr > iommu->pal) {\n+ if (addr < pbdev->pba || addr > iommu->pal) {\n error = ERR_EVENT_OORANGE;\n goto err;\n }\n@@ -601,7 +601,7 @@ static void s390_pci_ioat_replay(S390PCIBusDevice *pbdev)\n hwaddr curr, end;\n S390PCIIOMMU *iommu = pbdev->iommu;\n \n- curr = iommu->pba;\n+ curr = pbdev->pba;\n end = iommu->pal;\n \n if (pbdev->dm_mr) {\ndiff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex f4ec299614..7680d87080 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -753,7 +753,7 @@ int rpcit_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2, uintptr_t ra)\n goto err;\n }\n \n- if (end < iommu->pba || start > iommu->pal) {\n+ if (end < pbdev->pba || start > iommu->pal) {\n error = ERR_EVENT_OORANGE;\n goto err;\n }\n@@ -1026,7 +1026,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n return -EINVAL;\n }\n \n- iommu->pba = pba;\n+ pbdev->pba = pba;\n iommu->pal = pal;\n pbdev->g_iota = g_iota;\n \n@@ -1043,7 +1043,7 @@ void pci_dereg_ioat(S390PCIBusDevice *pbdev)\n {\n S390PCIIOMMU *iommu = pbdev->iommu;\n s390_pci_iommu_disable(pbdev);\n- iommu->pba = 0;\n+ pbdev->pba = 0;\n iommu->pal = 0;\n pbdev->g_iota = 0;\n }\n@@ -1416,7 +1416,7 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n return 0;\n }\n \n- stq_be_p(&fib.pba, pbdev->iommu->pba);\n+ stq_be_p(&fib.pba, pbdev->pba);\n stq_be_p(&fib.pal, pbdev->iommu->pal);\n stq_be_p(&fib.iota, pbdev->g_iota);\n stq_be_p(&fib.aibv, pbdev->routes.adapter.ind_addr);\ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex a7d1f1ade2..42f39a5cf0 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -275,7 +275,6 @@ struct S390PCIIOMMU {\n Object parent_obj;\n AddressSpace as;\n MemoryRegion mr;\n- uint64_t pba;\n uint64_t pal;\n uint64_t max_dma_limit;\n };\n@@ -352,6 +351,7 @@ struct S390PCIBusDevice {\n MemoryRegion *dm_mr;\n GHashTable *iotlb;\n uint64_t g_iota;\n+ uint64_t pba;\n S390PCIDMACount *dma_limit;\n MemoryRegion msix_notify_mr;\n IndAddr *summary_ind;\n","prefixes":["10/15"]}