{"id":2218896,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2218896/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402022921.298818-7-kshk@linux.ibm.com>","date":"2026-04-02T02:29:12","name":"[06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a7bafae41bde8fe2c352986dcd966a16ecd07feb","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.0/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402022921.298818-7-kshk@linux.ibm.com/mbox/","series":[{"id":498419,"url":"http://patchwork.ozlabs.org/api/1.0/series/498419/?format=json","date":"2026-04-02T02:29:08","name":"s390x/pci: Implement migration for emulated devices","version":1,"mbox":"http://patchwork.ozlabs.org/series/498419/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218896/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=I5G5G6CF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmQnp11K6z1yGH\n\tfor ; Thu, 02 Apr 2026 13:30:54 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w87pD-0004UJ-Vy; Wed, 01 Apr 2026 22:30:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87op-0004DH-Hk; Wed, 01 Apr 2026 22:30:03 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87on-0001kq-Kd; Wed, 01 Apr 2026 22:30:03 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 631KC0Nu4107161; Thu, 2 Apr 2026 02:29:58 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d64dgtajr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:58 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 6321ea0c030955;\n Thu, 2 Apr 2026 02:29:57 GMT","from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6uhk05hw-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:57 +0000","from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 6322TtYY32309768\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 02:29:55 GMT","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 9DF73580F4;\n Thu, 2 Apr 2026 02:29:55 +0000 (GMT)","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 152A6580F6;\n Thu, 2 Apr 2026 02:29:55 +0000 (GMT)","from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.247.119])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 02:29:55 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=W0304v40uMg9cvp2E\n 1tL4dSTvNqIXAhMIqxF4i8Fq+s=; b=I5G5G6CFG+y+L1WNlTnzq4oJ2d7Wa3fIr\n +YFtHyMefA0k1U4HbL37FrFf6ipzI83Ltr/MnAIiXRuQ5+hJh3hK/g9ppODgHMQW\n vpUoFZSBvAanzqBOPP1TjBV7N3LrcigxwApBo99Ie9CHX14I+8BwQbe9C0W4TaIk\n YzH+NLVL1OWXXXJAstHRJOnlrtexZrr702qIwXfmHIkgPFiKS3cS7DBu4YWv3iOB\n A7lsSp0Q7hEm6S7L6mmcV5D3SmpK6yOHiEG9iRgR79GE7AcvQB234Zz+1A1xqDun\n HYhw4FAuTgyjC7BWXT7yUv48yZjwdKDY4jnawbG77f1vljmKwGSLA==","From":"Konstantin Shkolnyy ","To":"mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy ","Subject":"[PATCH 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from\n S390PCIIOMMU","Date":"Wed, 1 Apr 2026 21:29:12 -0500","Message-Id":"<20260402022921.298818-7-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260402022921.298818-1-kshk@linux.ibm.com>","References":"<20260402022921.298818-1-kshk@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDAxOSBTYWx0ZWRfX4xuM1kw4TAcw\n U45OiW1g4Zlxe6nMetJhxQLdrLyLKb29lKMPWC98mY8WCYYy+vA18g5O7TKJxGitNl0JAGAIWHR\n 7ok4daBTwY2S4Q2//RmXQcotHblI8prfT0rdiJ11EIROwjyHysW9Cf3JcPX71o5O/+3oC3gG4Ut\n k9a2t2kHM8merzj6pWPtyJRsL17i10HGvS39HbPBdiJgrjSBu1Lsl6+kpDRpJn2ktE+O6STakO+\n FdHvICFxYgvOzdPw+sGen2LRlG2cvvOtUPv927KYgDLmQwYRHHq/SGVIcoQw6GDn3gZerkCQQ0F\n WH+4Pn1lXjgdSOvefaJkvyAsPJ3uJPAEl4sdQFfJdcuoiWcZCXnylfrIbnaZh6JZwYSM04s0PIn\n L1lqjSWn/YlPl3r73uID0BpeFbzsqc7R+U1oJIN34CXSRoSvBWZlTLmUvQkEnPdyNgTolrpI/jC\n 35Z1y+dYnZDl9qNjilw==","X-Authority-Analysis":"v=2.4 cv=QKZlhwLL c=1 sm=1 tr=0 ts=69cdd4a6 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=yINFAIt2aqTEABBYJGoA:9","X-Proofpoint-GUID":"4OsIh1I2fb5h98jDnNJMo0WeibUnNbMd","X-Proofpoint-ORIG-GUID":"4OsIh1I2fb5h98jDnNJMo0WeibUnNbMd","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-01_05,2026-04-01_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1011\n spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020019","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-6","X-Spam_score":"-0.7","X-Spam_bar":"/","X-Spam_report":"(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This pointer is no longer used, after fields were moved from S390PCIIOMMU\nto S390PCIBusDevice.\n\nSigned-off-by: Konstantin Shkolnyy \n---\n hw/s390x/s390-pci-bus.c | 15 +++++++--------\n include/hw/s390x/s390-pci-bus.h | 1 -\n 2 files changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 3f3123e62a..83e9ca99f3 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -551,7 +551,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n .perm = IOMMU_NONE,\n };\n \n- switch (iommu->pbdev->state) {\n+ switch (pbdev->state) {\n case ZPCI_FS_ENABLED:\n case ZPCI_FS_BLOCKED:\n if (!iommu->enabled) {\n@@ -586,9 +586,9 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n }\n err:\n if (error) {\n- iommu->pbdev->state = ZPCI_FS_ERROR;\n- s390_pci_generate_error_event(error, iommu->pbdev->fh,\n- iommu->pbdev->fid, addr, 0);\n+ pbdev->state = ZPCI_FS_ERROR;\n+ s390_pci_generate_error_event(error, pbdev->fh,\n+ pbdev->fid, addr, 0);\n }\n return ret;\n }\n@@ -767,7 +767,7 @@ void s390_pci_iommu_enable(S390PCIBusDevice *pbdev)\n * so the smallest IOMMU region we can define runs from 0 to the end\n * of the PCI address space.\n */\n- char *name = g_strdup_printf(\"iommu-s390-%04x\", iommu->pbdev->uid);\n+ char *name = g_strdup_printf(\"iommu-s390-%04x\", pbdev->uid);\n memory_region_init_iommu(&pbdev->iommu_mr, sizeof(pbdev->iommu_mr),\n TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),\n name, iommu->pal + 1);\n@@ -788,14 +788,14 @@ void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)\n * IOVA X + SDMA. VFIO will handle pinning via its memory listener.\n */\n g_autofree char *name = g_strdup_printf(\"iommu-dm-s390-%04x\",\n- iommu->pbdev->uid);\n+ pbdev->uid);\n \n pbdev->dm_mr = g_malloc0(sizeof(*pbdev->dm_mr));\n memory_region_init_alias(pbdev->dm_mr, OBJECT(&iommu->mr), name,\n get_system_memory(), 0,\n s390_get_memory_limit(s390ms));\n iommu->enabled = true;\n- memory_region_add_subregion(&iommu->mr, iommu->pbdev->zpci_fn.sdma,\n+ memory_region_add_subregion(&iommu->mr, pbdev->zpci_fn.sdma,\n pbdev->dm_mr);\n }\n \n@@ -1187,7 +1187,6 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,\n \n pbdev->pdev = pdev;\n pbdev->iommu = s390_pci_get_iommu(s, pci_get_bus(pdev), pdev->devfn);\n- pbdev->iommu->pbdev = pbdev;\n pbdev->state = ZPCI_FS_DISABLED;\n set_pbdev_info(pbdev);\n \ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex d9bafd6859..fcaaf19512 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -273,7 +273,6 @@ typedef struct S390PCIDMACount {\n \n struct S390PCIIOMMU {\n Object parent_obj;\n- S390PCIBusDevice *pbdev;\n AddressSpace as;\n MemoryRegion mr;\n bool enabled;\n","prefixes":["06/15"]}