{"id":2218895,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2218895/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260402022921.298818-3-kshk@linux.ibm.com>","date":"2026-04-02T02:29:08","name":"[02/15] s390x/pci: Create function to contain translation status check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a09ce7fdf6f1bc8853c9f43cbf06ec5d9cd77fbe","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.0/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402022921.298818-3-kshk@linux.ibm.com/mbox/","series":[{"id":498419,"url":"http://patchwork.ozlabs.org/api/1.0/series/498419/?format=json","date":"2026-04-02T02:29:08","name":"s390x/pci: Implement migration for emulated devices","version":1,"mbox":"http://patchwork.ozlabs.org/series/498419/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218895/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=NLPWrDci;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmQnp19vBz1yGY\n\tfor ; Thu, 02 Apr 2026 13:30:54 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w87ot-0004Dp-Dr; Wed, 01 Apr 2026 22:30:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87on-0004Co-Or; Wed, 01 Apr 2026 22:30:02 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w87om-0001kL-3O; Wed, 01 Apr 2026 22:30:01 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 631IVC5K3747399; Thu, 2 Apr 2026 02:29:55 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66msa3th-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:54 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 631NFY8m005910;\n Thu, 2 Apr 2026 02:29:54 GMT","from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6spy8ecx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:54 +0000","from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 6322TrJ628639948\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 02:29:53 GMT","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 12649580F9;\n Thu, 2 Apr 2026 02:29:53 +0000 (GMT)","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 7DB03580F7;\n Thu, 2 Apr 2026 02:29:52 +0000 (GMT)","from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.247.119])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 02:29:52 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=2nAuGIzcGNveeUJaf\n 4mJJ38OhIA5CorGjubqRHHjhZ8=; b=NLPWrDciDIkl4PsB+Z+mHRHeWYsYZi2Ja\n WelER1831fPNJZC0xRFQL60d3gfnCZ7Hn9JLlGuhG3odsmp1BCj2TzN9Um+hkyrF\n JHG9GcBEFnDcAwtacTGEQSW8s4FWGJ2WRec2OyHyf5nk8RLAuojeUKLxtcE8gV7A\n qnj0CexhwRKTpGav1w+R2tSfqFI+YxvR6iQCTRE9iAlFHPpGVn5ASutT1PqvkGtT\n En8u/yLmmlG39bN8llsAFe4VnmrgXCrWFwnrwZ8KAVbevr9mee4qCQRz9DPC+FnD\n Rq2vgrkBAjA/WcJcVMd+tWAh73Qcn8SZhsSQ717nqdiEFFXc7YhsA==","From":"Konstantin Shkolnyy ","To":"mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy ","Subject":"[PATCH 02/15] s390x/pci: Create function to contain translation\n status check","Date":"Wed, 1 Apr 2026 21:29:08 -0500","Message-Id":"<20260402022921.298818-3-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260402022921.298818-1-kshk@linux.ibm.com>","References":"<20260402022921.298818-1-kshk@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69cdd4a2 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=aCv-BzsnQx_gTHabB28A:9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDAxOSBTYWx0ZWRfX5niHhBrBqYXQ\n IzPtOF7m27HTh4KagUm8I1b7DRfFOqDSf3LBJfJBRVh+2mC+HhniY0iePUYdsT2YGBS+TlG/Yk4\n OsQgOGzn3a8a2gN9L5DfqDqQtFYszKAhyTrUaU2LKpwMr/wYl98atv0K47ivSYy1tpFm30d4cjk\n wICK1KVdJ2LFR5Znm8cIlhvoyLRI9/g+qNZUVOJWn01avV/Zt7t1ziLjGoqItQ61jm9f7TsKn8x\n vm7Z9fv9xczjkv+kERxjNxRkAuGZnp8ZPtY+qlR6Z565QYRPDrhjiiHOI+AhK3B1GYBmnBe7DrF\n 8yMYvX0htOKQBvkFdc4ajtOyRrl53KELxZJ9kWOEtRN51qipKNQLVaLHBGTtWaZQ2qoFbKc4VKU\n 4jR7luOM8AwSYUH1DV98O3iC1FxSL1USz6hkzjQsQqB1BLPbyv4qN9gP6e72X0EzNbawF9U4c1Z\n 4C6a1w65tHfe7mXA/hw==","X-Proofpoint-GUID":"bJt34xR9ATA-_JbR33aWrVNOlWS51Tl8","X-Proofpoint-ORIG-GUID":"bJt34xR9ATA-_JbR33aWrVNOlWS51Tl8","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-01_05,2026-04-01_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1011 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020019","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-6","X-Spam_score":"-0.7","X-Spam_bar":"/","X-Spam_report":"(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Make it more clear what the bit means, and the new function will be called\nfrom yet another place in the future.\n\nSigned-off-by: Konstantin Shkolnyy \n---\n hw/s390x/s390-pci-inst.c | 7 ++++++-\n include/hw/s390x/s390-pci-bus.h | 1 +\n 2 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex 1834596076..7c784b31f3 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -993,6 +993,11 @@ int pci_dereg_irqs(S390PCIBusDevice *pbdev)\n return 0;\n }\n \n+bool s390_pci_is_translation_enabled(uint64_t g_iota)\n+{\n+ return ((g_iota >> 11) & 0x1) != 0; /* \"T\" bit */\n+}\n+\n static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n uintptr_t ra)\n {\n@@ -1001,7 +1006,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n uint64_t pal = ldq_be_p(&fib.pal);\n uint64_t g_iota = ldq_be_p(&fib.iota);\n uint8_t dt = (g_iota >> 2) & 0x7;\n- uint8_t t = (g_iota >> 11) & 0x1;\n+ bool t = s390_pci_is_translation_enabled(g_iota);\n \n pba &= ~0xfff;\n pal |= 0xfff;\ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex 9228523ce8..eb15cb8b2d 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -390,6 +390,7 @@ int pci_chsc_sei_nt2_get_event(void *res);\n int pci_chsc_sei_nt2_have_event(void);\n void s390_pci_sclp_configure(SCCB *sccb);\n void s390_pci_sclp_deconfigure(SCCB *sccb);\n+bool s390_pci_is_translation_enabled(uint64_t g_iota);\n void s390_pci_iommu_enable(S390PCIIOMMU *iommu);\n void s390_pci_iommu_direct_map_enable(S390PCIIOMMU *iommu);\n void s390_pci_iommu_disable(S390PCIIOMMU *iommu);\n","prefixes":["02/15"]}