{"id":2218791,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2218791/?format=json","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.0/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260401220220.4418-4-andrei.otcheretianski@intel.com>","date":"2026-04-01T22:01:12","name":"[03/71] NAN: Fix memory leak in schedule validation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eda3a16b9079b8ac8448b6fa5d0ded20deaef1ff","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.0/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260401220220.4418-4-andrei.otcheretianski@intel.com/mbox/","series":[{"id":498402,"url":"http://patchwork.ozlabs.org/api/1.0/series/498402/?format=json","date":"2026-04-01T22:01:09","name":"NAN Data Path and Bootstrapping support","version":1,"mbox":"http://patchwork.ozlabs.org/series/498402/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218791/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1tUjClqx;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=MAMhkOYR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmJvR5qMpz1yFv\n\tfor ; Thu, 02 Apr 2026 09:05:23 +1100 (AEDT)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w83gL-0000000G9Wu-2p3F;\n\tWed, 01 Apr 2026 22:05:01 +0000","from mgamail.intel.com ([198.175.65.20])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w83gI-0000000G9Ue-18Xr\n\tfor hostap@lists.infradead.org;\n\tWed, 01 Apr 2026 22:05:00 +0000","from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2026 15:04:57 -0700","from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2026 15:04:56 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=3lpZVli53Lt1E+EZ3JhtMz8WPBFWvrtTK7jtqGjLXa4=; b=1tUjClqxISlErE\n\tJ4zD1zmElL163lzjx6P3kRW3vH9majuPEJGY3Uhka++kvNktmSS931QJz5xfVU65OcN9dIhSaDntd\n\thEXNIPZsQ6jfgAXyt04vuty7jaA7Ps0kbIKQnBX4AX6+UYiv16p5vm7vuC6QCVppjI2gB5fHRaCbx\n\tDcCiG8/YCQfIcpueqBWrNKwhoVmS93DgmQPLYUjnff1M6lHZpcdpWkIM++xmI4lxVctqRln8GddTg\n\tFh5IkqFora3rC3MV8KMxi8Arh8WiYbh+Tu84Ij/8eeDAlBT3uiMuSetPG4qO8gBxrpiIDflmlCKpk\n\tUqv/n+Pm+x9dOjqS3B4A==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775081098; x=1806617098;\n h=from:to:subject:date:message-id:in-reply-to:references:\n mime-version:content-transfer-encoding;\n bh=wlD8eEwa5ZgyhurlCpDjIYRRSaDl7a0M7gLyGoHxI6g=;\n b=MAMhkOYRaYKQK7X0GDIrYv49ObbmdMJWSlwVqyYTSV0XB1HeURnX5WtW\n A6pZNh4iK8DRXAtx1UL3GOYGtxjVijvfH1L8h5Z58M9F50/pY5t6I4P+F\n Jqs/p4PUiyBShOO71EBk2DDLqLVvC7ZcOiAsDG3f7n8ze5VspakVZS56s\n 0NbDfrqzqhN9a7fomVR3ci9DNEfo4cHtD9UxZ5wY2gjMvyrC4KuXRXXrq\n C217M1rE8Xxm3EImSHEeAaEMhZVqHWretSKooSP2159NUYL16R4886Lhf\n fXKMgEhNb0VmIbferZWGA8ffYE6yr/QKJpr7mbcgMXdbTI5zBj3KKG64B\n Q==;"],"X-CSE-ConnectionGUID":["+3GgiWZYSTyMYYID8g4YEA==","4EGuXXVRTgi0Zt6Hyfi/Mw=="],"X-CSE-MsgGUID":["17aJ8WIBT6yxBGSqCyVT1A==","ZOq8kSFxS8Gp3OvHXlxDnQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11746\"; a=\"75851555\"","E=Sophos;i=\"6.23,153,1770624000\";\n d=\"scan'208\";a=\"75851555\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org","Subject":"[PATCH 03/71] NAN: Fix memory leak in schedule validation","Date":"Thu, 2 Apr 2026 01:01:12 +0300","Message-ID":"<20260401220220.4418-4-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260401220220.4418-1-andrei.otcheretianski@intel.com>","References":"<20260401220220.4418-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260401_150458_358440_F88A879F ","X-CRM114-Status":"GOOD ( 10.61 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: The nan_sched_covered_by_avail_entries() function allocates\n memory for sched_entries via nan_sched_entries_to_avail_entries(),\n but fails\n to free it when nan_sched_to_bf() returns NULL. This causes a m [...]\n Content analysis details: (-1.9 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.20 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 1.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in\n sa-trusted.bondedsender.org]\n 1.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in sa-accredit.habeas.com]\n -0.5 DKIMWL_WL_HIGH DKIMwl.org - High trust sender\n 1.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.20 listed in\n bl.score.senderscore.com]","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"The nan_sched_covered_by_avail_entries() function allocates memory for\nsched_entries via nan_sched_entries_to_avail_entries(), but fails to\nfree it when nan_sched_to_bf() returns NULL. This causes a memory leak.\n\nAdd proper cleanup by calling nan_flush_avail_entries() before returning\non error. Also fix the error handling to properly check the return value\nof nan_sched_entries_to_avail_entries().\n\nSigned-off-by: Andrei Otcheretianski \n---\n src/nan/nan_util.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/nan/nan_util.c b/src/nan/nan_util.c\nindex 9c500c8536..2f8121d438 100644\n--- a/src/nan/nan_util.c\n+++ b/src/nan/nan_util.c\n@@ -1285,12 +1285,16 @@ bool nan_sched_covered_by_avail_entries(struct nan_data *nan,\n \t\treturn true;\n \n \tdl_list_init(&sched_entries);\n-\tret = nan_sched_entries_to_avail_entries(nan, &sched_entries,\n-\t\t\t\t\t\t sched, sched_len);\n+\tif (nan_sched_entries_to_avail_entries(nan,\n+\t\t\t\t\t &sched_entries,\n+\t\t\t\t\t sched, sched_len))\n+\t\treturn false;\n \n \tsched_bf = nan_sched_to_bf(nan, &sched_entries, &map_id, &reason);\n-\tif (!sched_bf)\n+\tif (!sched_bf) {\n+\t\tnan_flush_avail_entries(&sched_entries);\n \t\treturn false;\n+\t}\n \n \tnan_flush_avail_entries(&sched_entries);\n \n","prefixes":["03/71"]}