{"id":2218700,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2218700/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260401171927.396672-2-stefanha@redhat.com>","date":"2026-04-01T17:19:25","name":"[1/3] scsi: adjust error_prepend() formatting","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1236326eaa2f529975ab3d12a5df23da36fbe0c5","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/1.0/people/17227/?format=json","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260401171927.396672-2-stefanha@redhat.com/mbox/","series":[{"id":498372,"url":"http://patchwork.ozlabs.org/api/1.0/series/498372/?format=json","date":"2026-04-01T17:19:24","name":"scsi: PR live migration PREEMPT fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/498372/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2218700/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QXGj4tLq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmBb63rV3z1yCp\n\tfor ; Thu, 02 Apr 2026 04:20:50 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w7zEJ-0003Mb-4I; Wed, 01 Apr 2026 13:19:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w7zEF-0003Ix-2t\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:43 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w7zEC-0001In-VI\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 13:19:42 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-jEBZpI1AOlOrabhYHjk-5w-1; Wed,\n 01 Apr 2026 13:19:37 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B6421195608C; Wed, 1 Apr 2026 17:19:35 +0000 (UTC)","from localhost (unknown [10.44.32.12])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7688730001A2; Wed, 1 Apr 2026 17:19:34 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775063980;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=56IhqZsu/XJJ3I4EtYsq1VusSGeD9z30b3U0IZEUjbM=;\n b=QXGj4tLqKr9IrFciSBIT5BKzu4xIqo+S7EAz6R+O0zQm9ND4194k0IVFcj7MELGWkhsVCY\n 2uI/KyCFRYtvd6TAE7nDGyPsQu1MJ7Sse6g9FOhkwhte8jUKSjvFIOQSBJozA677xfrc2V\n R9cba+ryY1gzOgcyBiNSgHl1qy4jfuo=","X-MC-Unique":"jEBZpI1AOlOrabhYHjk-5w-1","X-Mimecast-MFC-AGG-ID":"jEBZpI1AOlOrabhYHjk-5w_1775063975","From":"Stefan Hajnoczi ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini , ,\n qemu-block@nongnu.org, Fam Zheng ,\n Stefan Hajnoczi ","Subject":"[PATCH 1/3] scsi: adjust error_prepend() formatting","Date":"Wed, 1 Apr 2026 13:19:25 -0400","Message-ID":"<20260401171927.396672-2-stefanha@redhat.com>","In-Reply-To":"<20260401171927.396672-1-stefanha@redhat.com>","References":"<20260401171927.396672-1-stefanha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=stefanha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"27","X-Spam_score":"2.7","X-Spam_bar":"++","X-Spam_report":"(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=1, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The error strings will be concatenated so add a separator to make the\ncombined error message easy to read.\n\nSigned-off-by: Stefan Hajnoczi \n---\n hw/scsi/scsi-generic.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c\nindex a2316a5266..b55d068323 100644\n--- a/hw/scsi/scsi-generic.c\n+++ b/hw/scsi/scsi-generic.c\n@@ -439,7 +439,7 @@ static bool scsi_generic_pr_register(SCSIDevice *s, uint64_t key, Error **errp)\n ret = scsi_SG_IO(s->conf.blk, SG_DXFER_TO_DEV, cmd, sizeof(cmd),\n buf, sizeof(buf), s->io_timeout, errp);\n if (ret < 0) {\n- error_prepend(errp, \"PERSISTENT RESERVE OUT with REGISTER\");\n+ error_prepend(errp, \"PERSISTENT RESERVE OUT with REGISTER: \");\n return false;\n }\n return true;\n@@ -463,7 +463,7 @@ static bool scsi_generic_pr_preempt(SCSIDevice *s, uint64_t key,\n ret = scsi_SG_IO(s->conf.blk, SG_DXFER_TO_DEV, cmd, sizeof(cmd),\n buf, sizeof(buf), s->io_timeout, errp);\n if (ret < 0) {\n- error_prepend(errp, \"PERSISTENT RESERVE OUT with PREEMPT\");\n+ error_prepend(errp, \"PERSISTENT RESERVE OUT with PREEMPT: \");\n return false;\n }\n return true;\n","prefixes":["1/3"]}