{"id":2205806,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2205806/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260305194329.1470084-1-vsementsov@yandex-team.ru>","date":"2026-03-05T19:43:29","name":"[13/12,v3] net/tap: check that user tries to define zero queues","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a464096b4fc13738b82b106ffc985ff43b79c1ad","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.0/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260305194329.1470084-1-vsementsov@yandex-team.ru/mbox/","series":[{"id":492602,"url":"http://patchwork.ozlabs.org/api/1.0/series/492602/?format=json","date":"2026-02-18T20:28:20","name":"net: refactoring and fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/492602/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2205806/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=EQR8fDpt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fRg376jwyz1xw1\n\tfor ; Fri, 06 Mar 2026 06:44:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vyEbl-0004zU-JI; Thu, 05 Mar 2026 14:43:41 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vyEbj-0004z8-FT\n for qemu-devel@nongnu.org; Thu, 05 Mar 2026 14:43:39 -0500","from forwardcorp1a.mail.yandex.net ([178.154.239.72])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vyEbh-0001yd-LW\n for qemu-devel@nongnu.org; Thu, 05 Mar 2026 14:43:39 -0500","from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:a189:0:640:4da6:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 69346C01EF;\n Thu, 05 Mar 2026 22:43:33 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:b93::1:1])\n by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VhvFMN0A1Cg0-a7Ib3pOl; Thu, 05 Mar 2026 22:43:32 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1772739812;\n bh=87dUWNkHcTPzQRSbWhPCiEzsPvmojygUsu9xACani3Q=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=EQR8fDptTWODqUoVP4iTOX1IHkV7dbdA34I0Yl1g/HoR/50XGoZ2g+rNcfD1qKZ3Y\n 6tJ7652EqySusz90HLEEt9njuZNRCHnJTdkUojDe7OVhzk3fBBL94u2mI45so2rFrp\n 0PjDpFm7J9UUYiv9E93aHPRVG3HqoTcOkVoNyPt0=","From":"Vladimir Sementsov-Ogievskiy ","To":"jasowang@redhat.com","Cc":"qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru","Subject":"[PATCH 13/12 v3] net/tap: check that user tries to define zero queues","Date":"Thu, 5 Mar 2026 22:43:29 +0300","Message-ID":"<20260305194329.1470084-1-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","References":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.72;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-5","X-Spam_score":"-0.6","X-Spam_bar":"/","X-Spam_report":"(-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.892, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.622,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add check for queues parameter to be non-zero, and for fd/fds\nparameters to be non-empty.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n net/tap.c | 4 ++++\n net/util.c | 5 +++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/net/tap.c b/net/tap.c\nindex 1623ddff5fb..383e158d5e2 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -807,6 +807,10 @@ static int tap_parse_fds_and_queues(const NetdevTapOptions *tap, int **fds,\n error_setg(errp, \"queues exceeds maximum %d\", INT_MAX);\n return -1;\n }\n+ if (tap->queues == 0) {\n+ error_setg(errp, \"queues must be greater than zero\");\n+ return -1;\n+ }\n queues = tap->queues;\n *fds = NULL;\n } else if (tap->fd || tap->fds) {\ndiff --git a/net/util.c b/net/util.c\nindex 1998a6554e0..8265f155484 100644\n--- a/net/util.c\n+++ b/net/util.c\n@@ -94,6 +94,11 @@ int net_parse_fds(const char *fds_param, int **fds, int expected_nfds,\n return -1;\n }\n \n+ if (nfds == 0) {\n+ error_setg(errp, \"no fds passed\");\n+ return -1;\n+ }\n+\n *fds = g_new(int, nfds);\n \n for (i = 0; i < nfds; i++) {\n","prefixes":["13/12","v3"]}