{"id":2198417,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198417/?format=json","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.0/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219202514.5781-20-andrei.otcheretianski@intel.com>","date":"2026-02-19T20:24:35","name":"[19/58] NAN: Add support for building schedule related attributes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6db1cc144e8a72c655e6d3c308e8314ac7774275","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.0/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260219202514.5781-20-andrei.otcheretianski@intel.com/mbox/","series":[{"id":492721,"url":"http://patchwork.ozlabs.org/api/1.0/series/492721/?format=json","date":"2026-02-19T20:24:21","name":"NAN: Add NAN Data Path (NDP) support","version":1,"mbox":"http://patchwork.ozlabs.org/series/492721/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198417/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PzEXUglC;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=R+/Ae7qn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH4g424QYz1xpY\n\tfor ; Fri, 20 Feb 2026 07:27:12 +1100 (AEDT)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAbh-0000000Bwzz-1L0T;\n\tThu, 19 Feb 2026 20:26:41 +0000","from mgamail.intel.com ([198.175.65.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAbR-0000000BwCB-2OTN\n\tfor hostap@lists.infradead.org;\n\tThu, 19 Feb 2026 20:26:34 +0000","from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:26 -0800","from aotchere-mobl1.ger.corp.intel.com (HELO\n aotchere-mobl1.intel.com) ([10.245.246.171])\n by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:22 -0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=sweSEzy6ShGgTcrDth0NbgwmcttuTLmdDnS+5jWrr94=; b=PzEXUglCmlwZ/e\n\tmGPNJG8HvV1PPkElzyWr6krDWM/NcyY1NNxRtSSL0RdQLqSpiKNGy2x7BZwEZP0VQlyPRC7F47lnB\n\tQICDvGNj4+3cZSF/yz9vU+WRuwsI1uHRZK2SiJL6Lmqc0jAd9J7biCzwI3WFjaE1K2t+5sbLvRcex\n\tjY54jXpGjL9dFKBdl7wTXXT1cMlKCy14dbLfOYCHe4Y3Y6xNjQG2s9bDzj+9dUHoRBAUvM+CetER4\n\t5e+h+HObWW3yC8cLS7seR30N2zQHHYVjg+MIeW0IPusmFvqo2T0eDxW7zeV3l3k5z3VYEHg/q9vsP\n\tvdJMIPuCNn6/GPFT0UEQ==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771532786; x=1803068786;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ZPZlmIkQFh0xL7QfTjVN/rFw1DY3SKSRkp3FL9uFEVI=;\n b=R+/Ae7qnKMV/Hz6CfbH8/DJs+MMLLbIVFqEQ6gE3F0Vr8FXz5fb8CJS0\n B1nNIjYUfELbN6IJyAo0MW0ZR/xyXP2GcEB+T+tSMRwYHm19Q0whPvxiJ\n EcFQAe+ZsthDS19WH9gXFQET+AKemHxFhVarWju290L5bF7abGy+8M7SS\n kzVX/GQmKPvSh+oePysemM3HYkXabGFbUmj4uuqxTGvX6CP8D8WfvOOuE\n mE4Pj0l3AyxX8cREeZGht4PnZeLd1WpFiCZb1B5jqKc/STGBo8DrD/4wd\n 9SGGesAHhw7bgDEmJbNTHDmLtovS1Pd8rHd/M39QcUYJ98i6XDgWal/QV\n w==;"],"X-CSE-ConnectionGUID":["za4jPpdeT5unCtPPotkbwQ==","Pc2z0chqSZWY8Eox4GP30A=="],"X-CSE-MsgGUID":["LRKvPeXyQAS1N4nDdi3/uA==","WdtjMQqxTjumbdRddkroGw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11706\"; a=\"90040001\"","E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"90040001\"","E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"219153819\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org,\n\tvamsin@qti.qualcomm.com,\n\tvganneva@qti.qualcomm.com,\n\tmaheshkkv@google.com","Cc":"Ilan Peer ","Subject":"[PATCH 19/58] NAN: Add support for building schedule related\n attributes","Date":"Thu, 19 Feb 2026 22:24:35 +0200","Message-ID":"<20260219202514.5781-20-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219202514.5781-1-andrei.otcheretianski@intel.com>","References":"<20260219202514.5781-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260219_122625_816149_796C8938 ","X-CRM114-Status":"GOOD ( 16.07 )","X-Spam-Score":"-4.4 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer Add support for\n building\n the NDL,\n NDC and QoS attributes. Signed-off-by: Ilan Peer \n --- src/nan/nan_i.h | 9 +++ src/nan/nan_ndl.c | 198\n ++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 207 insertions(+)\n Content analysis details: (-4.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.10 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n sa-trusted.bondedsender.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n bl.score.senderscore.com]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Ilan Peer \n\nAdd support for building the NDL, NDC and QoS attributes.\n\nSigned-off-by: Ilan Peer \n---\n src/nan/nan_i.h | 9 +++\n src/nan/nan_ndl.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 207 insertions(+)","diff":"diff --git a/src/nan/nan_i.h b/src/nan/nan_i.h\nindex a2ac279636..7548e380a9 100644\n--- a/src/nan/nan_i.h\n+++ b/src/nan/nan_i.h\n@@ -415,6 +415,15 @@ void nan_ndl_setup_failure(struct nan_data *nan, struct nan_peer *peer,\n void nan_ndl_reset(struct nan_data *nan, struct nan_peer *peer);\n int nan_ndl_handle_ndl_attr(struct nan_data *nan, struct nan_peer *peer,\n \t\t\t struct nan_msg *msg);\n+int nan_ndl_add_ndl_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf);\n+int nan_ndl_add_ndc_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf);\n+int nan_ndl_add_qos_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf);\n int nan_chan_to_chan_idx_map(struct nan_data *nan,\n \t\t\t u8 op_class, u8 channel, u16 *chan_idx_map);\n #endif /* NAN_I_H */\ndiff --git a/src/nan/nan_ndl.c b/src/nan/nan_ndl.c\nindex 0337ac97a6..d14f6bef21 100644\n--- a/src/nan/nan_ndl.c\n+++ b/src/nan/nan_ndl.c\n@@ -878,3 +878,201 @@ int nan_ndl_handle_ndl_attr(struct nan_data *nan, struct nan_peer *peer,\n \t\treturn -1;\n \t}\n }\n+\n+\n+/*\n+ * nan_ndl_add_ndl_attr - Add NDL attribute to frame\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @peer: NAN peer for NDL establishment\n+ * @buf: Frame buffer to which the attribute would be added\n+ *\n+ * Returns: 0 on success, negative on failure.\n+ */\n+int nan_ndl_add_ndl_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf)\n+{\n+\tstruct nan_ndl *ndl;\n+\tu16 ndl_ctrl;\n+\tu8 type;\n+\n+\tif (!peer || !peer->ndl)\n+\t\treturn -1;\n+\n+\tndl = peer->ndl;\n+\tndl_ctrl = 0;\n+\n+\twpa_printf(MSG_DEBUG, \"NAN: add NDL attribute. state=%s, status=%u\",\n+\t\t nan_ndl_state_str(ndl->state), ndl->status);\n+\n+\tswitch (ndl->state) {\n+\tcase NAN_NDL_STATE_NONE:\n+\tcase NAN_NDL_STATE_REQ_SENT:\n+\tcase NAN_NDL_STATE_RES_SENT:\n+\tcase NAN_NDL_STATE_CON_SENT:\n+\tdefault:\n+\t\treturn -1;\n+\tcase NAN_NDL_STATE_START:\n+\t\ttype = NAN_NDL_TYPE_REQUEST;\n+\t\tif (ndl->sched.ndc.len)\n+\t\t\tndl_ctrl |= NAN_NDL_CTRL_NDC_ATTR_PRESENT;\n+\t\tbreak;\n+\tcase NAN_NDL_STATE_REQ_RECV:\n+\t\ttype = NAN_NDL_TYPE_RESPONSE;\n+\t\tif (ndl->sched.ndc.len &&\n+\t\t ndl->status != NAN_NDL_STATUS_REJECTED)\n+\t\t\tndl_ctrl |= NAN_NDL_CTRL_NDC_ATTR_PRESENT;\n+\t\tbreak;\n+\tcase NAN_NDL_STATE_RES_RECV:\n+\t\ttype = NAN_NDL_TYPE_CONFIRM;\n+\t\tif (ndl->sched.ndc.len &&\n+\t\t ndl->status != NAN_NDL_STATUS_REJECTED)\n+\t\t\tndl_ctrl |= NAN_NDL_CTRL_NDC_ATTR_PRESENT;\n+\t\tbreak;\n+\tcase NAN_NDL_STATE_DONE:\n+\t\twpa_printf(MSG_DEBUG,\n+\t\t\t \"NAN: NDL: done. Not adding NDL attribute\");\n+\t\treturn 0;\n+\t}\n+\n+\t/* QoS attribute is going to be added */\n+\tif (ndl->local_qos.max_latency != NAN_QOS_MAX_LATENCY_NO_PREF ||\n+\t ndl->local_qos.min_slots != NAN_QOS_MIN_SLOTS_NO_PREF)\n+\t\tndl_ctrl |= NAN_NDL_CTRL_NDL_QOS_ATTR_PRESENT;\n+\n+\twpabuf_put_u8(buf, NAN_ATTR_NDL);\n+\twpabuf_put_le16(buf, sizeof(struct ieee80211_ndl));\n+\n+\twpabuf_put_u8(buf, ndl->dialog_token);\n+\twpabuf_put_u8(buf, type |\n+\t\t (ndl->status << NAN_NDL_STATUS_POS));\n+\twpabuf_put_u8(buf, ndl->reason);\n+\twpabuf_put_u8(buf, ndl_ctrl);\n+\n+\treturn 0;\n+}\n+\n+\n+/*\n+ * nan_ndl_add_ndc_attr - Add NDC attribute to frame\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @peer: NAN peer for NDL establishment\n+ * @buf: Frame buffer to which the attribute would be added\n+ * Returns: 0 on success, negative on failure.\n+ */\n+int nan_ndl_add_ndc_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf)\n+{\n+\tstruct nan_ndl *ndl;\n+\tu8 ndc_ctrl = NAN_NDC_CTRL_SELECTED;\n+\tu16 sched_entry_ctrl = 0;\n+\n+\tif (!peer || !peer->ndl)\n+\t\treturn -1;\n+\n+\tndl = peer->ndl;\n+\n+\tif (ndl->state != NAN_NDL_STATE_START &&\n+\t ndl->state != NAN_NDL_STATE_REQ_RECV &&\n+\t ndl->state != NAN_NDL_STATE_RES_RECV)\n+\t\treturn 0;\n+\n+\twpa_printf(MSG_DEBUG, \"NAN: Add NDC attribute. state=%s, status=%u\",\n+\t\t nan_ndl_state_str(ndl->state), ndl->status);\n+\n+\t/* NDC attribute is optional in case of reject */\n+\tif (ndl->status == NAN_NDL_STATUS_REJECTED)\n+\t\treturn 0;\n+\n+\t/*\n+\t * NDC attribute for NDP Request is optional. In all other cases it is\n+\t * mandatory\n+\t */\n+\tif (!ndl->sched.ndc.len) {\n+\t\tif (ndl->state != NAN_NDL_STATE_START) {\n+\t\t\twpa_printf(MSG_DEBUG, \"NAN: NDL: no NDC to add\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\treturn 0;\n+\t}\n+\n+\twpabuf_put_u8(buf, NAN_ATTR_NDC);\n+\twpabuf_put_le16(buf, (sizeof(struct ieee80211_ndc) +\n+\t\t\t sizeof(struct nan_sched_entry) +\n+\t\t\t ndl->sched.ndc.len));\n+\n+\twpabuf_put_data(buf, ndl->ndc_id, sizeof(ndl->ndc_id));\n+\twpabuf_put_u8(buf, ndc_ctrl);\n+\n+\t/* add the schedule entry */\n+\twpabuf_put_u8(buf, ndl->sched.ndc_map_id);\n+\n+\tsched_entry_ctrl |= ndl->sched.ndc.duration <<\n+\t\tNAN_TIME_BM_CTRL_BIT_DURATION_POS;\n+\tsched_entry_ctrl |= ndl->sched.ndc.period <<\n+\t\tNAN_TIME_BM_CTRL_PERIOD_POS;\n+\tsched_entry_ctrl |= ndl->sched.ndc.offset <<\n+\t\tNAN_TIME_BM_CTRL_START_OFFSET_POS;\n+\n+\twpabuf_put_le16(buf, sched_entry_ctrl);\n+\twpabuf_put_u8(buf, ndl->sched.ndc.len);\n+\n+\t/* add the bitmap */\n+\twpabuf_put_data(buf, ndl->sched.ndc.bitmap, ndl->sched.ndc.len);\n+\n+\treturn 0;\n+}\n+\n+\n+/*\n+ * nan_ndl_add_qos_attr - Add QOS attribute to frame\n+ *\n+ * @nan: NAN module context from nan_init()\n+ * @peer: NAN peer for NDL establishment\n+ * @buf: Frame buffer to which the attribute would be added\n+ * Returns: 0 on success, negative on failure.\n+ */\n+int nan_ndl_add_qos_attr(struct nan_data *nan,\n+\t\t\t const struct nan_peer *peer,\n+\t\t\t struct wpabuf *buf)\n+{\n+\tstruct nan_ndl *ndl;\n+\n+\tif (!peer || !peer->ndl)\n+\t\treturn -1;\n+\n+\tndl = peer->ndl;\n+\n+\twpa_printf(MSG_DEBUG, \"NAN: Add QoS attribute. state=%s, status=%u\",\n+\t\t nan_ndl_state_str(ndl->state), ndl->status);\n+\n+\tswitch (ndl->state) {\n+\tcase NAN_NDL_STATE_START:\n+\tcase NAN_NDL_STATE_REQ_RECV:\n+\tcase NAN_NDL_STATE_RES_RECV:\n+\t\tbreak;\n+\tcase NAN_NDL_STATE_NONE:\n+\tcase NAN_NDL_STATE_REQ_SENT:\n+\tcase NAN_NDL_STATE_RES_SENT:\n+\tcase NAN_NDL_STATE_CON_SENT:\n+\tcase NAN_NDL_STATE_CON_RECV:\n+\tcase NAN_NDL_STATE_DONE:\n+\tdefault:\n+\t\treturn 0;\n+\t}\n+\n+\tif (ndl->local_qos.max_latency == NAN_QOS_MAX_LATENCY_NO_PREF &&\n+\t ndl->local_qos.min_slots == NAN_QOS_MIN_SLOTS_NO_PREF)\n+\t\treturn 0;\n+\n+\twpabuf_put_u8(buf, NAN_ATTR_NDL_QOS);\n+\twpabuf_put_le16(buf, sizeof(struct ieee80211_nan_qos));\n+\twpabuf_put_u8(buf, ndl->local_qos.min_slots);\n+\twpabuf_put_le16(buf, ndl->local_qos.max_latency);\n+\n+\treturn 0;\n+}\n","prefixes":["19/58"]}