{"id":2198414,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198414/?format=json","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.0/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219202514.5781-17-andrei.otcheretianski@intel.com>","date":"2026-02-19T20:24:32","name":"[16/58] utils: Add few more functions to bitfield module","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"79b4df7da13f6a56d3e72a61c1a2db52d5baef82","submitter":{"id":62065,"url":"http://patchwork.ozlabs.org/api/1.0/people/62065/?format=json","name":"Andrei Otcheretianski","email":"andrei.otcheretianski@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20260219202514.5781-17-andrei.otcheretianski@intel.com/mbox/","series":[{"id":492721,"url":"http://patchwork.ozlabs.org/api/1.0/series/492721/?format=json","date":"2026-02-19T20:24:21","name":"NAN: Add NAN Data Path (NDP) support","version":1,"mbox":"http://patchwork.ozlabs.org/series/492721/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198414/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cjRGe54h;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=E995G/qW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH4fY44nLz1xpY\n\tfor ; Fri, 20 Feb 2026 07:26:45 +1100 (AEDT)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAbL-0000000BwU7-1Fkx;\n\tThu, 19 Feb 2026 20:26:19 +0000","from mgamail.intel.com ([198.175.65.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1vtAbJ-0000000BwCB-0qIZ\n\tfor hostap@lists.infradead.org;\n\tThu, 19 Feb 2026 20:26:18 +0000","from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:17 -0800","from aotchere-mobl1.ger.corp.intel.com (HELO\n aotchere-mobl1.intel.com) ([10.245.246.171])\n by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2026 12:26:14 -0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LV8vd9t/1mETwwkk89Wk5ncEwRAlLEggvsrpv5vzeVA=; b=cjRGe54htuPimx\n\tm1tViovmiltTcx1qNfwH2kMlYuYWC2bvFMr8XifHkgVucUFmY3bAbhDg9O+yGhk01NMHTbPdHEaJO\n\tABJilTMcAcOIFmRpH91S8UE2ju8/ltlFOm70xHDbPuyNRkAIT/jhqlzMEzuR1hJZ0NEwHouuROCS4\n\tzv7lVFDH8CoSLK84S9bzECMNCMWJU6lSeurLTYDL/NBWe5Y4zqK9AVqUHX+w42NMzmVjjM+593qJn\n\tlF85Uy15uZ05x0ElZPaxK+Goz1Ba070EYSzVphFQM9cm3qK7m0KTj/20IZEsOlVNWXLBxboEJpeKj\n\tpScPGbPwBdxwcVP6jtLA==;","v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1771532778; x=1803068778;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=dU3sndQDz9F4MPbmX/qRnseZbLwXWTENQ3KhHiMYa7U=;\n b=E995G/qW7fBYJdO+j0fESfWaaQ7vr8qpVkgxkRAnWtOlcJopEL0BAPLP\n I1WwXGyWgijK8lPjDnmFbtyDD5tdPEs0HKOs9qyM4wDMNO1TLK6IlYG+2\n q6YYAiLSOEz3ZyHeDrb2HawZohHU+YD7/DGrwI7NHbe3f+MhUomuLOZ5t\n fCOTZf3K2/cQbHihjdaCEITwaIKwI1hdXnOr8bLb5AWjbmYX8mMUjOVOw\n I02qe9CalYBbBUbDM1a3+BXu9Bcr7JTAk99yPlfVyZ5stmQKysJicSf5u\n j/sDZf1bH6wXH5KvWpc7RMttTk6h/GDJpWPlbeXfejcq10utG0cqJwAQK\n Q==;"],"X-CSE-ConnectionGUID":["8r6YAmmzTeyic4xQRMT6+w==","bmbtYjl5SIa654nmyVx/Dw=="],"X-CSE-MsgGUID":["pJNAvBUeQIakgIbxnLND3A==","bEBpc0OUQbebYxoVA+CTXg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11706\"; a=\"90039983\"","E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"90039983\"","E=Sophos;i=\"6.21,300,1763452800\";\n d=\"scan'208\";a=\"219153796\""],"X-ExtLoop1":"1","From":"Andrei Otcheretianski ","To":"hostap@lists.infradead.org,\n\tvamsin@qti.qualcomm.com,\n\tvganneva@qti.qualcomm.com,\n\tmaheshkkv@google.com","Cc":"Ilan Peer ","Subject":"[PATCH 16/58] utils: Add few more functions to bitfield module","Date":"Thu, 19 Feb 2026 22:24:32 +0200","Message-ID":"<20260219202514.5781-17-andrei.otcheretianski@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219202514.5781-1-andrei.otcheretianski@intel.com>","References":"<20260219202514.5781-1-andrei.otcheretianski@intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260219_122617_317649_380115DF ","X-CRM114-Status":"GOOD ( 18.42 )","X-Spam-Score":"-4.4 (----)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer These would be used\n by the NAN logic. Signed-off-by: Ilan Peer ---\n src/utils/bitfield.c\n | 158 +++++++++++++++++++++++++++++++++ src/utils/bitfield.h | 12 +++\n src/utils/utils_module_tests.c\n | 75 +++++++++++++++- 3 fil [...]\n Content analysis details: (-4.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.10 listed in list.dnswl.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [198.175.65.10 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"From: Ilan Peer \n\nThese would be used by the NAN logic.\n\nSigned-off-by: Ilan Peer \n---\n src/utils/bitfield.c | 158 +++++++++++++++++++++++++++++++++\n src/utils/bitfield.h | 12 +++\n src/utils/utils_module_tests.c | 75 +++++++++++++++-\n 3 files changed, 244 insertions(+), 1 deletion(-)","diff":"diff --git a/src/utils/bitfield.c b/src/utils/bitfield.c\nindex 8dcec3907e..d10936070a 100644\n--- a/src/utils/bitfield.c\n+++ b/src/utils/bitfield.c\n@@ -87,3 +87,161 @@ int bitfield_get_first_zero(struct bitfield *bf)\n \t\treturn -1;\n \treturn i;\n }\n+\n+\n+struct bitfield * bitfield_alloc_data(const u8 *data, size_t len)\n+{\n+\tstruct bitfield *bf;\n+\n+\tbf = os_zalloc(sizeof(*bf) + len);\n+\tif (!bf)\n+\t\treturn NULL;\n+\n+\tbf->bits = (u8 *)(bf + 1);\n+\tos_memcpy(bf->bits, data, len);\n+\n+\tbf->max_bits = len * 8;\n+\treturn bf;\n+}\n+\n+\n+struct bitfield * bitfield_dup(const struct bitfield *orig)\n+{\n+\tstruct bitfield *bf;\n+\n+\tif (!orig)\n+\t\treturn NULL;\n+\n+\tbf = os_memdup(orig,\n+\t\t sizeof(*orig) + (orig->max_bits + 7) / 8);\n+\tif (!bf)\n+\t\treturn NULL;\n+\n+\tbf->bits = (u8 *)(bf + 1);\n+\n+\treturn bf;\n+}\n+\n+\n+int bitfield_union_in_place(struct bitfield *a, const struct bitfield *b)\n+{\n+\tsize_t i, upper;\n+\n+\tif (!a || !b || a->max_bits < b->max_bits)\n+\t\treturn -1;\n+\n+\tupper = (b->max_bits + 7) / 8;\n+\n+\tfor (i = 0 ; i < upper; i++)\n+\t\ta->bits[i] |= b->bits[i];\n+\n+\treturn 0;\n+}\n+\n+\n+struct bitfield * bitfield_union(const struct bitfield *a,\n+\t\t\t\t const struct bitfield *b)\n+{\n+\tstruct bitfield *res;\n+\tint ret;\n+\n+\tif (!a || !b)\n+\t\treturn NULL;\n+\n+\tif (a->max_bits > b->max_bits) {\n+\t\tres = bitfield_dup(a);\n+\t\tret = bitfield_union_in_place(res, b);\n+\t} else {\n+\t\tres = bitfield_dup(b);\n+\t\tret = bitfield_union_in_place(res, a);\n+\t}\n+\n+\tif (!ret)\n+\t\treturn res;\n+\n+\tos_free(res);\n+\treturn NULL;\n+}\n+\n+\n+int bitfield_intersect_in_place(struct bitfield *a,\n+\t\t\t\tconst struct bitfield *b)\n+{\n+\tsize_t i, upper;\n+\n+\tif (!a || !b)\n+\t\treturn -1;\n+\n+\tif (a->max_bits < b->max_bits)\n+\t\tupper = (a->max_bits + 7) / 8;\n+\telse\n+\t\tupper = (b->max_bits + 7) / 8;\n+\n+\n+\tfor (i = 0 ; i < upper; i++)\n+\t\ta->bits[i] &= b->bits[i];\n+\n+\tupper = (a->max_bits + 7) / 8;\n+\tfor (; i < upper; i++)\n+\t\ta->bits[i] = 0;\n+\n+\treturn 0;\n+}\n+\n+\n+int bitfield_is_subset(const struct bitfield *a, struct bitfield *b)\n+{\n+\tsize_t i, upper;\n+\n+\tif (!a || !b)\n+\t\treturn -1;\n+\n+\tif (a->max_bits < b->max_bits)\n+\t\treturn 0;\n+\n+\tupper = (b->max_bits + 7) / 8;\n+\n+\tfor (i = 0; i < upper; i++) {\n+\t\tu8 res = a->bits[i] & b->bits[i];\n+\n+\t\tif (res != b->bits[i])\n+\t\t\treturn 0;\n+\t}\n+\n+\treturn 1;\n+}\n+\n+\n+size_t bitfield_size(const struct bitfield *bf)\n+{\n+\tif (!bf)\n+\t\treturn 0;\n+\treturn bf->max_bits;\n+}\n+\n+\n+int bitfield_intersects(const struct bitfield *a, const struct bitfield *b)\n+{\n+\tsize_t i, upper;\n+\n+\tif (!a || !b)\n+\t\treturn -1;\n+\n+\tif (a->max_bits < b->max_bits)\n+\t\tupper = (a->max_bits + 7) / 8;\n+\telse\n+\t\tupper = (b->max_bits + 7) / 8;\n+\n+\tfor (i = 0; i < upper; i++)\n+\t\tif (a->bits[i] & b->bits[i])\n+\t\t\treturn 1;\n+\n+\treturn 0;\n+}\n+\n+\n+void bitfield_dump(struct bitfield *bf, const char *title)\n+{\n+\twpa_printf(MSG_DEBUG, \"bitfield: %s: max_bits=%zu\", title, bf->max_bits);\n+\twpa_hexdump(MSG_DEBUG, \"bits: \", bf->bits, bf->max_bits / 8);\n+}\ndiff --git a/src/utils/bitfield.h b/src/utils/bitfield.h\nindex 7050a208c8..5b805773d2 100644\n--- a/src/utils/bitfield.h\n+++ b/src/utils/bitfield.h\n@@ -9,6 +9,8 @@\n #ifndef BITFIELD_H\n #define BITFIELD_H\n \n+#include \"utils/common.h\"\n+\n struct bitfield;\n \n struct bitfield * bitfield_alloc(size_t max_bits);\n@@ -18,4 +20,14 @@ void bitfield_clear(struct bitfield *bf, size_t bit);\n int bitfield_is_set(struct bitfield *bf, size_t bit);\n int bitfield_get_first_zero(struct bitfield *bf);\n \n+struct bitfield * bitfield_alloc_data(const u8 *data, size_t len);\n+struct bitfield * bitfield_dup(const struct bitfield *orig);\n+int bitfield_union_in_place(struct bitfield *a, const struct bitfield *b);\n+struct bitfield * bitfield_union(const struct bitfield *a,\n+\t\t\t\t const struct bitfield *b);\n+int bitfield_intersect_in_place(struct bitfield *a, const struct bitfield *b);\n+int bitfield_is_subset(const struct bitfield *a, struct bitfield *b);\n+size_t bitfield_size(const struct bitfield *bf);\n+int bitfield_intersects(const struct bitfield *a, const struct bitfield *b);\n+void bitfield_dump(struct bitfield *bf, const char *title);\n #endif /* BITFIELD_H */\ndiff --git a/src/utils/utils_module_tests.c b/src/utils/utils_module_tests.c\nindex 365f21fb11..58343f86d7 100644\n--- a/src/utils/utils_module_tests.c\n+++ b/src/utils/utils_module_tests.c\n@@ -127,10 +127,13 @@ static int printf_encode_decode_tests(void)\n \n static int bitfield_tests(void)\n {\n-\tstruct bitfield *bf;\n+\tstruct bitfield *bf, *bf_a = NULL, *bf_b = NULL, *bf_c = NULL;\n \tint i;\n \tint errors = 0;\n \n+\tu8 data_a[4] = {0xff, 0x3f, 0x01, 0xf0};\n+\tu8 data_b[4] = {0xff, 0xc0, 0xfe, 0x0f};\n+\n \twpa_printf(MSG_INFO, \"bitfield tests\");\n \n \tbf = bitfield_alloc(123);\n@@ -210,6 +213,76 @@ static int bitfield_tests(void)\n \t\terrors++;\n \tbitfield_free(bf);\n \n+\tbf_a = bitfield_alloc_data(data_a, sizeof(data_a));\n+\tif (!bf_a)\n+\t\tgoto fail;\n+\n+\tbf_b = bitfield_alloc_data(data_b, sizeof(data_b));\n+\tif (!bf_b)\n+\t\tgoto fail;\n+\n+\tbf_c = bitfield_dup(bf_a);\n+\tif (!bf_c)\n+\t\tgoto fail;\n+\n+\t/* test intersection */\n+\tif (bitfield_intersect_in_place(bf_c, bf_b))\n+\t\tgoto fail;\n+\n+\tfor (i = 0; i < 8; i++)\n+\t\tif (!bitfield_is_set(bf_c, i))\n+\t\t\tgoto fail;\n+\n+\tfor (; i < 32; i++)\n+\t\tif (bitfield_is_set(bf_c, i))\n+\t\t\tgoto fail;\n+\n+\tbitfield_free(bf_c);\n+\n+\t/* test union */\n+\tbf_c = bitfield_union(bf_a, bf_b);\n+\tif (!bf_c)\n+\t\tgoto fail;\n+\n+\tif (!bitfield_intersects(bf_a, bf_c) ||\n+\t !bitfield_intersects(bf_b, bf_c) ||\n+\t !bitfield_intersects(bf_c, bf_a) ||\n+\t !bitfield_intersects(bf_c, bf_b) ||\n+\t !bitfield_intersects(bf_a, bf_b))\n+\t\tgoto fail;\n+\n+\tfor (i = 0; i < 32; i++)\n+\t\tif (!bitfield_is_set(bf_c, i))\n+\t\t\tgoto fail;\n+\n+\tif (!bitfield_is_subset(bf_c, bf_a) ||\n+\t !bitfield_is_subset(bf_c, bf_b) ||\n+\t bitfield_is_subset(bf_a, bf_c) ||\n+\t bitfield_is_subset(bf_b, bf_c) ||\n+\t bitfield_is_subset(bf_a, bf_b))\n+\t\tgoto fail;\n+\n+\t/* test in place union */\n+\tif (bitfield_union_in_place(bf_a, bf_b))\n+\t\tgoto fail;\n+\n+\tif (bitfield_size(bf_a) != 32 ||\n+\t bitfield_size(bf_b) != 32 ||\n+\t bitfield_size(bf_c) != 32)\n+\t\tgoto fail;\n+\n+\tfor (i = 0; i < 32; i++)\n+\t\tif (!bitfield_is_set(bf_c, i))\n+\t\t\tgoto fail;\n+\tgoto out;\n+\n+fail:\n+\terrors++;\n+out:\n+\tbitfield_free(bf_a);\n+\tbitfield_free(bf_c);\n+\tbitfield_free(bf_b);\n+\n \tif (errors) {\n \t\twpa_printf(MSG_ERROR, \"%d bitfield test(s) failed\", errors);\n \t\treturn -1;\n","prefixes":["16/58"]}