{"id":2198384,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198384/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-38-philmd@linaro.org>","date":"2026-02-19T19:19:39","name":"[v2,37/50] gdbstub/helpers: Convert gdb_get_regl() macro to inlined helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dadb37a4c34b8d6e9e3e756cdbd1f6970e3c7dc2","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-38-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198384/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FlAdcjEA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3Py6xKRz1xvS\n\tfor ; Fri, 20 Feb 2026 06:30:46 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9e1-0001hd-4g; Thu, 19 Feb 2026 14:25:01 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9dS-0000BR-DU\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:24:27 -0500","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9dQ-0000FJ-3f\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:24:25 -0500","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso22520505e9.0\n for ; Thu, 19 Feb 2026 11:24:23 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-483a31bac27sm23936975e9.5.2026.02.19.11.24.20\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:24:21 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771529062; x=1772133862; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OjVXShC1NZd4A4MSPAW7OCNU5rjrdaDfYPCeoCtFstk=;\n b=FlAdcjEA0vfUIpd/UL1/1VGWoAE46rcP0UvKkb2YhnXGL6znuadQsHhlYXh6vl3gS7\n 5YX8O8xMlUz9Q3Q7Dtf29JIzy2hjbJdrFl36Xh8vrRcse9PBcNjFQ380uElXns3MZuJN\n CrIuxKiwSMqREcMbVxUV2hMscp2xwDzWMpkwEO3r6g2phm+r6mk5Xyn5S95A+SOwG3SL\n DQzLFU6XNJWvFk+WchVe0gdmMR4lb19Ryf8qrINGurvcTuqu1qztE8L5d5/vn0etU59x\n DFVu0SDI66OHprWyw+idTArA/+wmPrrtkcxpozTuBq3S5WwqdZmvpaAu4VF46VBfY16x\n wygA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771529062; x=1772133862;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=OjVXShC1NZd4A4MSPAW7OCNU5rjrdaDfYPCeoCtFstk=;\n b=iDc2JJk8UbrIU8xeTCcQnuAYK24lKSUcFrR3PQXtFUqfrtcMgD9W7LcssWFcW/HqMH\n eiRkwlbYxJf5ql5n9x8XS3iaQAoi18A90x5OxI44t6kP8BVQn8rSpE9gDXboGKlYTh+3\n ywpHJ/foxn/CuzqlwAu27v9Bgin/wzMKYGNKZilfiNbG5CEKHksfklDHK64r2AtVK+HG\n zHA0bRL5XVN35CoXehljgqugupDd0aqf55tmqDc9QnKsWsb2KOQ0teZZN10Pp282bXgL\n 9waktH53fXdf1VTLSA4U1XPLZajwz9raQHuscBxADUp0GtD42oaHEArMJgDc8t9KF4BZ\n rDEg==","X-Gm-Message-State":"AOJu0YzBpb3wlDBS2oYVaBPUfsO0NYD5EsiU8+1maw/d/YsBHNEF7Se8\n tkOtsYQnvLZrqaLO4RTgYzVeQwxEEgmKqCA/HayIKxvoS+mPUYWYDICQv3W69XcCtdD+CjDkKup\n Vfv861GTYQQ==","X-Gm-Gg":"AZuq6aIsWvFVEervSZP2f7BEJrdYvGbCYknbpO5iAileAXTGejCWcShIsy+Oi1SYoAY\n zlvSvNWeTsqHJKkohWJ83pjoZU9QCeZ8Myt6tFABZQu0r7yvZA6nXvBL5yX9u2c75q9kJ4egc0Q\n rxtiO71h1S8wZZBWLHQaXNSt26PqPKygFhRctZE2tKmSx3lBswPp/FJJ4mMPKqxVMMJ3O7b/o0h\n NQmEb9kPbStYWfDCrXu1xfxuNf9rfQ6HSoAb817sZKhB9rA+o9nF+CZJLE4/X6KCbtCS9dk7vby\n C1G9Q6y0jxIG9h5Rot3pIfAb0YSLfyhP7T+7qVRhDdLmbS1DexNiQjXrxQzF/FoEZuluhyTfBJe\n PL98JclAYwbRGVx9npXHKvvSJVk8W2JbcqEzaS40mrhQg2Lbf02R5i7jUe3lR7sB0Kn2R48wLKA\n 4qXt19I8cob5GrwqKIEgG77bC+HxPwlsD5nnQYtJZE3dYsTTmzOrTzOMuobvheskxyzw9jUx2j","X-Received":"by 2002:a05:600c:468d:b0:477:9890:9ab8 with SMTP id\n 5b1f17b1804b1-4839fe96a50mr54337215e9.3.1771529062085;\n Thu, 19 Feb 2026 11:24:22 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 37/50] gdbstub/helpers: Convert gdb_get_regl() macro to\n inlined helper","Date":"Thu, 19 Feb 2026 20:19:39 +0100","Message-ID":"<20260219191955.83815-38-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Rather than checking TARGET_LONG_BITS at build time,\ncheck target_long_bits() at runtime.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n include/gdbstub/helpers.h | 22 ++++++++++++++--------\n 1 file changed, 14 insertions(+), 8 deletions(-)","diff":"diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h\nindex 402514716d7..b2f41d6d280 100644\n--- a/include/gdbstub/helpers.h\n+++ b/include/gdbstub/helpers.h\n@@ -88,6 +88,20 @@ static inline int gdb_get_zeroes(GByteArray *array, size_t len)\n return len;\n }\n \n+/**\n+ * gdb_get_regl: append @val in @buf using 32 or 64-bit, depending on target\n+ *\n+ * This function is legacy and deprecated, thus should not be used in new code.\n+ */\n+static inline int gdb_get_regl(GByteArray *buf, uint64_t val)\n+{\n+ if (target_long_bits() == 64) {\n+ return gdb_get_reg64(buf, val);\n+ } else {\n+ return gdb_get_reg32(buf, val);\n+ }\n+}\n+\n /**\n * gdb_get_reg_ptr: get pointer to start of last element\n * @len: length of element\n@@ -101,12 +115,4 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, int len)\n return buf->data + buf->len - len;\n }\n \n-#ifdef COMPILING_PER_TARGET\n-#if TARGET_LONG_BITS == 64\n-#define gdb_get_regl(buf, val) gdb_get_reg64(buf, val)\n-#else\n-#define gdb_get_regl(buf, val) gdb_get_reg32(buf, val)\n-#endif\n-#endif /* COMPILING_PER_TARGET */\n-\n #endif /* _GDBSTUB_HELPERS_H_ */\n","prefixes":["v2","37/50"]}