{"id":2198357,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198357/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-22-philmd@linaro.org>","date":"2026-02-19T19:19:23","name":"[v2,21/50] target/ppc: Extract monitor-related code to monitor.c","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d22b38187b26963a79c7a1f22b7e774c8432f82f","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-22-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198357/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EHFCV6cu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3M03xVhz1xpY\n\tfor ; Fri, 20 Feb 2026 06:28:12 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9cv-0006m3-D1; Thu, 19 Feb 2026 14:23:53 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9bh-0003BP-4H\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:22:39 -0500","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9bc-0008EF-Im\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:22:35 -0500","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-4837907f535so12131935e9.3\n for ; Thu, 19 Feb 2026 11:22:29 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-483a31d3ebbsm19849735e9.13.2026.02.19.11.22.27\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:22:27 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528948; x=1772133748; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H6kLOb5sf0oiOLXCKzf8ybfs57Z7nX4EwutnQcKt5Kc=;\n b=EHFCV6cupYgzCkdP0o96oG1NlGLHQk5dzjt4LQbjc0jhun8JlGKifZrTPaK3zHloaT\n GCexnzpPY6jwVlCtz5RW4Hs2N6tMFs8cG6geq8/mbFpeO/K7J0l1S5u8zMuN2WJwXAML\n k2Gy6Oo7xl+w6hqqo0trB+i/cVhG+dZRS4E59xHVdExXZrs1CmvPAqRPxU/QoOFvdI1G\n 3ifmVw+m96V2XXnk9iJcaLlFQK1vMJzVKv9Uosqp7M/SmklfLF7OqraUY6W4Ya1EAUah\n z7KaZpQL6MZMMfaGSbl5d0+GkLC+Cxs5CLjjOxW9RR8/E29t5hKL5euANAj7890ch80A\n uUlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528948; x=1772133748;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=H6kLOb5sf0oiOLXCKzf8ybfs57Z7nX4EwutnQcKt5Kc=;\n b=Flvbvk8NnN1G88N5KJPuEcGLu/uE4klPDzfbJfXD7Dy53u7YmTPkG1UTzSZlwHLmrN\n K80WXnA22k+oU51x5yhdUVy4IDHI6NRgmI+hYw/xcxuJ8azdgGjK7EpElgX1dq08V7+e\n e6JUaG9TZ44BYgLdNHybll5dV3K5FABsHZjf+cvZeZnWkFW8/7NLsiQmI/myS0UpWES0\n rdg1QejncuV0qhqDXvGXRQ7eFrca04k4pTdZiQltKnp1QQBwdLyb2bktnKEsBZ55pVLC\n C016EVSPpOXcVQ05+GraLBUVnFdMow6+EkIZEFuSWgbeFVI6KgKHOaUmnxuoO9rQJs4m\n 1a1w==","X-Gm-Message-State":"AOJu0YwUjhUu4dfABhb2iupuCZ/Naq+mxfwEuyyadn12O3ZgKr7Ho/gQ\n C6lUtzDBRR3LiJYIwl8hXJYeW/WHGuo+dIxyXK9HExXZQ/M6sbzHygmzmohDHpuqRTshzvmuWtY\n B3Wl0eVpaQw==","X-Gm-Gg":"AZuq6aLGFWVQtMRrIfXQdH2GZZ43cDXo4pd35AZWDclpk/pWx4UUzml+kOKAr9a8qNH\n 9AkR7zZVdyv+ojL65H8gIn9Ulhh8d/i1ohElArQMEt55WJoSsyWcMujG9LLTOhB0f9s4WpfOj6T\n zwAyNG/JhephDqO651GM/X1TxXhpmvAcfhr06Db+O6F8+0YEFF3PH1GorYMYMTLpSI2fcEYZZ5m\n heqjZcj73sivA9S4XwwjBP59ikxv6mG9Wk6neRl2Hu5Zo+FTjyj87vyDDJVPnfMaEOUWaeZ8BPJ\n //md6kv5EqE2lOZa/lHirRNEIEGUMpSfTZ+kc754/Ag45CW5/jj28crQWlPvX4SoZEE3aT2sBfd\n q69KS711wP67iceUE2RzlYOHr6UuUoJ6uJkGv/ObluemhaXTtjvOibsWqaEJDr60XtjgpD/mkve\n 606wZZrBhijUKAFH09BxMFN5Nw23t6YBXIUdnOwBh+UMqROJVYQRIeRTelTpwppem1gY9XXfDm","X-Received":"by 2002:a05:600c:8709:b0:480:1c53:2085 with SMTP id\n 5b1f17b1804b1-48379bd731emr310092395e9.19.1771528948321;\n Thu, 19 Feb 2026 11:22:28 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Nicholas Piggin , Chinmay Rath ","Subject":"[PATCH v2 21/50] target/ppc: Extract monitor-related code to\n monitor.c","Date":"Thu, 19 Feb 2026 20:19:23 +0100","Message-ID":"<20260219191955.83815-22-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Keep ppc-qmp-cmds.c for QMP, use monitor.c for HMP.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/ppc/monitor.c | 41 +++++++++++++++++++++++++++++++++++++++\n target/ppc/ppc-qmp-cmds.c | 16 +--------------\n target/ppc/meson.build | 1 +\n 3 files changed, 43 insertions(+), 15 deletions(-)\n create mode 100644 target/ppc/monitor.c","diff":"diff --git a/target/ppc/monitor.c b/target/ppc/monitor.c\nnew file mode 100644\nindex 00000000000..46c49e96236\n--- /dev/null\n+++ b/target/ppc/monitor.c\n@@ -0,0 +1,41 @@\n+/*\n+ * QEMU PPC (monitor definitions)\n+ *\n+ * Copyright (c) 2003-2004 Fabrice Bellard\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qemu/ctype.h\"\n+#include \"monitor/monitor.h\"\n+#include \"monitor/hmp-target.h\"\n+#include \"monitor/hmp.h\"\n+#include \"cpu.h\"\n+\n+void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n+{\n+ CPUArchState *env1 = mon_get_cpu_env(mon);\n+\n+ if (!env1) {\n+ monitor_printf(mon, \"No CPU available\\n\");\n+ return;\n+ }\n+ dump_mmu(env1);\n+}\ndiff --git a/target/ppc/ppc-qmp-cmds.c b/target/ppc/ppc-qmp-cmds.c\nindex 66c3bcb2c38..96228919966 100644\n--- a/target/ppc/ppc-qmp-cmds.c\n+++ b/target/ppc/ppc-qmp-cmds.c\n@@ -1,5 +1,5 @@\n /*\n- * QEMU PPC (monitor definitions)\n+ * QEMU PPC (QMP definitions)\n *\n * Copyright (c) 2003-2004 Fabrice Bellard\n *\n@@ -24,26 +24,12 @@\n \n #include \"qemu/osdep.h\"\n #include \"cpu.h\"\n-#include \"monitor/monitor.h\"\n #include \"qemu/ctype.h\"\n-#include \"monitor/hmp-target.h\"\n-#include \"monitor/hmp.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-machine.h\"\n #include \"cpu-models.h\"\n #include \"cpu-qom.h\"\n \n-void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n-{\n- CPUArchState *env1 = mon_get_cpu_env(mon);\n-\n- if (!env1) {\n- monitor_printf(mon, \"No CPU available\\n\");\n- return;\n- }\n- dump_mmu(env1);\n-}\n-\n CpuModelExpansionInfo *\n qmp_query_cpu_model_expansion(CpuModelExpansionType type,\n CpuModelInfo *model,\ndiff --git a/target/ppc/meson.build b/target/ppc/meson.build\nindex b0d708bb519..d4ebbaf0a19 100644\n--- a/target/ppc/meson.build\n+++ b/target/ppc/meson.build\n@@ -43,6 +43,7 @@ ppc_system_ss.add(files(\n 'mmu-hash32.c',\n 'mmu-booke.c',\n 'mmu_common.c',\n+ 'monitor.c',\n 'ppc-qmp-cmds.c',\n ))\n ppc_system_ss.add(when: 'CONFIG_TCG', if_true: files(\n","prefixes":["v2","21/50"]}