{"id":2198349,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198349/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-25-philmd@linaro.org>","date":"2026-02-19T19:19:26","name":"[v2,24/50] target/sparc: Factor sparc_cpu_gdb_write_register() out","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"faf122cb337cebaf981ae081bbe8a3462b1266ac","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-25-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198349/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=DtKQqISS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3L43f0Nz1xpY\n\tfor ; Fri, 20 Feb 2026 06:27:24 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9cx-00074h-9o; Thu, 19 Feb 2026 14:23:55 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9bz-0003lA-Rr\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:03 -0500","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9bv-0008M8-EC\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:22:54 -0500","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so14359155e9.3\n for ; Thu, 19 Feb 2026 11:22:51 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-483a31b3e0dsm35954695e9.1.2026.02.19.11.22.48\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:22:49 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528970; x=1772133770; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Gp2sKwAqzwE1qDhhmH0nRCkz7CQKwljiKEsZ2Elj5KY=;\n b=DtKQqISSQ2V8qQT7eQjTVVxBS9f0AAGSos87trXNG+f44L/fv8ZguCLMhFAL297Dom\n F83NBGOUG0Fol4jr1lSUKVMQCWT2esGLCsmdA9SRGTuy26WLr9Yg8jCE3OWq0zANoh+2\n i+P4SpE6prxXSEccy6DBaPctot8un1eXtXXuYxSeqbG/exCJlSIRlvFwkmuC/Or2xSg1\n AeU87Bkml0gqdmaH0ddcZ0Ktkh+nwI9CCXmOS8W8yQr3m8YHKOhFJ4JiEp0THNC+QAPP\n 0qKyc9eeZww8yD/u4Jk29+JtPcEeFt1OOQA67EDcIk3VPSm1j7LVYIfgF6VrWtggwaC/\n rwog==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528970; x=1772133770;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Gp2sKwAqzwE1qDhhmH0nRCkz7CQKwljiKEsZ2Elj5KY=;\n b=blplmzT1GJ283agYp44oFXtoeIa/aOH5GdRYyzn1pl+mCa750WbBXgg5B7t1ClweGM\n fkdfc1ETe69PPRE4xQxp3SNMGuDt1OJYunEbXvLUtD06Tj7CJsTTSsXFnah6YCpbJ/jN\n Ie2FwHEoWUc72R47upZm9HBkxCt/BdEx6D88jHvOr7m97dSGHxLgHzzTtmtPCNqqj4qJ\n VBsAutxUp/Hl0gziGiWP/IKGWQDptpymvqyubI/ebNGOsNpWTiGoQ9yS77T0Gsj4HyfW\n RZy7Qba4cmlyBZQv3QLt77AQoCgXWZepkw+w4HZnZ4fVlWdehWbfPGgPxMaz9KiOovsI\n MRXA==","X-Gm-Message-State":"AOJu0YySFU3TL0z4pqHn0COEKhBKlJdG71284BpN9BaIldWqyAiK4S61\n KUtxY3IYgDUHf2gnNv9cHBJgqftLAzPvQU/8RZaGF4WGI9xu8Q4I877wUHheqFtN7MztJE7eSFp\n CmdZKwHl9Iw==","X-Gm-Gg":"AZuq6aI0cpC4DNUKx64vmP6ee2cluTqC10c2c0ZFcjMPFWVQeA0GxkhOpOEGYzQz0m8\n MqSwtEIjO+ya6flVrmmpD76v5NokmgogBY3Sb4v85uOJ0SGO864APgifV5T1sck3ab+27LU4EOf\n Xma+qvfGtGzMiRskkh3ASr4ayl29lOFJZcXHBWZzNCaH748YBqmnfm1V2KSb5tbp8jibKjf1xM2\n XNaoYwR6mk5bkQbXauNliQu7SzRBFx8NmlsFyaa3gbuD88lUvq8cI4TkSHjgZivZqDJTqIknKB6\n 3sLnrnMrwOtzKrJAwKKS/SXzcDtqi8RKNqxx54nVg5Cjz+C54QUZt7lpNBRDXVCUM9p+vSi7Raz\n mIbMPdMYmrGBWA4WeXGU6t0PMrJjYlK4AmXtKye+gPo94EWMqHW82KWyuvJwrMHpaE09F5fd36m\n 672uxjJlpbIm4pD2d+raXz/PsFSh/ynUshLgaoMPwwmFNwhojHS7F2KyvHuQqx0KlXpegELh6x","X-Received":"by 2002:a05:600c:3e87:b0:480:32da:f338 with SMTP id\n 5b1f17b1804b1-48373a0f961mr360858765e9.14.1771528969670;\n Thu, 19 Feb 2026 11:22:49 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Mark Cave-Ayland ,\n Artyom Tarasenko ","Subject":"[PATCH v2 24/50] target/sparc: Factor sparc_cpu_gdb_write_register()\n out","Date":"Thu, 19 Feb 2026 20:19:26 +0100","Message-ID":"<20260219191955.83815-25-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Factor sparc_cpu_gdb_write_register() out.\n\nPrefer ldn_p(target_long_bits/8) over target-specific ldtul_p().\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/sparc/gdbstub.c | 27 +++++++++++++--------------\n 1 file changed, 13 insertions(+), 14 deletions(-)","diff":"diff --git a/target/sparc/gdbstub.c b/target/sparc/gdbstub.c\nindex ed52e521dcc..d19819cd1a9 100644\n--- a/target/sparc/gdbstub.c\n+++ b/target/sparc/gdbstub.c\n@@ -124,19 +124,22 @@ static int sparc_cp0_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)\n return 0;\n }\n \n+static unsigned sparc_gdb_register_bytes(void)\n+{\n+#ifdef CONFIG_USER_ONLY\n+# if defined(TARGET_ABI32)\n+ return 4;\n+# endif\n+#endif\n+ return target_long_bits() / 8;\n+}\n+\n int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n {\n SPARCCPU *cpu = SPARC_CPU(cs);\n CPUSPARCState *env = &cpu->env;\n-#if defined(TARGET_ABI32)\n- uint32_t tmp;\n-\n- tmp = ldl_p(mem_buf);\n-#else\n- target_ulong tmp;\n-\n- tmp = ldtul_p(mem_buf);\n-#endif\n+ const unsigned regsz = sparc_gdb_register_bytes();\n+ uint64_t tmp = ldn_p(mem_buf, regsz);\n \n if (n < 8) {\n /* g0..g7 */\n@@ -145,11 +148,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n /* register window */\n env->regwptr[n - 8] = tmp;\n }\n-#if defined(TARGET_ABI32) || !defined(TARGET_SPARC64)\n- return 4;\n-#else\n- return 8;\n-#endif\n+ return regsz;\n }\n \n static int sparc_fpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n","prefixes":["v2","24/50"]}