{"id":2198348,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198348/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-26-philmd@linaro.org>","date":"2026-02-19T19:19:27","name":"[v2,25/50] target/ppc: Replace ldtul_p() -> ldn_p()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7f9ce6806a0568b1908499d6db40e32ca6ea1caa","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-26-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198348/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hKcflSHz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3Kw1qZSz1xpY\n\tfor ; Fri, 20 Feb 2026 06:27:16 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9d3-0007o7-96; Thu, 19 Feb 2026 14:24:03 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9c9-0003yR-Eb\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:10 -0500","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9c2-0008NV-Ix\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:03 -0500","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-48329eb96a7so7834605e9.3\n for ; Thu, 19 Feb 2026 11:22:58 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac9d77sm46266122f8f.33.2026.02.19.11.22.55\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:22:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528977; x=1772133777; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6UPVpAvrQsTFqtfqwhbhR6gBAqs95Qv+GAT25RJhMX0=;\n b=hKcflSHzukkf6iCYmdaxU5g2iCA0SAca8w5EjEPzpy8azKSPhvFUFTacuJGqQ3Un7f\n rjChQKu1sgMacImslBTnhZVdTI5vi5vF+K8oq/6CLbl+lAX4Pzv0ROhOXNmMtUy6hoMV\n MD/DtsyQLf8/h7PuHWp2AEApInujJBG+N91PEGAdUNI6UuflG4znFRRxJZn159GglaJg\n 1Dq2xIF/pHHZF2feyNOZxlf45JTbwlcW0oHoIAiiAYyiuGIWIblkbgDUfsLhW3/fh9Uv\n uAH78umd50V6q2aQIo9+YQuST7j2PM/d56a3I5JBrWleKnjQCvbTAfl0G3yOB6TXiRCr\n htCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528977; x=1772133777;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6UPVpAvrQsTFqtfqwhbhR6gBAqs95Qv+GAT25RJhMX0=;\n b=U0I8clpMW0hntSCRTll8oCuCKBaElRKLz+iNHI6QYDSwmLe17/sYphpre3i0YurrO+\n PZFzmX6HYdj4Q5CoxeDAX0VqeAVx1Skd9zp9YG0lLq3hclu5Lc47rtpA8MUkHkYtfVwW\n Lvk2ERskUWRi3xKum8xX5xtz56WW2hcPnF015gGGt81oYjOHiolvIOSqd2fRJ5889CzE\n wLW0h+qNsQ19iH8duk+ud2dS74DD9W24t2GDD3MPO4BfQkQlh6lj+9kH9U1yMk2aTh35\n EC0XKUrNmwsOUcIuMZa2Cx8nxwHrla/B4uI4lR5QiObTJOqbrHm47FUY5PtQ3sDX3BLY\n /tJA==","X-Gm-Message-State":"AOJu0YynBAKHV3oyl5AuxqtptxNEjJ9soM5uBAv8RamD8ixq0vhypL13\n uD8X/Z6E672f/VzYPZIo6PWnH1VwidLfJZM9b1utZUuqKLwgh24C92arXFgHC/fDlwOxTJtNX7i\n IoauhkbndBA==","X-Gm-Gg":"AZuq6aKz/yAD/A7e4oiNKiwQPE1a+gglgc64QSrODqblE95lNi4IGcJncX0Kwx+CHqN\n CIuGua55Hennl2/Itz9+zoEPmCpfmoYZLs/qOaxuhsriM/ljLXdWmiLc3okaKJO0ZIqGqhRx1+v\n JOzN4hdzE5w4JVNMWFaQGq8WBS2zeO/Xub+5QR5qwKxSMjMVKlMrW5lzuj7s+29XNyzFBcl093c\n BQ8zz8StvuQGs+gPpeBX3YB8EQ05raSOWP+pQ3lfbYq1KubgAkLokUHGDcFCjylInrKHC26mWxt\n lMtiZhnjOz2KkgM/Sfh5gPS/FFRZH0rEkcjdkyfRtevy0RG+PpObZYmZ9OUS06qrx0QC5NszyMW\n yGzPuVOOWVbOf1OyzrA02n3x4P1dRK9m6+m21q/0xDGHnsG4IFteGZDYT5xOYS7Nr3J7ZeoWiML\n 7RjHZCuQXyeyk1goCgcTz2Xt89Q9IqhnwcP7wiGh8sWtcpim/dgkMafqi8ImRz2d8pgMftGa1j","X-Received":"by 2002:a05:600c:6091:b0:477:df7:b020 with SMTP id\n 5b1f17b1804b1-4839e661d1bmr69464275e9.18.1771528976854;\n Thu, 19 Feb 2026 11:22:56 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Nicholas Piggin , Chinmay Rath ","Subject":"[PATCH v2 25/50] target/ppc: Replace ldtul_p() -> ldn_p()","Date":"Thu, 19 Feb 2026 20:19:27 +0100","Message-ID":"<20260219191955.83815-26-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Prefer ldn_p(target_long_bits/8) over target-specific ldtul_p().\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/ppc/gdbstub.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c\nindex ece1e5c9bd7..e0aae9c9eaf 100644\n--- a/target/ppc/gdbstub.c\n+++ b/target/ppc/gdbstub.c\n@@ -23,12 +23,12 @@\n #include \"gdbstub/helpers.h\"\n #include \"internal.h\"\n \n-static int ppc_gdb_register_len(int n)\n+static unsigned ppc_gdb_register_len(int n)\n {\n switch (n) {\n case 0 ... 31:\n /* gprs */\n- return sizeof(target_ulong);\n+ return target_long_bits() / 8;\n case 66:\n /* cr */\n case 69:\n@@ -42,7 +42,7 @@ static int ppc_gdb_register_len(int n)\n /* lr */\n case 68:\n /* ctr */\n- return sizeof(target_ulong);\n+ return target_long_bits() / 8;\n default:\n return 0;\n }\n@@ -85,7 +85,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n)\n {\n CPUPPCState *env = cpu_env(cs);\n uint8_t *mem_buf;\n- int r = ppc_gdb_register_len(n);\n+ unsigned r = ppc_gdb_register_len(n);\n \n if (!r) {\n return r;\n@@ -127,7 +127,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n)\n int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n {\n CPUPPCState *env = cpu_env(cs);\n- int r = ppc_gdb_register_len(n);\n+ unsigned r = ppc_gdb_register_len(n);\n \n if (!r) {\n return r;\n@@ -135,17 +135,17 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n ppc_maybe_bswap_register(env, mem_buf, r);\n if (n < 32) {\n /* gprs */\n- env->gpr[n] = ldtul_p(mem_buf);\n+ env->gpr[n] = ldn_p(mem_buf, r);\n } else if (n < 64) {\n /* fprs */\n *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf);\n } else {\n switch (n) {\n case 64:\n- env->nip = ldtul_p(mem_buf);\n+ env->nip = ldn_p(mem_buf, r);\n break;\n case 65:\n- ppc_store_msr(env, ldtul_p(mem_buf));\n+ ppc_store_msr(env, ldn_p(mem_buf, r));\n break;\n case 66:\n {\n@@ -154,17 +154,17 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n break;\n }\n case 67:\n- env->lr = ldtul_p(mem_buf);\n+ env->lr = ldn_p(mem_buf, r);\n break;\n case 68:\n- env->ctr = ldtul_p(mem_buf);\n+ env->ctr = ldn_p(mem_buf, r);\n break;\n case 69:\n cpu_write_xer(env, ldl_p(mem_buf));\n break;\n case 70:\n /* fpscr */\n- ppc_store_fpscr(env, ldtul_p(mem_buf));\n+ ppc_store_fpscr(env, ldn_p(mem_buf, r));\n break;\n }\n }\n","prefixes":["v2","25/50"]}