{"id":2198332,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198332/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-31-philmd@linaro.org>","date":"2026-02-19T19:19:32","name":"[v2,30/50] target/i386: Expand 64-bit definitions when TARGET_LONG_BITS == 64","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"79a03524afcb3989364ed72bbd13edae38c31491","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-31-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198332/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IcwkkuTB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3HP2K1Mz1xpY\n\tfor ; Fri, 20 Feb 2026 06:25:02 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9cw-0006uv-GD; Thu, 19 Feb 2026 14:23:54 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9ce-0005Y6-Jh\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:36 -0500","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9cc-0008VC-N7\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:23:36 -0500","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-48375f1defeso9550955e9.0\n for ; Thu, 19 Feb 2026 11:23:34 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac8209sm51744567f8f.30.2026.02.19.11.23.31\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:23:32 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771529013; x=1772133813; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ORxZRk5GfpOpGN2karLQcvtsyotrG6XvafLw6XoTvc0=;\n b=IcwkkuTBphib60DwL8NMvlxJYaPwnmp1SjoxW5UL+wzm7AAqI4npRrlSR3KWN2vR7N\n sc0N7Anen7mcg6DZ5az/YfTA/gSzmXX5TpO5YcpJfaCylD04PwFsu/3AAE46PKCQQ5EY\n utEXTZax+/jZ3I1+EroD/ud7iekp9mKRQzBUcKaHcURANS1WwyAp5T6kTbzgc0ZJGO6N\n GoiYf4KnFon8O1qmM5c0nYesxli1vvXPlgfcWQODyMpA3riQIx2EBLhVwxE7J9wsQvUH\n ywhXAwTk0gCWiXIQ7aGAnZ47H+Lyk8/wXk1/oC1htZ8OENQHmL6WcGxioD/OUzrgMa6J\n W3Ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771529013; x=1772133813;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ORxZRk5GfpOpGN2karLQcvtsyotrG6XvafLw6XoTvc0=;\n b=o1KKYfmNQWkQgQEf6T0hpgmdtOHke6nGeaCL1tbrvuezZobBE9XNKG8iSS/3FGPa8v\n V7kyoCXAu9AUfzEzqwuocRkEiGMCfdClfhz1Ompn22eTj1ct0YvAviBA959Ljn1/hyPV\n b32nNh6d6OfXfmD5/9DUjYeM0cSUDDypNskiityPaghtmrAjqxLmEa5Vc9lTbqvfQtw/\n +53z6NDp6VcDbY8uHlW/KMMWeXo0eUc7ImOaUCVC2gDhR5IebEkYjqjC47bPow/ZG91S\n OhbErwaCdJT+SNT3hxFjc4MfV7NEQux1vfwSN7K0/ydksj4pXKwAi/P5u1X+WvvuIZ8M\n Vjuw==","X-Gm-Message-State":"AOJu0YwtTTwcAjbR50Ru5jzrF/nOA0kparKSqZLFBq/NzEXJNmnSDpKc\n Y4JRvfRGbFDqREzHe/S3iJTu6LklD2EiYFRMx+K+FabUw46QZgOHzzUYLaHtIhF7fuuz+Qoz9eE\n 1MirvNL87gw==","X-Gm-Gg":"AZuq6aKrF67cw288mIiPRss4l09jmOpuBIwim3Kf3XO81G5Xw+SRnw05ohCPhE7MmNA\n V7d/Djt2kg14QnASw6ItWjOf1XO8BWvwZH7JrPilQO6/R5uof3RPTH8jNq2k9RJxw1gjbip7lwg\n rZ6sJGs+Mc1+WdAuU1c50GjKue2u4SB4Fi5sCwEGX7ALQNmA4o4Y2yUh7urhwCuWITDDa05/7zb\n UZbcN02GWAMhIVU4Hr5VnKa7pezrLyQTdSHL685jxSaB3p4t4XYegEOYnhfSyc3IDphihfWTUri\n CVxU0+H3Xiwp7jrnse14+XR6F17INvqJxRtvRoxRjdzB0QvRJAL7kChKaYpmYWosvzQF84xe31m\n I+W2ajbm/jjBYKtoBpXyExJxcobou8+dbVnuBVXXuENmEbkK1UkCBCJNsl4dOH61mY1PenwtCVE\n ec3kkQcanl3dsydNvGlX8dcfeC5wK4/RZcm1/PHsHYyRKP+PrJaU9huKRNxNUCdTGHZjuBY/N8","X-Received":"by 2002:a05:6000:2dca:b0:436:1a23:3949 with SMTP id\n ffacd0b85a97d-43958df369dmr14018313f8f.10.1771529012724;\n Thu, 19 Feb 2026 11:23:32 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Paolo Bonzini , Zhao Liu ","Subject":"[PATCH v2 30/50] target/i386: Expand 64-bit definitions when\n TARGET_LONG_BITS == 64","Date":"Thu, 19 Feb 2026 20:19:32 +0100","Message-ID":"<20260219191955.83815-31-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Where both gdb_read/write_register() functions check for\n'TARGET_LONG_BITS == 64' we can expand the following definitions:\n\n ldtul_p() -> ldq_p()\n\n gdb_get_regl() -> gdb_get_reg64()\n\nDo the same in i386_cpu_gdb_get_egprs(): check TARGET_LONG_BITS to\neffectively inline gdb_get_regl().\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/i386/gdbstub.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c\nindex f358bcf9e86..f1ce90a046e 100644\n--- a/target/i386/gdbstub.c\n+++ b/target/i386/gdbstub.c\n@@ -129,7 +129,7 @@ int x86_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)\n return gdb_get_reg64(mem_buf,\n env->regs[gpr_map[n]] & 0xffffffffUL);\n } else {\n- return gdb_get_regl(mem_buf, 0);\n+ return gdb_get_reg64(mem_buf, 0);\n }\n } else {\n return gdb_get_reg32(mem_buf, env->regs[gpr_map32[n]]);\n@@ -283,9 +283,9 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n if (n < CPU_NB_REGS) {\n if (TARGET_LONG_BITS == 64) {\n if (env->hflags & HF_CS64_MASK) {\n- env->regs[gpr_map[n]] = ldtul_p(mem_buf);\n+ env->regs[gpr_map[n]] = ldq_p(mem_buf);\n } else if (n < CPU_NB_REGS32) {\n- env->regs[gpr_map[n]] = ldtul_p(mem_buf) & 0xffffffffUL;\n+ env->regs[gpr_map[n]] = ldq_p(mem_buf) & 0xffffffffUL;\n }\n return sizeof(target_ulong);\n } else if (n < CPU_NB_REGS32) {\n@@ -449,8 +449,10 @@ static int i386_cpu_gdb_get_egprs(CPUState *cs, GByteArray *mem_buf, int n)\n /* EGPRs can be only directly accessible in 64-bit mode. */\n if (env->hflags & HF_CS64_MASK) {\n return gdb_get_reg64(mem_buf, env->regs[gpr_map[n + CPU_NB_REGS]]);\n+ } else if (TARGET_LONG_BITS == 64) {\n+ return gdb_get_reg64(mem_buf, 0);\n } else {\n- return gdb_get_regl(mem_buf, 0);\n+ return gdb_get_reg32(mem_buf, 0);\n }\n }\n \n","prefixes":["v2","30/50"]}