{"id":2198307,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198307/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-4-philmd@linaro.org>","date":"2026-02-19T19:19:05","name":"[v2,03/50] target/i386: Inline GDB_FORCE_64 definition","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bcc23387a5edac129c5c8e3762929a748afee20a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-4-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198307/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=INBBwybj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3FR1qYDz1xpl\n\tfor ; Fri, 20 Feb 2026 06:23:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9Za-00082o-GS; Thu, 19 Feb 2026 14:20:26 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9ZW-00081e-Na\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:20:22 -0500","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9ZV-0007cF-6T\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:20:22 -0500","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-483770e0b25so13860145e9.0\n for ; Thu, 19 Feb 2026 11:20:20 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a5ac92sm50716590f8f.1.2026.02.19.11.20.18\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:20:19 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528819; x=1772133619; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4DW4Sqm9now/2mzpdS1Uy9RLM6aBUgmF2xVJR1NJyKY=;\n b=INBBwybjbwHpzc+OOmqCtwBF7fF6llODMVjohz1lA5dIJrWEIDYECO2Ll7FMa6lpwm\n n55Zyvi8/dXZfipiq2z0z/aDMX1ooSbhEyEwp3akBt3+ehZfQUY6sxLIEcULSNo19cH9\n qaR450+rPP+kZaWoqZv0bZI/8kbAJuyBOT/M6Qd4wakF7Ts3Zb5t2Ip3Or2mHASO718c\n 6ahJYo7Kn1kqqVOSEauAWS9QLwuLY4iFUUREvNOnkHn91XTQhelWswxv+rHnnPFCN/0Z\n JKp9X0Umbnw2rhiESBuhOtEjVqEe+3YZn0llGcMVtV8H4XKsJJtnEkp4D0lZVAqH0UhF\n 0Chw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528819; x=1772133619;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4DW4Sqm9now/2mzpdS1Uy9RLM6aBUgmF2xVJR1NJyKY=;\n b=vNDrIzlgLBHo4tvGLbHQfgRbHpTrJXzJX2n14Lf8i0nj4MWlC9qO4hzpnG8tZgr+4z\n xGVJ6kIWOaIC5ziTy5NGf093gtNKoQveAB+d84TXLvPT0/RpgLsHaZFmFOH+bqgt1AtP\n MRMu7t1v7EWYfg7C/dj5RwudiZzkHy55GpbO3/Wr8dfW9SdIK/rYdN1N322TBg8Td7a3\n QuNhUcU5orYSZmzKA/Kad5GxD9h0ooSEmFpRr8rd0yVV6GrYwUJ5QwZsvR9gt0oGd/Ee\n 2/pp2oRd7YGI2SusLeXWT5LKcnWOK0wJeRuPq+sxfDPLrIfIlZbXTqqQBlZn89/oHpZY\n 0gkg==","X-Gm-Message-State":"AOJu0Yy/KaA6WySeCIEuWPTt7grAdxCw48SqX25xIRgVpkfbDHqSkRTK\n BTO2P8DqSsWK+n6fwmyhZAajbeC2E2RVfwCPoisO46eCsmSyV5DidUAEB9T14ptZ3xwnBOpMPVU\n h66RaZtH0kg==","X-Gm-Gg":"AZuq6aIdtUVDuduJODJTJ0HKrQtAkts4kb/9vDbn70ORWPf/dXWj//2h4KG6XnHUp6O\n deSUipYqqkuVIxHFzckwJn1N69d2ItV6gknBgfU24OQywY6fXlQmBjnsDFWtgfnBMgOR3CYUxV+\n 29PchpG4YPzOdL4WSZfr+llEdo4W6LAfdtWLg9fpr+y+vqh27mssSwPhvbMeHKjQS/sO4dT6GhT\n xECS7ZgoQ4ji6dR6qJTWMFkseavI5ZHE5OnytSZ3Kz0cJ+UUkmDwgt40zZLJeeoBY6QCLYvwVBq\n VcoONDV9Hm5A8ajYVlfZe1xjOCvCujY1V9yy+NMVnghPA1DUbLx1ateMUR9KLAZult4ajiU93T2\n 7ZCrjASmisH8YGRIVHxrLcz+ddtMUjvRiTNwHcOdlA8R/rfbXODwhPDQKp1hXZjNSmzgAQS3MOi\n kElRche18WuvN/SFfcK63joy/xKyszOtvNCZAkG8kUDWqci5HnoGwNwyW6knmUEs42WuVVE6cS","X-Received":"by 2002:a05:6000:1a8c:b0:435:8f1b:bb32 with SMTP id\n ffacd0b85a97d-43796aefc5cmr44207122f8f.32.1771528819465;\n Thu, 19 Feb 2026 11:20:19 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Paolo Bonzini , Zhao Liu ","Subject":"[PATCH v2 03/50] target/i386: Inline GDB_FORCE_64 definition","Date":"Thu, 19 Feb 2026 20:19:05 +0100","Message-ID":"<20260219191955.83815-4-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Directly checking TARGET_LONG_BITS allows to remove GDB_FORCE_64.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/i386/gdbstub.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c\nindex be41601cffc..291d56b8e13 100644\n--- a/target/i386/gdbstub.c\n+++ b/target/i386/gdbstub.c\n@@ -79,15 +79,9 @@ static const int gpr_map32[8] = { 0, 1, 2, 3, 4, 5, 6, 7 };\n #define IDX_CTL_CR8_REG (IDX_CTL_REGS + 4)\n #define IDX_CTL_EFER_REG (IDX_CTL_REGS + 5)\n \n-#ifdef TARGET_X86_64\n-#define GDB_FORCE_64 1\n-#else\n-#define GDB_FORCE_64 0\n-#endif\n-\n static int gdb_read_reg_cs64(uint32_t hflags, GByteArray *buf, target_ulong val)\n {\n- if ((hflags & HF_CS64_MASK) || GDB_FORCE_64) {\n+ if ((hflags & HF_CS64_MASK) || TARGET_LONG_BITS == 64) {\n return gdb_get_reg64(buf, val);\n }\n return gdb_get_reg32(buf, val);\n","prefixes":["v2","03/50"]}