{"id":2198297,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198297/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219191955.83815-9-philmd@linaro.org>","date":"2026-02-19T19:19:10","name":"[v2,08/50] target/ppc: Remove dead code depending on USE_APPLE_GDB","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a182f3a3b8006b9465c1ef2774b1af074bcbe664","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219191955.83815-9-philmd@linaro.org/mbox/","series":[{"id":492715,"url":"http://patchwork.ozlabs.org/api/1.0/series/492715/?format=json","date":"2026-02-19T19:19:03","name":"gdbstub: Build once on various targets (single-binary)","version":2,"mbox":"http://patchwork.ozlabs.org/series/492715/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198297/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XVmSiaTF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH3CY1T9Wz1xpl\n\tfor ; Fri, 20 Feb 2026 06:21:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt9aA-0008VD-9W; Thu, 19 Feb 2026 14:21:02 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vt9a8-0008Nu-9Q\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:21:00 -0500","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vt9a5-0007n9-F1\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 14:21:00 -0500","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-4376acce52eso833742f8f.1\n for ; Thu, 19 Feb 2026 11:20:57 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796ac8d82sm51683171f8f.31.2026.02.19.11.20.54\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 19 Feb 2026 11:20:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771528856; x=1772133656; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JKMwcn1d5KB8sji6SRmM4mI4+WQ2D8XijU3xMHY5so8=;\n b=XVmSiaTFvo5GkI6Qwz/gn5qVNdLpZ34Ufo/dcmsPzk+jY10ktoGKPWYWJjdfzf2qSS\n 3xqVuny91oDFhpmwbGRuN0AUr1Ut9+2e5lyJkPjsG73kWDq7UTA+YEkURwdDnTzgxTPi\n 0Br66VvBwbOzXaKjoup4TxQX2iIBud4eG4k0cZfl/vqrkBi9f/LzXih11u9qXVW76F++\n KVt3gReNch9SSWuT97mLpP13zPq7pRe+XayzPZAsiD2yuH/cIigAnZoeITkMg/vL6WQT\n Ril9/jL2e8lq5nnbylMLv9pOzhEl/jfZDo7MuGT2QiPB5cQVxrDH+hOZUJQLOet80wsb\n TjeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771528856; x=1772133656;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=JKMwcn1d5KB8sji6SRmM4mI4+WQ2D8XijU3xMHY5so8=;\n b=XMJ92kaqcdOfobB5heMf6QIGCfj0NkQ3+fF90QYam7qNrC8/pbb/LfiKSXzdKjMNk/\n uvF6cLPl4/KvKEOl9EeOoPoZoCAVR81GC6f8YoNBQVRio491EB1Q8HP8W9sVPP66k9Su\n M664nD3HbbXoJboYGiEyzBArslFgiIF8nMTiY6MqynJ54/zQH70KWy+g6tnYldd+GCKT\n fNw0INVyW18nqGH6u64mS6+VZOYEnWKmpj2qgfgBn/UyTifXNIp2r7RyqH2ZXCNH5d2n\n Hx5jtqSh6yBGlfQNtpjLQvHHspyvpkxs/05gSd8Qe1sX71Axd9XftFO+VeZRBRoIPS21\n yoCw==","X-Gm-Message-State":"AOJu0Yy5qW6+Ldldmzev21BDjY50I5kUAVhEh0oZtxEHkPEDxHTA3Iuh\n 5SPrJEm8xNrUXg3YvGFziUvG5hqv3Q64YDx1AfmEvA5XqUVN2rCPM89L+fEIpWgkFrSxtwYxXsu\n /ylzMVV+sSA==","X-Gm-Gg":"AZuq6aIWLVbFSg5iH3stJKpL1vo8aP6Px99/Drcs4X/E5d9p8aM6e4onbEGqXUitE1G\n RsWqOlLrzIKIKVAJBps6SxYzPHiiHPiMkPVanDiN76vV4RzmJmgcefGFaQUwnb4RyHkQJbV6htu\n VXKJAPqKnYT3xCwKNnhIOAovGMIIrLddnjgnWpGJ/AUvq953fDXcwVgyaTRdPdGS3PbqCXrMViE\n E8fHCOzoSccr9xm1YtyWxCc8QvskP8txk54J8vyYDavMhPO5ugsZglbPvr63HVFczAV3zxyPBLM\n dvdSD0FOjxZc/b20vwdmh7spNI6EOvD0gcDWChCGwBto3O5bquNa990rhujAI4uKX5tCTa1lTZu\n 8Ats22l7IBgb4muqgJLd0ev9uPjqwHfCRGAhoN0nHbc5vvY6sJQF2BlLiIFexPC+99qqKvUIMES\n chc0hxDi6/2m2JK1jXCYUkld20Nqffh84Ep1VkIuLTWkBwbhWsVQhMniFc/neZP9Q7kU8fefkNw\n /+NouH5GsE=","X-Received":"by 2002:a05:6000:4022:b0:437:6ca8:3ede with SMTP id\n ffacd0b85a97d-43958e010f5mr11815946f8f.15.1771528855595;\n Thu, 19 Feb 2026 11:20:55 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Richard Henderson , qemu-s390x@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org,\n qemu-ppc@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Nicholas Piggin , Chinmay Rath ","Subject":"[PATCH v2 08/50] target/ppc: Remove dead code depending on\n USE_APPLE_GDB","Date":"Thu, 19 Feb 2026 20:19:10 +0100","Message-ID":"<20260219191955.83815-9-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219191955.83815-1-philmd@linaro.org>","References":"<20260219191955.83815-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We never defined USE_APPLE_GDB, so the code introduced in commit\nb3cad3abf6d (\"PPC: Add support for Apple gdb in gdbstub\") is dead\nsince almost 12 years. Remove it.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/ppc/cpu.h | 2 -\n target/ppc/cpu_init.c | 7 ---\n target/ppc/gdbstub.c | 124 ------------------------------------------\n 3 files changed, 133 deletions(-)","diff":"diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h\nindex 49445eb4ca8..d637a50798f 100644\n--- a/target/ppc/cpu.h\n+++ b/target/ppc/cpu.h\n@@ -1637,9 +1637,7 @@ static inline bool vhyp_cpu_in_nested(PowerPCCPU *cpu)\n \n void ppc_cpu_dump_state(CPUState *cpu, FILE *f, int flags);\n int ppc_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);\n-int ppc_cpu_gdb_read_register_apple(CPUState *cpu, GByteArray *buf, int reg);\n int ppc_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);\n-int ppc_cpu_gdb_write_register_apple(CPUState *cpu, uint8_t *buf, int reg);\n #ifndef CONFIG_USER_ONLY\n hwaddr ppc_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);\n #endif\ndiff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c\nindex 27de8d80204..0b5610d02d5 100644\n--- a/target/ppc/cpu_init.c\n+++ b/target/ppc/cpu_init.c\n@@ -52,7 +52,6 @@\n #endif\n \n #include \"cpu_init.h\"\n-/* #define USE_APPLE_GDB */\n \n static const Property powerpc_cpu_properties[] = {\n DEFINE_PROP_BOOL(\"rtas-stopped-state\", PowerPCCPU,\n@@ -7554,12 +7553,6 @@ static void ppc_cpu_class_init(ObjectClass *oc, const void *data)\n #endif\n \n cc->gdb_num_core_regs = 70;\n-#ifdef USE_APPLE_GDB\n- cc->gdb_read_register = ppc_cpu_gdb_read_register_apple;\n- cc->gdb_write_register = ppc_cpu_gdb_write_register_apple;\n- cc->gdb_num_core_regs = 71 + 32;\n-#endif\n-\n cc->gdb_arch_name = ppc_gdb_arch_name;\n #if defined(TARGET_PPC64)\n cc->gdb_core_xml_file = \"power64-core.xml\";\ndiff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c\nindex b19c0f1ea9c..ece1e5c9bd7 100644\n--- a/target/ppc/gdbstub.c\n+++ b/target/ppc/gdbstub.c\n@@ -23,31 +23,6 @@\n #include \"gdbstub/helpers.h\"\n #include \"internal.h\"\n \n-static int ppc_gdb_register_len_apple(int n)\n-{\n- switch (n) {\n- case 0 ... 31:\n- /* gprs */\n- return 8;\n- case 32 ... 63:\n- /* fprs */\n- return 8;\n- case 64 ... 95:\n- return 16;\n- case 64 + 32: /* nip */\n- case 65 + 32: /* msr */\n- case 67 + 32: /* lr */\n- case 68 + 32: /* ctr */\n- case 70 + 32: /* fpscr */\n- return 8;\n- case 66 + 32: /* cr */\n- case 69 + 32: /* xer */\n- return 4;\n- default:\n- return 0;\n- }\n-}\n-\n static int ppc_gdb_register_len(int n)\n {\n switch (n) {\n@@ -149,59 +124,6 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n)\n return r;\n }\n \n-int ppc_cpu_gdb_read_register_apple(CPUState *cs, GByteArray *buf, int n)\n-{\n- CPUPPCState *env = cpu_env(cs);\n- uint8_t *mem_buf;\n- int r = ppc_gdb_register_len_apple(n);\n-\n- if (!r) {\n- return r;\n- }\n-\n- if (n < 32) {\n- /* gprs */\n- gdb_get_reg64(buf, env->gpr[n]);\n- } else if (n < 64) {\n- /* fprs */\n- gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32));\n- } else if (n < 96) {\n- /* Altivec */\n- gdb_get_reg64(buf, n - 64);\n- gdb_get_reg64(buf, 0);\n- } else {\n- switch (n) {\n- case 64 + 32:\n- gdb_get_reg64(buf, env->nip);\n- break;\n- case 65 + 32:\n- gdb_get_reg64(buf, env->msr);\n- break;\n- case 66 + 32:\n- {\n- uint32_t cr = ppc_get_cr(env);\n- gdb_get_reg32(buf, cr);\n- break;\n- }\n- case 67 + 32:\n- gdb_get_reg64(buf, env->lr);\n- break;\n- case 68 + 32:\n- gdb_get_reg64(buf, env->ctr);\n- break;\n- case 69 + 32:\n- gdb_get_reg32(buf, cpu_read_xer(env));\n- break;\n- case 70 + 32:\n- gdb_get_reg64(buf, env->fpscr);\n- break;\n- }\n- }\n- mem_buf = buf->data + buf->len - r;\n- ppc_maybe_bswap_register(env, mem_buf, r);\n- return r;\n-}\n-\n int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n {\n CPUPPCState *env = cpu_env(cs);\n@@ -248,52 +170,6 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n }\n return r;\n }\n-int ppc_cpu_gdb_write_register_apple(CPUState *cs, uint8_t *mem_buf, int n)\n-{\n- CPUPPCState *env = cpu_env(cs);\n- int r = ppc_gdb_register_len_apple(n);\n-\n- if (!r) {\n- return r;\n- }\n- ppc_maybe_bswap_register(env, mem_buf, r);\n- if (n < 32) {\n- /* gprs */\n- env->gpr[n] = ldq_p(mem_buf);\n- } else if (n < 64) {\n- /* fprs */\n- *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf);\n- } else {\n- switch (n) {\n- case 64 + 32:\n- env->nip = ldq_p(mem_buf);\n- break;\n- case 65 + 32:\n- ppc_store_msr(env, ldq_p(mem_buf));\n- break;\n- case 66 + 32:\n- {\n- uint32_t cr = ldl_p(mem_buf);\n- ppc_set_cr(env, cr);\n- break;\n- }\n- case 67 + 32:\n- env->lr = ldq_p(mem_buf);\n- break;\n- case 68 + 32:\n- env->ctr = ldq_p(mem_buf);\n- break;\n- case 69 + 32:\n- cpu_write_xer(env, ldl_p(mem_buf));\n- break;\n- case 70 + 32:\n- /* fpscr */\n- ppc_store_fpscr(env, ldq_p(mem_buf));\n- break;\n- }\n- }\n- return r;\n-}\n \n #ifndef CONFIG_USER_ONLY\n static void gdb_gen_spr_feature(CPUState *cs)\n","prefixes":["v2","08/50"]}