{"id":2198266,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198266/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219171810.602667-6-alex.bennee@linaro.org>","date":"2026-02-19T17:18:01","name":"[RFC,v2,05/14] hw/m68k: update mcf5208evb to 3-phase reset","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d738f94d2e2dcc8612e82ba33aa3395fc370c181","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.0/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219171810.602667-6-alex.bennee@linaro.org/mbox/","series":[{"id":492705,"url":"http://patchwork.ozlabs.org/api/1.0/series/492705/?format=json","date":"2026-02-19T17:17:57","name":"cpu_reset clean-ups for arm, alpha, mips, m68k and tricore","version":2,"mbox":"http://patchwork.ozlabs.org/series/492705/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198266/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZjRjmN8V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH0XB23G2z1xpl\n\tfor ; Fri, 20 Feb 2026 04:20:58 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt7fZ-0005To-RT; Thu, 19 Feb 2026 12:18:29 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vt7fR-0005OG-Ra\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 12:18:21 -0500","from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vt7fQ-0000SF-2v\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 12:18:21 -0500","by mail-ed1-x52c.google.com with SMTP id\n 4fb4d7f45d1cf-658b6757f7fso2313542a12.1\n for ; Thu, 19 Feb 2026 09:18:19 -0800 (PST)","from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-65bad3f137dsm3928037a12.27.2026.02.19.09.18.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 09:18:15 -0800 (PST)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id F41195F8BC;\n Thu, 19 Feb 2026 17:18:10 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771521498; x=1772126298; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HNFbszyLV6dYFrNFoEy5UENmIo/yFnvFimQs2acqFY8=;\n b=ZjRjmN8VxoEu0dbM5Mrh80oxgVJ1k0pfA0T3kX1VniDbUU4XRIuP4dX9l/BYPrq+sH\n 3jrtjc2FbREejBWDdYKEvmYnReJYxJvatMpYB39NubutvgOelw5j8CKvLyCRbOfseuEs\n pQRPZZ2z5OPt/YqgAXt36sFSBLr82zTkCcPNak3beY/e/fSLDIxfPhghFl9ep5lz9LaB\n mlUyi+dRN2ninMukpVm7Lw1hRT7keiF8PupixLoG/NA0icuEyP/vsegElJ0nHx8BKvjc\n Pn3gE3jryP+DQ+gsKFXS96w8XPW/KbuKcpzzx8XmYZ0Rl1fXeeUX+DU65xpP7eaBIrY0\n uLpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771521498; x=1772126298;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HNFbszyLV6dYFrNFoEy5UENmIo/yFnvFimQs2acqFY8=;\n b=HE0PO4Hf9fJBRH0eHfuVzysQPNSaYZR6nllp/xlq9/4+XAAbA4mibWGH+Aq7v0c8pT\n vYb9jLBLRNEBWIctiZa+Dx/6Vsv9HzXluMBNp5yPf9yPK81GLQyP7BC/QlOGbc9FLgH1\n 80kGNVnrCe+2HthaRZB6O2MFfQzVAYqLISME7IoW5P1BFpY97aSfAz7Ec/d01++7fSRi\n UcLT1ZYdvozkkCsk2VCKfxVGNC720NjWr/YSEXE+U6Wax+jdGSl3mf6Parf3Xbat5/tl\n y3Phfz2Lb/S6/+ATOfJ738xeka6jTV0MuZeZy24JFYvfqBZneIPcomNOLuk6AJ7CmD/O\n HRag==","X-Gm-Message-State":"AOJu0YwMzZF7iaqtOqO1pSecRgrW9DuE0/dD2Xu64RXX4vwWh48TUp87\n triJrHQuEgf0MP3smqIcwrIWl+3bScPY5uSSx7GBnrtMiE+g2H/6oESReV7tVEKTwZs=","X-Gm-Gg":"AZuq6aJkvGHGJ8PP/T7h0P8HVFxqef27Ikx0A5Rh2E4iixaRCzS8jm/+Y00zjJ0wMxc\n O8ZxNr+4aRukMykvb4+woKTGnl/Z705K1oc1TsnxUShNKD6pz/UNmNo96k6PhCreTbDYkrlfTbL\n ozBahSUEFIdVKtsE40B0AzhWtD5GojqMl9nDNvU8yP4mMym3+6h64Y3hqduTqtZ1wZeRSmiMjUq\n aINNY3E0QQA9ORwfIQ2DhvyUn4k4vVuwesg7Fku6t8RdARwnvuSQTFtkbIEjRPD28mo8+qxK0ns\n jhM4wUwBorPBxcw5ADmLwnKvb+Hx+5zeDwFlSa3hGq7favwmtMOi4HKmA5Zo/g8zXchmgbyp6Qq\n 7ohMa5Z7Fg3AN/qQuBByZwhzmoF4dW3tKGJUHcbUBvMo1Z28kRtsBzgXbJ8h1rwrnCMgjIFDujS\n Sm/gkwvSEtQFAgym/kSN79X+PP9BtzSyMXrw==","X-Received":"by 2002:a05:6402:5207:b0:658:b029:9e50 with SMTP id\n 4fb4d7f45d1cf-65e4f76df95mr1538580a12.12.1771521498318;\n Thu, 19 Feb 2026 09:18:18 -0800 (PST)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Yoshinori Sato , qemu-arm@nongnu.org,\n Laurent Vivier , Thomas Huth ,\n Marcel Apfelbaum ,\n Akihiko Odaki ,\n Aurelien Jarno ,\n Jim MacArthur ,\n Eduardo Habkost ,\n Peter Maydell ,\n Bastian Koppelmann , =?utf-8?q?Philippe_Mathieu-Da?=\n\t=?utf-8?q?ud=C3=A9?= ,\n Aleksandar Rikalo ,\n Richard Henderson ,\n Zhao Liu , Jiaxun Yang ,\n Yanan Wang ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ","Subject":"[RFC PATCH v2 05/14] hw/m68k: update mcf5208evb to 3-phase reset","Date":"Thu, 19 Feb 2026 17:18:01 +0000","Message-ID":"<20260219171810.602667-6-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260219171810.602667-1-alex.bennee@linaro.org>","References":"<20260219171810.602667-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::52c;\n envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Alex Bennée \n\n---\nv2\n - rewritten\n - favour cpu_reset over resettable_reset(cs)\n---\n hw/m68k/mcf5208.c | 26 ++++++++++++--------------\n 1 file changed, 12 insertions(+), 14 deletions(-)","diff":"diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c\nindex c6d1c5fae9f..38e2d1307a6 100644\n--- a/hw/m68k/mcf5208.c\n+++ b/hw/m68k/mcf5208.c\n@@ -27,6 +27,7 @@\n #include \"qemu/timer.h\"\n #include \"hw/core/ptimer.h\"\n #include \"system/system.h\"\n+#include \"system/reset.h\"\n #include \"system/qtest.h\"\n #include \"net/net.h\"\n #include \"hw/core/boards.h\"\n@@ -274,6 +275,13 @@ static void mcf_fec_init(MemoryRegion *sysmem, hwaddr base, qemu_irq *irqs)\n memory_region_add_subregion(sysmem, base, sysbus_mmio_get_region(s, 0));\n }\n \n+static void mcf5208evb_reset(MachineState *ms, ResetType type)\n+{\n+ CPUState *cs = first_cpu;\n+ qemu_devices_reset(type);\n+ cpu_reset(cs);\n+}\n+\n static void mcf5208evb_init(MachineState *machine)\n {\n ram_addr_t ram_size = machine->ram_size;\n@@ -289,11 +297,8 @@ static void mcf5208evb_init(MachineState *machine)\n MemoryRegion *sram = g_new(MemoryRegion, 1);\n \n cpu = M68K_CPU(cpu_create(machine->cpu_type));\n- env = &cpu->env;\n \n- /* Initialize CPU registers. */\n- env->vbr = 0;\n- /* TODO: Configure BARs. */\n+ env = &cpu->env;\n \n /* ROM at 0x00000000 */\n memory_region_init_rom(rom, NULL, \"mcf5208.rom\", ROM_SIZE, &error_fatal);\n@@ -343,10 +348,7 @@ static void mcf5208evb_init(MachineState *machine)\n \n /* Load firmware */\n if (machine->firmware) {\n- char *fn;\n- uint8_t *ptr;\n-\n- fn = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware);\n+ g_autofree char *fn = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware);\n if (!fn) {\n error_report(\"Could not find ROM image '%s'\", machine->firmware);\n exit(1);\n@@ -355,11 +357,6 @@ static void mcf5208evb_init(MachineState *machine)\n error_report(\"Could not load ROM image '%s'\", machine->firmware);\n exit(1);\n }\n- g_free(fn);\n- /* Initial PC is always at offset 4 in firmware binaries */\n- ptr = rom_ptr(0x4, 4);\n- assert(ptr != NULL);\n- env->pc = ldl_be_p(ptr);\n }\n \n /* Load kernel. */\n@@ -388,13 +385,14 @@ static void mcf5208evb_init(MachineState *machine)\n exit(1);\n }\n \n- env->pc = entry;\n+ env->direct_kernel_boot_pc = entry;\n }\n \n static void mcf5208evb_machine_init(MachineClass *mc)\n {\n mc->desc = \"MCF5208EVB\";\n mc->init = mcf5208evb_init;\n+ mc->reset = mcf5208evb_reset;\n mc->is_default = true;\n mc->default_cpu_type = M68K_CPU_TYPE_NAME(\"m5208\");\n mc->default_ram_id = \"mcf5208.ram\";\n","prefixes":["RFC","v2","05/14"]}