{"id":2198264,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198264/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219171810.602667-5-alex.bennee@linaro.org>","date":"2026-02-19T17:18:00","name":"[RFC,v2,04/14] hw/m68k: update nextcube to 3-phase reset","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"aef942b8f912a66e39c2b2cbe74ef1d0a2a8e5d1","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.0/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219171810.602667-5-alex.bennee@linaro.org/mbox/","series":[{"id":492705,"url":"http://patchwork.ozlabs.org/api/1.0/series/492705/?format=json","date":"2026-02-19T17:17:57","name":"cpu_reset clean-ups for arm, alpha, mips, m68k and tricore","version":2,"mbox":"http://patchwork.ozlabs.org/series/492705/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198264/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gNdPaKEm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fH0Wh6fhpz1xpl\n\tfor ; Fri, 20 Feb 2026 04:20:32 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt7fW-0005Rr-SP; Thu, 19 Feb 2026 12:18:26 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vt7fO-0005Li-L5\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 12:18:18 -0500","from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vt7fL-0000QG-Ty\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 12:18:18 -0500","by mail-ed1-x52f.google.com with SMTP id\n 4fb4d7f45d1cf-65baa72399fso1622977a12.0\n for ; Thu, 19 Feb 2026 09:18:15 -0800 (PST)","from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-b8fc7385f5dsm591973166b.20.2026.02.19.09.18.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 09:18:11 -0800 (PST)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id DCF205F8BA;\n Thu, 19 Feb 2026 17:18:10 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771521494; x=1772126294; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tmInN0JteBeMKRB6GTa7UJFQ9ygY8v6TAwibYQDcB7c=;\n b=gNdPaKEmVv1lmFM13V7qEEktc0Kj9TrTuGt/Z2N4p8CGjCPQ33/JVdyf+KVVT86/4g\n P8gYPIyrBvH6JkkgrD78URmSEQJsVlH+b3BfDpwME35PlA/fI+eb2j+kdil945/Hp5/M\n xp78io6n1X9HMNBad1bCWCiLYhh+RJLVPtU66CdpFesTt2hlHp82G/cv6e8vQ2SGA5kH\n 9i0OY8jy3j5zZ3ZGzRUuxy9sZNrOAYUcNPjzxa4NWdZzshEW/jytIMTzu9Vaz/srq8CT\n TfxwwS7BH9st1EHKwSAlErxkvn73QLWRcdjJQWJFc2O9inMvr4y+vvW1f5M+SdV9ioWs\n H8VA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771521494; x=1772126294;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tmInN0JteBeMKRB6GTa7UJFQ9ygY8v6TAwibYQDcB7c=;\n b=GcaAclI90WMqu30DRv332YqBsp2zeNXYkpGfUFn+QmWkOwq3XfHP/tU8kfeYdWjFYP\n VYxB1RK9wBpOmFRpDaPJGRM9MkYOMm/hPaNv+gMv5SBgl+0BCwoe1L3xA8+kUoZ7nuqh\n MCcJESgCs8qIwfIcseQs68ynXfO4YIasA6Dm8rQbqoH9NBMizz74Os1SlAc/CUhacJra\n o7ChJKMWIsYxuSiUKM7JfULhvMbn1Bl9JT1Z5lcT24vL9rF1f4osAvXghdxsFIFACjIN\n wDWJ5THdFoqLyv0AdsfWtgx50RotHH/Xa3FtfDbHktDpdoq11T8UOgpPh5/8HDLz6FWA\n wZuw==","X-Gm-Message-State":"AOJu0YyJ+QRHqu1uqEe29EBMhmY+xeDcKH/F789jUXJrh5XJNO/xCK0e\n cMiZPF2ZdymiP/tUKyzPEmUrJAbtrwRcNLREdVt8T02P8Q7Yu/Zm9T/PRUnubpkEfm6Hh3ha16Y\n NZM7g","X-Gm-Gg":"AZuq6aIdMKVIJonlFYuzrIoxf3I5I7kWkDmXN/h2y0FOH3CdeIpKvmqfXxl4i3DLR9p\n 8jVD/buj00SXn5uKP2AWSD8n+0VNHB3KrB4CKjlX7edwnOVfBXjRUqePI1mZ9gyAPZ3DrW+oVY0\n zVbbdR8NhjKqMUCHVCLJeYUnkc2qxJsttouB4XkiUe4t627ijKAXJ90tSe1HoweXkk76lm4lhAD\n tTWkx72QUwyKNbOYtwdeTGXn2HcZjZJLEIYr+Q8XTprx2Fhl+sgkM8aZSvpT1airS/J/Gqc8TpK\n IDGC+DGF0zeE3r70ab79xitdjZTjWiddUi/+embfswQGxr3dEA0Tc+5L72PVPPlqrLs4gcD27/M\n 8TaWdCoD8tJ/PRxXr3qOpR2T8KgINYG+XgpPmdWwkqoF8zWW+QHZQOSQNfKv3ItY/rWl1yl4iEm\n keTRwif7U45ZP+xVpCkOdTcL8=","X-Received":"by 2002:a17:907:728d:b0:b88:47b4:7626 with SMTP id\n a640c23a62f3a-b8fc3b66536mr1139397566b.27.1771521494227;\n Thu, 19 Feb 2026 09:18:14 -0800 (PST)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Yoshinori Sato , qemu-arm@nongnu.org,\n Laurent Vivier , Thomas Huth ,\n Marcel Apfelbaum ,\n Akihiko Odaki ,\n Aurelien Jarno ,\n Jim MacArthur ,\n Eduardo Habkost ,\n Peter Maydell ,\n Bastian Koppelmann , =?utf-8?q?Philippe_Mathieu-Da?=\n\t=?utf-8?q?ud=C3=A9?= ,\n Aleksandar Rikalo ,\n Richard Henderson ,\n Zhao Liu , Jiaxun Yang ,\n Yanan Wang ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ","Subject":"[RFC PATCH v2 04/14] hw/m68k: update nextcube to 3-phase reset","Date":"Thu, 19 Feb 2026 17:18:00 +0000","Message-ID":"<20260219171810.602667-5-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260219171810.602667-1-alex.bennee@linaro.org>","References":"<20260219171810.602667-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::52f;\n envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Alex Bennée \n\n---\nv2\n - re-written, tags dropped.\n - favour cpu_reset over resettable_reset(cs)\n---\n hw/m68k/next-cube.c | 23 +++++++++++++++++------\n 1 file changed, 17 insertions(+), 6 deletions(-)","diff":"diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c\nindex 26177c7b867..b10129dd9d7 100644\n--- a/hw/m68k/next-cube.c\n+++ b/hw/m68k/next-cube.c\n@@ -16,6 +16,7 @@\n #include \"exec/cpu-interrupt.h\"\n #include \"system/system.h\"\n #include \"system/qtest.h\"\n+#include \"system/reset.h\"\n #include \"hw/core/irq.h\"\n #include \"hw/m68k/next-cube.h\"\n #include \"hw/core/boards.h\"\n@@ -1249,6 +1250,19 @@ static const TypeInfo next_pc_info = {\n .class_init = next_pc_class_init,\n };\n \n+static void next_cube_reset(MachineState *ms, ResetType type)\n+{\n+ CPUState *cs = first_cpu;\n+ M68kCPU *cpu = M68K_CPU(cs);\n+\n+ qemu_devices_reset(type);\n+ cpu_reset(cs);\n+\n+ /* Initialize CPU registers. */\n+ cpu->env.vbr = 0;\n+ cpu->env.sr = 0x2700;\n+}\n+\n static void next_cube_init(MachineState *machine)\n {\n NeXTState *m = NEXT_MACHINE(machine);\n@@ -1266,10 +1280,6 @@ static void next_cube_init(MachineState *machine)\n }\n env = &cpu->env;\n \n- /* Initialize CPU registers. */\n- env->vbr = 0;\n- env->sr = 0x2700;\n-\n /* Peripheral Controller */\n pcdev = qdev_new(TYPE_NEXT_PC);\n object_property_set_link(OBJECT(pcdev), \"cpu\", OBJECT(cpu), &error_abort);\n@@ -1335,8 +1345,8 @@ static void next_cube_init(MachineState *machine)\n /* Initial PC is always at offset 4 in firmware binaries */\n ptr = rom_ptr(0x01000004, 4);\n g_assert(ptr != NULL);\n- env->pc = ldl_be_p(ptr);\n- if (env->pc >= 0x01020000) {\n+ cpu->env.direct_kernel_boot_pc = ldl_be_p(ptr);\n+ if (env->direct_kernel_boot_pc >= 0x01020000) {\n error_report(\"'%s' does not seem to be a valid firmware image.\",\n bios_name);\n exit(1);\n@@ -1355,6 +1365,7 @@ static void next_machine_class_init(ObjectClass *oc, const void *data)\n \n mc->desc = \"NeXT Cube\";\n mc->init = next_cube_init;\n+ mc->reset = next_cube_reset;\n mc->block_default_type = IF_SCSI;\n mc->default_ram_size = RAM_SIZE;\n mc->default_ram_id = \"next.ram\";\n","prefixes":["RFC","v2","04/14"]}