{"id":2198207,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198207/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219143332.3316679-9-ruslichenko.r@gmail.com>","date":"2026-02-19T14:33:07","name":"[v2,08/33] hw/core/fdt_generic_util: implement fdt_init_qdev","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1a95d48cfe8ffc43f257d007ca256ef237f28ff7","submitter":{"id":92275,"url":"http://patchwork.ozlabs.org/api/1.0/people/92275/?format=json","name":"Ruslan Ruslichenko","email":"ruslichenko.r@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219143332.3316679-9-ruslichenko.r@gmail.com/mbox/","series":[{"id":492690,"url":"http://patchwork.ozlabs.org/api/1.0/series/492690/?format=json","date":"2026-02-19T14:33:04","name":"hw/arm: Introduce generic FDT-driven machine","version":2,"mbox":"http://patchwork.ozlabs.org/series/492690/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198207/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=hWPPQJ/8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGx1M0QpKz1xpY\n\tfor ; Fri, 20 Feb 2026 01:42:31 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt57E-00008r-83; Thu, 19 Feb 2026 09:34:52 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vt57D-00008G-JX\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:34:51 -0500","from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vt57B-0002yL-Q1\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:34:51 -0500","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-4376acce52eso651942f8f.1\n for ; Thu, 19 Feb 2026 06:34:49 -0800 (PST)","from thinkpad-t470s.. (93-143-129-182.adsl.net.t-com.hr.\n [93.143.129.182]) by smtp.googlemail.com with ESMTPSA id\n ffacd0b85a97d-43796abd259sm52022770f8f.24.2026.02.19.06.34.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 06:34:47 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771511688; x=1772116488; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=deDtLpm5UCBRVz7TWoi3DqbhG6uyneflICAxyDhjR6g=;\n b=hWPPQJ/8+6WVeF0/2qHSp6i3TbEgDlsufaQhvW7GpdNLdiMYQ48mBD/AhxayZWwbLu\n ZpXqJ3mDfbII7X3WbPyg20Gz4UnqEcVv0DBQ568x059CLV68hsi99LUU5/Yc4U0aHa35\n AHXIWsZqlZ0Hpdk1q2/MBHvgs1xke/3O2e/A66K5mDtpkKZ0PpHeXx0+IULVt+JQYS0S\n UIaik6xFrXmXwbMy2B4lkvsS/l9k0PewPFHYb7I9LP+yv5cIH8JNZ0kVJstI6PvNqnNt\n ngPf9g8wIfI9plY68Ey8H3zVNjNXHCu65O1BtKaCTyyHoR3cMrckvXjtZ3a24SawDPVB\n s4pg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771511688; x=1772116488;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=deDtLpm5UCBRVz7TWoi3DqbhG6uyneflICAxyDhjR6g=;\n b=Xw/7YUZWjTFmcETEGdKxmJ26lP5ZP0AgRhL62jts41QHCGBqVow/xan/hOJrXZTrxY\n aaSOaVuQ0T1wkeQuuDDiZdodf6+di8aZS+rObfn6N5EFMgtIoM44EWPCiQ4vyot3w0x5\n JfD5yPyakbOG3TYI49fgzziALZ0kVCj7AabC9gu3aUGJM1Aazzdun3cFH8NpEHm9uLfb\n B95u6W5pN6Nz/J9Q7JB8CH5YHM989Ri4QR2rMNwtxUPrdr7XNxLFZjCKu43uW13M/uso\n 59BSTT8oS0KBri3BHQP+yOpB4P5InRNJ0tzs77Q6+IGV+9ltccQ/57vFOqP8NbVfkcge\n mUUQ==","X-Gm-Message-State":"AOJu0YxVCNd/hTjJhuI9GJUKDgSP15KSZ1OlKNcSKN5S70awODy6Wio0\n yPIwZ8sDAHXl3B28UHWt37IHy0XyZQyhcI+xvgGvZ/6yIrGQ7iz9Xd233JJBn6xt","X-Gm-Gg":"AZuq6aJO4VHPgzya8toBXrbafGIZQZbegjIA4+XSxT2HC8seXdN3oV0JUioD+eoWjX7\n 2+K/urfgH85r5PVoFWNgviXRAZzvAyjkTerMt0cxFc7TnYAzJdU+VIqpuePdRiKkMZRB5on5gyJ\n GbGvnzMwFHzb3tIYLQgt1iuNBpSntbaTgh6hpizjSDRkiEUraQ8tUCxlhCHXfcrfNqN+41Ei9WJ\n tla24w6fPec1FfhG/dHIcPHmfMRKx40vmD+dRi8I2LT299q9/y5UuQEzzWOI7WtxwOxeqGp9nuY\n d4AxuwC5bWjefObhk53l6gaAYS+IkIlFONG44kKFbBZ/6zHubKwZBWHPj6K64YaSAYeDR7dsold\n 6x7tdcubIHVymcRWFmCESymWvIzKVx2QkPz4jLhzpTuxxzrX3KfaOZE4H52eB6iE2uJwx1HmHgn\n AA7C/mhW/3TxCFPz3ODNyvf9pYbXOgqzu5OjHOGq79pq6DW8mhAO3AN8liYp+bfjNMZXiz","X-Received":"by 2002:a05:6000:22c9:b0:437:707e:9f57 with SMTP id\n ffacd0b85a97d-43958d55f30mr9429236f8f.0.1771511687896;\n Thu, 19 Feb 2026 06:34:47 -0800 (PST)","From":"Ruslan Ruslichenko ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" ,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu","Subject":"[PATCH v2 08/33] hw/core/fdt_generic_util: implement fdt_init_qdev","Date":"Thu, 19 Feb 2026 15:33:07 +0100","Message-ID":"<20260219143332.3316679-9-ruslichenko.r@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260219143332.3316679-1-ruslichenko.r@gmail.com>","References":"<20260219143332.3316679-1-ruslichenko.r@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42b;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-wr1-x42b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Ruslan Ruslichenko \n\nImplement main routine to create device object from\ncompat.\n\nThe following steps implemented:\n\n- parse node compatible and device types\n- try to create object from compat\n- set correct parent based on device tree.\n\nSigned-off-by: Ruslan Ruslichenko \n---\n hw/core/fdt_generic_util.c | 222 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 222 insertions(+)","diff":"diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 3606c11349..8131511e70 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -40,6 +40,7 @@\n #include \"qemu/config-file.h\"\n #include \"hw/core/boards.h\"\n #include \"qemu/option.h\"\n+#include \"hw/cpu/cluster.h\"\n \n #ifndef FDT_GENERIC_UTIL_ERR_DEBUG\n #define FDT_GENERIC_UTIL_ERR_DEBUG 3\n@@ -238,8 +239,229 @@ static int simple_bus_fdt_init(char *node_path, FDTMachineInfo *fdti)\n return 0;\n }\n \n+/* FIXME: figure out a real solution to this */\n+\n+#define DIGIT(a) ((a) >= '0' && (a) <= '9')\n+#define LOWER_CASE(a) ((a) >= 'a' && (a) <= 'z')\n+\n+static void trim_version(char *x)\n+{\n+ long result;\n+\n+ for (;;) {\n+ x = strchr(x, '-');\n+ if (!x) {\n+ return;\n+ }\n+ if (DIGIT(x[1])) {\n+ /* Try to trim Xilinx version suffix */\n+ const char *p;\n+\n+ qemu_strtol(x + 1, &p, 0, &result);\n+\n+ if (*p == '.') {\n+ *x = 0;\n+ return;\n+ } else if (*p == 0) {\n+ return;\n+ }\n+ } else if (x[1] == 'r' && x[3] == 'p') {\n+ /* Try to trim ARM version suffix */\n+ if (DIGIT(x[2]) && DIGIT(x[4])) {\n+ *x = 0;\n+ return;\n+ }\n+ }\n+ x++;\n+ }\n+}\n+\n+static void substitute_char(char *s, char a, char b)\n+{\n+ for (;;) {\n+ s = strchr(s, a);\n+ if (!s) {\n+ return;\n+ }\n+ *s = b;\n+ s++;\n+ }\n+}\n+\n+static inline const char *trim_vendor(const char *s)\n+{\n+ /* FIXME: be more intelligent */\n+ const char *ret = memchr(s, ',', strlen(s));\n+ return ret ? ret + 1 : s;\n+}\n+\n+static Object *fdt_create_from_compat(const char *compat, char **dev_type)\n+{\n+ Object *ret = NULL;\n+ char *c = g_strdup(compat);\n+\n+ /* Try to create the object */\n+ ret = object_new(c);\n+\n+ if (!ret) {\n+ /* Trim the version off the end and try again */\n+ trim_version(c);\n+ ret = object_new(c);\n+\n+ if (!ret) {\n+ /* Replace commas with full stops */\n+ substitute_char(c, ',', '.');\n+ ret = object_new(c);\n+ }\n+ }\n+\n+ if (!ret) {\n+ /*\n+ * Restart with the orginal string and now replace commas with full\n+ * stops and try again. This means that versions are still included.\n+ */\n+ g_free(c);\n+ c = g_strdup(compat);\n+ substitute_char(c, ',', '.');\n+ ret = object_new(c);\n+ }\n+\n+ if (dev_type) {\n+ *dev_type = c;\n+ } else {\n+ g_free(c);\n+ }\n+\n+ if (!ret) {\n+ const char *no_vendor = trim_vendor(compat);\n+\n+ if (no_vendor != compat) {\n+ return fdt_create_from_compat(no_vendor, dev_type);\n+ }\n+ }\n+ return ret;\n+}\n+\n+/*\n+ * Error handler for device creation failure.\n+ *\n+ * We look for qemu-fdt-abort-on-error properties up the tree.\n+ * If we find one, we abort with the provided error message.\n+ */\n+static void fdt_dev_error(FDTMachineInfo *fdti, char *node_path, char *compat)\n+{\n+ const char *abort_on_error;\n+ const char *warn_on_error;\n+\n+ warn_on_error = qemu_fdt_getprop_inherited(fdti->fdt, node_path,\n+ \"qemu-fdt-warn-on-error\", 0, NULL);\n+ abort_on_error = qemu_fdt_getprop_inherited(fdti->fdt, node_path,\n+ \"qemu-fdt-abort-on-error\", 0, NULL);\n+ if (warn_on_error) {\n+ if (strncmp(\"device_type\", compat, strlen(\"device_type\"))) {\n+ warn_report(\"%s: %s\", compat, warn_on_error);\n+ }\n+ }\n+\n+ if (abort_on_error) {\n+ error_report(\"Failed to create %s\", compat);\n+ error_setg(&error_fatal, \"%s\", abort_on_error);\n+ }\n+}\n+\n static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n {\n+ Object *dev, *parent;\n+ char *dev_type = NULL;\n+ char parent_node_path[DT_PATH_LENGTH];\n+\n+ if (!compat) {\n+ return 1;\n+ }\n+ dev = fdt_create_from_compat(compat, &dev_type);\n+ if (!dev) {\n+ DB_PRINT_NP(1, \"no match found for %s\\n\", compat);\n+ fdt_dev_error(fdti, node_path, compat);\n+ return 1;\n+ }\n+ DB_PRINT_NP(1, \"matched compat %s\\n\", compat);\n+\n+ /* Do this super early so fdt_generic_num_cpus is correct ASAP */\n+ if (object_dynamic_cast(dev, TYPE_CPU)) {\n+ fdt_generic_num_cpus++;\n+ DB_PRINT_NP(0, \"is a CPU - total so far %d\\n\", fdt_generic_num_cpus);\n+ }\n+\n+ if (qemu_devtree_getparent(fdti->fdt, parent_node_path, node_path)) {\n+ abort();\n+ }\n+ while (!fdt_init_has_opaque(fdti, parent_node_path) &&\n+ !object_dynamic_cast(dev, TYPE_CPU)) {\n+ fdt_init_yield(fdti);\n+ }\n+\n+ parent = fdt_init_get_opaque(fdti, parent_node_path);\n+\n+ if (object_dynamic_cast(dev, TYPE_CPU)) {\n+ parent = fdt_init_get_cpu_cluster(fdti, parent, compat);\n+ }\n+\n+ if (dev->parent) {\n+ DB_PRINT_NP(0, \"Node already parented - skipping node\\n\");\n+ } else if (parent) {\n+ DB_PRINT_NP(1, \"parenting node\\n\");\n+ object_property_add_child(OBJECT(parent),\n+ strdup(strrchr(node_path, '/') + 1),\n+ OBJECT(dev));\n+ if (object_dynamic_cast(dev, TYPE_DEVICE)) {\n+ Object *parent_bus = parent;\n+ unsigned int depth = 0;\n+\n+ DB_PRINT_NP(1, \"bus parenting node\\n\");\n+ /* Look for an FDT ancestor that is a Bus. */\n+ while (parent_bus && !object_dynamic_cast(parent_bus, TYPE_BUS)) {\n+ /*\n+ * Assert against insanely deep hierarchies which are an\n+ * indication of loops.\n+ */\n+ assert(depth < 4096);\n+\n+ parent_bus = parent_bus->parent;\n+ depth++;\n+ }\n+\n+ if (!parent_bus\n+ && object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) {\n+ /*\n+ * Didn't find any bus. Use the default sysbus one.\n+ * This allows ad-hoc busses belonging to sysbus devices to be\n+ * visible to -device bus=x.\n+ */\n+ parent_bus = OBJECT(sysbus_get_default());\n+ }\n+\n+ if (parent_bus) {\n+ qdev_set_parent_bus(DEVICE(dev), BUS(parent_bus),\n+ &error_abort);\n+ }\n+ }\n+ } else {\n+ DB_PRINT_NP(1, \"orphaning node\\n\");\n+ if (object_dynamic_cast(OBJECT(dev), TYPE_SYS_BUS_DEVICE)) {\n+ qdev_set_parent_bus(DEVICE(dev), BUS(sysbus_get_default()),\n+ &error_abort);\n+ }\n+\n+ /* FIXME: Make this go away (centrally) */\n+ object_property_add_child(\n+ object_get_root(),\n+ strrchr(node_path, '/') + 1,\n+ OBJECT(dev));\n+ }\n+ fdt_init_set_opaque(fdti, node_path, dev);\n+\n+ g_free(dev_type);\n+\n return 0;\n }\n \n","prefixes":["v2","08/33"]}