{"id":2198200,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198200/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219143332.3316679-11-ruslichenko.r@gmail.com>","date":"2026-02-19T14:33:09","name":"[v2,10/33] hw/core/fdt_generic_util: initilize qdev properties from fdt","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5d3ba9e879779f85a134ccc86d7d51237f832a36","submitter":{"id":92275,"url":"http://patchwork.ozlabs.org/api/1.0/people/92275/?format=json","name":"Ruslan Ruslichenko","email":"ruslichenko.r@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219143332.3316679-11-ruslichenko.r@gmail.com/mbox/","series":[{"id":492690,"url":"http://patchwork.ozlabs.org/api/1.0/series/492690/?format=json","date":"2026-02-19T14:33:04","name":"hw/arm: Introduce generic FDT-driven machine","version":2,"mbox":"http://patchwork.ozlabs.org/series/492690/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198200/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=IByYDXE4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGwvM6d4jz1xpl\n\tfor ; Fri, 20 Feb 2026 01:37:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vt57I-0000Bn-U0; Thu, 19 Feb 2026 09:34:56 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vt57G-0000AP-Sj\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:34:54 -0500","from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vt57F-0002zH-2C\n for qemu-devel@nongnu.org; Thu, 19 Feb 2026 09:34:54 -0500","by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-4359a316d89so962732f8f.0\n for ; Thu, 19 Feb 2026 06:34:52 -0800 (PST)","from thinkpad-t470s.. (93-143-129-182.adsl.net.t-com.hr.\n [93.143.129.182]) by smtp.googlemail.com with ESMTPSA id\n ffacd0b85a97d-43796abd259sm52022770f8f.24.2026.02.19.06.34.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Feb 2026 06:34:50 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771511691; x=1772116491; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8p7OUmEJMiBfURYJ4JeOsw/eoH+9F0GGVOCzGcWPVSw=;\n b=IByYDXE4AntdZsLnlphGtcsQ/AdULndKjN53Qt+OnExaoA20+nBZlLVhOIF97EZL7r\n 5BrTKlCy3WICV+VnQUwPgr4b8dJ+jO1o2gHCZqIa1ah/FxiCaE5VuuZKr5jLX8+wUHHA\n /6nfHemXfpVlHfnqeXVbWjX04w7XJKghBC01A9aJmiXnwEPhVDiJ/VrvYW3CVv73SDtn\n wXIVV+qGwoLSuy5fZJX4B34wNxAfibYyzz33tI+OAISnbA7HccMF5pMEgFH+S3nZVO72\n 2efDrIhazmWeRlYdXWmVKpnNbvXl5jc2iJ95TL9oploTxknVCXLPdfpzDqrNwD5TpkHx\n 2VoA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771511691; x=1772116491;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8p7OUmEJMiBfURYJ4JeOsw/eoH+9F0GGVOCzGcWPVSw=;\n b=Cp84c2tDUT+Ib2W2nM2Qxh3dJ59COsxPJX9SMUXrvkjvGVwS4hAfAcLBNZFDobzA57\n DtJekQAoHmsov1283Psvar++Uv45eN7byaGp5/uZs7puEPwFuNdHXkQ29pWNdAWVwrk2\n FbeAyulZRkYmDsigqH6jI8f9YchSKWSBEw4Iu0wD12aky7HFWT/ll04XX+ZIiGr2JX5Z\n izYr0zfKPZUe+PD/bSOUQ/eX7qD51QzrKQMspGJnIP4oPvtsYvyuc2bjqMYMaX8vq8NN\n +03XcxO0QSieExrDB0joDU3dC9o7BgIoiO14uATg1lIX6NZuUO+ALuUj2tIt9OjfaWyd\n HGfg==","X-Gm-Message-State":"AOJu0YwOUjS6iBr/3G3sHzcGDUeuDbOCuoxxa85WQiAdi+m7f9lrg3MF\n 49/UbxisBVCpnRs6DPaD+fkeW9A2zB/durgFnOwwD7Pi3/t60m9o24NxfEA42QPi","X-Gm-Gg":"AZuq6aK0IEz7nBWWgY6nxkA0jGuvZlESWN39j+tGBxqpXVp2z65UTGy7n6ITybHD/Y5\n n4gyifh6nI/Wvd5ln+2UWFmQzX3qbGgEjtAECJXhZIIinfzqd/tQUlrsADbbulN1Rh4KgyFYlRT\n hW8qJV/l/LW9VNZ2lgI+Li6R9ivbyJ8qg4MiUIdfrs1Lh48qg6kZVUKWY6A3Uq1rpJsjlV4Ff7M\n mHw5MtPMWEeN7J9/KwBt4jenHXoleAoe66eZ9vHX4LdjorYmr7y3W1YgMXsLE2Z/lpIRGzGg+su\n v0AJMdGy0olcOQM+3zLdOWEBQc1INfj/4kOikT+IEBeeLzZANhrPcQ+7Ko+EIPH4vwAt8p+Suzb\n L6eq5fH/D24tkSsJxQ8ak5rPRt79Aijrrpc6zeflPAz4ZdTu/Bpz0boYEh0x6VJ+CMo4hK7w32U\n 37moPLRxJAuPjN/+fBHrPxAuv07J1G3qna4Y+BiKbgFhWH4Dy8syTcFOOLLaELGGMiRXLY","X-Received":"by 2002:a05:6000:40dc:b0:437:6839:d5e with SMTP id\n ffacd0b85a97d-43958df370bmr9925523f8f.13.1771511690774;\n Thu, 19 Feb 2026 06:34:50 -0800 (PST)","From":"Ruslan Ruslichenko ","To":"qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org,\n artem_mygaiev@epam.com, volodymyr_babchuk@epam.com,\n takahiro.nakata.wr@renesas.com,\n \"Edgar E . Iglesias\" ,\n Ruslan_Ruslichenko@epam.com, balaton@eik.bme.hu","Subject":"[PATCH v2 10/33] hw/core/fdt_generic_util: initilize qdev properties\n from fdt","Date":"Thu, 19 Feb 2026 15:33:09 +0100","Message-ID":"<20260219143332.3316679-11-ruslichenko.r@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260219143332.3316679-1-ruslichenko.r@gmail.com>","References":"<20260219143332.3316679-1-ruslichenko.r@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::433;\n envelope-from=ruslichenko.r@gmail.com; helo=mail-wr1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Ruslan Ruslichenko \n\nThe patch adds possibility to read and parse device tree\nnode properties and set them to newly created object.\n\nSigned-off-by: Ruslan Ruslichenko \n---\n hw/core/fdt_generic_util.c | 222 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 222 insertions(+)","diff":"diff --git a/hw/core/fdt_generic_util.c b/hw/core/fdt_generic_util.c\nindex 8131511e70..2a3862b9ac 100644\n--- a/hw/core/fdt_generic_util.c\n+++ b/hw/core/fdt_generic_util.c\n@@ -40,7 +40,9 @@\n #include \"qemu/config-file.h\"\n #include \"hw/core/boards.h\"\n #include \"qemu/option.h\"\n+#include \"hw/core/qdev-properties.h\"\n #include \"hw/cpu/cluster.h\"\n+#include \"qobject/qlist.h\"\n \n #ifndef FDT_GENERIC_UTIL_ERR_DEBUG\n #define FDT_GENERIC_UTIL_ERR_DEBUG 3\n@@ -342,6 +344,25 @@ static Object *fdt_create_from_compat(const char *compat, char **dev_type)\n return ret;\n }\n \n+/*FIXME: roll into device tree functionality */\n+\n+static inline uint64_t get_int_be(const void *p, int len)\n+{\n+ switch (len) {\n+ case 1:\n+ return *((uint8_t *)p);\n+ case 2:\n+ return be16_to_cpu(*((uint16_t *)p));\n+ case 4:\n+ return be32_to_cpu(*((uint32_t *)p));\n+ case 8:\n+ return be32_to_cpu(*((uint64_t *)p));\n+ default:\n+ fprintf(stderr, \"unsupported integer length\\n\");\n+ abort();\n+ }\n+}\n+\n /*\n * Error handler for device creation failure.\n *\n@@ -369,10 +390,185 @@ static void fdt_dev_error(FDTMachineInfo *fdti, char *node_path, char *compat)\n }\n }\n \n+static void fdt_init_qdev_link_prop(Object *obj, ObjectProperty *p,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const QEMUDevtreeProp *prop)\n+{\n+ int len = prop->len;\n+ const void *val = prop->value;\n+ const char *propname = prop->name;\n+\n+ Object *linked_dev, *proxy;\n+ char target_node_path[DT_PATH_LENGTH];\n+ g_autofree char *propname_target = g_strconcat(propname, \"-target\", NULL);\n+ Error *errp = NULL;\n+\n+ if (qemu_devtree_get_node_by_phandle(fdti->fdt, target_node_path,\n+ get_int_be(val, len))) {\n+ abort();\n+ }\n+\n+ while (!fdt_init_has_opaque(fdti, target_node_path)) {\n+ fdt_init_yield(fdti);\n+ }\n+ linked_dev = fdt_init_get_opaque(fdti, target_node_path);\n+\n+ proxy = linked_dev ? object_property_get_link(linked_dev,\n+ propname_target,\n+ &errp) : NULL;\n+ if (!errp && proxy) {\n+ DB_PRINT_NP(0, \"detected proxy object for %s connection\\n\", propname);\n+ linked_dev = proxy;\n+ }\n+\n+ if (!linked_dev) {\n+ linked_dev = object_resolve_link(obj, propname,\n+ target_node_path, &errp);\n+ if (!linked_dev) {\n+ return;\n+ }\n+ }\n+\n+ errp = NULL;\n+ object_property_set_link(obj, propname, linked_dev, &errp);\n+ if (errp) {\n+ /* Unable to set the property, maybe it is a memory alias? */\n+ MemoryRegion *alias_mr;\n+ int offset = len / 2;\n+ int region = 0;\n+\n+ if (len > 4) {\n+ region = get_int_be(val + offset, len - offset);\n+ }\n+\n+ alias_mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(linked_dev), region);\n+\n+ object_property_set_link(obj, propname, OBJECT(alias_mr), &error_abort);\n+\n+ }\n+\n+ DB_PRINT_NP(0, \"set link %s\\n\", propname);\n+}\n+\n+static void fdt_init_qdev_scalar_prop(Object *obj, ObjectProperty *p,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const QEMUDevtreeProp *prop)\n+{\n+ const char *propname = trim_vendor(prop->name);\n+ const void *val = prop->value;\n+ int len = prop->len;\n+\n+ /* FIXME: handle generically using accessors and stuff */\n+ if (!strncmp(p->type, \"link\", 4)) {\n+ fdt_init_qdev_link_prop(obj, p, fdti, node_path, prop);\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"uint8\") || !strcmp(p->type, \"uint16\") ||\n+ !strcmp(p->type, \"uint32\") || !strcmp(p->type, \"uint64\") ||\n+ !strcmp(p->type, \"int8\") || !strcmp(p->type, \"int16\") ||\n+ !strcmp(p->type, \"int32\") || !strcmp(p->type, \"int64\")) {\n+ object_property_set_int(obj, propname,\n+ get_int_be(val, len), &error_abort);\n+ DB_PRINT_NP(0, \"set property %s to 0x%llx\\n\", propname,\n+ (unsigned long long)get_int_be(val, len));\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"boolean\") || !strcmp(p->type, \"bool\")) {\n+ object_property_set_bool(obj, propname,\n+ !!get_int_be(val, len), &error_abort);\n+ DB_PRINT_NP(0, \"set property %s to %s\\n\", propname,\n+ get_int_be(val, len) ? \"true\" : \"false\");\n+ return;\n+ }\n+\n+ if (!strcmp(p->type, \"string\") || !strcmp(p->type, \"str\")) {\n+ object_property_set_str(obj, propname,\n+ (const char *)val, &error_abort);\n+ DB_PRINT_NP(0, \"set property %s to %s\\n\", propname, (const char *)val);\n+ return;\n+ }\n+\n+ DB_PRINT_NP(0, \"WARNING: property is of unknown type\\n\");\n+}\n+\n+static size_t fdt_array_elem_len(FDTMachineInfo *fdti,\n+ const char *node_path,\n+ const char *propname)\n+{\n+ g_autofree char *elem_cells_propname = NULL;\n+ Error *err = NULL;\n+ uint32_t elem_cells;\n+\n+ /*\n+ * Default element size to 1 uint32_t cell, unless it is explicitly\n+ * given in the same FDT node (not inherited).\n+ */\n+ elem_cells_propname = g_strconcat(\"#\", propname, \"-cells\", NULL);\n+ elem_cells = qemu_fdt_getprop_cell(fdti->fdt, node_path,\n+ elem_cells_propname, 0, &err);\n+\n+ return (err ? 1 : elem_cells) * 4;\n+}\n+\n+static void fdt_init_qdev_array_prop(Object *obj,\n+ FDTMachineInfo *fdti,\n+ const char *node_path,\n+ QEMUDevtreeProp *prop)\n+{\n+ const char *propname = trim_vendor(prop->name);\n+ int nr = prop->len;\n+ uint32_t elem_len;\n+ QList *qlist = qlist_new();\n+ const char *prop_type;\n+ const void *prop_value = prop->value;\n+\n+ if (!prop->value || !nr) {\n+ return;\n+ }\n+\n+ elem_len = fdt_array_elem_len(fdti, node_path, propname);\n+ if (nr % elem_len) {\n+ return;\n+ }\n+\n+ nr /= elem_len;\n+\n+ prop_type = qdev_prop_get_array_elem_type(DEVICE(obj), propname);\n+ if (!prop_type) {\n+ DB_PRINT_NP(0, \"fail to get property array elem type\\n\");\n+ return;\n+ }\n+\n+ while (nr--) {\n+ if (!strcmp(prop_type, \"uint8\") || !strcmp(prop_type, \"uint16\") ||\n+ !strcmp(prop_type, \"uint32\") || !strcmp(prop_type, \"uint64\") ||\n+ !strcmp(prop_type, \"int8\") || !strcmp(prop_type, \"int16\") ||\n+ !strcmp(prop_type, \"int32\") || !strcmp(prop_type, \"int64\")) {\n+ qlist_append_int(qlist, get_int_be(prop_value, elem_len));\n+ } else if (!strcmp(prop_type, \"boolean\") || !strcmp(prop_type, \"bool\")) {\n+ qlist_append_bool(qlist, !!get_int_be(prop_value, elem_len));\n+ } else if (!strcmp(prop_type, \"string\") || !strcmp(prop_type, \"str\")) {\n+ qlist_append_str(qlist, (const char *)prop_value);\n+ }\n+\n+ prop_value += elem_len;\n+\n+ /* TBD: add link type support */\n+ }\n+\n+ qdev_prop_set_array(DEVICE(obj), propname, qlist);\n+ DB_PRINT_NP(0, \"set property %s propname to \\n\", propname);\n+}\n+\n static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n {\n Object *dev, *parent;\n char *dev_type = NULL;\n+ QEMUDevtreeProp *prop, *props;\n char parent_node_path[DT_PATH_LENGTH];\n \n if (!compat) {\n@@ -460,7 +656,33 @@ static int fdt_init_qdev(char *node_path, FDTMachineInfo *fdti, char *compat)\n }\n fdt_init_set_opaque(fdti, node_path, dev);\n \n+ props = qemu_devtree_get_props(fdti->fdt, node_path);\n+ for (prop = props; prop->name; prop++) {\n+ const char *propname = trim_vendor(prop->name);\n+ ObjectProperty *p = NULL;\n+\n+ p = object_property_find(OBJECT(dev), propname);\n+ if (p) {\n+ DB_PRINT_NP(1, \"matched property: %s of type %s, len %d\\n\",\n+ propname, p->type, prop->len);\n+ }\n+ if (!p) {\n+ continue;\n+ }\n+\n+ if (!strcmp(p->type, \"list\")) {\n+ fdt_init_qdev_array_prop(dev, fdti, node_path, prop);\n+ }\n+\n+ if (!strcmp(propname, \"type\")) {\n+ continue;\n+ }\n+\n+ fdt_init_qdev_scalar_prop(OBJECT(dev), p, fdti, node_path, prop);\n+ }\n+\n g_free(dev_type);\n+ g_free(props);\n \n return 0;\n }\n","prefixes":["v2","10/33"]}